Re: [PATCH 7/8] ide: make legacy IDE VLB modules check for the probe kernel params

2007-02-14 Thread Alan
On Wed, 14 Feb 2007 02:57:12 +0100 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: [PATCH] ide: make legacy IDE VLB modules check for the probe kernel params Legacy IDE VLB host drivers didn't check for probe options when compiled as modules, which was obviously wrong as we don't want

Re: [PATCH 7/8] ide: make legacy IDE VLB modules check for the probe kernel params

2007-02-14 Thread Bartlomiej Zolnierkiewicz
On Wednesday 14 February 2007 11:53, Alan wrote: On Wed, 14 Feb 2007 02:57:12 +0100 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: [PATCH] ide: make legacy IDE VLB modules check for the probe kernel params Legacy IDE VLB host drivers didn't check for probe options when compiled

Re: [PATCH 7/8] ide: make legacy IDE VLB modules check for the probe kernel params

2007-02-14 Thread Alan
No point obsoleting the old ones. By the time being obsolete turns into being anything like gone, the hardware won't exist. It just causes We don't have stable rules for kernel parameters. We have fifteen years of traditional, common sense and the like I'll make warnings more verbose,

Re: [PATCH 7/8] ide: make legacy IDE VLB modules check for the probe kernel params

2007-02-14 Thread Bartlomiej Zolnierkiewicz
On Wednesday 14 February 2007 12:17, Alan wrote: No point obsoleting the old ones. By the time being obsolete turns into being anything like gone, the hardware won't exist. It just causes We don't have stable rules for kernel parameters. We have fifteen years of traditional, common

Re: [PATCH] (pata-2.6 fix queue) sl82c105: DMA support code cleanup

2007-02-14 Thread Bartlomiej Zolnierkiewicz
On Tuesday 13 February 2007 22:43, Sergei Shtylyov wrote: Fold the now equivalent code in the ide_dma_check() method into a mere call to ide_use_dma(). Make config_for_dma() return non-zero if DMA mode has been set and call it from the ide_dma_check() method instead of ide_dma_on(). Also,

[PATCH 7/8] ide: make legacy IDE VLB modules check for the probe kernel params (v2)

2007-02-14 Thread Bartlomiej Zolnierkiewicz
new replacement patch [PATCH] ide: make legacy IDE VLB modules check for the probe kernel params Legacy IDE VLB host drivers didn't check for probe options when compiled as modules, which was obviously wrong as we don't want module to poke at random I/O ports by simply loading it. Fix it by

[PATCH] (pata-2.6 fix queue) cmd64x: interrupt status fixes

2007-02-14 Thread Sergei Shtylyov
The driver's ide_dma_test_irq() method was reading the MRDMODE register even on PCI0643/6 where it was write-only -- fix this by always reading the backward- compatible interrupt bits, renaming dma_alt_stat to irq_stat as these interrupt status bits are not coupled to DMA. In addition, wrong

[PATCH] (pata-2.6 fix queue) cmd64x: add/fix enablebits

2007-02-14 Thread Sergei Shtylyov
The IDE core looks at the wrong bit when checking if the secondary channel is enabled on PCI0646 -- CFR bit 8 is read-ahead disable, bit 3 is the correct one. Starting with PCI0646U chip, the primary channel can also be enbled/disabled -- so, add 'enablebits' initializers to each

Re: [PATCH] ide/pci/delkin_cb.c: pci_module_init to pci_register_driver

2007-02-14 Thread Bartlomiej Zolnierkiewicz
On Wednesday 14 February 2007 01:39, Richard Knutsson wrote: Convert pci_module_init() to pci_register_driver(). Signed-off-by: Richard Knutsson [EMAIL PROTECTED] --- Compile-tested with allyes, allmod allno on i386 applied, thanks - To unsubscribe from this list: send the line

Re: [PATCHSET] libata: PATA driver for Celleb

2007-02-14 Thread Jeff Garzik
Benjamin Herrenschmidt wrote: 2.6.20 has been released and (I think) it is the time of merge-window for 2.6.21. I want this patch to be merged at this time. Please tell me if there are anything I should do. FYI, Jeff, we have merged the rest of the celleb platform support in the 2.6.21 merge

Re: spidernet (was Re: [PATCHSET] libata: PATA driver for Celleb)

2007-02-14 Thread Benjamin Herrenschmidt
On Thu, 2007-02-15 at 00:12 -0500, Jeff Garzik wrote: My overall impression of spidernet development is that EVERYBODY is submitting patches at once, and expecting me to sort out the mess. No thanks. Speaking with one voice would be much appreciated. And said speaker should patch

Re: [PATCHSET] libata: PATA driver for Celleb

2007-02-14 Thread Benjamin Herrenschmidt
I'm totally confused about who the heck is the spidernet maintainer. Me too :-) My inbox is pelted by spidernet driver updates from multiple people, and often the spidernet patches (regardless of author) receive comments that give me pause. The MAINTAINERS file says SPIDERNET

sata_nv ADMA controller lockup investigation

2007-02-14 Thread Robert Hancock
While testing out some libata FUA changes I was working on, I was inadvertently able to reproduce the kind of NCQ command timeouts in sata_nv that a few people have reported. I since verified that the FUA stuff had nothing to do with it as it still happens even with FUA disabled. However I'm