Re: [PATCH] libata: add NCQ blacklist entries from Silicon Image Windows driver

2007-02-22 Thread Jens Axboe
On Thu, Feb 22 2007, Jeff Garzik wrote: Robert Hancock wrote: This patch adds in some NCQ blacklist entries taken from the Silicon Image Windows drivers' .inf files for the 3124 and 3132 controllers. These entries were marked as DisableSataQueueing. Assume these are in their blacklist for a

Re: Question about PATA Sil680 Cache Line Size and Performance Degradation on ARM XScale

2007-02-22 Thread Alan
Since Sil3124 has better PCI read/write performance, as a reference, could someone explain or point me to the PCI configuration code for Sil3124? I couldn't find it in sata_sil24.c. Are you sure the values used are not the power on ones in this case ? - To unsubscribe from this list: send the

Re: Question about PATA Sil680 Cache Line Size and Performance Degradation on ARM XScale

2007-02-22 Thread Jeff Garzik
Alan wrote: Since Sil3124 has better PCI read/write performance, as a reference, could someone explain or point me to the PCI configuration code for Sil3124? I couldn't find it in sata_sil24.c. Are you sure the values used are not the power on ones in this case ? The values used, most

Re: Question about PATA Sil680 Cache Line Size and Performance Degradation on ARM XScale

2007-02-22 Thread Jeff Garzik
Fajun Chen wrote: On 2/22/07, Jeff Garzik [EMAIL PROTECTED] wrote: Alan wrote: Since Sil3124 has better PCI read/write performance, as a reference, could someone explain or point me to the PCI configuration code for Sil3124? I couldn't find it in sata_sil24.c. Are you sure the values used

Re: [2.6.18,19] SATA boot problems (ICH6/ICH6W)

2007-02-22 Thread Gary Hade
On Wed, Feb 21, 2007 at 09:40:10PM +0900, Tejun Heo wrote: Hello, Gary. Gary Hade wrote: I instrumented the code and found that for the SATA hard drive BSY was set just before the call to ahci_init_port() from ahci_port_start() and clear after the return from ahci_init_port(). For the

Re: [PATCH 2.6.21-rc1 1/2] sata_vsc: factor the error and normal intr paths into separate routines

2007-02-22 Thread Tejun Heo
Hello, Dan. Dan Williams wrote: +static inline void vsc_error_intr(u8 port_status, struct ata_port *ap) +{ + if (port_status (VSC_SATA_INT_PHY_CHANGE | VSC_SATA_INT_ERROR_M)) + ata_port_freeze(ap); + else + ata_port_abort(ap); +} + +static void

Re: [PATCH 2.6.21-rc1 2/2] sata_vsc: clean up vsc_sata_interrupt

2007-02-22 Thread Tejun Heo
Hello, Just one nit. Dan Williams wrote: + if (unlikely(status == 0x || status == 0)) { + status printk(KERN_ERR DRV_NAME : IRQ status == 0x, + PCI fault or device removal?\n); People usually don't like using logical operator short

Re: Fwd: [LIBATA] drives not detected

2007-02-22 Thread Tejun Heo
Hello, Patrick Ale. Patrick Ale wrote: I am going to do a last ressort attempt. I am going to switch cables with a set of harddrives that are working properly and see if that works. I don't think cables or the drives are the problems here but please keep me posted about your test result. I

Re: [PATCH] libata: add NCQ blacklist entries from Silicon Image Windows driver

2007-02-22 Thread Ask Bjørn Hansen
On Feb 21, 2007, at 10:57 PM, Jeff Garzik wrote: +/* The following blacklist entries are taken from the Windows + driver .inf files for the Silicon Image 3124 and 3132. */ +{ Maxtor 7B250S0,BANC1B70,ATA_HORKAGE_NONCQ, }, [...] Do we have information that these drives

Re: [PATCH] libata: add NCQ blacklist entries from Silicon Image Windows driver

2007-02-22 Thread Jens Axboe
On Thu, Feb 22 2007, Mark Lord wrote: Jens Axboe wrote: Robert Hancock wrote: .. +/* The following blacklist entries are taken from the Windows + driver .inf files for the Silicon Image 3124 and 3132. */ +{ Maxtor 7B250S0,BANC1B70,ATA_HORKAGE_NONCQ, }, +{

Re: libata FUA revisited

2007-02-22 Thread Ric Wheeler
Jens Axboe wrote: On Wed, Feb 21 2007, Tejun Heo wrote: [cc'ing Ric, Hannes and Dongjun, Hello. Feel free to drag other people in.] Robert Hancock wrote: Jens Axboe wrote: But we can't really change that, since you need the cache flushed before issuing the FUA write. I've been advocating

Re: libata FUA revisited

2007-02-22 Thread Ric Wheeler
Tejun Heo wrote: [cc'ing Ric, Hannes and Dongjun, Hello. Feel free to drag other people in.] Robert Hancock wrote: Jens Axboe wrote: But we can't really change that, since you need the cache flushed before issuing the FUA write. I've been advocating for an ordered bit for years, so that we

Re: libata FUA revisited

2007-02-22 Thread Ric Wheeler
Tejun Heo wrote: Jens Axboe wrote: On Wed, Feb 21 2007, Tejun Heo wrote: [cc'ing Ric, Hannes and Dongjun, Hello. Feel free to drag other people in.] Robert Hancock wrote: Jens Axboe wrote: But we can't really change that, since you need the cache flushed before issuing the FUA write. I've

Re: libata FUA revisited

2007-02-22 Thread Robert Hancock
Ric Wheeler wrote: I think that FUA was designed for a different use case than what Linux is using barriers for currently. The advantage with FUA is when you have before barrier, after barrier and don't care sets, where only the specific things you care about ordering are in the before/after

Re: [PATCH] libata: add NCQ blacklist entries from Silicon Image Windows driver

2007-02-22 Thread Robert Hancock
Ask Bjørn Hansen wrote: On Feb 21, 2007, at 10:57 PM, Jeff Garzik wrote: +/* The following blacklist entries are taken from the Windows + driver .inf files for the Silicon Image 3124 and 3132. */ +{ Maxtor 7B250S0,BANC1B70,ATA_HORKAGE_NONCQ, }, [...] Do we have

Re: Disk stuck in error recovery loop with AHCI

2007-02-22 Thread Jim Paris
I wrote: I've been trying to track down data corruption I'm seeing on my server. Turns out it was a bad disk. Not a media error, but maybe bad RAM or logic on the drive. I saw an error with AHCI that I hadn't seen before with the other controllers. ... Because the error at [11588.19xx] was