Kill unused local variable idx in sil24_fill_sg().
Spotted by Jeff Garzik.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
Cc: Jeff Garzik <[EMAIL PROTECTED]>
diff --git a/drivers/ata/sata_sil24.c b/drivers/ata/sata_sil24.c
index e65e8d5..06413e8 100644
--- a/drivers/ata/sata_sil24.c
+++ b/drivers/
commit b350d3ae0a21fd093d99644a3cfb90f4fb275cb2
Author: Jeff Garzik <[EMAIL PROTECTED]>
Date: Mon Feb 26 01:26:06 2007 -0500
[libata] sata_mv: clean up DMA boundary issues, turn on 64-bit DMA
The chips covered by sata_mv have a 32-bit DMA boundary they must not
cross, not a 64K
H. Peter Anvin wrote:
> Ric Wheeler wrote:
>>
>> We still have the following challenges:
>>
>>(1) read-ahead often means that we will retry every bad sector at
>> least twice from the file system level. The first time, the fs read
>> ahead request triggers a speculative read that includes the
On Friday February 23, [EMAIL PROTECTED] wrote:
> On Fri, Feb 23, 2007 at 05:37:23PM -0700, Andreas Dilger wrote:
> > > Probably the only sane thing to do is to remember the bad sectors and
> > > avoid attempting reading them; that would mean marking "automatic"
> > > versus "explicitly requested
Just got sata_mv working under the new EH, on my 6041.
It probes and talks to disks just fine (chip doesn't support ATAPI),
and hotplug actually has a chance of working.
The 'mv-eh' branch of
git://git.kernel.org/pub/scm/linux/kernel/git/jgarzik/libata-dev.git mv-eh
contains the following updat
On 2/25/07, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote:
If it does then we can probably blame the bad capacity problem on
some hardware problem fixed by replacing cables...
Yea I can do that, however, when my natve capacity was in the peta
bytes the pata_pdc207x module didnt exist ei
Alan wrote:
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Alan wrote:
Also export dev_disable as this is needed by drivers doing slave decode
filtering, which will follow shortly
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
M
Mikael Pettersson wrote:
When I merged my 20619 new EH conversion with #libata-upstream
I had to manually resolve a conflict, and inadvertently lost
pdc_pata_ops' ->post_internal_cmd binding. Corrected by this patch.
Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]>
---
drivers/ata/sata_pr
On Sunday 25 February 2007, Tejun Heo wrote:
> Bartlomiej Zolnierkiewicz wrote:
> > Why can't libata do the right thing and just send IDENTIFY command
> > to the slave device first?
>
> That's my plan B. I'm just not sure whether it would do any good, would it?
Probably it would but to know for
> I have a Maxtor 320GB PATA drive connected to the PATA port of a via
> 6421 based card. I can see a SATA drive if I connect it to the SATA
> ports, but I can't see the PATA one using the unpatched driver.
The current VIA code is in 2.6.20-mm and I think 2.6.21-rc, please give
that a spin as it s
> According to Annex B of ATA/ATAPI-5, IDENTIFY should be issued to the
> slave device first to ensure that it releases PDIAG- and then use the
> cable detection result from the master device. As we IDENTIFY master
> first right after reset, slave if present is driving PDIAG-, so the
> master on I
This email lists some known regressions in 2.6.21-rc1 compared to 2.6.20
that are not yet fixed in Linus' tree.
If you find your name in the Cc header, you are either submitter of one
of the bugs, maintainer of an affectected subsystem or driver, a patch
of you caused a breakage or I'm considering
Bartlomiej Zolnierkiewicz wrote:
> Why can't libata do the right thing and just send IDENTIFY command
> to the slave device first?
That's my plan B. I'm just not sure whether it would do any good, would it?
--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the b
On Sunday 25 February 2007, Tejun Heo wrote:
> [cc'ing Mark, Bart and Sergei. Hi]
>
> Alan wrote:
> >>> This makes unreliable cable detection even more unreliable. Please
> >>> consider for -stable. Thanks.
> >
> > At minimum you also need to stop doing drive side detect for PATA_CBL_80
> > as
On Sunday 25 February 2007, Patrick Ale wrote:
> On 2/24/07, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote:
>
> Hoi and good afternoon :)
Hey!
> Okay so... this is my dmesg with the legacy IDE drivers loaded.
> Please note that I still use libata for my boot drive but that the
> current v
Each place in pdc_ata_init_one() that initialises a SATA
port first calls pdc_ata_setup_port(), and then manually
assigns the port's ->scr_addr. Simplify the code by extending
pdc_ata_setup_port() to also handle scr_addr initialisation;
for PATA ports we pass NULL as scr_addr.
The initialisation o
Adrian Bunk wrote:
> On Sun, Feb 25, 2007 at 01:28:42PM +0900, Tejun Heo wrote:
>> Hello, Adrian.
>>
>> Adrian Bunk wrote:
>>> On Tue, Feb 20, 2007 at 12:43:41PM +0900, Tejun Heo wrote:
Rafael J. Wysocki wrote:
> Update:
>
> I get the same BUG with 2.6.20-git13 100% of the time dur
On Sun, Feb 25, 2007 at 01:28:42PM +0900, Tejun Heo wrote:
> Hello, Adrian.
>
> Adrian Bunk wrote:
> > On Tue, Feb 20, 2007 at 12:43:41PM +0900, Tejun Heo wrote:
> >> Rafael J. Wysocki wrote:
> >>> Update:
> >>>
> >>> I get the same BUG with 2.6.20-git13 100% of the time during the resume.
> >>> T
[cc'ing Mark, Bart and Sergei. Hi]
Alan wrote:
>>> This makes unreliable cable detection even more unreliable. Please
>>> consider for -stable. Thanks.
>
> At minimum you also need to stop doing drive side detect for PATA_CBL_80
> as many controllers don't do both so if you've got host side det
On 2/24/07, Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote:
Hoi and good afternoon :)
Okay so... this is my dmesg with the legacy IDE drivers loaded.
Please note that I still use libata for my boot drive but that the
current vs native capacity errors disapeared *sniff*, no petabytes
after a
On Sat, 24 Feb 2007 20:52:22 -0500
Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Tejun Heo wrote:
> > 80c test mask is at bits 18 and 19 of EIDE Controller Configuration
> > not 22 and 23. Fix it.
> >
> > Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
> > ---
> > This makes unreliable cable detection e
On Sat, 24 Feb 2007 20:51:27 -0500
Jeff Garzik <[EMAIL PROTECTED]> wrote:
> Tejun Heo wrote:
> > ata_host_release() uses drvdata to determine ata_host to release and
> > clearing drvdata in ->remove_one causes NULL pointer deference. Clear
> > drvdata only in ata_host_release() after all resource
When I merged my 20619 new EH conversion with #libata-upstream
I had to manually resolve a conflict, and inadvertently lost
pdc_pata_ops' ->post_internal_cmd binding. Corrected by this patch.
Signed-off-by: Mikael Pettersson <[EMAIL PROTECTED]>
---
drivers/ata/sata_promise.c |1 +
1 files c
commit 7aa3ffd983c12d224e33e5d4f89ad083392f9d8d
Author: Jeff Garzik <[EMAIL PROTECTED]>
Date: Sun Feb 25 04:19:45 2007 -0500
[libata] sata_mv: Fix 50xx irq mask
IRQ mask bits assumed a 60xx or newer generation chip, which is very
wrong for the 50xx series. Luckily both generat
25 matches
Mail list logo
