Re: sata_inic162x driver for 2.6.19 timeouts etc

2007-03-16 Thread Mark Lord
Tejun Heo wrote: IIRC, I couldn't nudge the controller into the ADMA mode. Is ADMA some kind of standardized programming interface? Yes. Or it was supposed to be. Just for kicks, try hacking the PCI ID into pdc_adma.c and see what happens with it there. That driver does ADMA for (only) READs

[PATCH] libata: add support for READ/WRITE LONG

2007-03-16 Thread Mark Lord
(resending, again. why does this take months of wasted efforts?) The READ/WRITE LONG commands are theoretically obsolete, but the majority of drives in existance still implement them. The WRITE_LONG and WRITE_LONG_ONCE commands are of particular interest for fault injection testing -- eg.

Re: sata_inic162x driver for 2.6.19 timeouts etc

2007-03-16 Thread Alan Cox
On Fri, 16 Mar 2007 08:23:39 -0400 Mark Lord [EMAIL PROTECTED] wrote: Tejun Heo wrote: IIRC, I couldn't nudge the controller into the ADMA mode. Is ADMA some kind of standardized programming interface? ADMA is documented in the same place as the SFF PCI interface and you'll find it on the

Re: [PATCH] libata: add support for READ/WRITE LONG

2007-03-16 Thread Alan Cox
The fussy bit is that these commands require a non-standard sector size, usually 520 bytes instead of 512. Do we always know the worst case here as this breaks my pending patch to use bounce buffers for PIO so we transfer with IRQ enabled and I need to know the correct new worst case size.

Re: [PATCH] libata: add support for READ/WRITE LONG

2007-03-16 Thread Sergei Shtylyov
Hello. Mark Lord wrote: The READ/WRITE LONG commands are theoretically obsolete, but the majority of drives in existance still implement them. The WRITE_LONG and WRITE_LONG_ONCE commands are of particular interest for fault injection testing -- eg. creating media errors at specific

Re: [PATCH] libata: add support for READ/WRITE LONG

2007-03-16 Thread Alan Cox
Which requires from the drivers to be able to turn off IDE prefetch (and maybe posting too). I don't see that in this patch (or are you expecting them to just snoop' the commands and do it automagically?). We need to see which drivers have that problem and if its only the odd one then

Re: Add suport for Marvell 88SE6121 in ahci

2007-03-16 Thread Jose Alberto Reguero
El Miércoles, 31 de Enero de 2007, Jeff Garzik escribió: Jose Alberto Reguero wrote: This work for kernel 2.6.20-rc6 First apply this patch: http://marc.theaimsgroup.com/?l=linux-idem=116986924301674w=2 Then apply the patch attached. Comments: The Marvell 88SE6121 has three

Re: [PATCH] libata: add support for READ/WRITE LONG

2007-03-16 Thread Sergei Shtylyov
Mark Lord wrote: Alan Cox wrote: The fussy bit is that these commands require a non-standard sector size, usually 520 bytes instead of 512. Do we always know the worst case here as this breaks my pending patch to use bounce buffers for PIO so we transfer with IRQ enabled and I need to know

Re: IOMEGA IDE ZIP (ATAPI) drive

2007-03-16 Thread Albert Lee
Mark Lord wrote: Tejun Heo wrote: Mark Lord wrote: Really? I didn't notice when libata gained ATAPI-disk support. Are you *sure* about that?? Not sure sure but almost sure. :-) What ide-scsi does is borrowing SCSI mid and high level drivers while using ide as SCSI low level driver.

Re: [PATCH] libata: add support for READ/WRITE LONG

2007-03-16 Thread Mark Lord
Sergei Shtylyov wrote: Mark Lord wrote: Ugh. The drives default to 520 bytes (always), The old IDE drives used to have 4 and 7 byte ECC (seen in ancient Phoenix BIOS). Yes -- 4-bytes means a 520-byte transfer when using 16-bit words. The ATA standard specifies a default of 520 bytes,

Re: [PATCH] libata: add support for READ/WRITE LONG

2007-03-16 Thread Sergei Shtylyov
Hello. Mark Lord wrote: The fussy bit is that these commands require a non-standard sector size, usually 520 bytes instead of 512. Which requires from the drivers to be able to turn off IDE prefetch (and maybe posting too). I don't see that in this patch (or are you expecting them to

Re: IOMEGA IDE ZIP (ATAPI) drive

2007-03-16 Thread Mark Lord
Albert Lee wrote: Could you please apply the attached debugging patch for clue about what caused the HSM violation, thanks. I had to edit the patch to get it to apply on 2.6.21-rc3-git9, but here (attached) is the output from syslog. zip_insert.txt :: response to inserting a disc into the

Re: sata_inic162x driver for 2.6.19 timeouts etc

2007-03-16 Thread Jeff Garzik
Tejun Heo wrote: Oh well, I never got around to get the ADMA mode working. The sunix driver is TF/quasi-BMDMA based (w/o CONTROL register so I'm pretty sure they have some problem with LBA48). The docs[1] I have only have register description and nothing about the programming model. Me being

Re: sata_inic162x driver for 2.6.19 timeouts etc

2007-03-16 Thread Jeff Garzik
Tejun Heo wrote: nudge the controller into the ADMA mode. Is ADMA some kind of standardized programming interface? Yes. Search for ADMA on the linux-ata.org developer resources page: http://linux-ata.org/devel.html Both PDC and NVIDIA based their stuff off of ADMA. PDC's is closer to

Re: [PATCH] libata: add support for READ/WRITE LONG

2007-03-16 Thread Sergei Shtylyov
Hello. Mark Lord wrote: But if we really want to be 100% compliant, we could consider dropping to PIO0 for the command. Not worth it, though, as in practice this is not necessary, and it would mess up libata far more than is worthwhile for this effort. I think it only requires the *host*

Re: DVD drive fails in 2.6.20.2

2007-03-16 Thread Albert Lee
Vlad Codrea wrote: Hi, I've attached the full dmesg after applying Albert's patch. The new messages seem to be: ata2: protocol 7 task_state 4 ata2: protocol 7 task_state 4 (dev_stat 0x58) ata2: protocol 7 task_state 2 ata2: protocol 7 task_state 2 (dev_stat 0x58) ata2: protocol 7

Re: IOMEGA IDE ZIP (ATAPI) drive

2007-03-16 Thread Albert Lee
Mark Lord wrote: Albert Lee wrote: Could you please apply the attached debugging patch for clue about what caused the HSM violation, thanks. I had to edit the patch to get it to apply on 2.6.21-rc3-git9, but here (attached) is the output from syslog. zip_insert.txt :: response to

Re: [PATCH] libata: add support for READ/WRITE LONG

2007-03-16 Thread Mark Lord
Jeff Garzik wrote: Alan Cox wrote: I think it only requires the *host* to drop to PIO0 timings. In which case it should be achievable w/o libata modification -- if the driver has to snoop command and turn off prefetch, why not switch to PIO0 temporarily? This isn't a big issue.

Re: [PATCH] libata: add support for READ/WRITE LONG

2007-03-16 Thread Bartlomiej Zolnierkiewicz
On Friday 16 March 2007, Mark Lord wrote: Jeff Garzik wrote: Alan Cox wrote: I think it only requires the *host* to drop to PIO0 timings. In which case it should be achievable w/o libata modification -- if the driver has to snoop command and turn off prefetch, why not switch to

Re: [PATCH] libata: add support for READ/WRITE LONG

2007-03-16 Thread Sergei Shtylyov
Hello. Mark Lord wrote: I've tested ATA1 and newer PATA drives, and various SATA drives with these commands without bothering to drop to PIO0, and none of them had issues. Of course -- that PIO0 warning was for the sake of some ATA-1 drives. :-) Cheers MBR, Sergei - To unsubscribe

Re: IOMEGA IDE ZIP (ATAPI) drive

2007-03-16 Thread Mark Lord
Albert Lee wrote: .. Maybe we can wait a moment and give the slow ATAPI devices some time to set DRQ. Could you please try if the attached patch works, thanks. -- albert --- linux-2.6.20.3/drivers/ata/libata-core.c2007-03-15 18:03:27.0 +0800 +++

[PATCH] libata: kernel-doc fix

2007-03-16 Thread Randy Dunlap
From: Randy Dunlap [EMAIL PROTECTED] Warning(linux-2621-rc3g7/drivers/ata/libata-core.c:842): No description found for parameter 'unknown' Signed-off-by: Randy Dunlap [EMAIL PROTECTED] --- drivers/ata/libata-core.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ---

Re: IOMEGA IDE ZIP (ATAPI) drive

2007-03-16 Thread Albert Lee
Mark Lord wrote: Albert Lee wrote: .. Maybe we can wait a moment and give the slow ATAPI devices some time to set DRQ. Could you please try if the attached patch works, thanks. -- albert --- linux-2.6.20.3/drivers/ata/libata-core.c2007-03-15 18:03:27.0 +0800 +++

Re: libata: CD and dvd devices not recognized

2007-03-16 Thread Albert Lee
YUP wrote: Hi Albert, I think my cdrom drive is broken. I did some test under windows by means of nero-info tool and it shows that cdrom drive has not available read/write speed. Here is summary: Ok. Can windows or nero read any data out of the drive? If not, we can be quite sure it's

Re: DVD drive fails in 2.6.20.2

2007-03-16 Thread Albert Lee
Vlad Codrea wrote: Albert Lee wrote: ata2: protocol 7 task_state 4 === The device interrupts to receive CDB ata2: protocol 7 task_state 4 (dev_stat 0x58) == Good, DRQ seen. CDB sent. ata2: protocol 7 task_state 2 === interrupt. We expect DMA complete. ata2: protocol 7 task_state 2