Re: libata: CD and dvd devices not recognized

2007-03-20 Thread Albert Lee
YUP wrote: Hi Sergei, Albert and Bartek, Thanks for the patch. If you dealt with it, could you please apply this patch to 2.6.20.3 kernel and send me diff? I'm just afraid that I couldn't do it right. Albert and Bartek, please find latest dmsg output with Albert's patch. I quoted here

Re: libata: CD and dvd devices not recognized

2007-03-20 Thread Albert Lee
Albert Lee wrote: YUP wrote: Hi Sergei, Albert and Bartek, Thanks for the patch. If you dealt with it, could you please apply this patch to 2.6.20.3 kernel and send me diff? I'm just afraid that I couldn't do it right. Albert and Bartek, please find latest dmsg output with Albert's patch. I

Re: IOMEGA IDE ZIP (ATAPI) drive

2007-03-20 Thread Albert Lee
Mark Lord wrote: Albert Lee wrote: Mark Lord wrote: .. I patched the above in, and it was NEVER hit. Do you mean no wait for DRQ messages at all? Is the HSM violation still seen? The code you sent me to patch in was never hit. The wait for DRQ message therefore never gets output.

[PATCH 2.6.22 RESEND] Optional LED trigger for libata

2007-03-20 Thread Tony Vroon
This adds an optional wrapper around ata_ac_issue_prot that triggers the LED layer. This is used for the PMU LED on G5 towers (IDE trigger). My test platform is a PowerMac 7,3 (Dual G5 2.0GHz, June 2004) with a K2 (sata_svw) controller. Now respun as a single patch, and the function name

Re: [PATCH 2.6.22 RESEND] Optional LED trigger for libata

2007-03-20 Thread Tejun Heo
Tony Vroon wrote: This adds an optional wrapper around ata_ac_issue_prot that triggers the LED layer. This is used for the PMU LED on G5 towers (IDE trigger). My test platform is a PowerMac 7,3 (Dual G5 2.0GHz, June 2004) with a K2 (sata_svw) controller. Now respun as a single patch, and

Re: libata: CD and dvd devices not recognized

2007-03-20 Thread Sergei Shtylyov
Hello. YUP wrote: Well, I checked pata_pdc2027x.c code and found that code completely rewrited. For unexperienced user it is not so easy to apply. This patch was to drivers/ide/pci/pdc202xx_new.c -- and I thought libata driver had this enabled since then... wait, it *is* enabled there.

[PATCH] ide: revert ide: fix drive side 80c cable check, take 2 for now

2007-03-20 Thread Bartlomiej Zolnierkiewicz
[PATCH] ide: revert ide: fix drive side 80c cable check, take 2 for now ide: fix drive side 80c cable check, take 2 patch from Tejun Heo (commit fab59375b9543f84d1714f7dd00f5d11e531bd3e) fixed 80c bit test (bit13 of word93) but we also need to fix master/slave IDENTIFY order (slave device should

problem detecting ATAPI device with ahci on 2.6.21-rcx

2007-03-20 Thread Kristen Carlson Accardi
Hi, I upgrade a machine from 2.6.20-2.6.21-rc4 and am now having problems with my ATAPI device getting detected properly. Back tracking to 2.6.21-rc1, I find the problem existed there too, but not in 2.6.20. ahci :00:1f.2: version 2.0 ACPI: PCI Interrupt :00:1f.2[C] - GSI 19 (level, low)

[patch 0/3] [RFC] SATA Asynchronous Notification for ATAPI devices

2007-03-20 Thread Kristen Carlson Accardi
Hi! I was hoping you could give me some feedback on this partial implementation of Asynchronous Notification for ATAPI devices as defined in SATA 2.5 and AHCI 1.1. I am specifically concerned about the method I used to expose this functionality to user space (so that hal can stop polling if it

[patch 1/3] libata: check for AN support

2007-03-20 Thread Kristen Carlson Accardi
Check to see if an ATAPI device supports Asynchronous Notification. If so, enable it. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/libata-core.c === --- 2.6-git.orig/drivers/ata/libata-core.c

[patch 2/3] libata: expose AN support to user space via sysfs

2007-03-20 Thread Kristen Carlson Accardi
Allow user space to determine if an ATAPI device supports async notification (AN) of media changes. This is done by adding a new sysfs file async_notification to genhd. If the file reads 1, then the device supports async notification. If the file reads 0, it does not. A flag is set in the

[patch 3/3] libata: handle AN interrupt

2007-03-20 Thread Kristen Carlson Accardi
When we get an SDB FIS with the 'N' bit set, we should send an event to user space to indicate that there has been a media change. The ahci host controller will send the event via KOBJ_CHANGE uevent. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Index: 2.6-git/drivers/ata/ahci.c

[PATCH 1/3] sd: fix return value of sd_sync_cache()

2007-03-20 Thread Tejun Heo
sd_sync_cache() should return -errno on error, fix it. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/scsi/sd.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: work/drivers/scsi/sd.c === ---

[PATCH 2/3] sd: implement START/STOP management

2007-03-20 Thread Tejun Heo
Implement SBC START/STOP management. sdev-mange_start_stop is added. When it's set to one, sd STOPs the device on suspend and shutdown and STARTs it on resume. sdev-manage_start_stop defaults is in sdev instead of scsi_disk cdev to allow -slave_config() override the default configuration but is

[PATCH 3/4] libata: reimplement suspend/resume support using sdev-manage_start_stop

2007-03-20 Thread Tejun Heo
Reimplement suspend/resume support using sdev-manage_start_stop. * Device suspend/resume is now SCSI layer's responsibility and the code is simplified a lot. * DPM is dropped. This also simplifies code a lot. Suspend/resume status is port-wide now. * ata_scsi_device_suspend/resume() and

Re: [PATCH 3/4] libata: reimplement suspend/resume support using sdev-manage_start_stop

2007-03-20 Thread Christoph Hellwig
On Wed, Mar 21, 2007 at 12:25:33AM +0900, Tejun Heo wrote: Reimplement suspend/resume support using sdev-manage_start_stop. * Device suspend/resume is now SCSI layer's responsibility and the code is simplified a lot. Finally. I've been telling people to do it this way forever. Can you

Re: [PATCH 3/4] libata: reimplement suspend/resume support using sdev-manage_start_stop

2007-03-20 Thread Alan Cox
* DPM is dropped. This also simplifies code a lot. Suspend/resume status is port-wide now. Makes sense * sdev-manage_start_stop is set to 1 in ata_scsi_slave_config(). This fixes spindown on shutdown and suspend-to-disk. Yay Signed-off-by: Tejun Heo [EMAIL PROTECTED] Acked-by:

[PATCH 4/4] libata: implement libata.spindown_compat

2007-03-20 Thread Tejun Heo
Now that libata uses sd-manage_start_stop, libata spins down disk on shutdown. In an attempt to compensate libata's previous shortcoming, shutdown(8) syncs and spins down disks attached via libata. Some disks spin back up just to spin down again on STANDBYNOW1 if the command is issued when the

Re: [PATCH 3/4] libata: reimplement suspend/resume support using sdev-manage_start_stop

2007-03-20 Thread Oliver Neukum
Am Dienstag, 20. März 2007 17:39 schrieb Alan Cox: * sdev-manage_start_stop is set to 1 in ata_scsi_slave_config().   This fixes spindown on shutdown and suspend-to-disk. Yay Which kernel version is this? Regards Oliver - To unsubscribe from this list: send the

Re: [PATCH 2/3] sd: implement START/STOP management

2007-03-20 Thread James Bottomley
On Wed, 2007-03-21 at 00:13 +0900, Tejun Heo wrote: Implement SBC START/STOP management. sdev-mange_start_stop is added. When it's set to one, sd STOPs the device on suspend and shutdown and STARTs it on resume. sdev-manage_start_stop defaults is in sdev instead of scsi_disk cdev to allow

Re: [PATCH 2/3] sd: implement START/STOP management

2007-03-20 Thread Tejun Heo
James Bottomley wrote: On Wed, 2007-03-21 at 00:13 +0900, Tejun Heo wrote: Implement SBC START/STOP management. sdev-mange_start_stop is added. When it's set to one, sd STOPs the device on suspend and shutdown and STARTs it on resume. sdev-manage_start_stop defaults is in sdev instead of

Re: [PATCH 2/3] sd: implement START/STOP management

2007-03-20 Thread James Bottomley
On Wed, 2007-03-21 at 02:08 +0900, Tejun Heo wrote: I got too comfortable with libata-dev#upstream and forgot to verify patches against scsi-misc-2.6. Sorry about that. If you don't have objection against the content, I'll resubmit the SCSI part against scsi-misc-2.6. Once it's in

Re: [PATCH 2/3] sd: implement START/STOP management

2007-03-20 Thread Douglas Gilbert
Tejun Heo wrote: Implement SBC START/STOP management. sdev-mange_start_stop is added. When it's set to one, sd STOPs the device on suspend and shutdown and STARTs it on resume. sdev-manage_start_stop defaults is in sdev instead of scsi_disk cdev to allow -slave_config() override the default

Re: [PATCH 2/3] sd: implement START/STOP management

2007-03-20 Thread James Bottomley
On Tue, 2007-03-20 at 13:58 -0400, Douglas Gilbert wrote: I note at this point that the IMMED bit in the START STOP UNIT cdb is clear. [The code might note that as well.] All SCSI disks that I have seen, implement the IMMED bit and according to the SAT standard, so should SAT layers like the

Re: [ibm-acpi-devel] CONFIG_IBM_BAY

2007-03-20 Thread Henrique de Moraes Holschuh
On Tue, 20 Mar 2007, Shem Multinymous wrote: More like it is a make sure we can actually eject, as we have been told to. We might return an error instead, but if we do, we need a way to force-eject (e.g. echo 2 eject). Which stage are you referring to? Stage 2, of course. It is useful to

Re: CONFIG_IBM_BAY

2007-03-20 Thread Holger Macht
On Mon 19. Mar - 11:04:12, Kristen Carlson Accardi wrote: On Sun, 18 Mar 2007 19:55:30 +0100 Holger Macht [EMAIL PROTECTED] wrote: On Sun 18. Mar - 15:36:52, Henrique de Moraes Holschuh wrote: On Sun, 18 Mar 2007, Holger Macht wrote: those ThinkPads where it is needed. Afterwards it

Re: CONFIG_IBM_BAY

2007-03-20 Thread Holger Macht
On Tue 20. Mar - 17:07:07, Holger Macht wrote: On Mon 19. Mar - 11:11:09, Kristen Carlson Accardi wrote: On Mon, 19 Mar 2007 15:37:46 +0100 Holger Macht [EMAIL PROTECTED] wrote: Sure. What actually bothers me is that in its current state, the dock station driver signals 'green' on

Re: CONFIG_IBM_BAY

2007-03-20 Thread Kristen Carlson Accardi
On Tue, 20 Mar 2007 16:53:21 +0100 Holger Macht [EMAIL PROTECTED] wrote: On Mon 19. Mar - 11:04:12, Kristen Carlson Accardi wrote: On Sun, 18 Mar 2007 19:55:30 +0100 Holger Macht [EMAIL PROTECTED] wrote: On Sun 18. Mar - 15:36:52, Henrique de Moraes Holschuh wrote: On Sun, 18 Mar

Re: CONFIG_IBM_BAY

2007-03-20 Thread Holger Macht
On Tue 20. Mar - 09:19:32, Kristen Carlson Accardi wrote: On Tue, 20 Mar 2007 16:53:21 +0100 Holger Macht [EMAIL PROTECTED] wrote: On Mon 19. Mar - 11:04:12, Kristen Carlson Accardi wrote: On Sun, 18 Mar 2007 19:55:30 +0100 Holger Macht [EMAIL PROTECTED] wrote: On Sun 18. Mar

Re: [PATCH] ide: revert ide: fix drive side 80c cable check, take 2 for now

2007-03-20 Thread Tejun Heo
Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: revert ide: fix drive side 80c cable check, take 2 for now ide: fix drive side 80c cable check, take 2 patch from Tejun Heo (commit fab59375b9543f84d1714f7dd00f5d11e531bd3e) fixed 80c bit test (bit13 of word93) but we also need to fix

Re: libata: CD and dvd devices not recognized

2007-03-20 Thread Albert Lee
Hi Yarema, Thanks for the help. Some of the dmesgs you sent were truncated by the mailer, etc. We know it is INQUIRY, but we still have no clue why/how the INQUIRY or something caused the problem. Could you please open a bug on http://bugzilla.kernel.org/ and attach the dmesg there for easier

Re: [PATCH 2/3] sd: implement START/STOP management

2007-03-20 Thread Tejun Heo
Hello, Douglas. Douglas Gilbert wrote: Tejun, I note at this point that the IMMED bit in the START STOP UNIT cdb is clear. [The code might note that as well.] All SCSI disks that I have seen, implement the IMMED bit and according to the SAT standard, so should SAT layers like the one in

Re: [PATCH 2/3] sd: implement START/STOP management

2007-03-20 Thread Tejun Heo
James Bottomley wrote: On Wed, 2007-03-21 at 02:08 +0900, Tejun Heo wrote: I got too comfortable with libata-dev#upstream and forgot to verify patches against scsi-misc-2.6. Sorry about that. If you don't have objection against the content, I'll resubmit the SCSI part against scsi-misc-2.6.

Re: sata_nv ADMA controller lockup investigation

2007-03-20 Thread Neil Schemenauer
Not sure if this helps. I'm getting this reset with 2.6.21-rc4. After the reset the controller seems to work again. sata_nv :00:07.0: version 3.3 ACPI: PCI Interrupt Link [APSI] enabled at IRQ 22 ACPI: PCI Interrupt :00:07.0[A] - Link [APSI] - GSI 22 (level, low) - IRQ 22 sata_nv

Re: sata_nv ADMA controller lockup investigation

2007-03-20 Thread Robert Hancock
Neil Schemenauer wrote: Not sure if this helps. I'm getting this reset with 2.6.21-rc4. After the reset the controller seems to work again. ... ata2.00: ATA-7: Maxtor 6V300F0, VA111630, max UDMA/133 ata2.00: 586114704 sectors, multi 16: LBA48 NCQ (depth 31/32) ... ata2: EH in ADMA mode,