> /* Check if the ATA ports are enabled */
> - if ((pcicfg & 3) == 0)
> + if (!(pcicfg & 3))
> return -ENODEV;
Why - it was much clearer before and matches the logic below more
obviously ..
> + /* Map IO ports and initialize host accordingly */
> + iomap[0] =
Hello,
Craig Metz wrote:
> I was hoping that Linux would be able to do staggered spin-up itself in a
> reasonable manner. And, if it doesn't today, I am hoping that is just a matter
> of someone writing the code.
>
> I have done some digging in with the 2.6.20.3 libata code, and one thing I
>
Add PCI ID for new VIA chip. Original patch is from Maarten Vanraes.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
Cc: Maarten Vanraes <[EMAIL PROTECTED]>
diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
index faa7588..3675964 100644
--- a/drivers/ata/ahci.c
+++ b/drivers/ata/ahci.c
@@ -413,6
Convert pdc_adma, pata_cs5520, pata_isapnp, pata_ixp4xx_cf,
pata_legacy, pata_mpc52xx, pata_mpiix, pata_pcmcia, pata_pdc2027x,
pata_platform, pata_qdi, pata_scc and pata_winbond to new init model.
* init_one()'s now follow more consistent init order
* cs5520 now registers one host with two ports,
Doesn't libata have to do with SCSI devices? I'm afraid it wouldn't
work with CF, which is P-ATA compatible.
Wouldn't it work just to call ide_intr() explicitly from some polling
function, as Mark suggested?
Michael
On 4/10/07, Alan Cox <[EMAIL PROTECTED]> wrote:
> The only real restriction in
On Wed, 11 Apr 2007 10:39:58 +0200
Michael <[EMAIL PROTECTED]> wrote:
> Doesn't libata have to do with SCSI devices? I'm afraid it wouldn't
> work with CF, which is P-ATA compatible.
libata drives PATA and SATA devices, including CF.
> Wouldn't it work just to call ide_intr() explicitly from som
On Wed, 11 Apr 2007 15:42:05 +0900, Tejun Heo wrote:
...
> diff --git a/drivers/ata/sata_promise.c b/drivers/ata/sata_promise.c
> index baa8368..8e8fe59 100644
> --- a/drivers/ata/sata_promise.c
> +++ b/drivers/ata/sata_promise.c
...
> @@ -333,7 +349,7 @@ static struct pci_driver pdc_ata_pci_driver
Convert sata_via and sata_promise to new init model. Both controllers
can have combined configuration (SATA + PATA) and used twisted
initialization method (modifying port in ->port_start) to overcome
probe_ent limitations.
This patch converts both drivers to new init model in which such
configura
Alan Cox wrote:
> Found these by inspection:
>
> Command issuing goes via ata_qc_reinit() which sets up the device bits
> for the command to include the device select bit.
>
> If we are using NCQ then the code in ata_build_rw_tf sets bit 6 directly
> without using |= which clears the device selec
SB600 RAID and SB600 SATA is the same controller and share the
same PCI ID 0x4380. There is such PCI ID 0x4381.
Signed-off-by: Conke Hu <[EMAIL PROTECTED]>
-
diff -Nur linux-2.6.21-rc6-git3.orig/drivers/ata/ahci.c
linux-2.6.21-rc6-git3/drivers/ata/ahci.c
--- linux-2.6.21-rc6-git3.or
Conke Hu wrote:
>SB600 RAID and SB600 SATA is the same controller and share the
> same PCI ID 0x4380. There is such PCI ID 0x4381.
I assume 'no' is missing in the last sentence. :-)
--
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [
On 4/11/07, Tejun Heo <[EMAIL PROTECTED]> wrote:
Conke Hu wrote:
>SB600 RAID and SB600 SATA is the same controller and share the
> same PCI ID 0x4380. There is such PCI ID 0x4381.
I assume 'no' is missing in the last sentence. :-)
--
tejun
Oh, sorry :(
so, should I re-send the mail?
co
Conke Hu wrote:
> On 4/11/07, Tejun Heo <[EMAIL PROTECTED]> wrote:
>> Conke Hu wrote:
>> >SB600 RAID and SB600 SATA is the same controller and share the
>> > same PCI ID 0x4380. There is such PCI ID 0x4381.
>>
>> I assume 'no' is missing in the last sentence. :-)
>>
>> --
>> tejun
>>
>
> Oh,
SB600 RAID and SB600 SATA is the same controller and share the
same PCI ID 0x4380. There is no such PCI ID 0x4381.
Signed-off-by: Conke Hu <[EMAIL PROTECTED]>
-
diff -Nur linux-2.6.21-rc6-git3.orig/drivers/ata/ahci.c
linux-2.6.21-rc6-git3/drivers/ata/ahci.c
--- linux-2.6.21-rc6-git3
In message <[EMAIL PROTECTED]>, you write:
>Yeah, the silicon can do staggered spin up. SATA disks shouldn't spin
>up till PHY gets reset. libata currently probes each port serially, so
>it should sequentially spin up each drive. Or do they spin up during
>controller initialization?
On a cold
I see.
The problem is I am constrained to 2.6.14 kernel.
Is it still correct to say it is P-ATA compatible?
On 4/11/07, Alan Cox <[EMAIL PROTECTED]> wrote:
On Wed, 11 Apr 2007 10:39:58 +0200
Michael <[EMAIL PROTECTED]> wrote:
> Doesn't libata have to do with SCSI devices? I'm afraid it wouldn't
On Wed, 11 Apr 2007 17:10:12 +0200
Michael <[EMAIL PROTECTED]> wrote:
> I see.
> The problem is I am constrained to 2.6.14 kernel.
Make sure you backport any relevant network security fixes in that case.
If you are working to 2.6.14, then your easiest route may be to write a
polling CF driver fr
remove SPIN_LOCK_UNLOCKED, use DEFINE_SPINLOCK instead
Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]>
---
pata_winbond.c |2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/pata_winbond.c b/drivers/ata/pata_winbond.c
index 6c11103..cfcd2a5 100644
--- a/
On Wed, Apr 11, 2007 at 08:58:46PM +0530, Milind Arun Choudhary wrote:
> remove SPIN_LOCK_UNLOCKED, use DEFINE_SPINLOCK instead
>
> Signed-off-by: Milind Arun Choudhary <[EMAIL PROTECTED]>
Acked-by: Alan Cox <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-ide
On Apr 11 2007 20:58, Milind Arun Choudhary wrote:
>
>remove SPIN_LOCK_UNLOCKED, use DEFINE_SPINLOCK instead
Don't we have some more places where spinlocks could be janitorified?
Otherwise, ok!
Jan
--
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a messa
On Wed, Apr 11, 2007 at 12:23:13AM +0100, Alan Cox wrote:
> @@ -3341,6 +3545,11 @@ static int ata_dev_same_device(struct at
> "%llu != %llu\n",
> (unsigned long long)dev->n_sectors,
> (unsigned long long)new_n_se
When I reboot my notebook, it powers off and powers back on.
On poweroff a loud snapping noise seems to be coming from the
hard drive. Today I noticed there is no "shutdown: hda" on
the console when I reboot. Whne I do a normal poweroff the
message is displayed and there is no noise. Should the IDE
On Apr 11 2007 17:07, Chuck Ebbert wrote:
>
>When I reboot my notebook, it powers off and powers back on.
>On poweroff a loud snapping noise seems to be coming from the
>hard drive. Today I noticed there is no "shutdown: hda" on
>the console when I reboot. Whne I do a normal poweroff the
>message
Jan Engelhardt wrote:
> On Apr 11 2007 17:07, Chuck Ebbert wrote:
>> When I reboot my notebook, it powers off and powers back on.
>> On poweroff a loud snapping noise seems to be coming from the
>> hard drive. Today I noticed there is no "shutdown: hda" on
>> the console when I reboot. Whne I do a
On Apr 11 2007 17:35, Chuck Ebbert wrote:
>Jan Engelhardt wrote:
>> On Apr 11 2007 17:07, Chuck Ebbert wrote:
>>> When I reboot my notebook, it powers off and powers back on.
>>> On poweroff a loud snapping noise seems to be coming from the
>>> hard drive. Today I noticed there is no "shutdown: hd
Jan Engelhardt wrote:
> On Apr 11 2007 17:35, Chuck Ebbert wrote:
>> Jan Engelhardt wrote:
>>> On Apr 11 2007 17:07, Chuck Ebbert wrote:
When I reboot my notebook, it powers off and powers back on.
On poweroff a loud snapping noise seems to be coming from the
hard drive. Today I noti
kill the following compile warning.
drivers/ata/libata-core.c:1786: warning: comparison of distinct pointer types
lacks a cast
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index 735f0b0..3556281 100644
--- a/drivers/ata/libata-c
27 matches
Mail list logo
