[PATCH] libata: Add MMIO support to pata_sil680

2007-05-15 Thread Benjamin Herrenschmidt
This patch adds MMIO support to the pata_sil680 for taskfile IOs, based on what the old siimage does. I haven't bothered changing the chip setup stuff from PCI config cycles to MMIO though (siimage does it), I don't think it matters, I've only adapted it to use MMIO for taskfile accesses. I've

[PATCH] libata: Add MMIO support to pata_sil680

2007-05-15 Thread Benjamin Herrenschmidt
This patch adds MMIO support to the pata_sil680 for taskfile IOs, based on what the old siimage does. I haven't bothered changing the chip setup stuff from PCI config cycles to MMIO though (siimage does it), I don't think it matters, I've only adapted it to use MMIO for taskfile accesses. I've

Re: [PATCH] libata: Add MMIO support to pata_sil680

2007-05-15 Thread Benjamin Herrenschmidt
On Tue, 2007-05-15 at 16:11 +1000, Benjamin Herrenschmidt wrote: This patch adds MMIO support to the pata_sil680 for taskfile IOs, based on what the old siimage does. I haven't bothered changing the chip setup stuff from PCI config cycles to MMIO though (siimage does it), I don't think it

Re: [PATCH] libata: Add MMIO support to pata_sil680

2007-05-15 Thread Benjamin Herrenschmidt
On Tue, 2007-05-15 at 16:12 +1000, Benjamin Herrenschmidt wrote: This patch adds MMIO support to the pata_sil680 for taskfile IOs, based on what the old siimage does. I haven't bothered changing the chip setup stuff from PCI config cycles to MMIO though (siimage does it), I don't think it

Re: Fixing halt/shutdown for libata spindown handling

2007-05-15 Thread Tejun Heo
Hello, Daniel. Daniel Drake wrote: I was surprised to find that the /sbin/halt spin down implementation is very limited, it only works for IDE disks (by working through /proc/ide). This doesn't make sense to me, the libata commits state that userspace shutdown is spinning down libata disks.

[PATCH] libata: track spindown status and skip spindown_compat if possible

2007-05-15 Thread Tejun Heo
Our assumption that most distros issue STANDBYNOW seems wrong. The upstream sysvinit and thus many distros including gentoo and opensuse don't take any action for libata disks on spindown. We can skip compat handling for these distros so that they don't need to update anything to take advantage

Re: Fixing halt/shutdown for libata spindown handling

2007-05-15 Thread Francesco Pretto
Tejun Heo htejun at gmail.com writes: Final question: should spindown_compat be set to 0 for both shutdown and reboot, or just shutdown? It doesn't really matter. It just needs to be set while powering down. You can set it anywhere, during boot, in shutdown. Thanks.

Re: Fixing halt/shutdown for libata spindown handling

2007-05-15 Thread Tejun Heo
Francesco Pretto wrote: Tejun Heo htejun at gmail.com writes: Final question: should spindown_compat be set to 0 for both shutdown and reboot, or just shutdown? It doesn't really matter. It just needs to be set while powering down. You can set it anywhere, during boot, in shutdown.

Re: [PATCH] libata: Add MMIO support to pata_sil680

2007-05-15 Thread Alan Cox
On Tue, May 15, 2007 at 04:11:23PM +1000, Benjamin Herrenschmidt wrote: + if (!try_mmio) + goto use_pio; Please use a different naming scheme PIO means something quite different in ATA Rest looks fine although I'd be interested to know if you can measure any performance change.

Re: IT821x: no DMA since 2.6.21

2007-05-15 Thread Alan Cox
On Tue, 15 May 2007 12:53:08 +0200 Thomas Kuther [EMAIL PROTECTED] wrote: Hi! Since 2.6.21 I have a problem with the it821x driver on my ITE 8212 controller. Now I saw some updates to it821x in 2.6.22-rc1 and gave that a try, but the problem persists. I've had multiple reports of this. I

Re: IT821x: no DMA since 2.6.21

2007-05-15 Thread Thomas Kuther
On Di, 15.05.07 12:31 Alan Cox [EMAIL PROTECTED] wrote: On Tue, 15 May 2007 12:53:08 +0200 Thomas Kuther [EMAIL PROTECTED] wrote: Hi! Since 2.6.21 I have a problem with the it821x driver on my ITE 8212 controller. Now I saw some updates to it821x in 2.6.22-rc1 and gave that a try,

Re: IT821x: no DMA since 2.6.21

2007-05-15 Thread Alan Cox
I already tried pata_it821x and it failed to recognize the second harddisk hdf. I use the controller only for additional harddrives, no RAID, no cd-rom. Logs from that would be most helpful as I am maintaining the pata_it821x driver. Alan - To unsubscribe from this list: send the line

Re: [PATCH] libata: track spindown status and skip spindown_compat if possible

2007-05-15 Thread Francesco Pretto
Tejun Heo htejun at gmail.com writes: Our assumption that most distros issue STANDBYNOW seems wrong. The upstream sysvinit and thus many distros including gentoo and opensuse don't take any action for libata disks on spindown. We can skip compat handling for these distros so that they

Re: [PATCH] libata: track spindown status and skip spindown_compat if possible

2007-05-15 Thread Tejun Heo
Francesco Pretto wrote: Tejun Heo htejun at gmail.com writes: Our assumption that most distros issue STANDBYNOW seems wrong. The upstream sysvinit and thus many distros including gentoo and opensuse don't take any action for libata disks on spindown. We can skip compat handling for these

Re: [PATCH] libata: track spindown status and skip spindown_compat if possible

2007-05-15 Thread Stephen Clark
Tejun Heo wrote: Francesco Pretto wrote: Tejun Heo htejun at gmail.com writes: Our assumption that most distros issue STANDBYNOW seems wrong. The upstream sysvinit and thus many distros including gentoo and opensuse don't take any action for libata disks on spindown. We can skip

Serial ATA (SATA) shutdown info

2007-05-15 Thread Scott James Remnant
Hi there, I'm the author of Upstart (the init system used by Ubuntu, and other distributions) and was directed to the following page in order to update compatibility with newer kernels and libata: http://linux-ata.org/shutdown.html Unfortunately after reading this, things still aren't

Re: Serial ATA (SATA) shutdown info

2007-05-15 Thread Scott James Remnant
On Tue, 2007-05-15 at 17:34 +0200, Tejun Heo wrote: Hello, Scott. Hi, Thanks for your quick reply! Secondly, we've never attempted any workarounds for libata. Our halt/reboot only iterates /proc/ide, which should be empty for libata-based systems - therefore we've never issued FLUSH

Re: [PATCH] libata: track spindown status and skip spindown_compat if possible

2007-05-15 Thread Francesco Pretto
2007/5/15, Tejun Heo [EMAIL PROTECTED]: Yeah, it's a big mess. With this patch applied, what happens is... * If your shutdown(8) does issue STANDBYNOW : you get the big fat warning and kernel won't issue STANDBYNOW. * If your shutdown(8) doesn't issue STANDBYNOW : kernel issues FLUSH CACHE

Re: [PATCH] libata: Add MMIO support to pata_sil680

2007-05-15 Thread Benjamin Herrenschmidt
On Tue, 2007-05-15 at 07:08 -0400, Alan Cox wrote: On Tue, May 15, 2007 at 04:11:23PM +1000, Benjamin Herrenschmidt wrote: + if (!try_mmio) + goto use_pio; Please use a different naming scheme PIO means something quite different in ATA Indeed, the naming's a bit confusing,

[PATCH] libata: Add MMIO support to pata_sil680

2007-05-15 Thread Benjamin Herrenschmidt
This patch adds MMIO support to the pata_sil680 for taskfile IOs, based on what the old siimage does. I haven't bothered changing the chip setup stuff from PCI config cycles to MMIO though (siimage does it), I don't think it matters, I've only adapted it to use MMIO for taskfile accesses. I've

Re: [PATCH pata-2.6 fix queue] cmd64x: init. code cleanup

2007-05-15 Thread Bartlomiej Zolnierkiewicz
On Thursday 10 May 2007, Sergei Shtylyov wrote: Fix two minor issues with PCI0646 chip reporting in the init_chipset() method: IRQ workaround enabled message printed out not only for revision 0x01 and CMD646: chipset revision printed twice (by IDE core and the driver itself). Also, remove

Re: [patch 1/2] sl82c105: Switch to ref counting API

2007-05-15 Thread Bartlomiej Zolnierkiewicz
On Friday 11 May 2007, [EMAIL PROTECTED] wrote: From: Alan Cox [EMAIL PROTECTED] Not sure how this one got missed in the great purge some time ago but it did. Signed-off-by: Alan Cox [EMAIL PROTECTED] Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED]

Re: [patch 2/2] Use menuconfig objects: IDE

2007-05-15 Thread Bartlomiej Zolnierkiewicz
On Friday 11 May 2007, [EMAIL PROTECTED] wrote: From: Jan Engelhardt [EMAIL PROTECTED] Use menuconfigs instead of menus, so the whole menu can be disabled at once instead of going through all options. Signed-off-by: Jan Engelhardt [EMAIL PROTECTED] Cc: Bartlomiej Zolnierkiewicz [EMAIL

Re: [PATCH pata-2.6 fix queue] aec62xx: rework init_setup_aec6x80()

2007-05-15 Thread Bartlomiej Zolnierkiewicz
On Friday 11 May 2007, Sergei Shtylyov wrote: Rework init_setup_aec6x80() so that it won't rewrite the constant name strings anymore -- in order to do this: - in aec62xx_init_one(), pass a local copy of 'struct pci_device_id' down the call chain; - change the names for in

Re: [PATCH pata-2.6 fix queue] aec62xx: kill speedproc() method wrapper

2007-05-15 Thread Bartlomiej Zolnierkiewicz
On Friday 11 May 2007, Sergei Shtylyov wrote: There's no reason to have the speedproc() method wrapper for the two quite different chip families, so just get rid of it. Signed-off-by: Sergei Shtylyov [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 2/5] Use mutex instead of semaphore in IDE driver

2007-05-15 Thread Bartlomiej Zolnierkiewicz
On Monday 14 May 2007, Matthias Kaehlcke wrote: The IDE driver uses a semaphore as mutex. Use the mutex API instead of the (binary) semaphore. Signed-off-by: Matthias Kaehlcke [EMAIL PROTECTED] applied Since I already had a patch from you with identical patch summary/description (but for

Re: [PATCH]add the IDE device ID for ATI SB700

2007-05-15 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday 14 May 2007, gmail_ati wrote: From: [EMAIL PROTECTED] add the IDE device ids to atiixp_pci_tbl struct in atiixp.c for ATI SB700. Signed-off-by: Luugi Marsan [EMAIL PROTECTED] This patch is somehow missing the chunk adding PCI_DEVICE_ID_ATI_IXP700_IDE define to linux/pci_ids.h

[git patches] IDE updates/fixes

2007-05-15 Thread Bartlomiej Zolnierkiewicz
This time: * host driver fixes: - pdc202xx_old: mode programming rewrite (a lot of bugs fixed) - serverworks/sis5513: PIO mode setup fixes - sl82c105: MWDMA0/1 support by Sergei - cs5530/sc1200/sl82c105: -speedproc support (hdparm -X) * 2nd part of cleanups basing on DMA tuning rework

Re: IT821x: no DMA since 2.6.21

2007-05-15 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 15 May 2007, Alan Cox wrote: On Tue, 15 May 2007 12:53:08 +0200 Thomas Kuther [EMAIL PROTECTED] wrote: Hi! Since 2.6.21 I have a problem with the it821x driver on my ITE 8212 controller. Now I saw some updates to it821x in 2.6.22-rc1 and gave that a try, but the

RE: [PATCH]add the IDE device ID for ATI SB700

2007-05-15 Thread Henry Su
hi Bart, Thanks for your kindly reply, it's seems that something wrong with the MS outlook, the IXP700 device ID is defined to /linux/pci_ids.h in another patch,I will resend the complete patch. BRS, Henry -Original Message- From: Bartlomiej Zolnierkiewicz [mailto:[EMAIL PROTECTED]

Re: [PATCH] drivers/ata: correct a wrong free function for sata_nv driver

2007-05-15 Thread Jeff Garzik
Peer Chen wrote: For sata_nv driver in kernel 2.6.21 onward, Inside nv_init_one(),use 'hpriv = devm_kzalloc(pdev-dev, sizeof(*hpriv), GFP_KERNEL);' but using the kfree(hpriv) to free that data struction in nv_remove_one(), which will cause system hang when removing the sata_nv module. Change

Re: [PATCH] libata: fix shutdown warning message printing

2007-05-15 Thread Jeff Garzik
Tejun Heo wrote: Unlocking ap-lock and ssleeping don't work because SCSI commands can be issued from completion path without context. Reimplement delayed completion by allowing translation functions to override qc-scsidone(), storing the original completion function to scmd-scsi_done() and

Re: [PATCH] libata: track spindown status and skip spindown_compat if possible

2007-05-15 Thread Jeff Garzik
Tejun Heo wrote: Our assumption that most distros issue STANDBYNOW seems wrong. The upstream sysvinit and thus many distros including gentoo and opensuse don't take any action for libata disks on spindown. We can skip compat handling for these distros so that they don't need to update anything

RE: [PATCH] drivers/ata: correct a wrong free function for sata_nv driver

2007-05-15 Thread Peer Chen
Sorry for posting a fault patch,following is the right one. Signed-off-by: Peer Chen [EMAIL PROTECTED] === --- linux-2.6.22-rc1/drivers/ata/sata_nv.c.orig +++ linux-2.6.22-rc1/drivers/ata/sata_nv.c @@ -1619,7 +1619,7 @@ static void nv_remove_one (struct pci_de

[git patches] libata fixes

2007-05-15 Thread Jeff Garzik
All bug fixes. The two things that do not seem like bugfixes (separate out... and add ATA_FLAG_ACPI_SATA) are not as they seem. The former is a prep patch for a fix, and the latter fixes what ACPI considers a legacy IDE interface. Please pull from 'upstream-linus' branch of