Re: [PATCH libata-dev#upstream-fixes] libata: force PIO on IOMEGA ZIP 250 ATAPI

2007-06-10 Thread Tejun Heo
Jeff Garzik wrote: > Tejun Heo wrote: >> @@ -3769,6 +3769,7 @@ static const struct ata_blacklist_entry >> ata_device_blacklist [] = { >> { "_NEC DV5800A", NULL,ATA_HORKAGE_NODMA }, >> { "SAMSUNG CD-ROM SN-124","N001",ATA_HORKAGE_NODMA }, >> { "Seagate STT2A", NULL

Re: [PATCH] libata: limit post SRST nsect/lbal wait to ~100ms

2007-06-10 Thread Jeff Garzik
Tejun Heo wrote: After SRST, libata used to wait for nsect/lbal to be set to 1/1 for the slave device. However, some ATAPI devices don't set nsect/lbal after SRST and the wait itself isn't too useful as we're gonna wait for !BSY right after that anyway. Before reset-seq update, nsect/lbal wait

Re: [PATCH libata-dev#upstream-fixes] libata: force PIO on IOMEGA ZIP 250 ATAPI

2007-06-10 Thread Jeff Garzik
Tejun Heo wrote: IOMEGA ZIP 250 ATAPI claims MWDMA0 support but fails SETXFERMODE if asked to configure itself to MWDMA0. Force PIO. This fixes bugzilla bug#8497. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> Cc: Calvin Walton <[EMAIL PROTECTED]> --- There was another proposed patch which lower

[git patches] more libata fixes

2007-06-10 Thread Jeff Garzik
The following is CUMULATIVE to the previous push, but in the same linear history. IOW, pulling 'linus-plus-plus' also gets you 'upstream-linus'. But if you have already pulled 'upstream-linus', you will only receive these two changesets. Please pull from branch 'linus-plus-plus' of master.kernel

Re: [PATCH] pata_it821x: (partially) fix DMA in RAID mode

2007-06-10 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: Code intended to check DMA status was checking DMA command register. Moreover firmware seems to "forget" to set DMA capable bit for the slave device (at least in RAID mode but without ITE RAID volumes) so check device ID for DMA capable bit when deciding whether

Re: 2.6.22-rc regression: smartctl does not work with SATA disk

2007-06-10 Thread Justin Piszcz
On Sun, 10 Jun 2007, Mark Lord wrote: Kai Makisara wrote: The command 'smartctl -a /dev/sdb' fails with 2.6.22-rc4 kernel. The disk /dev/sdb is a SATA disk. The command does work still with a real SCSI disk. Last time I checked, one must supply the "-d ata" parameter to smartctl for it to w

Re: 2.6.22-rc regression: smartctl does not work with SATA disk

2007-06-10 Thread Mark Lord
Kai Makisara wrote: The command 'smartctl -a /dev/sdb' fails with 2.6.22-rc4 kernel. The disk /dev/sdb is a SATA disk. The command does work still with a real SCSI disk. Last time I checked, one must supply the "-d ata" parameter to smartctl for it to work with libata drives. Has this changed

Re: [PATCH 1/6] libata: update protocol numbers

2007-06-10 Thread Mark Lord
Jeff Garzik wrote: Albert Lee wrote: Patch 1/6: Update the ATA passthru protocol numbers according to the new spec. Signed-off-by: Albert Lee <[EMAIL PROTECTED]> applied 1-4, 6 to #upstream-fixes What about this one: [PATCH 5/6] libata: support ATAPI devices ?? I'm quite happy to let Al

Re: libata and legacy ide pcmcia failure

2007-06-10 Thread Mark Lord
Robert de Rooy wrote: Mark Lord wrote: Oh crap. I did test it a couple of months ago, but my boot/root drive is libata not IDE -- so no panic on boot with it. After booting, it worked just fine talking to PC-CARD CF devices using the polling. Ok, no problem. I recompiled the kernel with li

Re: [PATCH] pata_it821x: sync with IDE it821x driver

2007-06-10 Thread Alan Cox
> > NAK this too > > OK, I'm able to understand the meaning of "NAK" [1] but "this too"? That was me being confusing with something else I NAKked that wasn't from you. It may have made sense to Jeff but not you - sorry > PIO fix was directly ported from my it821x.c patch. I now see that thanks

Re: [PATCH] pata_it821x: (partially) fix DMA in RAID mode

2007-06-10 Thread Alan Cox
> Cc: Alan Cox <[EMAIL PROTECTED]> > Cc: Tejun Heo <[EMAIL PROTECTED]> > Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Alan Cox <[EMAIL PROTECTED]> > - /* Bits 5 and 6 indicate if DMA is active on master/slave */ > - /* It is possible that BMDMA isn't allocated

Re: [PATCH libata-dev#upstream-fixes] libata: force PIO on IOMEGA ZIP 250 ATAPI

2007-06-10 Thread Bartlomiej Zolnierkiewicz
On Sunday 10 June 2007, Alan Cox wrote: > On Sun, 10 Jun 2007 14:52:36 +0900 > Tejun Heo <[EMAIL PROTECTED]> wrote: > > > IOMEGA ZIP 250 ATAPI claims MWDMA0 support but fails SETXFERMODE if > > asked to configure itself to MWDMA0. Force PIO. > > This is only really a temporary fix. It appears to

Re: [PATCH] pata_it821x: sync with IDE it821x driver

2007-06-10 Thread Bartlomiej Zolnierkiewicz
Hi Alan! On Sunday 10 June 2007, Alan Cox wrote: > > @@ -258,8 +259,14 @@ static void it821x_passthru_set_piomode( > > static const u8 pio_want[]= { ATA_66, ATA_66, ATA_66, ATA_66, > > ATA_ANY }; > > > > struct it821x_dev *itdev = ap->private_data; > > + struct ata_device *pair =

[PATCH] pata_it821x: (partially) fix DMA in RAID mode

2007-06-10 Thread Bartlomiej Zolnierkiewicz
Code intended to check DMA status was checking DMA command register. Moreover firmware seems to "forget" to set DMA capable bit for the slave device (at least in RAID mode but without ITE RAID volumes) so check device ID for DMA capable bit when deciding whether to use DMA and remove DMA status c

Re: [PATCH] libata: limit post SRST nsect/lbal wait to ~100ms

2007-06-10 Thread Jeff Garzik
Tejun Heo wrote: After SRST, libata used to wait for nsect/lbal to be set to 1/1 for the slave device. However, some ATAPI devices don't set nsect/lbal after SRST and the wait itself isn't too useful as we're gonna wait for !BSY right after that anyway. Before reset-seq update, nsect/lbal wait

Re: [PATCH] pata_it821x: sync with IDE it821x driver

2007-06-10 Thread Alan Cox
> @@ -258,8 +259,14 @@ static void it821x_passthru_set_piomode( > static const u8 pio_want[]= { ATA_66, ATA_66, ATA_66, ATA_66, > ATA_ANY }; > > struct it821x_dev *itdev = ap->private_data; > + struct ata_device *pair = ata_dev_pair(adev); > int unit = adev->devno; > -

Re: [PATCH] pata_it821x: sync with IDE it821x driver

2007-06-10 Thread Alan Cox
> Hmmm... indeed. Alan, is there any reason we do that in ->set_piomode > not ->mode_filter? We end up with mismatching configuration between the > controller and the higher speed drive. We always talk more slowly than the drive which is just fine. Just about every device on every controller doe

Re: [PATCH libata-dev#upstream-fixes] libata: force PIO on IOMEGA ZIP 250 ATAPI

2007-06-10 Thread Alan Cox
On Sun, 10 Jun 2007 14:52:36 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > IOMEGA ZIP 250 ATAPI claims MWDMA0 support but fails SETXFERMODE if > asked to configure itself to MWDMA0. Force PIO. This is only really a temporary fix. It appears to manage MWDMA0 in some cases with old IDE.. - To unsub

[PATCH 5/5] via82cxxx: backport short cables support from pata_via.c

2007-06-10 Thread Bartlomiej Zolnierkiewicz
Backport short cables support from pata_via.c. This patch should allow UDMA > 2 modes on Acer Ferrari 3400. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/via82cxxx.c | 48 +--- 1 file changed, 41 insertions(+), 7 delet

[PATCH 2/5] piix: backport short cables support from ata_piix.c

2007-06-10 Thread Bartlomiej Zolnierkiewicz
Backport short cables support from ata_piix.c. This patch should allow UDMA > 2 modes on: - Acer 5602WLMi - Acer 3682WLMi - Asus W5F - Acer Aspire 2023WLMi Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/piix.c | 37 ++--- 1 fil

[PATCH 3/5] alim15x3: backport short cables support from pata_ali.c

2007-06-10 Thread Bartlomiej Zolnierkiewicz
Backport short cables support from pata_ali.c and while at it cleanup existing cable detection code. This patch should allow UDMA > 2 modes on HP Pavilion N5430 and Fujitsu P2000. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/alim15x3.c | 73

[PATCH 4/5] sis5513: backport short cables support from pata_sis.c

2007-06-10 Thread Bartlomiej Zolnierkiewicz
Backport short cables support from pata_sis.c. This patch should allow UDMA > 2 modes on ASUS A6K. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/pci/sis5513.c | 25 - 1 file changed, 24 insertions(+), 1 deletion(-) Index: b/drivers/ide/p

[PATCH 1/5] ide: add short cables support

2007-06-10 Thread Bartlomiej Zolnierkiewicz
This patch allows users to override both host and device side cable detection with "ideX=ata66" kernel parameter. Thanks to this it should be now possible to use UDMA > 2 modes on systems (laptops mainly) which use short 40-pin cable instead of 80-pin one. Next patches add automatic detection of

2.6.22-rc regression: smartctl does not work with SATA disk

2007-06-10 Thread Kai Makisara
The command 'smartctl -a /dev/sdb' fails with 2.6.22-rc4 kernel. The disk /dev/sdb is a SATA disk. The command does work still with a real SCSI disk. The computer has Athlon64 X2 and it is running x86_64 SMP kernel. The chipset is Nvidia CK804 and the sata_nv driver is used. The following outp