[PATCH/RFC 9/9] libata: remove irq_on/off and rename freeze()/thaw() to irq_on/off

Patch 9/9: It seems ->irq_on and ->irq_off are now only wrapped by freeze()/thaw() and unused elsewhere. This patch - Remove ->irq_on and ->irq_off. - Rename ->freeze and ->thaw to irq_on() and irq_off() to be specific. Hopefully the LLDDs need to implement only one irq on/off by either h

[PATCH/RFC 8/9] libata: remove writing of tf->ctl from ata_tf_load()

Patch 8/9: Currently ata_tf_load() writes to the Control register if it is changed. The relevant bits in the ctl register are HOB, SRST and nIEN. - HOB is only used by ata_tf_read(). - For SRST, soft reset is not the duty of tf_load. - For nIEN, explicit irq_on()/irq_off and freeze()/thaw() a

[PATCH/RFC 7/9] libata: pdc_freeze() semantic change

Patch 7/9: After checking the current implementations of freeze()/thaw(), it seems only pdc_freeze() do more than simple irq masking. Remove the DMA disable code from pdc_freeze(). The question is the design/semantic of freeze()/thaw(). Maybe we should limit them to simple irq on/off? Signed-o

[PATCH/RFC 6/9] libata: add freeze()/thaw() to old EH LLDDs

Patch 6/9: Since now the polling code path uses freeze()/thaw() regardless of old EH or new EH. Add freeze()/thaw() to old EH LLDDs for use by the polling code. Signed-off-by: Albert Lee <[EMAIL PROTECTED]> --- diff -Nrup 05_convert_hsm_to_freeze/drivers/ata/pata_ixp4xx_cf.c 06_add_freeze_thaw

[PATCH/RFC 5/9] libata: use freeze()/thaw() for polling

Patch 5/9: This patch changes polling codes to use freeze()/thaw() for irq off/on. ata_qc_set_polling() is also removed since now unused. The reason for freeze()/thaw(): some ATAPI devices raises INTRQ even if nIEN = 1. Using the host adapter irq mask mechanism, if available, is more reliable

[PATCH/RFC 4/9] libata: call irq_off from bmdma_freeze()

Patch 4/9: Minor patch to call irq_off() from bmdma_freeze() to avoid duplicated code. Signed-off-by: Albert Lee <[EMAIL PROTECTED]> --- diff -Nrup 03_add_irq_off_lldd/drivers/ata/libata-sff.c 04_convert_freeze/drivers/ata/libata-sff.c --- 03_add_irq_off_lldd/drivers/ata/libata-sff.c20

[PATCH/RFC 3/9] libata: add ->irq_off() to LLDDs

Patch 3/9: Minor patch to add the newly added ->irq_off() to LLDDs. Signed-off-by: Albert Lee <[EMAIL PROTECTED]> --- diff -Nrup 02_add_irq_off/drivers/ata/ahci.c 03_add_irq_off_lldd/drivers/ata/ahci.c --- 02_add_irq_off/drivers/ata/ahci.c 2007-06-01 12:08:21.0 +0800 +++ 03_add_irq_o

[PATCH/RFC 2/9] libata: add irq_off() for symmetry

Patch 2/9: Currently there is irq_on() but no irq_off(). Turning irq off is done via altering the nIEN bit of qc->tf, together with tf_load(). This patch adds irq_off() for symmetry. tf_load() and ata_qc_set_polling() will be fixed/removed in later patches. Signed-off-by: Albert Lee <[EMAIL PRO

[PATCH/RFC 1/9] libata: remove irq_on from ata_bus_reset() and ata_std_postreset()

Patch 1/9: It looks the calling of irq_on() in ata_bus_reset() and ata_std_postreset() are leftover of the earlier EDD reset. Remove them. Signed-off-by: Albert Lee <[EMAIL PROTECTED]> --- diff -Nrup 00_libata-dev/drivers/ata/libata-core.c 01_remove_leftover_irqon/drivers/ata/libata-core.c ---

[PATCH/RFC 0/9] libata: irq_on/off restructuring

For ATA, there are two levels of mechanism available to turn irq on/off. - device level: nIEN bit in the control register. nIEN masks INTRQ from the device. - host adapter level: some controller can mask out per-port irq from the host adapter. Currently various parts of libata deal with irq on

[-mm patch] drivers/ide/ide-dma.c: unexport ide_set_dma

ide_set_dma no longer has any modular user. Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> --- --- linux-2.6.22-rc4-mm2/drivers/ide/ide-dma.c.old 2007-06-14 23:52:30.0 +0200 +++ linux-2.6.22-rc4-mm2/drivers/ide/ide-dma.c 2007-06-14 23:52:38.0 +0200 @@ -847,8 +847,6 @@

[PATCH 2.6.22-rc4]: libata: PATA-mode fixes for sis_sata

Changed PATA handler for PATA-ports used by sata_sis. This patch was originally submitted by Jeff Garzik. Added PCI-ID 1180 for SiS966 Controller in pata_sis. The 1180 mode is fully compatible to other SiS PATA-controller. The PCI-ID 1183 is SATA in PATA-emulation, but not fully compatible to SiS

Re: [patch 2a/3] Expose Power Management Policy option to users

Kristen Carlson Accardi wrote: Ok - sorry for my ignorance about SCSI - but my sources (i.e. Arjan) tell me that the problem is that Link in ATA land means something different than Link in SCSI land, and that what I really need to do is leave this code under the Host class, but rename it to som

Re: SATA problems

Nigel Kukard wrote: I'm stumped trying to track down the below intermittent problem. I've confirmed this problem on 2.6.19, 2.6.20 and 2.6.21. Jun 14 07:55:52 nigel-m2v kernel: ata2.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen Jun 14 07:55:52 nigel-m2v kernel: ata2.00: cmd

Re: [patch 2a/3] Expose Power Management Policy option to users

On Wed, 13 Jun 2007 08:26:48 -0700 James Bottomley <[EMAIL PROTECTED]> wrote: > On Tue, 2007-06-12 at 10:46 -0700, Kristen Carlson Accardi wrote: > > Expose Power Management Policy option to users > > > > This patch will modify the scsi subsystem to allow > > users to set a power management polic

Re: libata interface fatal error

Hi Tejun, Okay, ich8. I don't think the chipset is at fault here and you have a lot of disks. My primary suspect is power supply problem but things like this are hard to prove. With the merged speed down fix, libata will do the right thing after a few errors, so ignoring the problem wouldn't

Re: libata interface fatal error

Florian Effenberger wrote: > Hi, > >> Can you post the result of 'hdparm -I /dev/sdX'? > > thanks a lot for your kind support, that is much appreciated! > > Attached is some machine output, hope that helps. Let me know I you need > more information. Okay, ich8. I don't think the chipset is at

Re: [patch 0/3] AHCI Link Power Management

Jens Axboe wrote: >> 1. It didn't have proper interface with userland. This was mainly >> because of missing ATA sysfs nodes. I'm not sure whether adding this to >> scsi node is a good idea. >> >> 2. It was focused on SATA link PS and couldn't cover the Lenovo case. >> >> I think we need somethin

Re: [patch 0/3] AHCI Link Power Management

On Tue, Jun 12 2007, Tejun Heo wrote: > Arjan van de Ven wrote: > >> I'm not sure about this. We need better PM framework to support > >> powersaving in other controllers and some ahcis don't save much > >> when only link power management is used, > > > > do you have data to support this? > > Y

Re: libata interface fatal error

Hi, Can you post the result of 'hdparm -I /dev/sdX'? thanks a lot for your kind support, that is much appreciated! Attached is some machine output, hope that helps. Let me know I you need more information. Florian 00:00.0 Host bridge: Intel Corporation P965/G965 Memory Controller Hub (rev

Re: libata interface fatal error

Florian Effenberger wrote: > Hi Tejun, > >> Okay, there was a bug in link speed limit logic. That's probably why >> speed down to 1.5Gbps didn't kick in. The attached patch contains the >> fix and hack to force 1.5Gbps. Please give it a shot. > > thanks a lot for your patch, it seems to work,

Re: libata and legacy ide pcmcia failure

Albert Lee wrote: >> >> libata can do most of this too by using ATA_FLAG_PIO_POLLING (doesn't >> cover nodata commands tho). >> > > Hi Tejun, > > Polling of nodata commands was fixed in: > http://marc.info/?l=linux-ide&m=116546272916399&w=2 Right. Thanks for reminding me. :-) -- tejun - To u

Re: [PROBLEM + PATCH] Sata port disabled by BIOS gets initialized

Hello, Matt Sealey wrote: > Isn't there a case for speeding up boot and not wasting resources by > respecting BIOS settings in this regard? If you have an 8-port > controller on a board and one disk, forcing all of them enabled > regardless of BIOS settings is just 7 redundant port scans. Ports c

Re: [patch 0/3] AHCI Link Power Management

Kristen Carlson Accardi wrote: > I'm not sure about this. We need better PM framework to support > powersaving in other controllers and some ahcis don't save much > when only link power management is used, do you have data to support this? >>> Yeah, it was some Lenovo notebook.