Re: how to handle pata_via when controller not in fully-pci-native mode (two irqs?)

2007-06-22 Thread Jeff Garzik
Matt Sealey wrote: Just bringing this up again as it's about that time of year. There's an issue with some Via southbridges (the only notable and confirmed example I have being the VT8231 on the PegasosPPC) which can be configured such that they report that they are in "PCI Native Mode", but in

Re: [RFC: 2.6 patch] schedule BLK_DEV_IDE_SATA for removal

2007-06-22 Thread Jeff Garzik
Paul Mackerras wrote: Alan Cox writes: On Fri, 22 Jun 2007 11:39:45 +0800 David Woodhouse <[EMAIL PROTECTED]> wrote: On Fri, 2007-06-22 at 01:52 +0200, Adrian Bunk wrote: Users should use the libata based drivers for SATA drives. NAK. Not all IDE drivers are converted yet. Not even all the

Re: [RFC: 2.6 patch] schedule BLK_DEV_IDE_SATA for removal

2007-06-22 Thread Paul Mackerras
Alan Cox writes: > On Fri, 22 Jun 2007 11:39:45 +0800 > David Woodhouse <[EMAIL PROTECTED]> wrote: > > > On Fri, 2007-06-22 at 01:52 +0200, Adrian Bunk wrote: > > > Users should use the libata based drivers for SATA drives. > > > > NAK. Not all IDE drivers are converted yet. Not even all the rel

how to handle pata_via when controller not in fully-pci-native mode (two irqs?)

2007-06-22 Thread Matt Sealey
Just bringing this up again as it's about that time of year. There's an issue with some Via southbridges (the only notable and confirmed example I have being the VT8231 on the PegasosPPC) which can be configured such that they report that they are in "PCI Native Mode", but in fact handle (and repo

Re: [PATCH] libata: Add pata_dma option so users can disable pata_dma as they can with old-ide

2007-06-22 Thread Alan Cox
> > I think a /sys/ "dma" attribute (pick a name) might be most appropriate, > > or we just just implement HDIO_[GS]ET_DMA as a simpler/lazier mechanism. > > The problem is that libata lacks any locking needed for having this > (and other useful) settings tunable on per device basis. Actually lib

Re: SATA update in 2.4, ICH8

2007-06-22 Thread Willy Tarreau
On Fri, Jun 22, 2007 at 08:29:15AM +0200, Vincent Bernat wrote: > Hi Willy ! > > > I do not have any idea right now. I recall having had some difficulties some > > time ago with ata_piix when piix itself was not disabled, but those were in > > the early libata times. I *believe* it's OK now but y

Error in syslog on 2.6.20

2007-06-22 Thread William Thompson
I'm not on either list, keep me in CC. I noticed the following error on a cdrom device: ata2.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen ata2.00: cmd a0/00:00:00:00:20/00:00:00:00:00/a0 tag 0 cdb 0x0 data 0 res 40/00:03:00:00:00/00:00:00:00:00/a0 Emask 0x4 (timeout) ata2:

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-22 Thread Jens Axboe
On Fri, Jun 22 2007, Kristen Carlson Accardi wrote: > On Thu, 21 Jun 2007 15:08:32 +0200 > Jens Axboe <[EMAIL PROTECTED]> wrote: > > > On Wed, Jun 20 2007, Kristen Carlson Accardi wrote: > > > Enable Aggressive Link Power management for AHCI controllers. > > > > > > This patch will set the correc

Re: [PATCH] libata: Add pata_dma option so users can disable pata_dma as they can with old-ide

2007-06-22 Thread Bartlomiej Zolnierkiewicz
On Friday 22 June 2007, Mark Lord wrote: > Alan Cox wrote: > > On Fri, 22 Jun 2007 11:01:09 -0400 > > Mark Lord <[EMAIL PROTECTED]> wrote: > > > >> Alan Cox wrote: > >>> Allow > >>> > >>> libata.pata_dma=0 > >>> > >>> to disable DMA (default is 1) > >>> > >>> SATA is unaffected as disabling DMA

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-22 Thread Kristen Carlson Accardi
On Thu, 21 Jun 2007 15:08:32 +0200 Jens Axboe <[EMAIL PROTECTED]> wrote: > On Wed, Jun 20 2007, Kristen Carlson Accardi wrote: > > Enable Aggressive Link Power management for AHCI controllers. > > > > This patch will set the correct bits to turn on Aggressive > > Link Power Management (ALPM) for

Re: [PATCH] libata: Add pata_dma option so users can disable pata_dma as they can with old-ide

2007-06-22 Thread Mark Lord
Alan Cox wrote: On Fri, 22 Jun 2007 11:01:09 -0400 Mark Lord <[EMAIL PROTECTED]> wrote: Alan Cox wrote: Allow libata.pata_dma=0 to disable DMA (default is 1) SATA is unaffected as disabling DMA for SATA makes no sense at all. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> Alan, Shou

Re: [RFT] hpt366: reset DMA state machine on timeouts

2007-06-22 Thread Linas Vepstas
On Fri, Jun 22, 2007 at 07:32:44PM +0400, Sergei Shtylyov wrote: > > >>Reset HPT36x's DMA state machine on a DMA timeout the way it's done for > >>HPT370. > >>drivers/ide/pci/hpt366.c | 24 +++- > > >This worked great! > >I hope you meant those messages were preceeded

Re: [RFT] hpt366: reset DMA state machine on timeouts

2007-06-22 Thread Alan Cox
> > Turn off UDMA and you turn off cable side error protection, so if your > > error is caused by noise you just did the electronic version of a long > > walk off a short pier. > > Right. Yes. Clearly, I must be debugging with half a brain, here. Half a brain each so together we can manage ;) I'

Re: [RFT] hpt366: reset DMA state machine on timeouts

2007-06-22 Thread Linas Vepstas
On Fri, Jun 22, 2007 at 04:54:31PM +0100, Alan Cox wrote: > >I'm not sure what to do if this had been the only disk in the system. > >Maybe if the eror reate exceed 100/minute, then dma is turned off > >permanently? > > Turn off UDMA and you turn off cable side error protection, so if

Re: [RFT] hpt366: reset DMA state machine on timeouts

2007-06-22 Thread Alan Cox
>I'm not sure what to do if this had been the only disk in the system. >Maybe if the eror reate exceed 100/minute, then dma is turned off >permanently? Turn off UDMA and you turn off cable side error protection, so if your error is caused by noise you just did the electronic version o

Re: [PATCH] libata: Add pata_dma option so users can disable pata_dma as they can with old-ide

2007-06-22 Thread Alan Cox
On Fri, 22 Jun 2007 11:01:09 -0400 Mark Lord <[EMAIL PROTECTED]> wrote: > Alan Cox wrote: > > Allow > > > > libata.pata_dma=0 > > > > to disable DMA (default is 1) > > > > SATA is unaffected as disabling DMA for SATA makes no sense at all. > > > > Signed-off-by: Alan Cox <[EMAIL PROTECTED]

Re: [BUG] ide dma_timer_expiry, then hard lockup

2007-06-22 Thread Sergei Shtylyov
Linas Vepstas wrote: I've got a hard lockup in the ide subsystem, probably due to some irq spew or something like that. I've just bought a brand new Maxtor 320GB disk driver for the insane price of $70 US to replace another failing drive. It works well under light load; I was able to copy ab

Re: [RFT] hpt366: reset DMA state machine on timeouts

2007-06-22 Thread Sergei Shtylyov
Hello. Linas Vepstas wrote: Reset HPT36x's DMA state machine on a DMA timeout the way it's done for HPT370. Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> --- Linas, here's what I've come up with -- this should apply against 2.6.21.y. Compile-tested only, not for merging. drivers/i

Re: [RFT] hpt366: reset DMA state machine on timeouts

2007-06-22 Thread Linas Vepstas
On Thu, Jun 21, 2007 at 09:54:47PM +0400, Sergei Shtylyov wrote: > Reset HPT36x's DMA state machine on a DMA timeout the way it's done for > HPT370. > > Signed-off-by: Sergei Shtylyov <[EMAIL PROTECTED]> > > --- > Linas, here's what I've come up with -- this should apply against 2.6.21.y. > Comp

Re: [PATCH] libata: Add pata_dma option so users can disable pata_dma as they can with old-ide

2007-06-22 Thread Mark Lord
Alan Cox wrote: Allow libata.pata_dma=0 to disable DMA (default is 1) SATA is unaffected as disabling DMA for SATA makes no sense at all. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> Alan, Should we really be piling up like this on global boot/module options rather than run-time fla

Re: SATA: Is "DPO and FUA" ever supported?

2007-06-22 Thread Sergei Shtylyov
Hello, I wrote. On each and every machine out there, and on every dmesg output posted on numerous mailinglists, I see messages similar to this: scsi 0:0:0:0: Direct-Access ATA ST3250620NS 3.AE PQ: 0 ANSI: 5 SCSI device sda: 488397168 512-byte hdwr sectors (250059 MB) SCSI devic

Re: SATA: Is "DPO and FUA" ever supported?

2007-06-22 Thread Sergei Shtylyov
Hello. Michael Tokarev wrote: On each and every machine out there, and on every dmesg output posted on numerous mailinglists, I see messages similar to this: scsi 0:0:0:0: Direct-Access ATA ST3250620NS 3.AE PQ: 0 ANSI: 5 SCSI device sda: 488397168 512-byte hdwr sectors (250059

Re: [PATCH] ide: Stop mapping ROMs

2007-06-22 Thread Sergei Shtylyov
Hello. Alan Cox wrote: Various old IDE drivers go mapping ROM devices for no apparent reason and without using the ROM mapping API we now have. They don't actually use Hm, do you mean the sysfs based aproach? I've tried that and somehow it failed to work for me -- that's because I deferre

[PATCH] libata: Add pata_dma option so users can disable pata_dma as they can with old-ide

2007-06-22 Thread Alan Cox
Allow libata.pata_dma=0 to disable DMA (default is 1) SATA is unaffected as disabling DMA for SATA makes no sense at all. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.22-rc4-mm2/drivers/ata/libata-core.c

Re: libata and legacy ide pcmcia failure

2007-06-22 Thread Mark Lord
Robert de Rooy wrote: I did another try with libata pcmcia support using 2.6.22-rc5 which already includes the nodata polling fix, in combination with disable-dev_init_param-and-setxfermode-for-CFA.patch and the timing-debug.patch ... Jun 22 13:19:44 localhost kernel: ata3.00: issuing IDENT

[PATCH] ide: Stop mapping ROMs

2007-06-22 Thread Alan Cox
Various old IDE drivers go mapping ROM devices for no apparent reason and without using the ROM mapping API we now have. They don't actually use the ROM they map and the new libata drivers are happy without it being mapped so rather than port them lets just junk it for the next -rc1. Signed-off-by

[PATCH] ide: Fix a theoretical Ooops case

2007-06-22 Thread Alan Cox
Found by a static analyser. It is in theory possible we dereference dev->id when it has become invalid. Re-order to avoid this. Not needed for new-ide as we no longer support the crazy exabyte nest stuff Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /u

Re: libata and legacy ide pcmcia failure

2007-06-22 Thread Robert de Rooy
Tejun Heo wrote: Albert Lee wrote: libata can do most of this too by using ATA_FLAG_PIO_POLLING (doesn't cover nodata commands tho). Hi Tejun, Polling of nodata commands was fixed in: http://marc.info/?l=linux-ide&m=116546272916399&w=2 Right. Thanks for reminding me. :-)

Re: [RFC: 2.6 patch] schedule BLK_DEV_IDE_SATA for removal

2007-06-22 Thread Alan Cox
On Fri, 22 Jun 2007 11:39:45 +0800 David Woodhouse <[EMAIL PROTECTED]> wrote: > On Fri, 2007-06-22 at 01:52 +0200, Adrian Bunk wrote: > > Users should use the libata based drivers for SATA drives. > > NAK. Not all IDE drivers are converted yet. Not even all the relatively > common ones. All the

Re: [RFC: 2.6 patch] schedule BLK_DEV_IDE_SATA for removal

2007-06-22 Thread Alan Cox
On Fri, 22 Jun 2007 01:52:11 +0200 Adrian Bunk <[EMAIL PROTECTED]> wrote: > Users should use the libata based drivers for SATA drives. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> > > --- > --- linux-2.6.22-rc4-mm2/Documentation/feature-removal-schedule.txt.old > 2007-06-21 23:41:03

Re: SATA update in 2.4, ICH8

2007-06-22 Thread Vincent Bernat
OoO Pendant le journal télévisé du jeudi 21 juin 2007, vers 20:21, Willy Tarreau <[EMAIL PROTECTED]> disait: > I do not have any idea right now. I recall having had some difficulties some > time ago with ata_piix when piix itself was not disabled, but those were in > the early libata times. I *bel