Re: PROBLEM: SATA AHCI driver significant throughput loss in 2.6.22-rc5-g75154f40-dirty

2007-06-30 Thread Andrew Morton
On Wed, 27 Jun 2007 00:17:24 -0400 Dan [EMAIL PROTECTED] wrote: Something changed with the AHCI SATA driver in the latest git version. With 2.6.21 I get ~49MB/sec according to hdparm. Using the latest git version I only get ~8MB/sec. I've attached my .config and have included some info about

[PATCH 2.6.22-rc6] add PCI-ID for Adaptec 1430SA 4-Port SATA Controller

2007-06-30 Thread Florian Attenberger
Hi, added this pci id to support my: lspci: 01:00.0 RAID bus controller: Adaptec Unknown device 0243 (rev 02) lspci -n: 01:00.0 0104: 9005:0243 (rev 02) seems to work fine. florian attenberger --- 2.6.22-rc6/drivers/ata/sata_mv.c2007-06-30 16:21:47.462020256 +0200 +++

Re: device error via SDB FIS

2007-06-30 Thread Justin Piszcz
Run smart tests yet? 1. smartctl -d ata -t short /dev/sda 2. smartctl -d ata -a /dev/sda (after few min) also replace short with long and then paste the output: smartctl -d ata -a /dev/sda There have been lots of reports on newegg concerning the HD501 DOA after several hours. Justin. On

[PATCH 1/15] serverworks: always tune PIO

2007-06-30 Thread Bartlomiej Zolnierkiewicz
* Always set -autotune so PIO gets correctly auto-tuned (previously -autotune was only set when -dma_base wasn't available, however -ide_dma_check()/-speedproc() was always trying to tune PIO when tuning DMA). * Move code responsible for programming chipset for PIO mode from

[PATCH 2/15] serverworks: fix DMA

2007-06-30 Thread Bartlomiej Zolnierkiewicz
The driver used to depend on BIOS settings for deciding whether it is OK to use DMA. However it seems that BIOS doesn't always handle all cases correctly so just let IDE core to decide about this. It should be a safe thing to do now, after the driver went through heavy bugfixing. Thanks for

[PATCH 3/15] ide: ide_start_power_step() fix WRT disabling DMA

2007-06-30 Thread Bartlomiej Zolnierkiewicz
* Do the same thing as probe_hwif() and always disable DMA so chipset DMA enabled bit gets cleared (if the drive doesn't support DMA ide_set_dma() won't try to tune it anyway). * Add TODO comment about respecting -using_dma setting. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]

[PATCH 4/15] sc1200: remove stale Power Management code

2007-06-30 Thread Bartlomiej Zolnierkiewicz
* Nowadays core IDE code handles restoring of PIO and DMA modes (ide-io.c:ide_start_power_step() etc) so remove open-coded version from sc1200_resume(). There should be no change in behavior because settings done by sc1200_resume() were always overridden by generic_ide_resume() and

[PATCH 5/15] ide: add ata_pio_cycle_time() helper

2007-06-30 Thread Bartlomiej Zolnierkiewicz
* Add ata_pio_cycle_time() helper. * Use it in ali14xx/ht6560b/qd65xx/cmd64{0,x}/sl82c105 and pmac host drivers (previously cycle time given by the device was only used for pio == 255). * Remove no longer needed ide_pio_data_t.cycle_time field. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH 6/15] ide: ide_find_best_pio_mode() fixes

2007-06-30 Thread Bartlomiej Zolnierkiewicz
* Check IORDY bit for PIO modes 2. * Some devices claim maximum PIO mode 2 in id-tPIO, they were punished too severly for this by being limited to PIO_SLOW. Limit them to PIO2 instead. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-timing.h | 10

[PATCH 8/15] ide: remove ide_find_best_pio_mode()

2007-06-30 Thread Bartlomiej Zolnierkiewicz
* Add -host_flags to ide_hwif_t to store ide_pci_device_t.host_flags, assign it in setup-pci.c:ide_pci_setup_ports(). * Add IDE_HFLAG_PIO_NO_{BLACKLIST,DOWNGRADE} to ide_pci_device_t.host_flags and teach ide_get_best_pio_mode() about them. Also remove needless !drive-id check while at it

[PATCH 9/15] ide: add PIO masks

2007-06-30 Thread Bartlomiej Zolnierkiewicz
* Add ATA_PIO[0-6] defines to linux/ata.h. * Add -pio_mask field to ide_pci_device_t and ide_hwif_t. * Add PIO masks to host drivers. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/cris/ide-cris.c|1 + drivers/ide/ide.c |2 ++

[PATCH 10/15] ide-cris: handle PIO auto-tuning in tune_cris_ide()

2007-06-30 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/cris/ide-cris.c |2 ++ 1 file changed, 2 insertions(+) Index: b/drivers/ide/cris/ide-cris.c === --- a/drivers/ide/cris/ide-cris.c +++

[PATCH 11/15] atiixp: -speedproc, filter out invalid modes passed from user-space

2007-06-30 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/atiixp.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) Index: b/drivers/ide/pci/atiixp.c === --- a/drivers/ide/pci/atiixp.c +++

[PATCH 12/15] alim15x3: -speedproc, filter out invalid modes passed from user-space

2007-06-30 Thread Bartlomiej Zolnierkiewicz
* -speedproc, filter out invalid modes passed from user-space. * Add FIXME about DMA timings never being set. * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/alim15x3.c | 15 +++ 1 file changed, 15 insertions(+) Index:

[PATCH 14/15] ide: remove stale changelog/comments/TODO from ide.c

2007-06-30 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c | 78 -- 1 file changed, 78 deletions(-) Index: b/drivers/ide/ide.c === --- a/drivers/ide/ide.c

[PATCH 15/15] ide: remove stale changelog from setup-pci.c

2007-06-30 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/setup-pci.c |6 -- 1 file changed, 6 deletions(-) Index: b/drivers/ide/setup-pci.c === --- a/drivers/ide/setup-pci.c +++ b/drivers/ide/setup-pci.c

Re: [PATCH 13/15] ide: add ata_set{_max}_pio()

2007-06-30 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: * Add IDE_HFLAG_ABUSE_{PREFETCH,FAST_DEVSEL,DMA_MODES} flags and set them in ht6560, cmd640, cmd64x and sc1200 host drivers. * Add set_pio_mode_abuse() for checking if host driver has a non-standard -tuneproc() implementation and use it in do_special(). *

Re: [PATCH 9/15] ide: add PIO masks

2007-06-30 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: * Add ATA_PIO[0-6] defines to linux/ata.h. ACK - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 5/15] ide: add ata_pio_cycle_time() helper

2007-06-30 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: * Add ata_pio_cycle_time() helper. ditto previous comment about highly inconsistent prefix usage - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: SATA/ADMA TIMEOUTS, dmesg output

2007-06-30 Thread Jeff Garzik
Charles Shannon Hendrix wrote: Following this post is output from Linux kernel 2.6.21 showing ADMA timeouts. 2.6.21 has improved the situation over earlier kernels, but the problems do still occur. nforce4 chipset, Seagate Barracuda SATA drives. This is meant mainly as an additional

Re: [PATCH 13/15] ide: add ata_set{_max}_pio()

2007-06-30 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 30 June 2007, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: * Add IDE_HFLAG_ABUSE_{PREFETCH,FAST_DEVSEL,DMA_MODES} flags and set them in ht6560, cmd640, cmd64x and sc1200 host drivers. * Add set_pio_mode_abuse() for checking if host driver has a non-standard

Re: [PATCH 13/15] ide: add ata_set{_max}_pio()

2007-06-30 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: This has been changing recently since ide_ prefix seems to have negative emotional connotations. :-) New patches for drivers/ide should use exclusively the ata_ prefix. So this choice to be inconsistent was made based entirely on fashion? This is the same as

Re: [PATCH 13/15] ide: add ata_set{_max}_pio()

2007-06-30 Thread Bartlomiej Zolnierkiewicz
On Saturday 30 June 2007, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: This has been changing recently since ide_ prefix seems to have negative emotional connotations. :-) New patches for drivers/ide should use exclusively the ata_ prefix. So this choice to be inconsistent was

Re: device error via SDB FIS

2007-06-30 Thread Daniel Schroeder
Justin Piszcz wrote: Run smart tests yet? 1. smartctl -d ata -t short /dev/sda 2. smartctl -d ata -a /dev/sda (after few min) also replace short with long and then paste the output: smartctl -d ata -a /dev/sda smartctl smartctl -a -d ata /dev/sdc smartctl version 5.37

Re: device error via SDB FIS

2007-06-30 Thread Justin Piszcz
On Sat, 30 Jun 2007, Daniel Schroeder wrote: Justin Piszcz wrote: Run smart tests yet? 1. smartctl -d ata -t short /dev/sda 2. smartctl -d ata -a /dev/sda (after few min) also replace short with long and then paste the output: smartctl -d ata -a /dev/sda smartctl smartctl -a -d ata

Re: device error via SDB FIS

2007-06-30 Thread Jeff Garzik
Daniel Schroeder wrote: hello list, i do not know, what this could mean, but i have never seen it before. System is 2.6.22-rc6, sil3132, samsung hd501lj (new hd under 10 power on hours) time line: 1: power on (single esata enclosure) 2: system recognizes and configures the disk 3: mount disk

Re: device error via SDB FIS

2007-06-30 Thread Justin Piszcz
On Sat, 30 Jun 2007, Jeff Garzik wrote: Daniel Schroeder wrote: hello list, i do not know, what this could mean, but i have never seen it before. System is 2.6.22-rc6, sil3132, samsung hd501lj (new hd under 10 power on hours) time line: 1: power on (single esata enclosure) 2: system

Re: device error via SDB FIS

2007-06-30 Thread Daniel Schroeder
ata3.00: exception Emask 0x0 SAct 0x2ef SErr 0x0 action 0x0 ata3.00: (irq_stat 0x00020002, device error via SDB FIS) ata3.00: cmd 61/28:30:17:83:68/00:00:1f:00:00/40 tag 6 cdb 0x0 data 20480 out res 51/04:30:17:83:68/50:04:1f:00:00/40 Emask 0x1 (device error) Command 0x61 is FPDMA

Re: device error via SDB FIS

2007-06-30 Thread Jeff Garzik
Daniel Schroeder wrote: ata3.00: exception Emask 0x0 SAct 0x2ef SErr 0x0 action 0x0 ata3.00: (irq_stat 0x00020002, device error via SDB FIS) ata3.00: cmd 61/28:30:17:83:68/00:00:1f:00:00/40 tag 6 cdb 0x0 data 20480 out res 51/04:30:17:83:68/50:04:1f:00:00/40 Emask 0x1 (device error)

[PATCH] ide: add ide_dev_has_iordy() helper (take 4)

2007-06-30 Thread Bartlomiej Zolnierkiewicz
* Add ide_dev_has_iordy() helper and use it sl82c105 host driver. * Remove no longer needed ide_pio_data_t.use_iordy field. v2/v3: * Fix issues noticed by Sergei: - correct patch description - fix comment in ide_get_best_pio_mode() v4: * Fix ata_ prefix (Noticed by Jeff). Signed-off-by:

[PATCH] ide: add ide_pio_cycle_time() helper (take 2)

2007-06-30 Thread Bartlomiej Zolnierkiewicz
* Add ide_pio_cycle_time() helper. * Use it in ali14xx/ht6560b/qd65xx/cmd64{0,x}/sl82c105 and pmac host drivers (previously cycle time given by the device was only used for pio == 255). * Remove no longer needed ide_pio_data_t.cycle_time field. v2: * Fix ata_ prefix (Noticed by Jeff).

Re: [PATCH 13/15] ide: add ata_set{_max}_pio()

2007-06-30 Thread Alan Cox
This has been changing recently since ide_ prefix seems to have negative emotional connotations. :-) New patches for drivers/ide should use exclusively the ata_ prefix. Then I would ask that new patches for drivers/ide are all rejected by Andrew Morton until you change policy. I don't see

Re: [PATCH] ide: add ide_set{_max}_pio() (take 2)

2007-06-30 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: * Add IDE_HFLAG_ABUSE_{PREFETCH,FAST_DEVSEL,DMA_MODES} flags and set them in ht6560, cmd640, cmd64x and sc1200 host drivers. * Add set_pio_mode_abuse() for checking if host driver has a non-standard -tuneproc() implementation and use it in do_special(). *

Re: [PATCH] ide: add ide_set{_max}_pio() (take 2)

2007-06-30 Thread Alan Cox
* Fix ata_ prefix (Noticed by Jeff). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Thanks Bart! Ditto - its really very helpful to tell people ata_ in the trace mail Jeff (or me), ide_ mail Bart 8) - To unsubscribe from this list: send

Re: [PATCH] ide: add ide_set{_max}_pio() (take 2)

2007-06-30 Thread Bartlomiej Zolnierkiewicz
On Sunday 01 July 2007, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: * Add IDE_HFLAG_ABUSE_{PREFETCH,FAST_DEVSEL,DMA_MODES} flags and set them in ht6560, cmd640, cmd64x and sc1200 host drivers. * Add set_pio_mode_abuse() for checking if host driver has a non-standard

Re: [PATCH] ide: add ide_set{_max}_pio() (take 2)

2007-06-30 Thread Bartlomiej Zolnierkiewicz
On Sunday 01 July 2007, Alan Cox wrote: * Fix ata_ prefix (Noticed by Jeff). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Thanks Bart! Ditto - its really very helpful to tell people ata_ in the trace mail Jeff (or me), ide_ mail