[PATCH 2.6.22-rc7 3/3] libata: pata_via CX700 quirks

2007-07-04 Thread Tejun Heo
For some reason, via decided that combined SATA/PATA setup in sata_via isn't good enough and added a SATA port without SCR access to CX700. For yet another unknown reason, slave slot of the SATA port dislikes SETXFER. This patch implements two quirks for CX700 - VIA_SATA_PATA and VIA_BAD_SLAVE_SET

[PATCH 2.6.22-rc7 2/3] libata: implement HORKAGE_SETXFER

2007-07-04 Thread Tejun Heo
Make CFA SETXFER failure handling into HORKAGE. This will be used to allow other cases to ignore SETXFER failure. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- drivers/ata/libata-core.c | 15 ++- include/linux/libata.h|1 + 2 files changed, 11 insertions(+), 5 deletions(

[PATCH 2.6.22-rc7 1/3] libata: clean up horkage handling

2007-07-04 Thread Tejun Heo
Horkage handling had the following problems. * dev->horkage was positioned after ATA_DEVICE_CLEAR_OFFSET, so it was cleared before the device is configured. This broke HORKAGE_DIAGNOSTIC. * Some used dev->horkage while others called ata_device_blacklisted() directly. This was at best conf

[PATCH 2.6.22-rc7] libata: quirk IOMEGA ZIP 250 ATAPI FLOPPY

2007-07-04 Thread Tejun Heo
The Zip 250 which chokes on MWDMA SET_XFERMODE sometimes have "Floppy" appeneded to its model number. Quirk it too. http://bugzilla.kernel.org/show_bug.cgi?id=8563 Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> Cc: Hans de Bruin <[EMAIL PROTECTED]> --- It seems the Zip 250 mwdma failure on libat

Re: [PATCH 8/10] libata: remove writing of tf->ctl from ata_tf_load()

2007-07-04 Thread Albert Lee
Mark Lord wrote: > Albert Lee wrote: > >> Patch 8/10: >> >> The relevant bits in the ctl register are HOB, SRST and nIEN. >> - HOB is only used by ata_tf_read(). >> - For SRST, soft reset is not the duty of tf_load. >> - For nIEN, explicit irq_on()/irq_off and freeze()/thaw() are provided. >>

Re: [PATCH 2.6.22-rc7] libata: fix assigned IRQ reporting

2007-07-04 Thread Tejun Heo
Francois Romieu wrote: > Tejun Heo <[EMAIL PROTECTED]> : >> Tejun Heo wrote: >>> Francois Romieu wrote: I have rebuilt on top of 872aad45d6174570dd2e1defc3efee50f2cfcc72 and it still seems bizarre: >> Okay, 872aad45 doesn't have the patch yet. Either apply the patch >> manually or you ne

Re: how to handle pata_via when controller not in fully-pci-native mode (two irqs?)

2007-07-04 Thread Tejun Heo
Hello, Matt. Matt Sealey wrote: > Tejun Heo wrote: >> I forgot about the PCI resource fix up done for legacy hosts. I think >> making the host legacy is the best way to take here considering that - >> no change for both ide and libata, just some fix up in platform code. >> ATA native/legacy thing

Re: ata1: soft resetting port

2007-07-04 Thread Tejun Heo
Soeren Sonnenburg wrote: >>> pci_express :00:1c.2:pcie03: resuming >>> sr 0:0:0:0: resuming >>> sd 2:0:1:0: resuming >>> sd 2:0:1:0: [sda] Starting disk >>> ata1.00: configured for UDMA/33 >>> ata3.01: revalidation failed (errno=-2) >>> ata3: failed to recover some devices, retrying in 5 secs >

Re: [1/2] 2.6.22-rc7: known regressions

2007-07-04 Thread David Woodhouse
On Tue, 2007-07-03 at 18:45 +0200, Michal Piotrowski wrote: > Hi all, > > Here is a list of some known regressions in 2.6.22-rc7. Oh, and here's another one for you. My Bluetooth mouse just stopped working and hidd is deadlocked... hidd D 1FE27798 5940 1695 1 (NOTLB) Call Trace:

[PATCH 2.6.22 REGRESSION] Fix slab redzone alignment

2007-07-04 Thread David Woodhouse
Commit b46b8f19c9cd435ecac4d9d12b39d78c137ecd66 fixed a couple of bugs by switching the redzone to 64 bits. Unfortunately, it neglected to ensure that the _second_ redzone, after the slab object, is aligned correctly. This caused illegal instruction faults on sparc32, which for some reason not enti

Re: [1/2] 2.6.22-rc7: known regressions

2007-07-04 Thread David Woodhouse
On Tue, 2007-07-03 at 18:45 +0200, Michal Piotrowski wrote: > Subject: random invalid instruction occourances on sparc32 (sun4c) > References : http://lkml.org/lkml/2007/6/17/111 > Submitter : Mark Fortescue <[EMAIL PROTECTED]> > Status : problem is being debugged Hm, when testing the fi

"libata ignore_hpa=1" doesn't wok on SATA ?

2007-07-04 Thread yong Jung
Hi, . I would like to see the whole disk area and erase the hpa area in my desktop. At first I tried "setmax.c" program but it didn't work on SATA at least. So I upgraeded it to FC7 and added "libata ignore_hpa=1" option on boot command and /etc/modprobe.conf. This option was accepted but still th

[PATCH 2.6.22-rc7-git1] sis5513: adding PCI-ID

2007-07-04 Thread Uwe koziolek
The SiS966 has one additional PCI-ID 1180. If the chipset is using this PCI-ID, the primary channel is connected to the first PATA-port. The secondary channel is connected to SATA-ports in IDE emulation mode. The legacy IO-ports are used. the including of the PCI-ID into pata_sis is not sufficie

Re: [PATCH] ide: add ide_set{_max}_pio() (take 2)

2007-07-04 Thread Bartlomiej Zolnierkiewicz
On Wednesday 04 July 2007, Sergei Shtylyov wrote: > Bartlomiej Zolnierkiewicz wrote: > > >>> reporting PIO mode selected from ->tuneproc implementations. > > >>>* Rename ->tuneproc hook to ->set_pio_mode > > >>Well, tuneproc() went with speedproc() rather well. :-) > > > ->set_pio_mode goe

Re: ata1: soft resetting port

2007-07-04 Thread Soeren Sonnenburg
On Thu, 2007-07-05 at 03:01 +0900, Tejun Heo wrote: > Soeren Sonnenburg wrote: > > On Tue, 2007-07-03 at 15:40 +0900, Tejun Heo wrote: > >> Soeren Sonnenburg wrote: > >>> Dear List, > >>> > >>> since the switch to > >>> > >>> CONFIG_ATA=y > >>> CONFIG_ATA_ACPI=y > >>> CONFIG_ATA_PIIX=y, > >>> > >>

Re: [PATCH 8/10] libata: remove writing of tf->ctl from ata_tf_load()

2007-07-04 Thread Mark Lord
Albert Lee wrote: Patch 8/10: The relevant bits in the ctl register are HOB, SRST and nIEN. - HOB is only used by ata_tf_read(). - For SRST, soft reset is not the duty of tf_load. - For nIEN, explicit irq_on()/irq_off and freeze()/thaw() are provided. Since EH/HSM now call explicit freez

Re: how to handle pata_via when controller not in fully-pci-native mode (two irqs?)

2007-07-04 Thread Matt Sealey
Tejun Heo wrote: > > I forgot about the PCI resource fix up done for legacy hosts. I think > making the host legacy is the best way to take here considering that - > no change for both ide and libata, just some fix up in platform code. > ATA native/legacy thing doesn't mean much. It's just how

Re: [PATCH 2.6.22-rc7] libata: fix assigned IRQ reporting

2007-07-04 Thread Francois Romieu
Tejun Heo <[EMAIL PROTECTED]> : > Tejun Heo wrote: > > Francois Romieu wrote: > >> I have rebuilt on top of 872aad45d6174570dd2e1defc3efee50f2cfcc72 and it > >> still seems bizarre: > > Okay, 872aad45 doesn't have the patch yet. Either apply the patch > manually or you need to wait a bit more. I

Re: [PATCH 3/6] siimage: PIO mode setup fixes

2007-07-04 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Add sil_tuneproc() wrapper for siimage_tuneproc() which also sets PIO mode on the device. Planning on the global prefix change? :-) Yep. Well, it didn't work out with 'ata_'... ;-) Because of bad libata taking over our preciouss namespace..

Re: Linux Software RAID is really RAID?

2007-07-04 Thread Mark Lord
Tejun Heo wrote: Mark Lord wrote: I believe he said it was ICH5 (different post/thread). My observation on ICH5 is that if one unplugs a drive, then the chipset/cpu locks up hard when toggling SRST in the EH code. Specifically, it locks up at the instruction which restores SRST back to the non

Re: [PATCH 9/15] ide: add PIO masks

2007-07-04 Thread Bartlomiej Zolnierkiewicz
On Wednesday 04 July 2007, Alan Cox wrote: > > > It doesn't need to do anything. > > > > Not true. It should call ide_config_drive_speed() at least, else PIO > > autotuning won't actually work. > > Indeed - I forgot that old-ide doesn't do this itself but leaves it up to > the driver to for

Re: [PATCH 6/15] ide: ide_find_best_pio_mode() fixes

2007-07-04 Thread Bartlomiej Zolnierkiewicz
On Wednesday 04 July 2007, Sergei Shtylyov wrote: > Hello. > > Bartlomiej Zolnierkiewicz wrote: > > > [PATCH] ide: ide_find_best_pio_mode() fixes (take 2) > > > * Check IORDY bit for PIO modes > 2. > > > * Some devices claim maximum PIO mode > 2 in id->tPIO, they were punished > > too > > se

Re: [PATCH 3/6] siimage: PIO mode setup fixes

2007-07-04 Thread Bartlomiej Zolnierkiewicz
On Wednesday 04 July 2007, Sergei Shtylyov wrote: > Hello. > > Bartlomiej Zolnierkiewicz wrote: > > >>A lot to argue about here... > > >>>* Add sil_tuneproc() wrapper for siimage_tuneproc() which also sets > >>> PIO mode on the device. > > >>Planning on the global prefix change? :-) >

Re: ata1: soft resetting port

2007-07-04 Thread Tejun Heo
Soeren Sonnenburg wrote: > On Tue, 2007-07-03 at 15:40 +0900, Tejun Heo wrote: >> Soeren Sonnenburg wrote: >>> Dear List, >>> >>> since the switch to >>> >>> CONFIG_ATA=y >>> CONFIG_ATA_ACPI=y >>> CONFIG_ATA_PIIX=y, >>> >>> the ATA_PIIX driver manages both, internal sata disk aswell as cd/dvd >>>

Re: [PATCH] ide: add ide_set{_max}_pio() (take 2)

2007-07-04 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: reporting PIO mode selected from ->tuneproc implementations. * Rename ->tuneproc hook to ->set_pio_mode Well, tuneproc() went with speedproc() rather well. :-) ->set_pio_mode goes better with ->set_dma_mode ;-) Ah, good to know where we're movin

Re: Some NCQ numbers...

2007-07-04 Thread Dan Aloni
On Wed, Jul 04, 2007 at 08:17:35PM +0400, Michael Tokarev wrote: > Dan Aloni wrote: > > On Thu, Jun 28, 2007 at 02:51:58PM +0400, Michael Tokarev wrote: > >> [..] > >> Test machine was using MPTSAS driver for the following card: > >> SCSI storage controller: LSI Logic / Symbios Logic SAS1064E PCI

Re: BIOS does not recognize 500GB-disk

2007-07-04 Thread Hadmut Danisch
Justin Piszcz wrote: > > Turn off NCQ on the drive, limit to 1.5GBps operation, try again, I have > the same issue with a new RAPTOR (NCQ) and old motherboard. Yup, that was the problem. The VIA chipset did not support SATA-II. I had to set a jumper on the disk to slow it down to SATA-I. Unfor

Re: [PATCH 5/6] ide: add ata_dev_has_iordy() helper

2007-07-04 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: I was thinking of checking if the drive really supports IORDY before issuing a command to set PIO mode (and just skipping the command if there's no IORDY -- well, maybe adding an extra check that the passed mode is acceptable to the drive, i.e. <= its default

Re: [PATCH 6/15] ide: ide_find_best_pio_mode() fixes

2007-07-04 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: ide_find_best_pio_mode() fixes (take 2) * Check IORDY bit for PIO modes > 2. * Some devices claim maximum PIO mode > 2 in id->tPIO, they were punished too severly for this by being limited to PIO_SLOW. Limit them to PIO2 instead.

Re: Some NCQ numbers...

2007-07-04 Thread Michael Tokarev
Dan Aloni wrote: > On Thu, Jun 28, 2007 at 02:51:58PM +0400, Michael Tokarev wrote: >> [..] >> Test machine was using MPTSAS driver for the following card: >> SCSI storage controller: LSI Logic / Symbios Logic SAS1064E PCI-Express >> Fusion-MPT SAS (rev 02) >> >> Pretty similar results were obta

Re: [PATCH 3/6] siimage: PIO mode setup fixes

2007-07-04 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: A lot to argue about here... * Add sil_tuneproc() wrapper for siimage_tuneproc() which also sets PIO mode on the device. Planning on the global prefix change? :-) Yep. Well, it didn't work out with 'ata_'... ;-) * Add code limiting

Re: [patch 2.6.22-rc6] ATA: add a PCI ID for Intel Santa Rosa PATA controller

2007-07-04 Thread Thorsten Leemhuis
On 02.07.2007 16:36, Chr wrote: > On Monday, 2. July 2007, Thorsten Leemhuis wrote: >>> but Alan Cox wrote: >>> http://www.mail-archive.com/linux-ide%40vger.kernel.org/msg07417.html Its ich_pata_133 - all the newer chips are. >> Intel afaik never supported Ultra ATA 133 officially in any of

Re: Some NCQ numbers...

2007-07-04 Thread James Bottomley
On Wed, 2007-07-04 at 10:19 +0900, Tejun Heo wrote: > Michael Tokarev wrote: > > Well. It looks like the results does not depend on the > > elevator. Originally I tried with deadline, and just > > re-ran the test with noop (hence the long delay with > > the answer) - changing linux elevator chang

Re: [PATCH] pata_hpt3x3: Major reworking and testing

2007-07-04 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: Does anybody have DOS driver for HPT343? Google doesn't have it... I have the drivers for HPT34[35] -- tried dissassembling them some years ago... /me wants I tried sending binaries as is but GMail bounced them off. :-/ Will try to tar a

Re: [PATCH 9/15] ide: add PIO masks

2007-07-04 Thread Alan Cox
> > It doesn't need to do anything. > > Not true. It should call ide_config_drive_speed() at least, else PIO > autotuning won't actually work. Indeed - I forgot that old-ide doesn't do this itself but leaves it up to the driver to forget 8) - To unsubscribe from this list: send the line "un

Re: [PATCH 9/15] ide: add PIO masks

2007-07-04 Thread Sergei Shtylyov
Hello. Alan Cox wrote: .bootable = ON_BOARD, \ .enablebits = { {0x40, 1, 1}, {0x40, 0x10, 0x10} }, \ + .pio_mask = ATA_PIO5, \ } Just noticed that this driver does nothing in its tuneproc() method.

Re: Libata PATA status

2007-07-04 Thread Alan Cox
On Wed, 4 Jul 2007 15:29:30 +0200 Andi Kleen <[EMAIL PROTECTED]> wrote: > > You could probably reliably map "hda/b/c/d" initially with some kind of > > forwarder providing nobody hot plugged them. Just not sure I see the > > PATA hotplug? > > SATA systems typically already use /dev/sda*, it ju

Re: [git patches] libata fixes

2007-07-04 Thread David Woodhouse
On Tue, 2007-07-03 at 18:21 +0100, Alan Cox wrote: > Chuck posted a link to an attachment in bugzilla not to anything from > version control. And the bugzilla bug clearly indicates who posted the > attachment. Probably Chuck should have posted the bug number as well. Perhaps it would have helped i

Re: Libata PATA status

2007-07-04 Thread Andi Kleen
> You could probably reliably map "hda/b/c/d" initially with some kind of > forwarder providing nobody hot plugged them. Just not sure I see the PATA hotplug? SATA systems typically already use /dev/sda*, it just applies to PATA. > point of doing it kernel side. The point would be that old us

Re: Libata PATA status

2007-07-04 Thread Alan Cox
> > > disabled without risking breaking old root file systems. > > > > That would be udevd for new systems or "ln -s" for old ones ? > > Then old kernels couldn't be booted anymore. Why not. I boot back and forth randomly between old and new IDE kernels without problems. The root fs loaded is s

Re: Libata PATA status

2007-07-04 Thread Andi Kleen
On Wed, Jul 04, 2007 at 01:17:46PM +0100, Alan Cox wrote: > On 04 Jul 2007 15:00:26 +0200 > Andi Kleen <[EMAIL PROTECTED]> wrote: > > > Alan Cox <[EMAIL PROTECTED]> writes: > > > > > > Post SRST > > What is SRST? > > > > My personal wish list feature would be a little forwarder driver > > to fo

Re: Libata PATA status

2007-07-04 Thread Alan Cox
On 04 Jul 2007 15:00:26 +0200 Andi Kleen <[EMAIL PROTECTED]> wrote: > Alan Cox <[EMAIL PROTECTED]> writes: > > > > Post SRST > What is SRST? Sorry missed the first question. SRST is the reset signal used when you want to set up (or beat back into sanity) an IDE bus. It causes a specific set o

Re: Libata PATA status

2007-07-04 Thread Alan Cox
On 04 Jul 2007 15:00:26 +0200 Andi Kleen <[EMAIL PROTECTED]> wrote: > Alan Cox <[EMAIL PROTECTED]> writes: > > > > Post SRST > What is SRST? > > My personal wish list feature would be a little forwarder driver > to forward /dev/hd* to /dev/sd* for this; then old IDE could be > disabled without

Re: Libata PATA status

2007-07-04 Thread Andi Kleen
Alan Cox <[EMAIL PROTECTED]> writes: > > Post SRST What is SRST? My personal wish list feature would be a little forwarder driver to forward /dev/hd* to /dev/sd* for this; then old IDE could be disabled without risking breaking old root file systems. -Andi - To unsubscribe from this list: send

Re: ata1: soft resetting port

2007-07-04 Thread Soeren Sonnenburg
On Tue, 2007-07-03 at 15:40 +0900, Tejun Heo wrote: > Soeren Sonnenburg wrote: > > Dear List, > > > > since the switch to > > > > CONFIG_ATA=y > > CONFIG_ATA_ACPI=y > > CONFIG_ATA_PIIX=y, > > > > the ATA_PIIX driver manages both, internal sata disk aswell as cd/dvd > > rom. However I am being f

Re: Some NCQ numbers...

2007-07-04 Thread Justin Piszcz
On Wed, 4 Jul 2007, Justin Piszcz wrote: On Wed, 4 Jul 2007, Michael Tokarev wrote: > Tejun Heo wrote: >> Hello, >> >> Michael Tokarev wrote: >>> Well. It looks like the results does not depend on the >>> elevator. Originally I tried with deadline, and just >>> re-ran the test with noop (he

Re: Some NCQ numbers...

2007-07-04 Thread Justin Piszcz
On Wed, 4 Jul 2007, Michael Tokarev wrote: Tejun Heo wrote: Hello, Michael Tokarev wrote: Well. It looks like the results does not depend on the elevator. Originally I tried with deadline, and just re-ran the test with noop (hence the long delay with the answer) - changing linux elevator ch

Re: Some NCQ numbers...

2007-07-04 Thread Michael Tokarev
Tejun Heo wrote: > Hello, > > Michael Tokarev wrote: >> Well. It looks like the results does not depend on the >> elevator. Originally I tried with deadline, and just >> re-ran the test with noop (hence the long delay with >> the answer) - changing linux elevator changes almost >> nothing in the

Re: [PATCH] libata_acpi: A different strategy for using ACPI information

2007-07-04 Thread Alan Cox
> Looks fairly reasonable to me. However, I suspect any use of _GTM is > somewhat dangerous (at least after the resume) unless we use the _STM > and _GTF methods in the proper sequence when resuming. (Is that in the > -mm tree now?) Yes - and we only use it in these drivers to check for cable e

Re: [PATCH libata-dev#upstream] libata: simplify PCI legacy SFF host handling

2007-07-04 Thread Alan Cox
> Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> > Cc: Alan Cox <[EMAIL PROTECTED]> > --- > Gee, I like it. The BAR fixup thing was a really good idea. :-) Told you it would 8) Looks good to me Acked-by: Alan Cox <[EMAIL PROTECTED]> [Jeff - this replaces the minimal tweak I sent out to use t

Re: sata_sil, writing bug with multiple cards?

2007-07-04 Thread 7091
Alan Cox writes: Not suprised to be honest. We have a large number of reports that are all of the following form "Nvidia chipset, Silicon Image SATA, corruption" and several reports that BIOS updates fixed it. Unfortunately we don't know what the BIOS updates do (or indeed if what they do

Re: Libata PATA status

2007-07-04 Thread Mikael Pettersson
On Tue, 3 Jul 2007 23:04:26 -0400, Kyle Moffett wrote: > Has anyone started a rewrite of the PPC/PowerMac IDE > driver? The current one is in "drivers/ide/ppc/pmac.c", and supports > these chipsets: >OHare ATA >Heathrow ATA >KeyLargo ATA-3 >KeyLargo ATA-4 >UniNorth ATA-6 (I

[PATCH 9/10] libata: Integrate freeze/thaw with irq_on/off

2007-07-04 Thread Albert Lee
Patch 9/10: irq_on/irq_off are now only wrapped by freeze/thaw (and unused otherwise). We can integrate freeze/thaw with irq_on/irq_off. Signed-off-by: Albert Lee <[EMAIL PROTECTED]> --- This is for libata-core. The LLDDs will be fixed in the next patch. diff -Nrup 08_tfload_cleanup/drivers/at

Re: Libata PATA status

2007-07-04 Thread Alan Cox
> I'd love to try to poke holes in the libata PATA support, but sadly > it doesn't look like any of my systems built-in ATA chipsets are > supported yet. Has anyone started a rewrite of the PPC/PowerMac IDE > driver? The current one is in "drivers/ide/ppc/pmac.c", and supports > these chi

Re: sata_sil, writing bug with multiple cards?

2007-07-04 Thread Tejun Heo
Alan Cox wrote: >> # Make a RAID5 array of 3 out of the 4 drives I'll eventually be using >> mdadm --create /dev/md6 --chunk=64 --level=raid5 --raid-devices=4 /dev/sda1 >> /dev/sdb1 /dev/sdc1 missing >> # Make the FS >> mkfs.ext3 /dev/md6 >> # Test >> cp KNOPPIX_V5.1.0CD-2006-12-30-EN.iso kn1.iso

Re: sata_sil, writing bug with multiple cards?

2007-07-04 Thread Alan Cox
> # Make a RAID5 array of 3 out of the 4 drives I'll eventually be using > mdadm --create /dev/md6 --chunk=64 --level=raid5 --raid-devices=4 /dev/sda1 > /dev/sdb1 /dev/sdc1 missing > # Make the FS > mkfs.ext3 /dev/md6 > # Test > cp KNOPPIX_V5.1.0CD-2006-12-30-EN.iso kn1.iso > cp kn1.iso kn2.iso >

Re: Linux Software RAID is really RAID?

2007-07-04 Thread Alan Cox
> > A hard(ware) lockup, not software. > > That's why Intel says ICH5 doesn't do hotplug. > > OIC. I don't think there's much left to do from the driver side then. > Or is there any workaround? I'm not familiar with the ICH5 SATA side but on the PATA side we also need to run code to fix up chips

[PATCH 8/10] libata: remove writing of tf->ctl from ata_tf_load()

2007-07-04 Thread Albert Lee
Patch 8/10: The relevant bits in the ctl register are HOB, SRST and nIEN. - HOB is only used by ata_tf_read(). - For SRST, soft reset is not the duty of tf_load. - For nIEN, explicit irq_on()/irq_off and freeze()/thaw() are provided. Since EH/HSM now call explicit freeze()/thaw() for irq of

[PATCH libata-dev#upstream] libata: simplify PCI legacy SFF host handling

2007-07-04 Thread Tejun Heo
With PCI resource fix up for legacy hosts. We can use the same code path to allocate IO resources and initialize host for both legacy and native SFF hosts. Only IRQ requesting needs to be different. Rename ata_pci_*_native_host() to ata_pci_*_sff_host(), kill all legacy specific functions and u

[PATCH 7/10] libata: pdc_freeze() semantic change

2007-07-04 Thread Albert Lee
Patch 7/10: After checking the current implementations of freeze()/thaw(), it seems only pdc_freeze() do more than simple irq masking. Remove the DMA stop code from pdc_freeze(). Signed-off-by: Albert Lee <[EMAIL PROTECTED]> --- diff -Nrup 06_add_freeze_thaw_to_lldd/drivers/ata/sata_promise.c

[PATCH 6/10] libata: add freeze/thaw to old EH LLDDs

2007-07-04 Thread Albert Lee
Patch 6/10: Now that HSM polling code path uses freeze()/thaw() regardless of old EH or new EH. Add freeze()/thaw() to old EH LLDDs for the HSM polling code. Signed-off-by: Albert Lee <[EMAIL PROTECTED]> --- diff -Nrup 05_convert_hsm_to_freeze/drivers/ata/pata_ixp4xx_cf.c 06_add_freeze_thaw_to

[PATCH libata-dev#upstream] libata: kill duplicate functions

2007-07-04 Thread Tejun Heo
I like these _dumb functions but I think we can live with just one copy. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- drivers/ata/libata-core.c | 79 -- 1 file changed, 79 deletions(-) Index: work/drivers/ata/libata-core.c ===

[PATCH 5/10] libata: use freeze/thaw for polling

2007-07-04 Thread Albert Lee
Patch 5/10: This patch changes polling codes to use freeze()/thaw() for irq off/on. The reason is: some ATAPI devices raises INTRQ even of nIEN = 1. Using the host adapter irq mask mechanism, if available, is more reliable than the device nIEN bit. ata_qc_set_polling() is also removed since no

Re: how to handle pata_via when controller not in fully-pci-native mode (two irqs?)

2007-07-04 Thread Tejun Heo
Matt Sealey wrote: > Well, let's put the class code as "native" since the chip is made "native", > in a platform file somewhere. Then, we can have a configuration option in > the platform code which allows users to choose whether the IDE configuration > is reworked to steer to a single IRQ or two I

[PATCH 4/10] libata: call irq_off from bmdma_freeze()

2007-07-04 Thread Albert Lee
Patch 4/10: Call irq_off() from bmdma_freeze() and remove duplicated code. Signed-off-by: Albert Lee <[EMAIL PROTECTED]> --- diff -Nrup 03_add_irq_off_lldd/drivers/ata/libata-sff.c 04_convert_freeze/drivers/ata/libata-sff.c --- 03_add_irq_off_lldd/drivers/ata/libata-sff.c2007-07-04 1

Re: sata_sil, writing bug with multiple cards?

2007-07-04 Thread Tejun Heo
Andi Kleen wrote: > On Wednesday 04 July 2007 10:17:34 [EMAIL PROTECTED] wrote: > >>> Most likely it is some sort of hardware bug that we might >>> not be able to do much about. Have you tried contacting SIL or VIA? >> No, I haven't. Like I mentioned above, the OpenBSD drivers seemed to work, >

[PATCH 3/10] libata: implement ->irq_off in LLDDs

2007-07-04 Thread Albert Lee
Patch 3/10: Implement the newly added ->irq_off in LLDDs. Signed-off-by: Albert Lee <[EMAIL PROTECTED]> --- diff -Nrup 02_add_irq_off/drivers/ata/ahci.c 03_add_irq_off_lldd/drivers/ata/ahci.c --- 02_add_irq_off/drivers/ata/ahci.c 2007-07-04 11:26:30.0 +0800 +++ 03_add_irq_off_lldd/dr

[PATCH 2/10] libata: add irq_off

2007-07-04 Thread Albert Lee
Patch 2/10: Currently there is ->irq_on but no ->irq_off. Turning irq off is done via altering the nIEN bit of qc->tf, together with tf_load(). This patch adds ->irq_off for symmetry. tf_load() and ata_qc_set_polling() will be fixed/removed in later patches. Signed-off-by: Albert Lee <[EMAIL P

[PATCH 1/10] libata: remove irq_on from ata_bus_reset() and ata_std_postreset()

2007-07-04 Thread Albert Lee
Patch 1/10: After checking, it seems calling irq_on() in ata_bus_reset() and ata_std_postreset() are leftover of the EDD reset. Remove them. Signed-off-by: Albert Lee <[EMAIL PROTECTED]> --- diff -Nrup 00_libata-dev/drivers/ata/libata-core.c 01_remove_leftover_irqon/drivers/ata/libata-core.c

Re: sata_sil, writing bug with multiple cards?

2007-07-04 Thread Andi Kleen
On Wednesday 04 July 2007 10:17:34 [EMAIL PROTECTED] wrote: > > Most likely it is some sort of hardware bug that we might > > not be able to do much about. Have you tried contacting SIL or VIA? > > No, I haven't. Like I mentioned above, the OpenBSD drivers seemed to work, > or at least did wit

[PATCH 0/10] libata: irq_on/off restructuring

2007-07-04 Thread Albert Lee
For ATA, there are two levels of mechanism available to turn irq on/off. - device level: nIEN bit in the control register. This masks INTRQ from the device. - host adapter level: some controller can mask out per-port irq from the host adapter. Currently various parts of libata deal with irq on/o

[PATCH 2/2] libata: change the last state of pio read to HSM_ST_IDLE

2007-07-04 Thread Albert Lee
Patch 2/2: After reading the last pio data block, the HSM is waiting for device to be idle, not waiting for the last interrupt. This patch changes the state after "PIO data-in" to HSM_ST_IDLE instead of HSM_ST_LAST for accuracy. Signed-off-by: Albert Lee <[EMAIL PROTECTED]> --- diff -Nrup 01_m

[PATCH 1/2] libata: move ata_altstatus() to pio data xfer functions

2007-07-04 Thread Albert Lee
Patch 1/2: Move ata_altstatus() out from ata_hsm_move() to the pio data xfer functions like ata_pio_sectors() and atapi_pio_bytes() where it makes more sense. Signed-off-by: Albert Lee <[EMAIL PROTECTED]> --- atapi_send_cdb() already calls ata_altstatus() inside. This patch makes ata_pio_sectors(

[PATCH 0/2] libata: minor pio fixes (resend)

2007-07-04 Thread Albert Lee
Minor pio fixes: 1/2: move ata_altstatus() to pio data xfer functions 2/2: change the last state of pio read to HSM_ST_IDLE (The previous "remove unneeded ata_altstatus() from ata_hsm_qc_complete()" has been accepted.) Patch against the libata-dev tree for your review. - To unsubscribe from this

Re: [PATCH 1/1] ide: pdc202xx_new PLL input clock fix

2007-07-04 Thread Albert Lee
Sergei Shtylyov wrote: > Bartlomiej Zolnierkiewicz wrote: > >> typos fixed manually > > Signed-off-by: Albert Lee <[EMAIL PROTECTED]> > > >>>Except for types in description: > > >Said he, while making his own typo. :-) > :) -- albert - To unsubscribe from this list: send the

Re: [info] What's in Jeff's libata-dev inbox?

2007-07-04 Thread Albert Lee
Jeff Garzik wrote: >>> I have patches from Alan (pata_sis FIFO whack, pata_dma option), Tejun, >>> Albert and Kristen still to be reviewed. Will get to those on Friday, >>> after the July 4th US holiday.tions(-) > > > Just to be more specific, my to-review inbox contains: > > Alan: pata_sis FIF

Re: sata_sil, writing bug with multiple cards?

2007-07-04 Thread 7091
Andi Kleen writes: If it has >2GB or so it might be worth trying booting it with mem=2G Nope, only 1GB of RAM. Most likely it is some sort of hardware bug that we might not be able to do much about. Have you tried contacting SIL or VIA? No, I haven't. Like I mentioned above, the OpenBSD

Re: sata_sil, writing bug with multiple cards?

2007-07-04 Thread Andi Kleen
On Wednesday 04 July 2007 05:53:30 Tejun Heo wrote: > [EMAIL PROTECTED] wrote: > > Apologies for the chain-replying to myself, just replying as I think of > > things to try. > > [EMAIL PROTECTED] writes: > >> Here's an odd data point. > >> I just broke that array, formatted all three of those part