[PATCH 2/2] ata_piix: fix suspend/resume for some TOSHIBA laptops

2007-07-10 Thread Tejun Heo
ACPI implementations in several TOSHIBA laptops are weird and burn cpu cycles for tens of seconds while trying to suspend if the PCI device for the ATA controller is disabled when the ACPI suspend is called. This patch uses DMI to match those machines and bypass device disable on those machines

[PATCH 2.6.22/-stable] libata: add FUJITSU MHV2080BH to NCQ blacklist

2007-07-10 Thread Tejun Heo
Please warmly welcome the first member from FUJITSU to the prestigious NCQ spurious completion club. This is reported by Serge Van Thillo in bugzilla bug 8730. http://bugzilla.kernel.org/show_bug.cgi?id=8730 Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Serge van Thillo [EMAIL PROTECTED] ---

[PATCH] ata_piix: kill incorrect invalid map value warning

2007-07-10 Thread Tejun Heo
The last two slots of MAP 00b of ich6m was incorrectly marked as reserved. This is left over from converting the entry to allow 00b. This causes no real problem. It only makes the driver print annoying warning message. Fix it. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --

ICH4 support in ata_piix?

2007-07-10 Thread Koen Vermeer
Hi, In driver 2.00ac7 (kernel 2.6.20), my ICH4 (82801DBM) ATA controller (i855 chipset) was supported in ata_piix.c. In newer versions (2.10ac1/2.6.21 and later), support seems to have been removed. I'm looking for information on this change. Is it actually removed, or just moved to some other

[PATCH] scc_pata.c: Workaround for errata A308

2007-07-10 Thread Akira Iguchi
Workaround for errata A308: turn down the UDMA mode and retry the DMA command when the data lost condition is detected. Signed-off-by: Kou Ishizaki [EMAIL PROTECTED] Signed-off-by: Akira Iguchi [EMAIL PROTECTED] --- diff -purN -X linux-powerpc-git/Documentation/dontdiff

[PATCH] pata_scc.c: Workaround for errata A308

2007-07-10 Thread Akira Iguchi
Workaround for errata A308: turn down the UDMA mode and retry the DMA command when the data lost condition is detected. Signed-off-by: Kou Ishizaki [EMAIL PROTECTED] Signed-off-by: Akira Iguchi [EMAIL PROTECTED] --- diff -purN -X linux-powerpc-git/Documentation/dontdiff

Re: sata_sil, writing bug with multiple cards?

2007-07-10 Thread Tejun Heo
Tejun Heo wrote: Andi Kleen wrote: On Wednesday 04 July 2007 10:17:34 [EMAIL PROTECTED] wrote: Most likely it is some sort of hardware bug that we might not be able to do much about. Have you tried contacting SIL or VIA? No, I haven't. Like I mentioned above, the OpenBSD drivers seemed to

sata-via failure on 2.6.22 for via 6421 chipset (Was: Libata PATA status)

2007-07-10 Thread Rod Whitby
Rod Whitby wrote: Our project is also working on adding support to the kernel for the Freecom FSG-3 NAS device. It uses the sata-via driver for it's VIA_6421 chipset, but the main drive is a PATA drive (the device also has an eSATA external port). We're currently stuck at 2.6.18 with

Re: Question about PATA Sil680 Bus Reset Code

2007-07-10 Thread Sergei Shtylyov
Alan Cox wrote: I guess it's been blindly copied over form drivers/ide/pci/siimage.c... Yet the order of events between IDE and libata drivers is different: the old driver's resetproc() method is called just after the twiddling the bit on/off, the new driver calls ata_std_softreset()

Re: [PATCH 10/12] ide: move ide_rate_filter() calls to the upper layer

2007-07-10 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: * Move ide_rate_filter() calls from host drivers to IDE core. * Make ide_rate_filter() static. * Make 'speed' argument of -speedproc const. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej

Freeze after disabling write cache with hdparm -W0 /dev/sda

2007-07-10 Thread Simon Farnsworth
Hello, We're trying to consistently disable write caching on our systems (one PATA disk on /dev/sda), by running the following command during boot: hdparm -W0 /dev/sda However, on some disks, we see a freeze of between 30 seconds and 2 minutes after issuing this command. How do we avoid this

Re: Possible data corruption sata_sil24?

2007-07-10 Thread Tejun Heo
Hello, David Shaw wrote: I'm having a problem with data corruption using devmapper on a SATA disk using sata_sil24. I've done some work tracking it down, and hopefully you folks can point me further in the right direction. The kernel I'm using is 2.6.21-1.3228.fc7 (i.e. Fedora 7). LVM2 is

Re: [PATCH 2/7] sata_promise: pdc_freeze() semantic change

2007-07-10 Thread Tejun Heo
Mikael Pettersson wrote: Albert's patch is OK as far as sata_promise is concerned, but I want to see an update of libata.tmpl and libata-eh.c to indicate the new, weakened, specification of freeze/thaw before I ACK this patch. Aye aye sir. -- tejun - To unsubscribe from this list: send the

ata and netdev (was Re: -mm merge plans for 2.6.23)

2007-07-10 Thread Jeff Garzik
(just to provide my indicator of status) Andrew Morton wrote: libata-config_pm=n-compile-fix.patch that's for a branch that you don't get via libata-dev#ALL, #mv-ahci-pata. pata_acpi-restore-driver.patch see Alan's comments. I've been ignoring pata_acpi for a while, because IMO it

Re: [PATCH 2.6.22-rc7] libata: fix assigned IRQ reporting

2007-07-10 Thread Francois Romieu
Tejun Heo [EMAIL PROTECTED] : [...] H... Weird. Can you please apply the attached patch and post boot dmesg? Thanks. It works perfectly in 2.6.22 but the .config is not the same. I'll report if it makes a difference. -- Ueimor - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 1/2] [ide] mmio ide support

2007-07-10 Thread Linas Vepstas
On Sun, Jul 08, 2007 at 03:15:41PM +0200, Bartlomiej Zolnierkiewicz wrote: on the argument that drivers/ide/ is going away soon. Most current distros have already moved over to using libata exclusively. The in-kernel default for PATA systems is still IDE subsystem. In part because

Re: [PATCH 1/3] Make the IDE DMA timeout modifiable

2007-07-10 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: On Feb 20, 2007, at 5:44 PM, Bartlomiej Zolnierkiewicz wrote: On Wednesday 21 February 2007 02:19, Suleiman Souhlal wrote: It can be changed via /proc/ide/hd?/settings. Why do we need to change IDE DMA timeout dynamically? I've used it to

Re: Problem with SiS Ide/Pata/Sata on 2.6.22-rc7-git4

2007-07-10 Thread Thomas Backlund
Alan Cox skrev: If you modprobe only sis5513 OR If you modprobe only sis5513 and then sata_sis/pata_sis: - you get this: (the hdb drive does not get detected/usable) Don't mix old and new IDE like that. We allow both so you can use old SIS and new Jmicron etc for example but there are

Re: [PATCH 5/12] it8213: PIO fixes

2007-07-10 Thread Bartlomiej Zolnierkiewicz
On Monday 09 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Rename it8213_tuneproc() to it8213_tune_pio() and add it8213_tuneproc() wrapper. Move finding of the best PIO mode to the new wrapper. * Add setting of transfer mode on the device to it8213_tuneproc().

Re: [PATCH 8/12] scc_pata: PIO fixes

2007-07-10 Thread Bartlomiej Zolnierkiewicz
On Monday 09 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Use pio == 255 == auto-tune in scc_config_drive_for_dma() instead of forcing PIO4 on PIO fallback. Fix comment while at it. * Rename scc_tuneproc() to scc_tune_pio() and add scc_tuneproc() wrapper.

Re: [PATCH 3/12] cs5520: fix PIO auto-tuning in -ide_dma_check method

2007-07-10 Thread Bartlomiej Zolnierkiewicz
On Monday 09 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] added - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to

Re: [PATCH 2/12] ide: mode limiting fixes for user requested speed changes

2007-07-10 Thread Bartlomiej Zolnierkiewicz
On Monday 09 July 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Sorry, more grammar nitpicking follows (-: * Add an extra argument to ide_max_dma_mode() for passing requested transfer mode. Use it as an upper limit when finding the best DMA for device/host. *

Re: [PATCH 1/12] ide: add missing ide_rate_filter() calls to -speedproc()-s

2007-07-10 Thread Bartlomiej Zolnierkiewicz
On Monday 09 July 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: * Fix icside, cris-ide, au1xxx-ide, amd74xx, via82cxxx and pmac host drivers to use ide_rate_filter(). This results in the following modes (from user requests) being clipped down: -

Re: Question about PATA Sil680 Bus Reset Code

2007-07-10 Thread Bartlomiej Zolnierkiewicz
On Tuesday 10 July 2007, Sergei Shtylyov wrote: Alan Cox wrote: I guess it's been blindly copied over form drivers/ide/pci/siimage.c... Yet the order of events between IDE and libata drivers is different: the old driver's resetproc() method is called just after the twiddling the

Re: [PATCH] PCMCIA: Add another MemoryCard to ide-cd/pata_pcmcia

2007-07-10 Thread Bartlomiej Zolnierkiewicz
[ please always cc: linux-ide@ on ATA patches ] ^ s/ide-cd/ide-cs/ ;-) On Tuesday 10 July 2007, Marcin Juszkiewicz wrote: From: Marcin Juszkiewicz [EMAIL PROTECTED] One card submitted by user. Signed-off-by: Marcin Juszkiewicz [EMAIL PROTECTED] This patch doesn't apply because of

Re: [PATCH 1/1] libata: pata_pdc2027x PLL input clock fix

2007-07-10 Thread Mikael Pettersson
On Tue, 10 Jul 2007 11:52:59 +0800, Albert Lee wrote: Recently the PLL input clock of pata_pdc2027x is sometimes detected higer than expected (e.g. 20.027 MHz compared to 16.714 MHz). It seems sometimes the mdelay() function is not as precise as it used to be. Per Alan's advice, HT or power

[PATCH 2/6] ide-cris: fix -set_pio_mode method to set transfer mode on the device

2007-07-10 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/cris/ide-cris.c |2 ++ 1 file changed, 2 insertions(+) Index: b/drivers/ide/cris/ide-cris.c === --- a/drivers/ide/cris/ide-cris.c +++

[PATCH 1/6] icside: fix -speedproc to return on unsupported modes

2007-07-10 Thread Bartlomiej Zolnierkiewicz
icside_set_speed() happily accepts unsupported transfer modes which results in drive-drive_data being set to the maximum value (480) and drive-current_speed being set to the unsupported transfer mode. Fix it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Cc: Russell King [EMAIL

[PATCH 6/6] ide: config_drive_for_dma() fixes

2007-07-10 Thread Bartlomiej Zolnierkiewicz
* Add DMA blacklist checking (-ide_dma_on check probably can go now). * Add -atapi_dma flag checking and remove no longer needed ns87415_ide_dma_check() from ns87415 host driver. * Remove now needless __ide_dma_check() wrapper and symbol export. * Check drive-autodma instead of hwif-autodma

Re: [PATCH 2.6.22-rc7 1/3] libata: clean up horkage handling

2007-07-10 Thread Jeff Garzik
Tejun Heo wrote: Horkage handling had the following problems. * dev-horkage was positioned after ATA_DEVICE_CLEAR_OFFSET, so it was cleared before the device is configured. This broke HORKAGE_DIAGNOSTIC. * Some used dev-horkage while others called ata_device_blacklisted() directly.

Re: [patch 09/11] pata_hpt3x3: major reworking and testing

2007-07-10 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Alan Cox [EMAIL PROTECTED] The HPT343/345 (aka 363) is a bit of a warped device. For many setups you need to access the other registers via BAR4 offsets. PIO is now rock solid, DMA isn't. Unfortunately the drivers/ide hpt34x driver is completely broken so

Re: [PATCH 2.6.22-rc7] libata: quirk IOMEGA ZIP 250 ATAPI FLOPPY

2007-07-10 Thread Jeff Garzik
Tejun Heo wrote: The Zip 250 which chokes on MWDMA SET_XFERMODE sometimes have Floppy appeneded to its model number. Quirk it too. http://bugzilla.kernel.org/show_bug.cgi?id=8563 Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Hans de Bruin [EMAIL PROTECTED] --- It seems the Zip 250 mwdma

Re: [PATCH 01/16] libata-link: separate out ata_eh_handle_dev_fail()

2007-07-10 Thread Jeff Garzik
Tejun Heo wrote: Separate out ata_eh_handle_dev_fail() from ata_eh_recover(). This is in preparation of ata_link and PMP support. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-eh.c | 96 +- 1 files changed, 52 insertions(+), 44

Re: [PATCH 10/16] libata-link: separate out link initialization functions

2007-07-10 Thread Jeff Garzik
Tejun Heo wrote: Separate out link initialization into ata_link_init() and ata_link_init_sata_spd_limit(). Signed-off-by: Tejun Heo [EMAIL PROTECTED] Function name too long :) Drop _limit perhaps. Anyway, ACK 3-10 - To unsubscribe from this list: send the line unsubscribe linux-ide in the

Re: [PATCH 16/16] libata-link: update Power Management to handle PMP links

2007-07-10 Thread Jeff Garzik
Tejun Heo wrote: Update Power Management to consider PMP links. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-core.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) ACK - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of