[patch] Add more device IDs for supporting ATI SB700

2007-07-14 Thread su henry
From: [EMAIL PROTECTED] The SATA controller device ID will be different according to the onchip SATA type set in the system BIOS: DeviceDevice ID SATA in IDE mode 0x4390 SATA in AHCI mode0x4391 SATA in non-raid5 driver 0x4392 SATA in rai

Re: sata_inic162x issue - PCMCIA card

2007-07-14 Thread Mark Lord
jm_928 wrote: Hi, I have an esata PCMCIA card based on the Initio 1620 chipset. When inserting this into my Dell D600 laptop (running Ubuntu 7.04 with the 2.6.20-16 kernel) I get the following error messages: [ 27.66] sata_inic162x :03:00.0: version 0.1 [ 27.66] PCI: Enabling de

Re: [PATCH 1/6] icside: fix ->speedproc to return on unsupported modes

2007-07-14 Thread Russell King
On Sat, Jul 14, 2007 at 12:54:35AM +0100, Alan Cox wrote: > > We need to set the IRQ enable initially so that the identity information > > can be read and the drive accessed etc. However, if no drives are > > detected on a port, there is no callback into the low level driver - > > the port_disable

Re: sata_inic162x issue - PCMCIA card

2007-07-14 Thread Jeff Garzik
jm_928 wrote: Hi, I have an esata PCMCIA card based on the Initio 1620 chipset. When inserting this into my Dell D600 laptop (running Ubuntu 7.04 with the 2.6.20-16 kernel) I get the following error messages: [ 27.66] sata_inic162x :03:00.0: version 0.1 [ 27.66] PCI: Enabling de

Re: [PATCH 1/6] icside: fix ->speedproc to return on unsupported modes

2007-07-14 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: [PATCH] icside: fix ->speedproc to return on unsupported modes (take 3) * All other implementations of ->speedproc return zero on success and non-zero on failure. Currently it doesn't matter for icside host driver and isn't a bug per se since: - ide_

Re: [PATCH] siimage: fix ->set_pio_mode method to select PIO data transfer

2007-07-14 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Remember to select PIO data transfer (with IORDY monitored) in sil_tune_pio() (->set_pio_mode method) so the controller is always programmed correctly for PIO transfers (this is important if DMA is not going to be used). * Don't set DMA/UDMA timings for

Re: [PATCH] cs5520: don't enable VDMA in ->speedproc

2007-07-14 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: There is no need to do it in cs5520_tune_chipset() (->speedproc method) since it is correctly handled by cs5520_dma_on() (->ide_dma_on method). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, S

Re: [PATCH] piix/slc90e66: fix PIO1 handling in ->speedproc method (take 2)

2007-07-14 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Don't call {piix,slc90e66}_dma_2_pio() for PIO modes in {piix,slc90e66}_tune_chipset(). * Add PIO1 handling to {piix,slc90e66}_tune_chipset(). * Bump driver version. v2: * Remove PIO modes from {piix,slc90e66}_dma_2_pio(), they are no longer needed

Re: [PATCH] it8213: PIO fixes (take 2)

2007-07-14 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Rename it8213_tuneproc() to it8213_tune_pio() and add it8213_tuneproc() wrapper. Move finding of the best PIO mode to the new wrapper. * Add setting of transfer mode on the device to it8213_tuneproc(). * Don't call it8213_dma_2_pio() for PIO modes in i

Re: [PATCH] sc1200: remove redundant warning message from sc1200_tune_chipset()

2007-07-14 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: ide_config_drive_speed() called by sc1200_set_xfer_mode() already gives a meaningful warning message in case of failure. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> MBR, Sergei - To uns

Re: [PATCH 3/6] ide-pmac: PIO fixes

2007-07-14 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: * Add setting transfer mode on the device to pmac_ide_set_pio_mode(). * Fix pmac_ide_set_pio() to always program chipset for given PIO timing instead of only when the device we want to program PIO timing for is the currently selected one. Hm, w

sata_inic162x issue - PCMCIA card

2007-07-14 Thread jm_928
Hi, I have an esata PCMCIA card based on the Initio 1620 chipset. When inserting this into my Dell D600 laptop (running Ubuntu 7.04 with the 2.6.20-16 kernel) I get the following error messages: [ 27.66] sata_inic162x :03:00.0: version 0.1 [ 27.66] PCI: Enabling device :03:00

Re: [PATCH] Unbreak build of PMP with ACPI disabled

2007-07-14 Thread Petr Vandrovec
Tejun Heo wrote: Ryan Power wrote: I'm also experiencing this problem on a with the sata_nv module. I suspect that it may at least not be controller dependant, as it's also occurring on my silicon image controller (sata_sil, SiI3512). It looks like something is zeroing out part of the return r

Re: [RFT][PATCH v7] sata_mv: convert to new EH

2007-07-14 Thread Tuomas Leikola
On 7/13/07, dean gaudet <[EMAIL PROTECTED]> wrote: > I presume from your past messages your tests include multiple disks at the > same time? yep, 4 disks... i was getting 4x74MB/s with dd read. unfortunately i don't have more disks in the system at this point so i can't test all 8 ports at full

Re: [PATCH 2/3] libata: use ->proto_mask in drivers

2007-07-14 Thread Alan Cox
On Sat, 14 Jul 2007 04:17:28 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > > Review definitely helps here... Without knowing what the precise semantics are that is hard. Every SFF_DMA case may not be supporting DMA depending upon the configuration so it should probably be set by ata_pci_init_on

Re: 40-wire/80-wire detection

2007-07-14 Thread Craig Block
--- Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > > Please send the output of hdparm --Istdout for this drive. > > "idex=ata66" or CONFIG_IDEDMA_IVB=y should also help but we really would > like to detect and workaround such issues automatically, without the need > for user headaches.

[PATCH 3/3] libata: replace ATA_FLAG_{NCQ,NO_ATAPI} using ->proto_mask

2007-07-14 Thread Jeff Garzik
commit a02791c8298bc0c2202a49c5e781ed2c68132dc8 Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Sat Jul 14 04:10:11 2007 -0400 [libata] Use ->proto_mask to replace NCQ and NO_ATAPI flags Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> drivers/ata/ahci.c |2 +- drivers/

[PATCH 2/3] libata: use ->proto_mask in drivers

2007-07-14 Thread Jeff Garzik
Review definitely helps here... commit b8485b72aa93a82bcb48835f04c8cf06cd0b1f37 Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Sat Jul 14 03:54:56 2007 -0400 [libata] Fill in ->proto_mask setting for all drivers Using observations on pio_mask/mwdma_mask/udma_mask settings, set

[PATCH 1/3] libata: add ->proto_mask

2007-07-14 Thread Jeff Garzik
commit c7baac44f3a02b895873cce48c6e426ddbea06b9 Author: Jeff Garzik <[EMAIL PROTECTED]> Date: Sat Jul 14 03:27:11 2007 -0400 [libata] Introduce per-port taskfile protocol masks One ATA_PMASK_$name bitmapped value exists for each ATA_PROT_$name value. ->proto_mask membe

[PATCH 0/3] libata: add taskfile protocol ->proto_mask info member

2007-07-14 Thread Jeff Garzik
These patches add proto_mask alongside pio_mask, mwdma_mask, and udma_mask. This is a more uniform way to export which features host controllers support (DMA? NCQ? ATAPI? ATAPI DMA?), rather than creating a new ATA_FLAG_xxx for each. This also opens the door to useful things like combining "if p