Re: libata [ata_piix] still no resume from S3 ?

2007-07-20 Thread Tejun Heo
Rúben Fonseca wrote: I wish I could disable this card reader. It is built in on the hardware, and there are no drivers for Linux. There is no option on the BIOS to disable the device. Is there any way (kernel parameters, magic program, etc) to disable this device without opening my laptop to

Re: [PATCH] ahci: reimplement port_map handling

2007-07-20 Thread Tejun Heo
Tejun Heo wrote: Reimplement port_map handling such that 1. Non-zero PORTS_IMPL value is always examined and used if consistent with cap.n_ports. 2. When PI and cat.n_ports are inconsistent, honor cap.n_ports and force port_map to be ((1 cap.n_ports) - 1). 3. There were two

Re: PATA driver for Atmel AVR32

2007-07-20 Thread Kristoffer Nyborg Gregertsen
Here is the code, tips and reviews would be appriciated too :) /* * AVR32 SMC/CFC PATA Driver * * Copyright (C) 2007 Atmel Norway * * This program is free software; you can redistribute it and/or modify * it under the terms of the GNU General Public License version 2 as * published by the

PATA driver for Atmel AVR32

2007-07-20 Thread Kristoffer Nyborg Gregertsen
Hello everybody, I'm developing an PATA driver for the Atmel AVR32 architecture (driver code will be sent as reply to this thread). I develop on version 2.6.22.atmel.3. The driver is currently partially working, but there are some issues with data transfers (PIO 0). Data transfers hang after

[PATCH] ahci: reimplement port_map handling

2007-07-20 Thread Tejun Heo
Reimplement port_map handling such that 1. Non-zero PORTS_IMPL value is always examined and used if consistent with cap.n_ports. 2. When PI and cat.n_ports are inconsistent, honor cap.n_ports and force port_map to be ((1 cap.n_ports) - 1). 3. There were two separate places dealing with

[PATCH 4/4] ide: use only -set_pio_mode method for programming PIO modes

2007-07-20 Thread Bartlomiej Zolnierkiewicz
Use -set_pio_mode method to program PIO modes in ide_set_xfer_rate() (the only place which used -speedproc to program PIO modes) and remove handling of PIO modes from all -speedproc implementations. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej

Re: PATA driver for Atmel AVR32

2007-07-20 Thread Kristoffer Nyborg Gregertsen
On Friday 20 July 2007 11:08:19 Kristoffer Nyborg Gregertsen wrote: There might be problems with the signals from the AVR32s External Bus Interface to the ATA device, although it seems fine when looking with the logic analyzer. Can a random signal fault generate this kind of failure? Or is

Re: [PATCH] Fix SMART reporting on 2.6.22

2007-07-20 Thread Jeff Garzik
Petr Vandrovec wrote: On Mon, Jul 16, 2007 at 07:32:57PM +0900, Tejun Heo wrote: [cc'ing Jeff and Albert] Petr Vandrovec wrote: Fix reported task file values in sense data ata_tf_read was setting HOB bit when lba48 command was submitted, but was not clearing it before reading normal data.

Re: [patch] libata: fix last_ctl caching in ata_tf_read()

2007-07-20 Thread Jeff Garzik
Chuck Ebbert wrote: libata: fix last_ctl caching in ata_tf_read() last_ctl was not cached properly. (Pointed out by Tejun Heo.) Signed-off-by: Chuck Ebbert [EMAIL PROTECTED] --- (Apply after Petr's patch to fix SMART bugs.) drivers/ata/libata-sff.c |4 1 file changed, 4

Re: [PATCH 2.6.22-git13] libata: add ST9160821AS 3.CLF to NONCQ blacklist

2007-07-20 Thread Jeff Garzik
Tejun Heo wrote: Yay, the first one from Seagate. 3.ALC firmware is okay. This was reported by Sam Freed on bugzilla bug 8759. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Sam Freed [EMAIL PROTECTED] --- drivers/ata/libata-core.c |1 + 1 file changed, 1 insertion(+)

Re: [PATCH] ahci.c: fix CONFIG_PM=n compilation

2007-07-20 Thread Jeff Garzik
Alexey Dobriyan wrote: Commit df69c9c5438b4e396a64d42608b2a6c48a3e7475 moved only prototype of out of CONFIG_PM. Move function out as well. Box seems to boot fine. Signed-off-by: Alexey Dobriyan [EMAIL PROTECTED] --- drivers/ata/ahci.c | 16 1 file changed, 8 insertions(+),

Re: [PATCH] pata_scc.c: small fixes (Workaround for errata A308)

2007-07-20 Thread Jeff Garzik
Akira Iguchi wrote: This patch fixes some issues of the previous patch: - Use mode_filter() hook to limit ATAPI UDMA mode - data loss warning message - handling of udma_mask Signed-off-by: Kou Ishizaki [EMAIL PROTECTED] Signed-off-by: Akira Iguchi [EMAIL PROTECTED] applied - To unsubscribe

unexpected scsi timeout

2007-07-20 Thread Vasily Averin
Tejun, Jeff I've noticed that some scsi commands for DVD-drive attached to pata_via successfully finishes without any delays but reports about TIMEOUT condition. It happens because of ATA_ERR bit is set in status register. As result for each command Error Handler thread awakened, requests sense

Re: [patch] add more device IDs for supporting SB700 (resend)

2007-07-20 Thread Jeff Garzik
su henry wrote: From: [EMAIL PROTECTED] The SATA controller device ID is different according to the onchip SATA type set in the system BIOS: Device Device ID SATA in IDE mode 0x4390 SATA in AHCI mode 0x4391 SATA in non-raid5 driver 0x4392

Re: [PATCH] ahci: reimplement port_map handling

2007-07-20 Thread Jeff Garzik
Where does this stand, now that I dove into PMP patchset 1 of 4? Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [patch 10/11] iomap: sort out the broken address reporting caused by the iomap layer

2007-07-20 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Alan Cox [EMAIL PROTECTED] Add an iomap_name() function which translates an I/O map into a string to print. Use it for the Libata layer For now we use 0x for I/O and 0x for MMIO. I'm assuming that eventually some other platforms will want to use

Re: [patch 11/11] ata: use iomap_name()

2007-07-20 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Alan Cox [EMAIL PROTECTED] Use iomap_name() in the libata layer Signed-off-by: Alan Cox [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] ACK will await resend when previous patch

Re: PATA driver for Atmel AVR32

2007-07-20 Thread Kristoffer Nyborg Gregertsen
On Friday 20 July 2007 13:14:43 Alan Cox wrote: /* * SMC timings to match ATAPI-4 PIO timing specs (given in ns) * See Figure 20 and Table 29 on pages 262-263 in T13/1153D revision 18 */ static const int smc_tot_cycle[5] = {600, 390, 350, 190, 135}; /* = t0 */ static const int

Re: [PATCH 17/21] libata: improve SCSI scan failure handling

2007-07-20 Thread Jeff Garzik
Tejun Heo wrote: SCSI scan may fail due to memory allocation failure even if EH is not in progress. Due to use of GFP_ATOMIC in SCSI scan path, allocation failure isn't too rare especially while probing multiple devices at once which is the case when a bunch of devices are connected to PMP.

Re: [PATCH 02/21] libata: add @is_cmd to ata_tf_to_fis()

2007-07-20 Thread Jeff Garzik
Tejun Heo wrote: Jeff Garzik wrote: Tejun Heo wrote: Add @is_cmd to ata_tf_to_fis(). This controls bit 7 of the second byte which tells the device whether this H2D FIS is for a command or not. This cleans up ahci a bit and will be used by PMP. Signed-off-by: Tejun Heo [EMAIL PROTECTED] ---

Re: [PATCH 02/21] libata: add @is_cmd to ata_tf_to_fis()

2007-07-20 Thread Jeff Garzik
Tejun Heo wrote: +extern void ata_tf_to_fis(const struct ata_taskfile *tf, + u8 pmp, int is_cmd, u8 *fis); I'm applying these... but I would like to start seeing 'bool' type used for arguments like is_cmd, for situations where the only values we -ever- care about are

Re: [PATCH 02/21] libata: add @is_cmd to ata_tf_to_fis()

2007-07-20 Thread Jeff Garzik
Tejun Heo wrote: Add @is_cmd to ata_tf_to_fis(). This controls bit 7 of the second byte which tells the device whether this H2D FIS is for a command or not. This cleans up ahci a bit and will be used by PMP. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/ahci.c| 10

Re: [PATCH 12/21] libata: make -scr_read/write callbacks return error code

2007-07-20 Thread Jeff Garzik
Tejun Heo wrote: Convert -scr_read/write callbacks to return error code to better indicate failure. This will help handling of SCR_NOTIFICATION. This is a welcome improvement, for reasons beyond PMP. Thanks, Jeff - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH] ahci: reimplement port_map handling

2007-07-20 Thread Tejun Heo
Jeff Garzik wrote: Where does this stand, now that I dove into PMP patchset 1 of 4? I can regenerate this one later. -- tejun - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 17/21] libata: improve SCSI scan failure handling

2007-07-20 Thread Tejun Heo
Jeff Garzik wrote: Tejun Heo wrote: SCSI scan may fail due to memory allocation failure even if EH is not in progress. Due to use of GFP_ATOMIC in SCSI scan path, allocation failure isn't too rare especially while probing multiple devices at once which is the case when a bunch of devices are

[PATCH] pata_acpi: Rework the ACPI drivers based upon experience of what the BIOS can do

2007-07-20 Thread Alan Cox
Signed-off-by: Alan Cox [EMAIL PROTECTED] Don't assume the BIOS can validate modes or has any sense at all. Instead use the BIOS timings to deduce the modes. diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.22-rc6-mm1/drivers/ata/pata_acpi.c

[PATCH] pata_ali: Correct HP detect

2007-07-20 Thread Alan Cox
Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.22-rc6-mm1/drivers/ata/pata_ali.c linux-2.6.22-rc6-mm1/drivers/ata/pata_ali.c --- linux.vanilla-2.6.22-rc6-mm1/drivers/ata/pata_ali.c 2007-07-02 20:50:11.0 +0100

[PATCH] pata_cs5520: Fix probe bug introduced by 2.6.22 (regression)

2007-07-20 Thread Alan Cox
Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.22-rc6-mm1/drivers/ata/pata_cs5520.c linux-2.6.22-rc6-mm1/drivers/ata/pata_cs5520.c --- linux.vanilla-2.6.22-rc6-mm1/drivers/ata/pata_cs5520.c 2007-07-02

PATCH: iomap (Corrected - ignore last one)

2007-07-20 Thread Alan Cox
Allow for 64bit MMIO ports in the iomap printing buffer Signed-off-by: Alan Cox [EMAIL PROTECTED] --- linux-2.6.22-rc6-mm1/include/asm-generic/iomap.h~ 2007-07-20 14:08:07.0 +0100 +++ linux-2.6.22-rc6-mm1/include/asm-generic/iomap.h2007-07-20 14:08:07.310897944 +0100 @@ -67,7

Re: [PATCH 1/1] ide: pdc202xx_new PLL input clock fix

2007-07-20 Thread Bahadir Balban
On 7/3/07, Albert Lee [EMAIL PROTECTED] wrote: Recently the PLL input clock of Promise 2027x is sometimes detected higer than expected (e.g. 20.027 MHz compared to 16.714 MHz). It seems sometimes the mdelay() function is not as precise as it used to be. Per Alan's advice, HT or power management

[PATCH broken-out-2007-07-20-00-22] drivers/ata/libata-core.c build fix

2007-07-20 Thread Michal Piotrowski
Hi Kristen, Hmmm... ata-ahci-alpm-enable-link-power-management-for-ata-drivers.patch drivers/ata/libata-core.c: In function 'ata_dev_configure': drivers/ata/libata-core.c:2039: error: implicit declaration of function 'ata_device_blacklisted' make[2]: *** [drivers/ata/libata-core.o] Error 1

Re: [PATCH 2/4] it8213/piix/slc90e66: don't change DMA settings when programming PIO

2007-07-20 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/drivers/ide/pci/it8213.c === --- a/drivers/ide/pci/it8213.c +++

Re: [PATCH 3/4] sis5513: don't change UDMA settings when programming PIO

2007-07-20 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH] fix remaining scr_read/write users and the documentation

2007-07-20 Thread James Bottomley
This fixes up the usage in libsas (which are easy to miss, since they're only in the scsi-misc tree) ... and also corrects the documentation on the point of what these two function pointers actually return. James diff --git a/Documentation/DocBook/libata.tmpl b/Documentation/DocBook/libata.tmpl

Re: pata_via with software raid1: attempt to access beyond end of device

2007-07-20 Thread Dâniel Fraga
On Fri, 20 Jul 2007 16:37:09 +0100 Alan Cox [EMAIL PROTECTED] wrote: Ok try booting with libata.ignore_hpa=1 I used that option: [EMAIL PROTECTED] ~$ dmesg|grep hpa Kernel command line: auto BOOT_IMAGE=linux rw root=902 panic=5 libata.ignore_hpa=1 and tried to

Re: pata_via with software raid1: attempt to access beyond end of device

2007-07-20 Thread Alan Cox
But I really don't know why mkreiserfs is creating a filesystem with 64k more than allowed by the device... maybe a bug in mkreiserfs? The strange is that it didn't happen with the OLD IDE drivers... could it be a pata_via bug? pata_via doesn't deal with disk sizes. That is