Re: [2.6.23-rc1] ata_piix: EH pending after completion, repeating EH (cnt=4)

2007-07-24 Thread Tejun Heo
Mikael Pettersson wrote: This machine has a known good Samsung SATA DVD on ICH8 [8086:2820]. With kernel 2.6.23-rc1 I now get the following: ata_piix :00:1f.2: version 2.11 ata_piix :00:1f.2: MAP [ P0 P2 P1 P3 ] ACPI: PCI Interrupt :00:1f.2[B] - GSI 19 (level, low) - IRQ 19

Re: [PATCH] pata_hpt37x: Fix 2.6.22 clock PLL regression

2007-07-24 Thread Sergei Shtylyov
Hello. Alan Cox wrote: Just one version of Linux ago The PLL code broke - oh no! But set the right mode And fix up the code Makes the PLL timing sync go /me applauds :-) Closes-bug: #8791 Signed-off-by: Alan Cox [EMAIL PROTECTED] Acked-by: Sergei

Re: drivers/ide/pci/cs5535.c: array overrun

2007-07-24 Thread Jordan Crouse
The Coverity checker spotted the following array overrun in drivers/ide/pci/cs5535.c: -- snip -- if (speed = XFER_UDMA_0 speed = XFER_UDMA_7) reg |= cs5535_udma_timings[speed - XFER_UDMA_0]; Fix is attached. Somebody got overzealous - the 5535 only supports up to

Re: [PATCH] pata_hpt37x: Fix 2.6.22 clock PLL regression

2007-07-24 Thread Jeff Garzik
Alan Cox wrote: Just one version of Linux ago The PLL code broke - oh no! But set the right mode And fix up the code Makes the PLL timing sync go Closes-bug: #8791 Signed-off-by: Alan Cox [EMAIL PROTECTED] applied - To unsubscribe from this list: send

Re: [PATCH] pata_ali: Correct HP detect

2007-07-24 Thread Jeff Garzik
Alan Cox wrote: Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.22-rc6-mm1/drivers/ata/pata_ali.c linux-2.6.22-rc6-mm1/drivers/ata/pata_ali.c --- linux.vanilla-2.6.22-rc6-mm1/drivers/ata/pata_ali.c 2007-07-02

Re: [PATCH 2/2] ata_piix: fix suspend/resume for some TOSHIBA laptops

2007-07-24 Thread Jeff Garzik
Tejun Heo wrote: + /* Some braindamaged ACPI suspend implementations expect the +* controller to be awake on entry; otherwise, it burns cpu +* cycles and power trying to do something to the sleeping +* beauty. +*/ applied 1-2... HOWEVER... I would not

Re: [PATCH 2/2] ata_piix: fix suspend/resume for some TOSHIBA laptops

2007-07-24 Thread Jeff Garzik
Alan Cox wrote: A more generalized rule to consider for the future would be to ensure that ALL suspend routines put the hardware back into its pre-Linux init mode before suspending. i.e. that means if we turned on some enhanced mode, we must switch back to legacy mode before calling pci_xxx

Re: [PATCH] pata_hpt37x: Fix 2.6.22 clock PLL regression

2007-07-24 Thread Linus Torvalds
On Tue, 24 Jul 2007, Alan Cox wrote: Just one version of Linux ago The PLL code broke - oh no! But set the right mode And fix up the code Makes the PLL timing sync go Alan, I'm getting a bit worried about you. Linus - To unsubscribe from

Re: Time Problems with 2.6.23-rc1-gf695baf2

2007-07-24 Thread Bartlomiej Zolnierkiewicz
On Wednesday 25 July 2007, Bartlomiej Zolnierkiewicz wrote: Hi, On Wednesday 25 July 2007, Michal Piotrowski wrote: Hi, On 24/07/07, Eric Sesterhenn / Snakebyte [EMAIL PROTECTED] wrote: hi, seems like the clock got screwed or something similar. During bootup the computer

Re: unexpected scsi timeout

2007-07-24 Thread Albert Lee
Vasily Averin wrote: Tejun Heo wrote: [cc'ing Albert] Vasily Averin wrote: Tejun, Jeff I've noticed that some scsi commands for DVD-drive attached to pata_via successfully finishes without any delays but reports about TIMEOUT condition. It happens because of ATA_ERR bit is set in status