Re: sata_nv or port issue?

2007-07-26 Thread Tejun Heo
Zivago Lee wrote: I'm running Ubuntu Feisty on the 2.6.20 kernel (Linux miyagip 2.6.20-16-generic #2 SMP Thu Jun 7 20:19:32 UTC 2007 i686 GNU/Linux). Please give a shot at 2.6.22. It will report more detail about what's going on. -- tejun - To unsubscribe from this list: send the line

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-26 Thread Sergei Shtylyov
Hello. Vitaly Bordug wrote: I acn undertand your complaint in the context of an OF driver (which we don't have yet) but mmio-ide just means nothing to the current driver, and it doesn't convery enough info on the programming interface for the conceivable OF driver, it also does need to know

Re: [PATCH] cs5535: check ide_config_drive_speed() return value

2007-07-26 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH] au1xxx: fix au1xxx_set_pio_mode()

2007-07-26 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Set transfer mode on the device before programming the host controller for the new timings (matches what auide_tune_chipset() is doing wrt DMA modes). It's not that the most other drives are doing something different... :-) Signed-off-by: Bartlomiej

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-26 Thread Guennadi Liakhovetski
On Thu, 26 Jul 2007, Sergei Shtylyov wrote: Guennadi Liakhovetski wrote: Ok, thanks for the explanation Alan. So, there's no technical argument, just being nice to the users, and add a new driver, which we know we'll have to remove soon, thus having to persuade its users, who by that

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-26 Thread Sergei Shtylyov
Hello. Guennadi Liakhovetski wrote: driver to using platform-device. I got a reply, that it's not worth it now that IDE is slowly becoming obsolete, and the pata_platform serves the perpose perfectly well. I found this argument reasonable, I had the same doubt, just wanted to double-check.

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-26 Thread Bartlomiej Zolnierkiewicz
On Wednesday 25 July 2007, Alan Cox wrote: pata_platform and ide_platform are carrying same driver names, to easily switch between these drivers, without need to touch platform code. Signed-off-by: Anton Vorontsov [EMAIL PROTECTED] Signed-off-by: Vitaly Bordug [EMAIL PROTECTED]

Re: [PATCH 11/11] ide-pmac: remove pmac_ide_do_setfeature() (take 2)

2007-07-26 Thread Bartlomiej Zolnierkiewicz
On Tuesday 24 July 2007, Benjamin Herrenschmidt wrote: On Tue, 2007-07-24 at 00:29 +0200, Bartlomiej Zolnierkiewicz wrote: Use ide_config_drive_speed() instead of pmac_ide_do_setfeature() and remove the latter, also ide-iops.c::__ide_wait_stat() could be static again. Since for IDE PMAC

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-26 Thread Guennadi Liakhovetski
On Wed, 25 Jul 2007, Alan Cox wrote: driver to using platform-device. I got a reply, that it's not worth it now that IDE is slowly becoming obsolete, and the pata_platform serves the perpose perfectly well. I found this argument reasonable, I had the same doubt, just wanted to

Re: CONFIG_IDE_PROC_FS: /sys is not full replacement of /proc

2007-07-26 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 18 July 2007, Andrey Borzenkov wrote: May be I miss something obvious but most information that was available in /proc/ide is missing under /sys. At the very least, Mandriva hardware detection expects /proc/ide/hdX/model; nothing close is under /sys. It is really better to

[PATCH] amd74xx/via82cxxx: check ide_config_drive_speed() return value

2007-07-26 Thread Bartlomiej Zolnierkiewicz
* Check ide_config_drive_speed() return value. * While at also call ide_config_drive_speed() if the transfer mode is XFER_PIO_SLOW (this case happens iff the transfer mode has already been set on the device by ide-proc.c::set_xfer_rate()) and remove redundant setting of

Re: [PATCH] pata_cmd64x: Correct the speed ranges

2007-07-26 Thread Jeff Garzik
Sergei Shtylyov wrote: Note that the olde driver has MWDMA fixed, and the new one has it still borken, yet MWDMA2 is the mode you're using. What about MWDMA is broken? Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL

Re: [PATCH] ide: move ide_config_drive_speed() calls to upper layers

2007-07-26 Thread Bartlomiej Zolnierkiewicz
On Friday 27 July 2007, Bartlomiej Zolnierkiewicz wrote: * Add IDE_HFLAG_POST_SET_MODE host to indicate the need to program the host for the transfer mode after programming the device. Set it in au1xxx-ide/cs5530/cs5535/pdc202xx_new/sc1200/via82cxxx host drivers. and amd74xx :) - To

Re: [PATCH 11/11] ide-pmac: remove pmac_ide_do_setfeature() (take 2)

2007-07-26 Thread Benjamin Herrenschmidt
On Thu, 2007-07-26 at 20:04 +0200, Bartlomiej Zolnierkiewicz wrote: On Tuesday 24 July 2007, Benjamin Herrenschmidt wrote: On Tue, 2007-07-24 at 00:29 +0200, Bartlomiej Zolnierkiewicz wrote: Use ide_config_drive_speed() instead of pmac_ide_do_setfeature() and remove the latter, also

Re: [PATCH] pata_cmd64x: Correct the speed ranges

2007-07-26 Thread Mikael Pettersson
On Thu, 26 Jul 2007 18:43:01 +0100, Alan Cox wrote: I must have been half asleep when doing the original code Signed-off-by: Alan Cox [EMAIL PROTECTED] [patch to fix .udma_mask in pata_cmd64x omitted] This fix inspired me to finally try to convert my Sun Ultra5 (sparc64) with a CMD646

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-26 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 26 July 2007, Guennadi Liakhovetski wrote: On Wed, 25 Jul 2007, Alan Cox wrote: driver to using platform-device. I got a reply, that it's not worth it now that IDE is slowly becoming obsolete, and the pata_platform serves the perpose perfectly well. I found this

Re: [PATCH 1/2] [IDE] Platform IDE driver (was: MMIO IDE driver)

2007-07-26 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 25 July 2007, Vitaly Bordug wrote: This is now very similar to pata_platform.c, they both use same platform data structure and same resources. To achieve that, byte_lanes_swapping platform data variable and platform specified iops removed from that driver. It's fine,

[PATCH] pata_mpiix: Forget a conversion

2007-07-26 Thread Alan Cox
This one applies after the big patch. Without it the mpiix module won't load as it still tries to use the old ata_std_ports symbol which I only just noticed after posting the main diff. (Andrew you might want to just cat the two together, sorry about that) Signed-off-by: Alan Cox [EMAIL

[PATCH] libata: Store bus addresses (versus -mm for testing)

2007-07-26 Thread Alan Cox
As we cannot reverse iomap results portably as we tried before the libata layer needs to keep bus addresses around for reporting. This first big patch adds a structure for it and teaches the drivers to keep the information. Thankfully most drivers go via libata-sff and it can do the work for them.

Re: sata_nv or port issue?

2007-07-26 Thread Zivago Lee
On Thu, 2007-07-26 at 17:23 +0900, Tejun Heo wrote: Zivago Lee wrote: I'm running Ubuntu Feisty on the 2.6.20 kernel (Linux miyagip 2.6.20-16-generic #2 SMP Thu Jun 7 20:19:32 UTC 2007 i686 GNU/Linux). Please give a shot at 2.6.22. It will report more detail about what's going on.

[PATCH] libata-sff; Unbreak non DMA capable controllers again

2007-07-26 Thread Alan Cox
Seems nobody else is checking/testing this case as it keeps getting horked. If we have no BAR4 mapping on an SFF controller this is *NOT* an error, it just means it isn't doing BMDMA. Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-26 Thread Vitaly Bordug
On Wed, 25 Jul 2007 21:06:42 +0400 Sergei Shtylyov wrote: Hello. Vitaly Bordug wrote: This updates relevant platform code (freescale mpc8349itx target) to make the CompactFlash work in TrueIDE mode. Erm, I'm not sure it's worth submitting the platform device driver for PowerPC

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-26 Thread Sergei Shtylyov
Hello, I wrote: Also, what mmio-ide in the compat properly means in the context of ide_platform which is able to handle both port and memory mapped IDE. I/O-space is only valid in the context of PCI, ISA, or similar buses, and the bus-specific reg format indicates whether it's mmio-space

Re: [2.6.23-rc1] ata_piix: EH pending after completion, repeating EH (cnt=4)

2007-07-26 Thread Tejun Heo
Mikael Pettersson wrote: On Tue, 24 Jul 2007 17:32:29 +0900, Tejun Heo wrote: Mikael Pettersson wrote: This machine has a known good Samsung SATA DVD on ICH8 [8086:2820]. With kernel 2.6.23-rc1 I now get the following: ata_piix :00:1f.2: version 2.11 ata_piix :00:1f.2: MAP [ P0 P2

Problem with size after growing a device on 3ware-9500

2007-07-26 Thread Lars Michael Jogbäck
Hi, I don't know really which subsystem this, so I'm sending this to the linux-ide list. Please direct me to a more appropriate place if this is not correct. I'm using a 3ware 9500 with Linux 2.6.18.1. I've grown the HW raid5-array and here is where the problem begins. After the card had

Re: [PATCH] pata_cmd64x: Correct the speed ranges

2007-07-26 Thread Sergei Shtylyov
Mikael Pettersson wrote: This fix inspired me to finally try to convert my Sun Ultra5 (sparc64) with a CMD646 [1095:0646 rev 03] to libata. With pata_cmd64x the machine has so far survived a usual boot/mrproper/reconfig/make/install/reboot kernel update cycle without any issues, and

Re: [PATCH] pdc202xx_new: check ide_config_drive_speed() return value

2007-07-26 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH] icside: fix -speedproc to return on unsupported modes (take 5)

2007-07-26 Thread Bartlomiej Zolnierkiewicz
* All other implementations of -speedproc return zero on success and non-zero on failure. Currently it doesn't matter for icside host driver and isn't a bug per se since: - ide_set_xfer_rate() return value is ignored by all IDE core users - icside doesn't (yet!) use ide_tune_dma() in

Re: [PATCH] pata_cmd64x: Correct the speed ranges

2007-07-26 Thread Sergei Shtylyov
Hello. Alan Cox wrote: I must have been half asleep when doing the original code Signed-off-by: Alan Cox [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc1-mm1/drivers/ata/pata_cmd64x.c

[PATCH] pata_cmd64x: Correct the speed ranges

2007-07-26 Thread Alan Cox
I must have been half asleep when doing the original code Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc1-mm1/drivers/ata/pata_cmd64x.c linux-2.6.23rc1-mm1/drivers/ata/pata_cmd64x.c ---

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-07-26 Thread Vitaly Bordug
On Wed, 25 Jul 2007 13:46:57 -0500 Scott Wood wrote: Sergei Shtylyov wrote: I acn undertand your complaint in the context of an OF driver (which we don't have yet) but mmio-ide just means nothing to the current driver, and it doesn't convery enough info on the programming interface

[PATCH 2/4] libata: ACPI checks for 80wire cable

2007-07-26 Thread Alan Cox
Provide actual methods for checking if the ACPI support thinks the cable is 80wire, or doesn't know Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc1-mm1/drivers/ata/libata-acpi.c

Re: Problems with nVidia nForce 520 Chipset

2007-07-26 Thread Craig Block
--- Tejun Heo [EMAIL PROTECTED] wrote: Craig Block wrote: I'm having a problem getting Linux to handle the SATA drives and controllers on a new computer with an ASUS M2N-X motherboard. This is a socket AM2 board and has an nVidia nForce 520 chipset. Does 'noapic' kernel parameter

Re: [2.6.23-rc1] ata_piix: EH pending after completion, repeating EH (cnt=4)

2007-07-26 Thread Mikael Pettersson
On Thu, 26 Jul 2007 15:31:10 +0900, Tejun Heo wrote: Mikael Pettersson wrote: On Tue, 24 Jul 2007 17:32:29 +0900, Tejun Heo wrote: Mikael Pettersson wrote: This machine has a known good Samsung SATA DVD on ICH8 [8086:2820]. With kernel 2.6.23-rc1 I now get the following: ata_piix

Please pull for stable ATA

2007-07-26 Thread Jeff Garzik
Please pull commit fe36cb53cfd82f3c0796a0826e1c9caf198c8f97 Author: Petr Vandrovec [EMAIL PROTECTED] Date: Fri Jul 20 07:44:44 2007 -0400 [libata] Fix reported task file values in sense data into the 2.6.22 stable tree. - To unsubscribe from this list:

[PATCH] au1xxx: fix au1xxx_set_pio_mode()

2007-07-26 Thread Bartlomiej Zolnierkiewicz
Set transfer mode on the device before programming the host controller for the new timings (matches what auide_tune_chipset() is doing wrt DMA modes). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/mips/au1xxx-ide.c |7 +++ 1 file changed, 3 insertions(+), 4

[PATCH 4/4] libata: ACPI checks for 80wire cable

2007-07-26 Thread Alan Cox
Testing this on the VIA boards fixes several problems with otherwise undetectable SATA bridge chips Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc1-mm1/drivers/ata/pata_via.c

Re: [PATCH] ide: move ide_config_drive_speed() calls to upper layers

2007-07-26 Thread Bartlomiej Zolnierkiewicz
On Friday 27 July 2007, Bartlomiej Zolnierkiewicz wrote: On Friday 27 July 2007, Bartlomiej Zolnierkiewicz wrote: * Add IDE_HFLAG_POST_SET_MODE host to indicate the need to program the host for the transfer mode after programming the device. Set it in

[PATCH] cs5535: check ide_config_drive_speed() return value

2007-07-26 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cs5535.c |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) Index: b/drivers/ide/pci/cs5535.c === --- a/drivers/ide/pci/cs5535.c +++

[PATCH] pdc202xx_new: check ide_config_drive_speed() return value

2007-07-26 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/pdc202xx_new.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) Index: b/drivers/ide/pci/pdc202xx_new.c === ---

[PATCH 3/4] libata: ACPI checks for 80wire cable

2007-07-26 Thread Alan Cox
We can make use of this on the pata_amd driver as many Nvidia devices don't have reliable cable detect. Signed-off-by: Alan Cox [EMAIL PROTECTED] diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc1-mm1/drivers/ata/pata_amd.c

[PATCH 1/4] libata: ACPI checks for 80wire cable

2007-07-26 Thread Alan Cox
We can use the ACPI mode information with several drivers as a hint to cable type. If the ACPI mode set by the BIOS is faster than UDMA33 then we know the BIOS thinks there are 80wire cables. If it doesn't set such a mode or it has no ACPI method then we get no further information and can rely on

Re: Re+: SATA hard drive no longer comes up as /dev/sda on 2.6.22 with Intel ICH6M

2007-07-26 Thread Tejun Heo
Hello, P.C.Chan wrote: The last straw which breaks the SATA support is CONFIG_IDE_GENERIC=y. Please see enclosed config files. The description being: *generic/default IDE chipset support (IDE_GENERIC) If unsure, say Y.* The linux distributions would have a hard time in preparing a

[PATCH] ide: make CONFIG_IDE_GENERIC default to N

2007-07-26 Thread Tejun Heo
These days, CONFIG_IDE_GENERIC causes more confusion and misconfiguration than it helps. Especially so because libata is linked after the generic driver. Default to N. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ide/Kconfig |4 ++-- 1 file changed, 2 insertions(+), 2

Re: Problems with nVidia nForce 520 Chipset

2007-07-26 Thread Tejun Heo
Craig Block wrote: --- Tejun Heo [EMAIL PROTECTED] wrote: Craig Block wrote: I'm having a problem getting Linux to handle the SATA drives and controllers on a new computer with an ASUS M2N-X motherboard. This is a socket AM2 board and has an nVidia nForce 520 chipset. Does 'noapic' kernel

Re: drivers/ide/pci/cs5535.c: array overrun

2007-07-26 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 24 July 2007, Jordan Crouse wrote: The Coverity checker spotted the following array overrun in drivers/ide/pci/cs5535.c: -- snip -- if (speed = XFER_UDMA_0 speed = XFER_UDMA_7) reg |= cs5535_udma_timings[speed - XFER_UDMA_0]; Not a bug per se since

[PATCH] pci: rename __pci_reenable_device() to pci_reenable_device()

2007-07-26 Thread Tejun Heo
Rename __pci_reenable_device() to pci_reenable_device(). Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- Jeff, Greg wanted to drop the preceding underscores before exporting the function and the updated patch was posted but the earlier version was applied. This patch renames the function.

[PATCH] ata_piix: add Tecra M3 to broken suspend blacklist

2007-07-26 Thread Tejun Heo
Add Tecra M3 to the broken suspend blacklist. Tecra M3 doesn't have proper DMI_PRODUCT_NAME but has an OEM_STRING instead. Match it. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/ata_piix.c |8 1 file changed, 8 insertions(+) Index: work/drivers/ata/ata_piix.c

[PATCH] ata_piix: implement piix_borken_suspend()

2007-07-26 Thread Tejun Heo
Separate out broken suspend blacklist matching into piix_broken_suspend(). Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/ata_piix.c | 60 - 1 file changed, 30 insertions(+), 30 deletions(-) Index: work/drivers/ata/ata_piix.c