[PATCH] hook ACPI _PSx method to IDE power on/off

2007-08-02 Thread Shaohua Li
ACPI spec defines the sequence of IDE power on/off: Powering down: Call _GTM. Power down drive (calls _PS3 method and turns off power planes). Powering up: Power up drive (calls _PS0 method if present and turns on power planes). Call _STM passing info from _GTM

SiS driver K2.4 for 180/182/965/966....

2007-08-02 Thread Franck Bourdonnec
Hello Uwe Jeff, I'm trying to follow the 'life' of this driver sata_sis.c. I want to report back in Kernel 2.4.34 the additions found since some time. I do this to extend IPCOP usage of SATA boards and also to contribute to linux kernel if possible. It's not easy because there is many source,

ICH8 CF timeout (regression)...

2007-08-02 Thread Daniel J Blueman
I'm experiencing timeouts with libata when reading from a compact flash card connected to onboard IDE. Reproducible with 2.6.20, 2.6.22, 2.6.23-rc1, with both short cable and a on-mobo CF socket on a x86-64 Core2Duo. Sometimes (~7%), we see some EH and the interface stablises, then the system

[PATCH] pata_isapnp: use MODULE_DEVICE_TABLE()

2007-08-02 Thread Jeff Garzik
I found this while doing ISDN PCI API conversions... I presume this omission was not intentional? Signed-off-by: Jeff Garzik [EMAIL PROTECTED] diff --git a/drivers/ata/pata_isapnp.c b/drivers/ata/pata_isapnp.c index 5525518..91a396f 100644 --- a/drivers/ata/pata_isapnp.c +++

Re: ST340823A disk size issue

2007-08-02 Thread Alan Cox
Additionally fs/partitions/check.c:rescan_partitions() should warn if the partition exceeds device size and we are not seeing any such warning. Why would it if there isn't anything wrong ? The same disks just work in libata even with the hpa being disabled. It closed a pile of long standing

Re: [PATCH] pata_isapnp: use MODULE_DEVICE_TABLE()

2007-08-02 Thread Alan Cox
On Thu, 2 Aug 2007 07:06:07 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: I found this while doing ISDN PCI API conversions... I presume this omission was not intentional? Signed-off-by: Jeff Garzik [EMAIL PROTECTED] Looks fine to me Alan - To unsubscribe from this list: send the line

Re: ST340823A disk size issue

2007-08-02 Thread Sergei Shtylyov
Mikko Rapeli wrote: diff -ru linux-2.6.22.1/drivers/ide/ide-disk.c linux-2.6.22.1.new/drivers/ide/ide-disk.c --- linux-2.6.22.1/drivers/ide/ide-disk.c 2007-07-10 21:56:30.0 +0300 +++ linux-2.6.22.1.new/drivers/ide/ide-disk.c 2007-08-01 22:59:47.0 +0300 @@ -502,6

Re: No equivalent for ide-scsi available with the new PATA drivers?

2007-08-02 Thread Mark Lord
Alan Cox wrote: On Mon, 23 Jul 2007 12:36:44 -0400 Chuck Ebbert [EMAIL PROTECTED] wrote: People with IDE tape drives are complaining there's no ide-scsi driver available anymore with the new PATA layer. Is anyone working on one? It would make no sense. The libata layer is already using the

Re: [PATCH] sata_qstor, pdc_adma, sata_sx4: convert to new EH

2007-08-02 Thread Mark Lord
Jeff Garzik wrote: This is just a refresh of the existing libata-dev.git#new-eh patches that convert all remaining old-EH drivers to new EH, against 2.6.23-rc1. All three conversions are completely untested. pdc_adma and sata_qstor need reviewing by someone with docs, in addition to testing.

Re: [PATCH UPDATED] libata: add support for ATA_16 on ATAPI

2007-08-02 Thread Mark Lord
Tejun Heo wrote: Jeff Garzik wrote: Tejun Heo wrote: Jeff, Mark, are you guys okay with the modified version? Close! Thanks for revising! My only comment now is that I dislike atapi_scmd85. That means nothing to me. I liked the old name better. Or maybe use atapi_passthru16. The

Re: hpt374 sata (Highpoint Rocket 1540)

2007-08-02 Thread Sergei Shtylyov
Alan Cox wrote: Too bad, this is the standard HPT subsystem ID of 0x0001... So, nothing comes to my mind other than add a module parameter to hpt366.c to specify that we're using the crippled SATA bridge... well, maybe it would also make sense to scan the BIOS for the signatures... Since

Re: [PATCH] sata_qstor, pdc_adma, sata_sx4: convert to new EH

2007-08-02 Thread Tejun Heo
Mark Lord wrote: Jeff Garzik wrote: This is just a refresh of the existing libata-dev.git#new-eh patches that convert all remaining old-EH drivers to new EH, against 2.6.23-rc1. All three conversions are completely untested. pdc_adma and sata_qstor need reviewing by someone with docs, in

Re: ST340823A disk size issue

2007-08-02 Thread Bartlomiej Zolnierkiewicz
On Thursday 02 August 2007, Alan Cox wrote: Additionally fs/partitions/check.c:rescan_partitions() should warn if the partition exceeds device size and we are not seeing any such warning. Why would it if there isn't anything wrong ? Look at the __generic_make_requests() snippet (which was

Re: ST340823A disk size issue

2007-08-02 Thread Mikko Rapeli
On Wed, Aug 01, 2007 at 02:05:56PM +0100, Alan Cox wrote: You've got an odd sized disk. If you have that, old IDE, and you also have anything which tries to read the last sector (eg GPT partitioning) it'll break as it tries to read 1K block sizes. Vendors normally clip the drive to an even

Re: ST340823A disk size issue

2007-08-02 Thread Sergei Shtylyov
Hello, I wrote: diff -ru linux-2.6.22.1/drivers/ide/ide-disk.c linux-2.6.22.1.new/drivers/ide/ide-disk.c --- linux-2.6.22.1/drivers/ide/ide-disk.c2007-07-10 21:56:30.0 +0300 +++ linux-2.6.22.1.new/drivers/ide/ide-disk.c2007-08-01 22:59:47.0 +0300 @@ -502,6 +502,17 @@

Re: ST340823A disk size issue

2007-08-02 Thread Alan Cox
We should never ever see 1K requests for the last 512 bytes sector coming from the block layer. If we make driver handle such cases we may be just papering over some other issue. Quite possibly but at least in early 2.6 that issue was there, and that means without actually doing proper tests

Re: [PATCH] hook ACPI _PSx method to IDE power on/off

2007-08-02 Thread Matthew Garrett
On Thu, Aug 02, 2007 at 02:14:08PM +0800, Shaohua Li wrote: ACPI spec defines the sequence of IDE power on/off: Most distributions seem to be using the libata PATA code now - any plans to implement it there as well? -- Matthew Garrett | [EMAIL PROTECTED] - To unsubscribe from this list: send

Re: hpt374 sata (Highpoint Rocket 1540)

2007-08-02 Thread Alan Cox
Since you don't do a reset is it not sufficient to check word93 on the Ah, you mean to identify a SATA drive? Need to try this... That is the basic approach libata uses, and I've been runnin for a while with patches to actually pick this case up and flip the cable type as well. PATA

Re: Boot fails on Intel SATA controller

2007-08-02 Thread Quel Qun
-- Original message -- From: Tejun Heo [EMAIL PROTECTED] Quel Qun wrote: -- Original message -- From: Tejun Heo [EMAIL PROTECTED] Hello, Luiz Fernando N. Capitulino wrote: Hi there, A Mandriva user is reporting

Re: ICH8 CF timeout (regression)...

2007-08-02 Thread Tejun Heo
Daniel J Blueman wrote: I'll grab kernel logs from the legacy ATA boot; what else can help debug this issue? No problem testing patches too. Yeap, please post the old log. --- [2] ata2.00: limiting speed to UDMA/33:PIO4 ata2.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen

[PATCH] block: add protocol discriminators to requests and queues

2007-08-02 Thread James Bottomley
This looks small and innocuous, but it's actually the beginning of moving the upper layer drivers into block and adding a filtering layer. The idea is that the queue contains a queue_protocol parameter which details what the device actually speaks. The requests are likewise filled in with a

Libata Sil3124 hybrid drive failure

2007-08-02 Thread Fajun Chen
Hi, Does anyone know if libata supports hybrid drive on Sil3124? I tried to play with Seagate hybrid drive and got protocol mismatch error when adding LBAs to pinned set or querying pinned set? Sil24 driver code does not set Protocol Override field in PRB, just wonder if we need to set protocol

Re: [PATCH] block: add protocol discriminators to requests and queues

2007-08-02 Thread Matthew Wilcox
On Thu, Aug 02, 2007 at 12:47:25PM -0500, James Bottomley wrote: This looks small and innocuous, but it's actually the beginning of moving the upper layer drivers into block and adding a filtering layer. The idea is that the queue contains a queue_protocol parameter which details what the

[PATCH] Optional libata LED trigger for PowerMac G5

2007-08-02 Thread Tony Vroon
This adds an optional wrapper around ata_ac_issue_prot that triggers the LED layer. Powermac G5 machines with an Apple K2 controller will now blink the PMU LED to harddisk activity if CONFIG_ADB_PMU_LED_IDE is defined (like on a PowerBook/iBook). This avoids any pollution of the hot path on

Re: [PATCH] block: add protocol discriminators to requests and queues

2007-08-02 Thread James Bottomley
On Thu, 2007-08-02 at 12:51 -0600, Matthew Wilcox wrote: On Thu, Aug 02, 2007 at 12:47:25PM -0500, James Bottomley wrote: This looks small and innocuous, but it's actually the beginning of moving the upper layer drivers into block and adding a filtering layer. The idea is that the queue

Re: Libata Sil3124 hybrid drive failure

2007-08-02 Thread Jeff Garzik
Fajun Chen wrote: Does anyone know if libata supports hybrid drive on Sil3124? I tried to play with Seagate hybrid drive and got protocol mismatch error when adding LBAs to pinned set or querying pinned set? Sil24 driver code does not set Protocol Override field in PRB, just wonder if we need

Re: [PATCH 2/3] sis5513: always tune PIO

2007-08-02 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Always set -autotune in init_hwif_sis5513(), this means practically no change in behavior since PIO was always tuned in -ide_dma_check and autotune was always set for -dma_base == 0 case. * Bump driver version. Signed-off-by: Bartlomiej

Re: ST340823A disk size issue

2007-08-02 Thread Alan Cox
hdd: reading: block=78165360, sectors=1, buffer=0xc1e63000 hdd: dma_intr: status=0x51 { DriveReady SeekComplete Error } hdd: dma_intr: error=0x10 { SectorIdNotFound }, LBAsect=78165360, Ok this one does look like its actually a specific drive firmware error ide1: reset: master: error (0x00?)

Re: Early ATA devices

2007-08-02 Thread Alan Cox
So in theory we can persuade libata to drive original MFM/RLL disks with relatively few changes Does anyone have a working device to test? I'm currently testing a 40MB pre-ATA IDE drive and with the LBA/non-LBA fix I sent to Andrew and the 'its ancient, its PIO 2 who cares if SETXFER

Re: ICH8 CF timeout (regression)...

2007-08-02 Thread Daniel J Blueman
On 02/08/07, Tejun Heo [EMAIL PROTECTED] wrote: Daniel J Blueman wrote: I'll grab kernel logs from the legacy ATA boot; what else can help debug this issue? No problem testing patches too. Yeap, please post the old log. Not much actually - perhaps I need to enable some debugging: Uniform

[PATCH] sc1200: always tune PIO

2007-08-02 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/sc1200.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) Index: b/drivers/ide/pci/sc1200.c === --- a/drivers/ide/pci/sc1200.c +++

[PATCH] ide-cris: always tune PIO

2007-08-02 Thread Bartlomiej Zolnierkiewicz
Cc: Mikael Starvik [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/cris/ide-cris.c |2 ++ 1 file changed, 2 insertions(+) Index: b/drivers/ide/cris/ide-cris.c === ---

Re: [PATCH] ide: add cable detection for early UDMA66 devices (take 2)

2007-08-02 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday 30 July 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: * Move ide_in_drive_list() from ide-dma.c to ide-iops.c. * Add ivb_list[] table for listening early UDMA66 devices which don't conform to ATA4 standard wrt cable detection (bit14 is

Re: ST340823A disk size issue

2007-08-02 Thread Bartlomiej Zolnierkiewicz
On Thursday 02 August 2007, Alan Cox wrote: hdd: reading: block=78165360, sectors=1, buffer=0xc1e63000 hdd: dma_intr: status=0x51 { DriveReady SeekComplete Error } hdd: dma_intr: error=0x10 { SectorIdNotFound }, LBAsect=78165360, Ok this one does look like its actually a specific drive

[PATCH] slc90e66: always tune PIO

2007-08-02 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/slc90e66.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Index: b/drivers/ide/pci/slc90e66.c === --- a/drivers/ide/pci/slc90e66.c

Re: ST340823A disk size issue

2007-08-02 Thread Mikko Rapeli
On Fri, Aug 03, 2007 at 12:34:13AM +0200, Bartlomiej Zolnierkiewicz wrote: Mikko, please verify that the following patch fixes the issue. A few oopses later and this actually works with vanilla 2.6.22.1 and Debian 2.6.18 (2.6.18.dfsg.1-12etch2), latter without EXPORT_SYMBOL_GPL since it's there

Re: [PATCH] cs5530: always tune PIO

2007-08-02 Thread Alan Cox
On Fri, 3 Aug 2007 00:46:27 +0200 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cs5530.c | 19 ++- 1 file changed, 6 insertions(+), 13 deletions(-) Index: b/drivers/ide/pci/cs5530.c