Re: [PATCHSET] libata: implement ata_link, take 6

2007-08-06 Thread Tejun Heo
James Bottomley wrote: On Sat, 2007-08-04 at 17:42 +0900, Tejun Heo wrote: This is the sixth take of implement ata_link patchset. This patchset contains 14 patches which can be categorized as follows. #01-02: implement ata_link #03-06: make libata deal with link instead of port #07-09:

Re: 2.6.23-rc2: check_irq_resend on resume (ali15x3)

2007-08-06 Thread Bartlomiej Zolnierkiewicz
commit 0fc4969b866671dfe39b1a9119d0fdc7ea0f63e5 I doubt that this particular report helps in debugging ne2k-pci problem... ;) On Saturday 04 August 2007, Andrey Borzenkov wrote: Just noticed this; I do not remember having seen it before, but I also do not check dmesg every time after

Re: 2.6.23-rc2 regression: check_irq_resend() warning from cmd64x

2007-08-06 Thread Bartlomiej Zolnierkiewicz
commit 0fc4969b866671dfe39b1a9119d0fdc7ea0f63e5 Linus, please revert it. On Sunday 05 August 2007, Mikael Pettersson wrote: This is on a sparc64 ultra5 with a rev 3 CMD646. Starting with kernel 2.6.23-rc2, each boot triggers a WARNING from kernel/irq/resend.c: Uniform Multi-Platform E-IDE

[PATCHSET 2/4] libata: implement ata_link, take 7

2007-08-06 Thread Tejun Heo
Hello, all. This is the seventh take of implement ata_link patchset. This patchset contains 14 patches which can be categorized as follows. #01-02: implement ata_link #03-06: make libata deal with link instead of port #07-09: misc link stuff (link init, reset_tries, ata_link_abort()) #10-14:

[PATCH 02/14] libata-link: implement and use link/device iterators

2007-08-06 Thread Tejun Heo
Multiple links and different number of devices per link should be considered to iterate over links and devices. This patch implements and uses link and device iterators - ata_port_for_each_link() and ata_link_for_each_dev() - and ata_link_max_devices(). This change makes a lot of functions

[PATCH 03/14] libata-link: linkify PHY-related functions

2007-08-06 Thread Tejun Heo
Make the following PHY-related functions to deal with ata_link instead of ata_port. * sata_print_link_status() * sata_down_spd_limit() * ata_set_sata_spd_limit() and friends * sata_link_debounce/resume() * sata_scr_valid/read/write/write_flush() * ata_link_on/offline() This patch introduces no

[PATCH 04/14] libata-link: linkify EH action helpers

2007-08-06 Thread Tejun Heo
Make ata_eh_about_to_do() and ata_eh_done() deal with ata_link instead of ata_port. This patch introduces no behavior change. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-eh.c | 35 ++- 1 files changed, 18 insertions(+), 17 deletions(-)

[PATCH 08/14] libata-link: separate out link initialization functions

2007-08-06 Thread Tejun Heo
Separate out link initialization into ata_link_init() and ata_link_init_sata_spd(). Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-core.c | 84 ++--- 1 files changed, 64 insertions(+), 20 deletions(-) diff --git

[PATCH 10/14] libata-link: add PMP links

2007-08-06 Thread Tejun Heo
Add link-pmp, ap-nr_pmp_links, ap-pmp_link[], and implement/update link helpers. printk helpers are updated such that port and link are identifed as 'ataP:' if no PMP is attached, while device is identified as 'ataP.DD:'. If PMP is attached, they become 'ataP:', 'ataP.LL:' and 'ataP.LL' - ie.

[PATCH 06/14] libata-link: linkify config/EH related functions

2007-08-06 Thread Tejun Heo
Make the following functions deal with ata_link instead of ata_port. * ata_set_mode() * ata_eh_autopsy() and related functions * ata_eh_report() and related functions * suspend/resume related functions * ata_eh_recover() and related functions Signed-off-by: Tejun Heo [EMAIL PROTECTED] ---

[PATCH 09/14] libata-link: implement ata_link_abort()

2007-08-06 Thread Tejun Heo
Implement ata_link_abort(). Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-core.c |1 + drivers/ata/libata-eh.c | 50 include/linux/libata.h|1 + 3 files changed, 38 insertions(+), 14 deletions(-) diff --git

[PATCH 13/14] libata-link: update hotplug to handle PMP links

2007-08-06 Thread Tejun Heo
Update hotplug to handle PMP links. When PMP is attached, the PMP number corresponds to C of SCSI H:C:I:L. While at it, change argument to ata_find_dev() to @devno from @id to avoid confusion with SCSI device ID. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-core.c |7

[PATCH 14/14] libata-link: update Power Management to handle PMP links

2007-08-06 Thread Tejun Heo
Update Power Management to consider PMP links. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-core.c |7 +-- 1 files changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c index 50721bc..d9e59e9 100644 ---

[PATCH 05/14] libata-link: linkify reset

2007-08-06 Thread Tejun Heo
Make reset methods and related functions deal with ata_link instead of ata_port. * ata_do_reset() * ata_eh_reset() * all prereset/reset/postreset methods and related functions This patch introduces no behavior change. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/ahci.c |

Re: ASUS P5W motherboard PMP

2007-08-06 Thread Tejun Heo
Also, please report the result of 'lspci -nn' and 'dmidecode'. -- tejun - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Disk spin down issue on shut down/suspend to disk

2007-08-06 Thread Michael Sedkowski
Some additional info: As I stated before I'm using a patched sysvinit package with patch from Debian bug 426224 with provide a patched hddown.c. http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=426224 Michael - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a

Re: Disk spin down issue on shut down/suspend to disk

2007-08-06 Thread Henrique de Moraes Holschuh
On Mon, 06 Aug 2007, Tejun Heo wrote: Cc'ing Henrique. Any ideas? Check if /etc/init.d/halt is calling halt(8) with the -h flag. If it is, remove that -h flag. Usually, there is a hddown variable that holds it, you just need to get rid of it. I don't know anything about a Sidux, though. --

Re: Disk spin down issue on shut down/suspend to disk

2007-08-06 Thread Michael Sedkowski
Dnia 06-08-2007, Pn o godzinie 11:23 -0300, Henrique de Moraes Holschuh napisał(a): On Mon, 06 Aug 2007, Tejun Heo wrote: Cc'ing Henrique. Any ideas? Check if /etc/init.d/halt is calling halt(8) with the -h flag. If it is, remove that -h flag. Usually, there is a hddown variable that

Re: [PATCH 1/11] atiixp: DMA setup fixes

2007-08-06 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Fix handling of unsupported/invalid modes in atiixp_set_dma_mode(). * ATI controllers allow separate PIO and DMA timings so remove programming of PIO modes from atiixp_set_dma_mode(). Also remove no longer needed atiixp_dma_2_pio() helper. Why

Re: [PATCH] fix IDE legacy mode resource

2007-08-06 Thread Yoichi Yuasa
Hello Jeff, Do you have any comments? On Sun, 29 Jul 2007 17:15:44 +0900 Yoichi Yuasa [EMAIL PROTECTED] wrote: On Sat, 28 Jul 2007 14:13:06 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Yoichi Yuasa wrote: Hi, I got the following error on MIPS Cobalt. MIPS Cobalt has the

Re: Disk spin down issue on shut down/suspend to disk

2007-08-06 Thread Henrique de Moraes Holschuh
On Mon, 06 Aug 2007, Michael Sedkowski wrote: Dnia 06-08-2007, Pn o godzinie 11:23 -0300, Henrique de Moraes Holschuh napisa??(a): On Mon, 06 Aug 2007, Tejun Heo wrote: Cc'ing Henrique. Any ideas? Check if /etc/init.d/halt is calling halt(8) with the -h flag. If it is, remove that

Re: [PATCH 11/11] ide: remove -ide_dma_check

2007-08-06 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Add IDE_HFLAG_TRUST_BIOS_FOR_DMA host flag for host drivers that depend on BIOS for programming device/controller for DMA. Set it in cy82c693, generic, ns87415, opti621 and trm290 host drivers. * Add IDE_HFLAG_VDMA host flag for host drivers using VDMA.

Re: Disk spin down issue on shut down/suspend to disk

2007-08-06 Thread Rafael J. Wysocki
On Monday, 6 August 2007 17:01, Henrique de Moraes Holschuh wrote: On Mon, 06 Aug 2007, Michael Sedkowski wrote: Dnia 06-08-2007, Pn o godzinie 11:23 -0300, Henrique de Moraes Holschuh napisa??(a): On Mon, 06 Aug 2007, Tejun Heo wrote: Cc'ing Henrique. Any ideas? Check if

Re: Disk spin down issue on shut down/suspend to disk

2007-08-06 Thread Michael Sedkowski
Dnia 06-08-2007, Pn o godzinie 12:01 -0300, Henrique de Moraes Holschuh napisał(a): On Mon, 06 Aug 2007, Michael Sedkowski wrote: Dnia 06-08-2007, Pn o godzinie 11:23 -0300, Henrique de Moraes Holschuh napisa??(a): On Mon, 06 Aug 2007, Tejun Heo wrote: Cc'ing Henrique. Any ideas?

Re: [PATCH 6/11] ide: remove ide_use_fast_pio()

2007-08-06 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Remove ide_use_fast_pio() and just re-tune PIO unconditionally if DMA tuning has failed in -ide_dma_check. All host drivers using ide_use_fast_pio() set drive-autotune so PIO is always tuned anyway and in some cases we _really_ need to re-tune PIO because PIO

Re: [PATCH 3/3] aec62xx: always tune PIO

2007-08-06 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] Index: b/drivers/ide/pci/aec62xx.c === --- a/drivers/ide/pci/aec62xx.c +++

Re: [PATCH] ide: add cable detection for early UDMA66 devices (take 2)

2007-08-06 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: if (hwif-cbl == ATA_CBL_PATA40_SHORT) return 1; Wait, shouldn't this check come ahead of all the other code since we're basically overriding every other check with it? Fixed. Hm, not completely but well... [PATCH] ide: add

Re: [PATCH] sc1200: always tune PIO

2007-08-06 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 10/11] ide-pmac: add PIO autotune fallback to -ide_dma_check

2007-08-06 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Since ide-pmac allows separate PIO and DMA timings, and ide-pmac always sets -autotune this change shouldn't have any other effect than bringing ide-pmac driver in-line with other host drivers wrt -ide_dma_check implementation. Signed-off-by: Bartlomiej

Re: [PATCH 9/10] ide-cris: add PIO autotune fallback to -ide_dma_check

2007-08-06 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Since ide-cris allows separate PIO and DMA timings, and ide-cris always sets -autotune this change shouldn't have any other effect than bringing ide-cris driver in-line with other host drivers wrt -ide_dma_check implementation. Signed-off-by: Bartlomiej

Re: [PATCH 1/2] pata_hpt37x: actually clock HPT374 by 50 MHz DPLL

2007-08-06 Thread Bob Ham
On Sun, 2007-08-05 at 22:45 +0400, Sergei Shtylyov wrote: The DPLL tuning code always set up it for 66 MHz due to wrong UltraDMA mask including mode 5 used to check for the necessity of 66 MHz clocking -- This caused 66 MHz clock to be used for HPT374 chip that does not tolerate it. While

Re: Disk spin down issue on shut down/suspend to disk

2007-08-06 Thread Tejun Heo
Rafael J. Wysocki wrote: Sidux is a Debian Unstable based distro with it's own set of patches including the shut down patch provided here: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=426224 You'll probably have to ask Sidux what changes they made that could cause the double spin down,

Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374

2007-08-06 Thread Bob Ham
On Mon, 2007-08-06 at 00:06 +0400, Sergei Shtylyov wrote: HPT374 BIOS seems to only save f_CNT register value for the function #0 before re-tuning DPLL causing the driver to report obviously distorted f_CNT for the function #1 -- fix this by always reading the saved f_CNT register value from

Re: [PATCH 1/2] pata_hpt37x: actually clock HPT374 by 50 MHz DPLL

2007-08-06 Thread Sergei Shtylyov
Bob Ham wrote: The DPLL tuning code always set up it for 66 MHz due to wrong UltraDMA mask including mode 5 used to check for the necessity of 66 MHz clocking -- This caused 66 MHz clock to be used for HPT374 chip that does not tolerate it. While fixing this, also remove PLL mode from the TODO

Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374

2007-08-06 Thread Sergei Shtylyov
Bob Ham wrote: HPT374 BIOS seems to only save f_CNT register value for the function #0 before re-tuning DPLL causing the driver to report obviously distorted f_CNT for the function #1 -- fix this by always reading the saved f_CNT register value from in the init_chipset() method the function #0

Re: [PATCH 1/2] [IDE] Platform IDE driver

2007-08-06 Thread Segher Boessenkool
More importantly, reg-shift doesn't say what part of the bigger words to access. A common example is byte-wide registers on a 32-bit-only bus; it's about 50%-50% between connecting the registers to the low byte vs. connecting it to the byte with the lowest address. We already have

Re: [PATCH 2/2] [POWERPC] MPC8349E-mITX: use platform IDE driver for CF interface

2007-08-06 Thread Segher Boessenkool
The hardware is called (E)IDE, the protocol is called ATA. Or that's what I was told -- I think there's some historic revisionism involved, too. ATA is the interface and standards for the ANSI standards based disk attachment. IDE Integrated Drive Electronics is a marketing name used to cover

Re: ICH8 CF timeout (regression)...

2007-08-06 Thread Kristen Carlson Accardi
On Sat, 04 Aug 2007 15:04:54 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Daniel J Blueman wrote: Tejun, On 03/08/07, Tejun Heo [EMAIL PROTECTED] wrote: Daniel J Blueman wrote: The ICH8 south-bridge I have is the mobile variant and does come equipped with native parallel IDE - see page

Re: ICH8 CF timeout (regression)...

2007-08-06 Thread Tejun Heo
Kristen Carlson Accardi wrote: In the data sheet in section 5.15.2.3 it describes a value of map.mv of 1 as meaning that the SATA controller is emulating the logical secondary channel, and the PATA channel will be the primary. For a value of map.mv == 2, we have the SATA controller being

Re: [PATCH] ide: move ide_config_drive_speed() calls to upper layers

2007-08-06 Thread Sergei Shtylyov
Hello again. :-) Bartlomiej Zolnierkiewicz wrote: * Add ide_set_pio_mode()/ide_set_dma_mode() helpers and convert all direct -set_pio_mode/-speedproc users to use these helpers. * Move ide_config_drive_speed() calls from -set_pio_mode/-speedproc methods to callers. * Rename -speedproc

[PATCH] ata_piix: update map 10b for ich8m

2007-08-06 Thread Tejun Heo
Fix map entry 10b for ich8. It's [P0 P2 IDE IDE] like ich6 / ich6m. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Kristen Carlson Accardi [EMAIL PROTECTED] --- Many users can be hit by this. Please consider for -stable. Thanks. drivers/ata/ata_piix.c |2 +- 1 file changed, 1

Re: [PATCH] ata_piix: update map 10b for ich8m

2007-08-06 Thread Kristen Carlson Accardi
On Tue, 7 Aug 2007 02:43:27 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Fix map entry 10b for ich8. It's [P0 P2 IDE IDE] like ich6 / ich6m. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Kristen Carlson Accardi [EMAIL PROTECTED] Acked-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- Many

Re: [PATCH] mark PCI resource with start 0 as unassigned

2007-08-06 Thread Segher Boessenkool
But 0 _is_ a valid PCI I/O address. Do we now have to start I wasn't in PCI 2.1 (later the corresponding passage have disppeared). SFF controllers often use 0 to indicate a channel isn't configured and present. Libata and old IDE both assume these semantics for an SFF IDE device

Re: [PATCH 3/11] au1xxx-ide: use ide_tune_dma()

2007-08-06 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Good, that's what I lacked for hpt366.c! Were you planning to push it to Linus soon? * Add -mdma_filter to ide_hwif_t and use it in ide_get_mode_mask(). Hm, why not mwdma_filter()? That mdma word has unneeded connotation. ;-) * Remove needless

Re: [PATCH] ide-cris: always tune PIO

2007-08-06 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: Disk spin down issue on shut down/suspend to disk

2007-08-06 Thread Michael Sedkowski
Dnia 07-08-2007, Wt o godzinie 02:03 +0900, Tejun Heo napisał(a): Rafael J. Wysocki wrote: Sidux is a Debian Unstable based distro with it's own set of patches including the shut down patch provided here: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=426224 You'll probably have to ask

Re: Disk spin down issue on shut down/suspend to disk

2007-08-06 Thread Tejun Heo
Michael Sedkowski wrote: Hmmm... If the problem only shows up on nx6325, it might be that ACPI is pulling unnecessary stunt. Please apply the attached patch and report when the disk spins down and up. Disk spins down on Pre-shutdown prepare and then goes up and down on Power down. Oh...

Re: Disk spin down issue on shut down/suspend to disk

2007-08-06 Thread Rafael J. Wysocki
On Monday, 6 August 2007 20:21, Michael Sedkowski wrote: Dnia 07-08-2007, Wt o godzinie 02:03 +0900, Tejun Heo napisał(a): Rafael J. Wysocki wrote: Sidux is a Debian Unstable based distro with it's own set of patches including the shut down patch provided here:

Re: Boot fails on Intel SATA controller

2007-08-06 Thread Quel Qun
The kernel compiles and boots after applying this patch to 2.6.23-rc1. -- Eric -- Original message -- From: Tejun Heo [EMAIL PROTECTED] Please test the attached patch. -- tejun ---BeginMessage--- diff --git a/drivers/ata/libata-core.c

Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374

2007-08-06 Thread Alan Cox
+ if (chip_type == HPT374 (PCI_FUNC(dev-devfn) 1)) { + struct pci_dev *dev1 = pci_get_slot(dev-bus, + dev-devfn - 1); Can be NULL + unsigned long io_base = pci_resource_start(dev1,

Re: Disk spin down issue on shut down/suspend to disk

2007-08-06 Thread Rafael J. Wysocki
On Monday, 6 August 2007 20:43, Tejun Heo wrote: Michael Sedkowski wrote: Hmmm... If the problem only shows up on nx6325, it might be that ACPI is pulling unnecessary stunt. Please apply the attached patch and report when the disk spins down and up. Disk spins down on Pre-shutdown

Re: Disk spin down issue on shut down/suspend to disk

2007-08-06 Thread Michael Sedkowski
Dnia 07-08-2007, Wt o godzinie 03:43 +0900, Tejun Heo napisał(a): Oh... crap, so acpi wants to sync cache on shutdown. I wonder whether it spins down the disk correctly. Does emergency unload count increase after each power down? Also, please post the result of 'dmidecode'. Thanks. I do

Re: [PATCH] mark PCI resource with start 0 as unassigned

2007-08-06 Thread Alan Cox
O That's of course the smarter choice, _if_ we have a choice at all -- on PowerPC, the PCI setup on certain platforms is done by the firmware (and we don't want to mess with it for various reasons), and some _do_ map PCI legacy I/O at 0. Not in this case though, so let's just ignore that

Re: [PATCH] mark PCI resource with start 0 as unassigned

2007-08-06 Thread Benjamin Herrenschmidt
On Mon, 2007-08-06 at 20:04 +0200, Segher Boessenkool wrote: That's of course the smarter choice, _if_ we have a choice at all -- on PowerPC, the PCI setup on certain platforms is done by the firmware (and we don't want to mess with it for various reasons), and some _do_ map PCI legacy I/O at

Re: Disk spin down issue on shut down/suspend to disk

2007-08-06 Thread Robert Hancock
Tejun Heo wrote: Michael Sedkowski wrote: Hmmm... If the problem only shows up on nx6325, it might be that ACPI is pulling unnecessary stunt. Please apply the attached patch and report when the disk spins down and up. Disk spins down on Pre-shutdown prepare and then goes up and down on Power

Re: Disk spin down issue on shut down/suspend to disk

2007-08-06 Thread Henrique de Moraes Holschuh
On Tue, 07 Aug 2007, Tejun Heo wrote: Michael Sedkowski wrote: Hmmm... If the problem only shows up on nx6325, it might be that ACPI is pulling unnecessary stunt. Please apply the attached patch and report when the disk spins down and up. Disk spins down on Pre-shutdown prepare and

[PATCH] libata: implement BROKEN_HPA horkage and apply it to HDS724040KLSA80

2007-08-06 Thread Tejun Heo
HDS724040KLSA80 reports that it supports HPA LBA48 but craps itself on READ_NATIVE_MAX_EXT. Implement BROKEN_HPA horkage and apply it to the drive. If the horkage is set, all HPA operations are skipped. While at it, make HPA test a bit more reliable by also checking ata_id_has_hpa().