On Wed, 8 Aug 2007 14:40:08 +0900
Tejun Heo <[EMAIL PROTECTED]> wrote:
> Certain device which reports diagnostic failure also reports invalid
> device signature. Assume ATA_DEV_ATA on diagnostic failure if reset
> indicates device presence.
>
> This is fix for bugzilla bug 8784.
Acked-by: Alan
Alan Cox lxorguk.ukuu.org.uk> writes:
>
> > So then ap->prd[idx].flags_len gets set to (0x1 & 0x) = 0 !
> > So this sg element ends up with a zero length, even though the
> > transfer size should be 64k.
> >
> > Is this correct behaviour, if not, should it be corrected ?
>
> The specif
On Wed, 08 Aug 2007 11:21:08 +0900
Tejun Heo <[EMAIL PROTECTED]> wrote:
> Alan Cox wrote:
> >>> I'd rather know what is going on here. A drive can legitimately
> >>> support LBA48 and HPA and refuse READ_NATIVE_MAX_EXT.
> >> READ_NATIVE_MAX_EXT is mandatory if HPA && LBA48, no
> >
> > Ok the repo
Dnia 07-08-2007, Wt o godzinie 23:28 +0200, Maciej Rutecki napisał(a):
> > > Well, on my box (nx6325) with the appended (experimental) patch applied
> > > on top of 2.6.23-rc1 with the patchset from
> >
> > s/2.6.23-rc1/2.6.23-rc2/
> >
>
> HP nx 6310, _old_ shutdown 2.6.23-rc2+above patches:
>
>
> > The specification says that 0x means 64K. A couple of controllers do
> > get this wrong and we did recently add a second sg list builder for those.
> >
> > Perhaps a comment or two is in order ?
> > -
>
> Thanks - but which specification is this ?
>
> As far as I am aware there is no spe
Alan Cox lxorguk.ukuu.org.uk> writes:
>
>>> The specification says that 0x means 64K. A couple of controllers do
>>> get this wrong and we did recently add a second sg list builder for those.
>>>
>>> Perhaps a comment or two is in order ?
>>> -
>>
>> Thanks - but which specification is thi
> Thanks for clarifying - as you say, the spec is specific to PCI.
> Our silicon has its own host interface which was confused by a length of zero
> !
You aren't the first. If you look at the current tree you'll see we now
have
ata_dumb_qc_prep()
for interfaces that think 0x is zero
Alan Cox lxorguk.ukuu.org.uk> writes:
>
> SFF 8038i covers the standard taskfile IDE class PCI device interface for
> PIO and DMA. It also covers the alternate ADMA interface.
>
>> Since DMA controller details may vary according to hardware, I
>> would have expected that ata_fill_sg() would be on
> I note also that Intel's Serial ATA AHCI spec has a 22-bit DMA byte count
> in the PRDT, so 0 == 64k cannot be assumed here either.
Different standard and our AHCI driver doesn't use ata_fill_sg either 8)
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a mes
On Wednesday, 8 August 2007 04:56, Tejun Heo wrote:
> Rafael J. Wysocki wrote:
> > Well, on my box (nx6325) with the appended (experimental) patch applied
> > on top of 2.6.23-rc1 with the patchset from
> > http://www.sisk.pl/kernel/hibernation_and_suspend/2.6.23-rc2/patches/ , the
> > double spin
Hi,
Since I have upgraded to 2.6.22.1 from 2.6.20 I have problems with
Samsung disks. Sometimes the disks stall for about half a minute and
then I have these messages in the logs:
Aug 6 20:10:11 twister kernel: ata7: EH in ADMA mode, notifier 0x0
notifier_error 0x0 gen_ctl 0x1501000 status 0x40
On Wednesday, 8 August 2007 02:23, Robert Hancock wrote:
> Henrique de Moraes Holschuh wrote:
> > On Tue, 07 Aug 2007, Tejun Heo wrote:
> >> Henrique de Moraes Holschuh wrote:
> >>> On Tue, 07 Aug 2007, Tejun Heo wrote:
> Michael Sedkowski wrote:
> >> Hmmm... If the problem only shows up o
Ok this is a different approach to handling it - knowing it is an off by
one so we can handle the drive if clipped
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.23rc1-mm1/drivers/ata/libata-core.c
linux-2.6.23rc1-mm1
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.23rc1-mm1/drivers/ata/libata-core.c
linux-2.6.23rc1-mm1/drivers/ata/libata-core.c
--- linux.vanilla-2.6.23rc1-mm1/drivers/ata/libata-core.c 2007-07-26
15:02:57.
On some early drives (pre ATA1) this feature is not supported. If it
fails then we know the drive geometry is the hardware geometry and the
one we tried to set anyway so just carry on.
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linu
Remembered this while doing auditing and code review versus the specs
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.23rc1-mm1/drivers/ata/libata-core.c
linux-2.6.23rc1-mm1/drivers/ata/libata-core.c
--- linux.vanilla-
Em Wed, 08 Aug 2007 11:21:08 +0900
Tejun Heo <[EMAIL PROTECTED]> escreveu:
| Alan Cox wrote:
| >>> I'd rather know what is going on here. A drive can legitimately
| >>> support LBA48 and HPA and refuse READ_NATIVE_MAX_EXT.
| >> READ_NATIVE_MAX_EXT is mandatory if HPA && LBA48, no
| >
| > Ok the r
Set the MWDMA timing by updating the correct registers. Split the PIO
path as this is mostly shared code. Wants testing.
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.23rc1-mm1/drivers/ata/pata_cmd64x.c
linux-2.6.23r
- Fix those which require a word is checked for validity
- Note limits on version information with ancient ATA
- Correct EIDE dword_io check ready for adding 32bit PIO
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.23r
Luiz Fernando N. Capitulino wrote:
> Em Wed, 08 Aug 2007 11:21:08 +0900
> Tejun Heo <[EMAIL PROTECTED]> escreveu:
>
> | Alan Cox wrote:
> | >>> I'd rather know what is going on here. A drive can legitimately
> | >>> support LBA48 and HPA and refuse READ_NATIVE_MAX_EXT.
> | >> READ_NATIVE_MAX_EXT i
Tejun Heo wrote:
Michael Sedkowski wrote:
Dnia 07-08-2007, Wt o godzinie 03:43 +0900, Tejun Heo napisał(a):
Does emergency unload count increase
after each power down?
I think I got it.
Using smartctl I've done a test and shut down, then repeted the test.
The only values that where diffrent
Mark Lord wrote:
> Tejun Heo wrote:
>> Michael Sedkowski wrote:
>>> Dnia 07-08-2007, Wt o godzinie 03:43 +0900, Tejun Heo napisał(a):
Does emergency unload count increase
after each power down?
>>> I think I got it.
>>> Using smartctl I've done a test and shut down, then repeted the tes
Tejun Heo wrote:
Mark Lord wrote:
> Tejun Heo wrote:
>> Michael Sedkowski wrote:
>>> Dnia 07-08-2007, Wt o godzinie 03:43 +0900, Tejun Heo napisał(a):
Does emergency unload count increase
after each power down?
>>> I think I got it.
>>> Using smartctl I've done a test and shut do
Mark Lord wrote:
> Heh.. I haven't instrumented it yet, but I did discover a bit more about
> it:
>
> The Power-Off_Retract_Count incrmenents *only* when there's data in the
> on-drive write-cache. So if I haven't written anything significantly large
> before suspending, then it often does NOT in
Jeff,
This patch (below) is needed by WD drives that powerup-in-standby.
Cheers
Mark
Original Message
Subject: + libata-adjust-libata-to-ignore-errors-after.patch added to -mm tree
Date: Wed, 18 Jul 2007 17:03:29 -0700
From: [EMAIL PROTECTED]
To: [EMAIL PROTECTED]
CC: [EMAIL
Updated and simplified driver. Use only register transfer timing for both
data and register transfers. This gives poorer performance in PIO1 and 2,
but should not be a problem in PIO3 and 4, correct me if I'm wrong :)
The driver works very we'll but I still wonder about the interrupts. I have
an i
Mark Lord wrote:
Tejun Heo wrote:
Mark Lord wrote:
..
FWIW, Tejun, with 2.6.22, my new Seagate 160GB SATA drive (notebook)
increments the "Power-Off_Retract_Count" on each suspend-to-RAM operation.
It does not do any double spin-up/spin-down things though.
Hmmm.. It shouldn't. libata now is
Mark Lord wrote:
My suspend script now has this little chunk of code at the point
where it actually does the suspend-to-RAM:
sync; sync
hdparm -F /dev/sda ## flush drive write cache
sleep 1 ## allow time for the flush to complete
echo mem > /sys/power/state ## suspen
Mark Lord wrote:
> Further to this, if I have an active-writer running at the time of suspend,
> then even my scripted "sleep 1" is not good enough, as additional writes
> are still happening before/after the flush.
>
> Now I'll reboot and try it with the "sleep 1" hardcoded inside
> sd_suspend().
Hi Brian,
Brian J. Murrell pisze:
> I am using Ubuntu Gutsy, which is the in-development branch heading for
> their next stable release.
You forgot about message subject, so no one has read this report.
>
> I have noticed that since some kernel release post-2.6.20 I have been
> unable to mount
Mark Lord wrote:
Jeff,
This patch (below) is needed by WD drives that powerup-in-standby.
drivers/ata/libata-core.c~libata-adjust-libata-to-ignore-errors-after
drivers/ata/libata-core.c
--- a/drivers/ata/libata-core.c~libata-adjust-libata-to-ignore-errors-after
+++ a/drivers/ata/libata-core.
-- Original message --
From: Tejun Heo <[EMAIL PROTECTED]>
> Luiz Fernando N. Capitulino wrote:
> > Em Wed, 08 Aug 2007 11:21:08 +0900
> > Tejun Heo <[EMAIL PROTECTED]> escreveu:
> >
> > | Alan Cox wrote:
> > | >>> I'd rather know what is going on here. A drive can
Em Wed, 08 Aug 2007 16:50:39 +
[EMAIL PROTECTED] (Quel Qun) escreveu:
| -- Original message --
| From: Tejun Heo <[EMAIL PROTECTED]>
| > Luiz Fernando N. Capitulino wrote:
| > > Em Wed, 08 Aug 2007 11:21:08 +0900
| > > Tejun Heo <[EMAIL PROTECTED]> escreveu:
|
Tejun Heo wrote:
Mark Lord wrote:
Further to this, if I have an active-writer running at the time of suspend,
then even my scripted "sleep 1" is not good enough, as additional writes
are still happening before/after the flush.
Now I'll reboot and try it with the "sleep 1" hardcoded inside
sd_su
On Wed, 2007-08-08 at 18:28 +0200, Michal Piotrowski wrote:
> Hi Brian,
Hi Michal,
> Brian J. Murrell pisze:
> > I am using Ubuntu Gutsy, which is the in-development branch heading for
> > their next stable release.
>
> You forgot about message subject, so no one has read this report.
Indeed.
Hello,
Here is an updated set of patches that implement Asynchronous Notification
support for ATAPI devices. In this version I no longer export the AN
capability through genhd, and the uevent is sent by the scsi_device
instead of gendisk. I added a generic SCSI device event mechanism so
that it
Check to see if an ATAPI device supports Asynchronous Notification.
If so, enable it.
Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
Index: 2.6-git/drivers/ata/libata-core.c
===
--- 2.6-git.orig/drivers/ata/libata-core.c
If a scsi_device supports async notification for media change, then
let user space know this capability exists by creating a new sysfs
entry "media_change_notify", which will be 1 if it is supported, and
0 if not supported. Create a routine which allows scsi devices to
send a uevent when media cha
If Asynchronous Notification of media change events is supported,
pass that information up to the SCSI layer.
Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
Index: 2.6-git/drivers/ata/libata-scsi.c
===
--- 2.6-git.orig/dr
When we get an SDB FIS with the 'N' bit set, we should send
an event to user space to indicate that there has been a
media change. This will be done via the scsi device.
Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]>
Index: 2.6-git/drivers/ata/ahci.c
=
On Wed, 8 Aug 2007 12:08:10 -0700
Kristen Carlson Accardi <[EMAIL PROTECTED]> wrote:
> ===
> --- 2.6-git.orig/include/linux/libata.h
> +++ 2.6-git/include/linux/libata.h
> @@ -139,7 +139,8 @@ enum {
> ATA_DFLAG_FLUSH_EXT = (
Support the use of '*' in model_num and model_rev entries
in ata_device_blacklist[].
CC: [EMAIL PROTECTED]
Signed-off-by: David Milburn <[EMAIL PROTECTED]>
---
drivers/ata/libata-core.c | 11 +--
1 files changed, 9 insertions(+), 2 deletions(-)
diff --git a/drivers/ata/libata-core.c b
Hi Tejun, Alan, Jeff,
This is open bug list for SATA subsystem. It has more items than other
subsystems, but mainly because this is such a hot technology now and
so much work is being done in this area. Needless to say It is very
well maintained and exemplary for some other areas that are not that
On Sunday 05 August 2007, Sergei Shtylyov wrote:
> HPT374 BIOS seems to only save f_CNT register value for the function #0 before
> re-tuning DPLL causing the driver to report obviously distorted f_CNT for the
> function #1 -- fix this by always reading the saved f_CNT register value from
> in the
On Sunday 05 August 2007, Sergei Shtylyov wrote:
> The Marvell bridge chips used on HighPoint SATA cards do not seem to support
> the UltraDMA modes 1, 2, and 3 (as well as any MWDMA modes), so the driver
> needs to account for this in the udma_filter() method. In order to achieve
> that, do the f
On Monday 06 August 2007, Sergei Shtylyov wrote:
> Bartlomiej Zolnierkiewicz wrote:
>
> Good, that's what I lacked for hpt366.c! Were you planning to push it to
> Linus soon?
Not really but if needed I will extract MWDMA filter part and push it sooner.
> > * Add ->mdma_filter to ide_hwif_t
On Wed, 8 Aug 2007 15:20:57 -0500
David Milburn <[EMAIL PROTECTED]> wrote:
> Support the use of '*' in model_num and model_rev entries
> in ata_device_blacklist[].
>
> CC: [EMAIL PROTECTED]
> Signed-off-by: David Milburn <[EMAIL PROTECTED]>
Suggestion: Pull the match function out of line so you
Natalie Protasevich wrote:
Hi Tejun, Alan, Jeff,
This is open bug list for SATA subsystem. It has more items than other
...
http://bugzilla.kernel.org/show_bug.cgi?id=7693
http://bugzilla.kernel.org/show_bug.cgi?id=8738 adaptec and sata bad interaction
http://bugzilla.kernel.org/show_bug.cgi?i
Hello, Natalie.
Natalie Protasevich wrote:
> http://bugzilla.kernel.org/show_bug.cgi?id=7693
This bug isn't related to libata in anyway. It's "Can't use radeonfb
with dvi port on a Samsung SyncMaster 204B (1600x1200)".
> http://bugzilla.kernel.org/show_bug.cgi?id=8738 adaptec and sata bad
> in
On Wed, 2007-08-08 at 15:31 -0700, Natalie Protasevich wrote:
> Hi Tejun, Alan, Jeff,
>
> This is open bug list for SATA subsystem. It has more items than other
> subsystems, but mainly because this is such a hot technology now and
> so much work is being done in this area. Needless to say It is v
On Thu, Aug 09 2007, Tejun Heo wrote:
> > http://bugzilla.kernel.org/show_bug.cgi?id=7805 tejun is pinging
> > pktcdvd maintainer (?)
>
> Not a libata bug. This is caused by pktcdvd holding onto the device
> thus preventing it from being revalidated. Didn't get pong for my ping
> yet. Jens, any
51 matches
Mail list logo