pata_ali exceptions (timeout)

2007-08-11 Thread Frederik Himpe
I'm using a Linux 2.6.22.2 kernel. When the pata_ali driver loads and disks are detected, the system appears to hang for some time, and there are exceptions/timeouts in the dmesg log. The hardware is a Compaq Evo N1020v laptop computer. I attach the output of dmesg and lspci -vvxx I suppose

Re: pata_ali exceptions (timeout)

2007-08-11 Thread Andrey Borzenkov
On Saturday 11 August 2007, Frederik Himpe wrote: I'm using a Linux 2.6.22.2 kernel. When the pata_ali driver loads and disks are detected, the system appears to hang for some time, and there are exceptions/timeouts in the dmesg log. The hardware is a Compaq Evo N1020v laptop computer. I

Re: [patch 0/4] Updated AN patches, now without gendisk

2007-08-11 Thread Kay Sievers
On 8/8/07, Kristen Carlson Accardi [EMAIL PROTECTED] wrote: Here is an updated set of patches that implement Asynchronous Notification support for ATAPI devices. In this version I no longer export the AN capability through genhd, and the uevent is sent by the scsi_device instead of gendisk.

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-11 Thread Sergei Shtylyov
Hello. Bartlomiej Zolnierkiewicz wrote: Index: linux-2.6/drivers/ide/pci/hpt366.c === --- linux-2.6.orig/drivers/ide/pci/hpt366.c +++ linux-2.6/drivers/ide/pci/hpt366.c [...] + case HPT372 : + case HPT372A: +

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: Index: linux-2.6/drivers/ide/pci/hpt366.c === --- linux-2.6.orig/drivers/ide/pci/hpt366.c +++ linux-2.6/drivers/ide/pci/hpt366.c

Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: + if (chip_type == HPT374 (PCI_FUNC(dev-devfn) 1)) { + struct pci_dev *dev1 = pci_get_slot(dev-bus, +

Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374

2007-08-11 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: + if (chip_type == HPT374 (PCI_FUNC(dev-devfn) 1)) { + struct pci_dev *dev1 = pci_get_slot(dev-bus, +dev-devfn - 1); Can be NULL Not really. This may not be

Re: [PATCH 3/11] au1xxx-ide: use ide_tune_dma()

2007-08-11 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Good, that's what I lacked for hpt366.c! Were you planning to push it to Linus soon? Not really but if needed I will extract MWDMA filter part and push it sooner. Erm, may I just merge it to my patch (mentioning you of course)? Sure. I guess

Re: [PATCH 3/11] au1xxx-ide: use ide_tune_dma()

2007-08-11 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Good, that's what I lacked for hpt366.c! Were you planning to push it to Linus soon? Not really but if needed I will extract MWDMA filter part and push it sooner. Erm, may I just merge it to my patch (mentioning you of course)? Sure. I guess

Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: + if (chip_type == HPT374 (PCI_FUNC(dev-devfn) 1)) { + struct pci_dev *dev1 = pci_get_slot(dev-bus, + dev-devfn -

Re: [PATCH 3/11] au1xxx-ide: use ide_tune_dma()

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, you wrote: Bartlomiej Zolnierkiewicz wrote: Good, that's what I lacked for hpt366.c! Were you planning to push it to Linus soon? Not really but if needed I will extract MWDMA filter part and push it sooner. Erm, may I just merge it to my patch

Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374

2007-08-11 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: + if (chip_type == HPT374 (PCI_FUNC(dev-devfn) 1)) { + struct pci_dev *dev1 = pci_get_slot(dev-bus, +dev-devfn - 1); Can be NULL Not really. This may not be

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-11 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Index: linux-2.6/drivers/ide/pci/hpt366.c === --- linux-2.6.orig/drivers/ide/pci/hpt366.c +++ linux-2.6/drivers/ide/pci/hpt366.c [...] + case HPT372 : + case HPT372A: + case

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Index: linux-2.6/drivers/ide/pci/hpt366.c === --- linux-2.6.orig/drivers/ide/pci/hpt366.c +++ linux-2.6/drivers/ide/pci/hpt366.c [...] +

Re: [PATCH 3/11] au1xxx-ide: use ide_tune_dma()

2007-08-11 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Good, that's what I lacked for hpt366.c! Were you planning to push it to Linus soon? Not really but if needed I will extract MWDMA filter part and push it sooner. Erm, may I just merge it to my patch (mentioning you of course)? Sure. I guess

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-11 Thread Sergei Shtylyov
Hello, I wrote: 101 files changed, 1880 insertions(+), 2828 deletions(-) please look at -mm or IDE quilt tree instead. :) Looking... When are you planning to push out to Linus the ide-mode-limiting-fixes-for-user-requested-speed-changes.patch? I'd like my HPT37x SATA mode

Re: [PATCH 2/2] hpt366: UltraDMA filtering for SATA cards

2007-08-11 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Index: linux-2.6/drivers/ide/pci/hpt366.c === --- linux-2.6.orig/drivers/ide/pci/hpt366.c +++ linux-2.6/drivers/ide/pci/hpt366.c [...] + case HPT372 : + case HPT372A: + case

[PATCH] hpt366: fix PCI clock detection for HPT374 (take 4)

2007-08-11 Thread Sergei Shtylyov
HPT374 BIOS seems to only save f_CNT register value for the function #0 before re-tuning DPLL (that causes the driver to report obviously distorted f_CNT for the function #1) -- fix this by always reading the saved f_CNT register value from the function #0 in the driver's init_chipset() method.

Re: [PATCH] pata_cmd64x: Set up MWDMA modes properly

2007-08-11 Thread Sergei Shtylyov
Hello. Alan Cox wrote: Set the MWDMA timing by updating the correct registers. Split the PIO path as this is mostly shared code. Wants testing. Cool! So much simpler than my fix to the old IDE driver... Signed-off-by: Alan Cox [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL

Re: [PATCH] pata_cmd64x: Set up MWDMA modes properly

2007-08-11 Thread Alan Cox
That function rocks (except I didn't get what the address setup timings mean to SW/MW DMA)... They don't, it merges the DMA and PIO ones and you end up with the PIO ones. + * Used when configuring the devices ot set the PIO timings. All the What's ot? to - will fix regD

Re: [PATCH 1/2] hpt366: fix PCI clock detection for HPT374

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: + if (chip_type == HPT374 (PCI_FUNC(dev-devfn) 1)) { + struct pci_dev *dev1 = pci_get_slot(dev-bus, +dev-devfn - 1);

Re: [PATCH] pata_cmd64x: Set up MWDMA modes properly

2007-08-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 11 August 2007, Sergei Shtylyov wrote: Hello. Alan Cox wrote: Set the MWDMA timing by updating the correct registers. Split the PIO path as this is mostly shared code. Wants testing. Cool! So much simpler than my fix to the old IDE driver... Signed-off-by: Alan Cox