Re: Resets on sil3124 sil3726 PMP

2007-08-15 Thread Tejun Heo
Hello, Rusty. Rusty Conover wrote: I'm having some trouble with my e-SATA ports being reset. I'm testing 2.6.22.1 with the 20070808 patch tarball on a nortec ds-1220 flashed to Silicon Image bios version 6.4.09 (the latest). I'm testing with 6 500gig SATA drives shown as:

Re: sata drive loosing connection/resetting port

2007-08-15 Thread Tejun Heo
Andreas Radke wrote: already tried different ports, several SATA cables on that mainboard and psu works well. the Samsung drive works well no matter where connected. never had any issues with the Raptor drive when it was connected to the old Intel P965 board before. what's the difference form

Re: [PATCH 01/14] libata-link: introduce ata_link

2007-08-15 Thread Jeff Garzik
Tejun Heo wrote: Introduce ata_link. It abstracts PHY and sits between ata_port and ata_device. This new level of abstraction is necessary to support SATA Port Multiplier, which basically adds a bunch of links (PHYs) to a ATA host port. Fields related to command execution, spd_limit and EH

Re: [PATCH] libata: Correct IORDY handling

2007-08-15 Thread Jeff Garzik
Alan Cox wrote: Debugging a report of a problem with an ancient solid state disk showed up some problems in the IORDY handling 1. We check the wrong bit to see if the device has IORDY 2. Even then some ancient creaking piles of crap don't support SETXFER at all. I think this

Re: [PATCH 1/2] libata: move ata_altstatus() to pio data xfer functions

2007-08-15 Thread Jeff Garzik
Albert Lee wrote: Patch 1/2: Move ata_altstatus() out from ata_hsm_move() to the pio data xfer functions like ata_pio_sectors() and atapi_pio_bytes() where it makes more sense. Signed-off-by: Albert Lee [EMAIL PROTECTED] --- atapi_send_cdb() already calls ata_altstatus() inside. This patch

Re: [2.6.23-rc3] Regression: spurious completions during NCQ

2007-08-15 Thread Frans Pop
On Tuesday 14 August 2007, Tejun Heo wrote: Frans Pop wrote: I've been running 2.6.23-rc2 without problems. Today I compiled 2.6.23-rc3 and shortly after boot got the following messages in my logs: kernel: ata1.00: spurious completions during NCQ issue=0x0 SAct=0x7ffc7

Re: [PATCH RE-UPDATED] libata: add support for ATA_16 on ATAPI

2007-08-15 Thread Jeff Garzik
Tejun Heo wrote: From: Mark Lord [EMAIL PROTECTED] Add support for issuing ATA_16 passthru commands to ATAPI devices managed by libata. It requires the previous CDB length fix patch. A boot/module parameter, atapi_scmd85=1 can be used to globally disable this feature, if ever desired. tj:

Re: [2.6.23-rc3] Regression: spurious completions during NCQ

2007-08-15 Thread Tejun Heo
Frans Pop wrote: On Tuesday 14 August 2007, Tejun Heo wrote: Frans Pop wrote: I've been running 2.6.23-rc2 without problems. Today I compiled 2.6.23-rc3 and shortly after boot got the following messages in my logs: kernel: ata1.00: spurious completions during NCQ issue=0x0 SAct=0x7ffc7

Re: [PATCH] libata-core: Document some limits/assumptions about ID_ATA

2007-08-15 Thread Jeff Garzik
Alan Cox wrote: Signed-off-by: Alan Cox [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libata: Note that our cache flush code needs fixing up

2007-08-15 Thread Jeff Garzik
Alan Cox wrote: Remembered this while doing auditing and code review versus the specs Signed-off-by: Alan Cox [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [patch 24/25] pata_cmd64x: Set up MWDMA modes properly

2007-08-15 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Alan Cox [EMAIL PROTECTED] Set the MWDMA timing by updating the correct registers. Split the PIO path as this is mostly shared code. Wants testing. Signed-off-by: Alan Cox [EMAIL PROTECTED] Tested-by: Mikael Pettersson [EMAIL PROTECTED] Signed-off-by: Andrew

Re: Still having problems with sata_promise on all late kernels - shutdown too - BISECTED

2007-08-15 Thread Tejun Heo
Brad Campbell wrote: Brad Campbell wrote: http://www.fnarfbargle.com/CIMG1029.JPG (I have posted this screen shot previously. It's still doing exactly the same thing on both boxes). git-bisect shows up this commit as the guilty party. I can't just revert it on a recent tree though. Will

Re: regression problem with Maxtor disk

2007-08-15 Thread Tejun Heo
Lieven Marchand wrote: Robert Hancock [EMAIL PROTECTED] writes: It looks like there are some lines missing from this log, there should be a line before the res lines indicating what the failed command was.. There isn't. I snipped some irrelevant stuff but nothing about a command. The

Re: Still having problems with sata_promise on all late kernels

2007-08-15 Thread Tejun Heo
[cc'ing Mikael Pettersson] Brad Campbell wrote: Tejun Heo wrote: ATA bus error is a strong indicator for hardware problem. Please get a separate power supply (doesn't have to be an expensive one), power it up [1], and connect some of the drives to the power supply and see whether errors

Re: regression problem with Maxtor disk

2007-08-15 Thread Lieven Marchand
Robert Hancock [EMAIL PROTECTED] writes: It looks like there are some lines missing from this log, there should be a line before the res lines indicating what the failed command was.. There isn't. I snipped some irrelevant stuff but nothing about a command. The full log is appended. My

Re: [patch 4/4] libata: send event when AN received

2007-08-15 Thread Jeff Garzik
applied the attached slightly modified patch. main changes: * SCSI stuff has not been applied yet, so libata's notify is a no-op for now * fixed endian bug in SDB FIS handling diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c index 757369e..c41bd2c 100644 --- a/drivers/ata/ahci.c +++

Re: [patch 2/4] scsi: expose AN support to user space

2007-08-15 Thread Jeff Garzik
Kristen Carlson Accardi wrote: If a scsi_device supports async notification for media change, then let user space know this capability exists by creating a new sysfs entry media_change_notify, which will be 1 if it is supported, and 0 if not supported. Create a routine which allows scsi devices

Re: [patch 1/4] Store interrupt value

2007-08-15 Thread Jeff Garzik
Kristen Carlson Accardi wrote: Use a stored value for which interrupts to enable. Changing this allows us to selectively turn off certain interrupts later and have them stay off. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] applied, after adding ahci: prefix to subject line

Re: [PATCH] pata_artop: fix UDMA5 for AEC6280[R] and UDMA6 for AEC6880[R]

2007-08-15 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: Maximum supported UDMA mode for AEC6280[R] is UDMA5 (not UDMA4) and for AEC6880[R] it is UDMA6 (not UDMA5): * Fix the problem by adding missing struct ata_port_info to artop_init_one(). * Use the right naming (s/626/628/). * Bump driver version. Fixes

Re: [PATCH 1/2] pata_hpt37x: actually clock HPT374 with 50 MHz DPLL (take 2)

2007-08-15 Thread Jeff Garzik
Sergei Shtylyov wrote: The DPLL tuning code always set up it for 66 MHz due to wrong UltraDMA mask including mode 5 used to check for the necessity of 66 MHz clocking -- this caused 66 MHz clock to be used for HPT374 chip that does not tolerate it. While fixing this, also remove PLL mode from

Re: [PATCH] ata_piix: add TECRA M7 to broken suspend list

2007-08-15 Thread Jeff Garzik
Tejun Heo wrote: Add TECRA M7 to broken suspend list. Reported by Marie Koreen. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Marie Koreen [EMAIL PROTECTED] --- drivers/ata/ata_piix.c |7 +++ 1 file changed, 7 insertions(+) applied to #upstream-fixes - To unsubscribe from this

Re: [patch 25/25] ata_piix: disallow UDMA 133 on ICH5 ICH7

2007-08-15 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Christian Lamparter [EMAIL PROTECTED] There is another outstanding issue with ata_piix.c. Intel has never officially supported anything faster than PATA 100MB/s. But, the ata_piix.c driver define the ICH5 ICH7 as UDMA6 (aka 133MB/s) capable. [ Well, no one has

Re: [patch 04/25] libata-add-irq_flags-to-struct-pata_platform_info-fix

2007-08-15 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Andrew Morton [EMAIL PROTECTED] Remove unneeded, undesirable cast of void*. Cc: Jeff Garzik [EMAIL PROTECTED] Cc: Sonic Zhang [EMAIL PROTECTED] Cc: Tejun Heo [EMAIL PROTECTED] Cc: Alan Cox [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] ---

Re: [PATCH 1/1] AVR32 PATA driver

2007-08-15 Thread Kristoffer Nyborg Gregertsen
Forget about what I said about using polling, I was just fooled by the benchmark tool. Could the last patch I've sent you be accepted? - Kristoffer Nyborg Gregertsen - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH libata-dev#upstream 3/3] libata: implement and use ata_port_desc() to report port configuration

2007-08-15 Thread Jeff Garzik
Tejun Heo wrote: Currently, port configuration reporting has the following problems. * iomapped address is reported instead of raw address * report contains irrelevant fields or lacks necessary fields for non-SFF controllers. * host-irq/irq2 are there just for reporting and hacky. This patch

Re: [PATCH libata-dev#upstream 1/3] libata: use ata_port_printk() in ata_wait_idle()

2007-08-15 Thread Jeff Garzik
Tejun Heo wrote: ata_wait_idle() identified controller by printing out the address of the Status register. This is bogus because 1. it's iomapped address 2. some controllers don't have Status register and don't initialize the field. Use ata_port_printk() instead. Signed-off-by: Tejun Heo

Re: [PATCH libata-dev#upstream 2/2] libata: move EH repeat reporting into ata_eh_report()

2007-08-15 Thread Jeff Garzik
Tejun Heo wrote: EH is sometimes repeated without any error or action. For example, this happens when probing IDENTIFY fails because of a phantom device. In these cases, all the repeated EH does is making sure there is no unhandled error or pending action and return. This repeation is

Re: look at this log!!! - no

2007-08-15 Thread MikeW
not unless you use a more meaningful Subject line ... - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH take #5] [libata] libata driver for bf548 on chip ATAPI controller.

2007-08-15 Thread Sonic Zhang
Update: 1. Condition branch code instead of while loop from Alan Cox. 2. Condtinue in PIO mode after failing to request DMA. Signed-off-by: Sonic Zhang [EMAIL PROTECTED] --- drivers/ata/Kconfig | 28 + drivers/ata/Makefile |1 drivers/ata/pata_bf54x.c | 1581

[git patches] libata fixes

2007-08-15 Thread Jeff Garzik
Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/ata_piix.c |9 - drivers/ata/libata-core.c |2 +- drivers/ata/pata_artop.c | 19

Re: [PATCH take #5] [libata] libata driver for bf548 on chip ATAPI controller.

2007-08-15 Thread Alan Cox
On Wed, 15 Aug 2007 17:14:15 +0800 Sonic Zhang [EMAIL PROTECTED] wrote: Update: 1. Condition branch code instead of while loop from Alan Cox. 2. Condtinue in PIO mode after failing to request DMA. Signed-off-by: Sonic Zhang [EMAIL PROTECTED] Acked-by: Alan Cox [EMAIL PROTECTED] Minor

Accessing CDROM drive in laptop SATA/PATA hardware config

2007-08-15 Thread Thomas Hahn
Hello, I have tried to get some help from linux.debian.laptop but so far no replies. Sorry if I address the wrong people ... I have a Toshiba M40X-112 laptop. ---snip--- Linux satellita 2.6.22-1-686-bigmem #1 SMP Sun Jul 29 15:54:01 UTC 2007 i686 GNU/Linux ---snap--- So far I am quite happy

sata_sil, sil3512, and PMP?

2007-08-15 Thread Petr Vandrovec
Hello, is anybody working on PMP support in sata_sil driver, or should I give it a try, or is it simpler to just shell out $70 to get 3124 based device with FIS based switching? According to datasheet it seems that 3512 should be able to do command based switching without (too big)

booting from MD raid using libata

2007-08-15 Thread Ethan Sommer
I've been trying to diagnose a problem we've been having for a few days and I think I've found the problem. (I'm hoping you might have the solution.) I have a system which has a intel 965 MB and a couple SIL based SATA cards one of which is hooked up to a few PMPs. If I try to boot the

Re: [PATCH] ST340823A, HPA and libata

2007-08-15 Thread Mikko Rapeli
On Wed, Aug 08, 2007 at 02:25:05PM +0100, Alan Cox wrote: Ok this is a different approach to handling it - knowing it is an off by one so we can handle the drive if clipped Patch works with 2.6.23-rc2 after the boot problem was solved. -Mikko - To unsubscribe from this list: send the line

Re: [patch 2/4] scsi: expose AN support to user space

2007-08-15 Thread James Bottomley
On Wed, 2007-08-15 at 04:13 -0400, Jeff Garzik wrote: Kristen Carlson Accardi wrote: If a scsi_device supports async notification for media change, then let user space know this capability exists by creating a new sysfs entry media_change_notify, which will be 1 if it is supported, and 0

Re: Still having problems with sata_promise on all late kernels - shutdown too - BISECTED

2007-08-15 Thread Brad Campbell
Tejun Heo wrote: Brad Campbell wrote: Brad Campbell wrote: http://www.fnarfbargle.com/CIMG1029.JPG (I have posted this screen shot previously. It's still doing exactly the same thing on both boxes). git-bisect shows up this commit as the guilty party. I can't just revert it on a recent tree

Re: [patch 1/4] libata: check for AN support

2007-08-15 Thread Kristen Carlson Accardi
On Wed, 15 Aug 2007 03:59:10 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: Since I wanted to get in Tejun's ata_link changes before this, this will require a rediff. But more importantly, as I was going to apply it I noticed another problem: we need to verify that SiS and NVIDIA both

Re: [patch 2/4] scsi: expose AN support to user space

2007-08-15 Thread Kristen Carlson Accardi
On Wed, 15 Aug 2007 09:01:49 -0500 James Bottomley [EMAIL PROTECTED] wrote: On Wed, 2007-08-15 at 04:13 -0400, Jeff Garzik wrote: Kristen Carlson Accardi wrote: If a scsi_device supports async notification for media change, then let user space know this capability exists by creating a

Re: Still having problems with sata_promise on all late kernels

2007-08-15 Thread Brad Campbell
Mikael Pettersson wrote: The box was described as a KT600 chipset era machine with 3 Promise SATA150TX4 cards, a SIL3112 card, and an on-board VIA controller. According to the `lspci' posted the box probably also has an AGP card and at least one gigaether card (there's two, I guess one might be

Re: Early ATA devices

2007-08-15 Thread Erik Mouw
On Thu, Aug 02, 2007 at 09:47:06PM +0100, Alan Cox wrote: So in theory we can persuade libata to drive original MFM/RLL disks with relatively few changes Does anyone have a working device to test? I'm currently testing a 40MB pre-ATA IDE drive and with the LBA/non-LBA fix I sent to

Re: Early ATA devices

2007-08-15 Thread Alan Cox
FWIW, I have a Seagate ST225 (still zero bad blocks) with controller. If I can persuade the old 386 to do a netboot I can test it. Right now it'll fail on the identify (may fail earlier on the reset signature test actually). Alan - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH #upstream-fixes] libata: fix n_sectors failure handling during revalidation

2007-08-15 Thread Alan Cox
On Thu, 16 Aug 2007 03:02:22 +0900 Tejun Heo [EMAIL PROTECTED] wrote: If revalidation fails because device has different n_sectors after configuration the original n_sectors should be restored before failing revalidation. Without this fix, n_sectors difference will incorrectly and silently

[PATCH 1/4] libata: move ata_id_n_sectors() upward

2007-08-15 Thread Tejun Heo
Move ata_id_n_sectors() upward right below ata_id_c_string(). This is to accomodate later changes. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-core.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) Index:

[PATCH 2/4] libata: implement BROKEN_HPA horkage and apply to affected drives

2007-08-15 Thread Tejun Heo
Some drives choke on READ_NATIVE_MAX_ADDRESS[_EXT]. Implement ATA_HORKAGE_BROKEN_HPA and apply it to affected drives. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- WDC drives are from bugzilla bug . drivers/ata/libata-core.c |6 +- include/linux/libata.h|1 + 2 files

Re: [PATCH 2/4] libata: implement BROKEN_HPA horkage and apply to affected drives

2007-08-15 Thread Tejun Heo
Alan Cox wrote: +{ HDS724040KLSA80,KFAOA20N, ATA_HORKAGE_BROKEN_HPA, }, +{ WDC WD3200JD-00KLB0, WD-WCAMR1130137, ATA_HORKAGE_BROKEN_HPA }, +{ WDC WD2500JD-00HBB0, WD-WMAL71490727, ATA_HORKAGE_BROKEN_HPA }, I'm still a little bothered that we haven't seen these reported

[PATCH #upstream-fixes] libata: fix n_sectors failure handling during revalidation

2007-08-15 Thread Tejun Heo
If revalidation fails because device has different n_sectors after configuration the original n_sectors should be restored before failing revalidation. Without this fix, n_sectors difference will incorrectly and silently pass revalidation when revalidation is retried. Signed-off-by: Tejun Heo

Re: [PATCH 2/4] libata: implement BROKEN_HPA horkage and apply to affected drives

2007-08-15 Thread Alan Cox
+ { HDS724040KLSA80,KFAOA20N, ATA_HORKAGE_BROKEN_HPA, }, + { WDC WD3200JD-00KLB0, WD-WCAMR1130137, ATA_HORKAGE_BROKEN_HPA }, + { WDC WD2500JD-00HBB0, WD-WMAL71490727, ATA_HORKAGE_BROKEN_HPA }, I'm still a little bothered that we haven't seen these reported with old IDE

RE: sata_sil, sil3512, and PMP?

2007-08-15 Thread Eunice Chen
3512/3112/3114 controllers do not support PMP. 3124/3132 controllers do. Eunice -Original Message- From: [EMAIL PROTECTED] [mailto:[EMAIL PROTECTED] On Behalf Of Petr Vandrovec Sent: Wednesday, August 15, 2007 5:47 AM To: linux-ide@vger.kernel.org Subject: sata_sil, sil3512, and PMP?

ST340823A disk size issue - Revisited

2007-08-15 Thread Eddie Atherton
Hi, I found the above thread while searching for the reason I was getting lots of errors while trying to build out a new server. Yes, I am using an ST340823A drive. However, I am getting slightly different results for the drive capacity, which I'm not sure if that could cause issues with

Re: regression problem with Maxtor disk

2007-08-15 Thread Lieven Marchand
Tejun Heo [EMAIL PROTECTED] writes: It seems klogd clipped some messages. Can you please turn on printk timestamp, enlarge printk log buffersize and post the result of 'dmesg' after errors? [ 33.587986] libata version 2.21 loaded. [ 33.592361] ACPI: PCI Interrupt Link [APCH] enabled at

Re: regression problem with Maxtor disk

2007-08-15 Thread Robert Hancock
Lieven Marchand wrote: Tejun Heo [EMAIL PROTECTED] writes: It seems klogd clipped some messages. Can you please turn on printk timestamp, enlarge printk log buffersize and post the result of 'dmesg' after errors? [ 34.576963] ata1: SATA link up 1.5 Gbps (SStatus 113 SControl 300) [

RE: [patch 2/4] scsi: expose AN support to user space

2007-08-15 Thread Moore, Eric
On Wednesday, August 15, 2007 8:02 AM, James Bottomley wrote: Actually, we just got a second potential consumer ... although I'll reprod to have the reporter send it to the list. It's a device that needs notice of report luns data changing. The proposed mechanism looks a bit narrow now

RE: sata_sil, sil3512, and PMP?

2007-08-15 Thread vandrove
Quoting Eunice Chen [EMAIL PROTECTED]: 3512/3112/3114 controllers do not support PMP. 3124/3132 controllers do. Um... Well, that's bad. Can you update datasheet then? http://www.siliconimage.com/docs/SiI-DS-0102-D.pdf says on page 77: === Serial ATA SControl Address Offset: 0x100 (Channel