Re: 2.6.23-rc4-mm1

2007-09-11 Thread Jens Axboe
On Mon, Sep 10 2007, Torsten Kaiser wrote: On 9/10/07, FUJITA Tomonori [EMAIL PROTECTED] wrote: On Mon, 10 Sep 2007 12:20:38 -0700 Andrew Morton [EMAIL PROTECTED] wrote: On Mon, 10 Sep 2007 20:59:49 +0200 Torsten Kaiser [EMAIL PROTECTED] wrote: The system boots, reads the

[patch] ata: increase allowed config flags

2007-09-11 Thread Kristen Carlson Accardi
In anticipation of more features, increase number of config flags allowed, and move the init flags. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Cc: Hugh Dickens [EMAIL PROTECTED] Index: 2.6-mm/include/linux/libata.h

[PATCH 00/27] blk_end_request: full I/O completion handler (take 2)

2007-09-11 Thread Kiyoshi Ueda
Hello, The following is the revised patch-set, fixing the issue pointed out by Jens and Benny. Changes from the previous post are below: o Rebased on top of 2.6.23-rc4-mm1 o Don't pass the lock held information (PATCH 01) o Removed sect2byte() macro (PATCH 02) o fixed blk_rq_size() and

[PATCH 02/27] blk_end_request: add blk_rq_size() functions (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch adds functions to get the size of request in bytes. They are useful because blk_end_request() takes bytes as a completed I/O size instead of sectors. Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- include/linux/blkdev.h | 24

[PATCH 03/27] blk_end_request: changing block layer core (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts core parts of block layer to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- block/ll_rw_blk.c | 15 +-- 1 files changed, 5 insertions(+), 10 deletions(-) diff -rupN

[PATCH 01/27] blk_end_request: add new request completion interface (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch adds 2 new interfaces for request completion: o blk_end_request() : called without queue lock o __blk_end_request() : called with queue lock held Some device drivers call some generic functions below between end_that_request_{first/chunk} and end_that_request_last(). o

[PATCH 04/27] blk_end_request: changing arm (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts arm to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- arch/arm/plat-omap/mailbox.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff -rupN

[PATCH 05/27] blk_end_request: changing um (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts um to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- arch/um/drivers/ubd_kern.c | 10 +- 1 files changed, 1 insertion(+), 9 deletions(-) diff -rupN

[PATCH 06/27] blk_end_request: changing DAC960 (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts DAC960 to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/block/DAC960.c |5 + 1 files changed, 1 insertion(+), 4 deletions(-) diff -rupN 05-um-caller-change/drivers/block/DAC960.c

[PATCH 07/27] blk_end_request: changing floppy (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts floppy to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/block/floppy.c |8 +++- 1 files changed, 3 insertions(+), 5 deletions(-) diff -rupN

[PATCH 08/27] blk_end_request: changing lguest (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts lguest to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/block/lguest_blk.c |5 + 1 files changed, 1 insertion(+), 4 deletions(-) diff -rupN

[PATCH 09/27] blk_end_request: changing nbd (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts nbd to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/block/nbd.c |4 +--- 1 files changed, 1 insertion(+), 3 deletions(-) diff -rupN 08-lguest-caller-change/drivers/block/nbd.c

[PATCH 10/27] blk_end_request: changing ps3disk (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts ps3disk to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/block/ps3disk.c |6 +- 1 files changed, 1 insertion(+), 5 deletions(-) diff -rupN 09-nbd-caller-change/drivers/block/ps3disk.c

[PATCH 11/27] blk_end_request: changing sunvdc (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts sunvdc to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/block/sunvdc.c |5 + 1 files changed, 1 insertion(+), 4 deletions(-) diff -rupN 10-ps3disk-caller-change/drivers/block/sunvdc.c

[PATCH 13/27] blk_end_request: changing ub (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts ub to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/block/ub.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff -rupN 12-sx8-caller-change/drivers/block/ub.c

[PATCH 14/27] blk_end_request: changing viodasd (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts viodasd to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/block/viodasd.c |5 + 1 files changed, 1 insertion(+), 4 deletions(-) diff -rupN 13-ub-caller-change/drivers/block/viodasd.c

[PATCH 12/27] blk_end_request: changing sx8 (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts sx8 to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/block/sx8.c |4 +--- 1 files changed, 1 insertion(+), 3 deletions(-) diff -rupN 11-sunvdc-caller-change/drivers/block/sx8.c

[PATCH 15/27] blk_end_request: changing xen-blkfront (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts xen-blkfront to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/block/xen-blkfront.c |5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff -rupN

[PATCH 16/27] blk_end_request: changing viocd (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts viocd to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/cdrom/viocd.c |5 + 1 files changed, 1 insertion(+), 4 deletions(-) diff -rupN 15-xen-caller-change/drivers/cdrom/viocd.c

[PATCH 17/27] blk_end_request: changing i2o_block (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts i2o_block to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/message/i2o/i2o_block.c |8 ++-- 1 files changed, 2 insertions(+), 6 deletions(-) diff -rupN

[PATCH 18/27] blk_end_request: changing mmc (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts mmc to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/mmc/card/block.c | 24 +--- drivers/mmc/card/queue.c |4 ++-- 2 files changed, 7 insertions(+), 21 deletions(-)

[PATCH 19/27] blk_end_request: changing s390 (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts s390 to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/s390/block/dasd.c |4 +--- drivers/s390/char/tape_block.c |3 +-- 2 files changed, 2 insertions(+), 5 deletions(-) diff

[PATCH 20/27] blk_end_request: changing scsi (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts scsi mid-layer to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/scsi/scsi_lib.c | 13 ++--- 1 files changed, 2 insertions(+), 11 deletions(-) diff -rupN

[PATCH 21/27] blk_end_request: changing ide-scsi (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts ide-scsi to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/scsi/ide-scsi.c |8 1 files changed, 4 insertions(+), 4 deletions(-) diff -rupN

[PATCH 22/27] blk_end_request: changing xsysace (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts xsysace to use blk_end_request(). xsysace is a little bit different from normal drivers. xsysace driver has a state machine in it. It calls end_that_request_first() and end_that_request_last() from different states. (ACE_FSM_STATE_REQ_TRANSFER and ACE_FSM_STATE_REQ_COMPLETE,

[PATCH 24/27] blk_end_request: changing cpqarray (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts cpqarray to use blk_end_request(). cpqarray is a little bit different from normal drivers. cpqarray directly calls bio_endio() and disk_stat_add() when completing request. But those can be replaced with __end_that_request_first(). After the replacement, request completion

[PATCH 25/27] blk_end_request: changing ide normal caller (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts normal parts of ide to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |6 +++--- drivers/ide/ide-io.c | 22 +++--- 2 files changed, 10 insertions(+), 18

[PATCH 23/27] blk_end_request: changing cciss (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts cciss to use blk_end_request(). cciss is a little bit different from normal drivers. cciss directly calls bio_endio() and disk_stat_add() when completing request. But those can be replaced with __end_that_request_first(). After the replacement, request completion procedures

[PATCH 27/27] blk_end_request: remove/unexport end_that_request_* (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch removes the following functions: o end_that_request_first() o end_that_request_chunk() and stops exporting the functions below: o end_that_request_last() Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED] --- block/ll_rw_blk.c |

[PATCH 26/27] blk_end_request: changing ide-cd (take 2)

2007-09-11 Thread Kiyoshi Ueda
This patch converts ide-cd (cdrom_newpc_intr()) to use blk_end_request(). Due to the oddness of the driver, the patch adds a variant of the interface, blk_end_request_callback(). cdrom_newpc_intr() of ide-cd is the only function in the kernel tree which needs to call end_that_request_first() and

Re: [PATCH 22/27] blk_end_request: changing xsysace (take 2)

2007-09-11 Thread Grant Likely
On 9/11/07, Kiyoshi Ueda [EMAIL PROTECTED] wrote: This patch converts xsysace to use blk_end_request(). xsysace is a little bit different from normal drivers. xsysace driver has a state machine in it. It calls end_that_request_first() and end_that_request_last() from different states.

[git patches] IDE fixes for 2.6.23-rc6

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/bart/ide-2.6.git/ to receive the following updates: drivers/ata/pata_ali.c |7 ++ drivers/ide/Kconfig|4 +- drivers/ide/ide-iops.c |3 +- drivers/ide/pci/alim15x3.c |7 ++

ata_piix, laptop cdrom, ICH7: EH, limiting speed to PIO

2007-09-11 Thread Sergey Dolgov
Hi! On my hp nx7300 laptop, 2 following scenarios can happen during bootup (see attachments for the full logs): the good one [1] and the one where multiple EHs lead to limiting the speed [2]. [1] one is more rare, but it seems to be persistent over reboots: once it happened, just rebooting the

Re: [PATCH 2/4] hpt366: MWDMA filter for SATA cards

2007-09-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 08 September 2007, Sergei Shtylyov wrote: Hello, I wrote: Sergei Shtylyov wrote: The patch was 4/4 of course. :- Probably I was too esctatic about the code. ;-) Or rarher me. :-) The Marvell bridge chips used on HighPoint SATA cards do not seem to support

Re: [PATCH 3/4] ide: make ide_rate_filter() also respect PIO and SW/MW DMA mode masks (take 2)

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 08 September 2007, Sergei Shtylyov wrote: Once I quothed: Make ide_rate_filter() also respect PIO/SWDMA/MWDMA mode masks. While at it, make the udma_filter() method calls take precedence over using the mode masks. This one not looking to pretty -- I've geve

Re: [PATCH 5/10] hpt366: remove -init_setup

2007-09-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 08 September 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Split off hpt{374,371,366}_init() helper from init_setup_hpt{374,371,366}(). * Merge init_setup_{374,372n,371,372a,302,366}() into hpt366_init_one(). While at it: * Use HPT36x name for

Re: [-mm patch] remove ide_get_error_location()

2007-09-11 Thread Bartlomiej Zolnierkiewicz
On Sunday 09 September 2007, Adrian Bunk wrote: On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote: ... Changes since 2.6.23-rc3-mm1: ... git-block.patch ... git trees ... ide_get_error_location() is no longer used. Signed-off-by: Adrian Bunk [EMAIL PROTECTED]

[PATCH 1/10] cmd64x: always set hwif-chipset for CMD646

2007-09-11 Thread Bartlomiej Zolnierkiewicz
hwif-chipset should be set to ide_cmd646 also when DMA base is invalid. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cmd64x.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: b/drivers/ide/pci/cmd64x.c

[PATCH 2/10] ide: fix disabled ports reporting for PCI controllers

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Report all disabled ports in ide_pci_setup_ports() (prevents the bogus warning when ide_hwif_configure()-ide_match_hwif() fails to find free ide_hwifs[] slots). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/setup-pci.c | 10 -- 1 file changed, 4

[PATCH 3/10] rz1000: set serialized flag only if mate interface exists

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Setting hwif-serialized makes sense only if the mate interface exists. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/rz1000.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: b/drivers/ide/pci/rz1000.c

[PATCH 4/10] serverworks: remove dead code from svwks_set_dma_mode()

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/serverworks.c |7 --- 1 file changed, 7 deletions(-) Index: b/drivers/ide/pci/serverworks.c === --- a/drivers/ide/pci/serverworks.c +++

[PATCH 5/10] ide: add hwif_register_devices() helper

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Add hwif_register_devices() helper to fix code duplication between probe_hwif_init_with_fixup() and ideprobe_init(). Also remove stale comment while at it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c | 51

[PATCH 6/10] ide: remove unused -next field from ide_pci_device_t

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- include/linux/ide.h |1 - 1 file changed, 1 deletion(-) Index: b/include/linux/ide.h === --- a/include/linux/ide.h +++ b/include/linux/ide.h @@ -1283,7 +1283,6 @@

[PATCH 7/10] ide: add -chipset field to ide_pci_device_t

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Add -chipset field to ide_pci_device_t and use it in ide_hwif_configure() to set hwif-chipset. Convert cmd64x, cy82c693, rz1000 and trm290 host drivers to use this new ability. While at it define hwif_chipset_t as u8 to save some space in hw_regs_t, ide_hwif_t and ide_pci_device_t instances.

[PATCH 8/10] ide: add IDE_HFLAG_FORCE_LEGACY_IRQS host flag

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_FORCE_LEGACY_IRQS host flag to tell ide_pci_setup_ports() to always set hwif-irq to legacy IRQ 14/15 and convert generic IDE PCI and via82cxxx host drivers to use it. While at it: * Add IDE_HFLAGS_UMC define (generic IDE PCI host driver). * Remove no longer needed

[PATCH 9/10] ide: add IDE_HFLAG_RQSIZE_256 host flag

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_RQSIZE_256 host flag to tell ide_pci_setup_ports() to set hwif-rqsize to 256 sectors. Convert pdc202xx_old host driver to use it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/pdc202xx_old.c | 18 ++ drivers/ide/setup-pci.c

[PATCH 10/10] ide: add IDE_HFLAG_{IO_32BIT,UNMASK_IRQS} host flags

2007-09-11 Thread Bartlomiej Zolnierkiewicz
Add IDE_HFLAG_{IO_32BIT,UNMASK_IRQS} host flag to tell ide_pci_setup_ports() to set drive-{io_32bit,unmask} for both drives on the interface. Convert amd74xx, sl82c105 and via82cxxx host drivers to use these new host flags. While at it: * Add IDE_HFLAGS_AMD define (amd74xx host driver). * Add

Re: [PATCH] drivers/firmware: const-ify DMI API and internals

2007-09-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 01 September 2007, Jeff Garzik wrote: commit 457b6eb3bf3341d2e143518a0bb99ffbb8d754c4 Author: Jeff Garzik [EMAIL PROTECTED] Date: Sat Sep 1 10:16:45 2007 -0400 drivers/firmware: const-ify DMI API and internals Three main sets of changes: 1)

Re: libata not working for sis5533

2007-09-11 Thread Andrew Morton
On Sun, 09 Sep 2007 13:35:26 +0200 Patrizio Bassi [EMAIL PROTECTED] wrote: Patrizio Bassi ha scritto: Jan Engelhardt ha scritto: On Sep 8 2007 11:38, Patrizio Bassi wrote: Jan Engelhardt wrote: I shall give this a spin too, since I happen to have sis5513. Just booted this

Re: [git patches] IDE fixes for 2.6.23-rc6

2007-09-11 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: Please pull from: master.kernel.org:/pub/scm/linux/kernel/git/bart/ide-2.6.git/ to receive the following updates: drivers/ata/pata_ali.c |7 ++ drivers/ide/Kconfig|4 +- drivers/ide/ide-iops.c |3 +-

[PATCH] Blacklist NCQ for WDC1600BEVS-22RST0

2007-09-11 Thread Maurizio Monge
This patch fixes the spurious completions during NCQ kernel error i used to get. Unluckily this drive SHOULD work with NCQ, but on my system it does not. If you think that instead it should work i will provide you additional information amout my system (i have already posted some on this list and

Re: [-mm patch] remove ide_get_error_location()

2007-09-11 Thread Jens Axboe
On Tue, Sep 11 2007, Bartlomiej Zolnierkiewicz wrote: On Sunday 09 September 2007, Adrian Bunk wrote: On Fri, Aug 31, 2007 at 09:58:22PM -0700, Andrew Morton wrote: ... Changes since 2.6.23-rc3-mm1: ... git-block.patch ... git trees ... ide_get_error_location() is no