[PATCH v3] [POWERPC] Fix build errors when BLOCK=n

2007-09-19 Thread Emil Medve
These are the symptom error messages: CC arch/powerpc/kernel/setup_32.o In file included from include/linux/blkdev.h:17, from include/linux/ide.h:13, from arch/powerpc/kernel/setup_32.c:13: include/linux/bsg.h:67: warning: 'struct request_queue' declared in

Re: [PATCH v2] [POWERPC] Fix build errors when BLOCK=n

2007-09-19 Thread Paul Mackerras
Emil Medve writes: > --- a/arch/powerpc/kernel/ppc_ksyms.c > +++ b/arch/powerpc/kernel/ppc_ksyms.c > @@ -12,12 +12,15 @@ > #include > #include > #include > +#if defined(CONFIG_IDE) || defined(CONFIG_IDE_MODULE) > #include > +#endif Why are we still including linux/ide.h at all here? > #

Re: [PATCH] libata: Add a drivers/ide style DMA disable

2007-09-19 Thread Tejun Heo
Chuck Ebbert wrote: > On 08/22/2007 06:37 PM, Alan Cox wrote: >> This is useful when debugging, handling problem systems, or for >> distributions just to get the system installed so it can be sorted >> out later. >> >> This is a bit smarter than the old IDE one and lets you do >> >> libata.pata_dma

sata_via: bit SATA_2DEV of SATA_PATA_SHARING register

2007-09-19 Thread Tejun Heo
Hello, Jeff. Do you recall why sata_via doesn't support configuration where SATA_2DEV bit is set in the SATA_PATA_SHARING PCI conf reg? Is it a leftover from the days when libata didn't support mixed PATA/SATA setup? I have a machine which does that and just skipping the test makes it work just

Re: ATAPI tape drives broken with libata

2007-09-19 Thread Alan Cox
> I can read and write the tape successfully, and the written data matches > what is later read back from it. > > Here's the hack I used. Not ready for mainline, but perhaps it will > help Alan or whomever come up with something nice for Jeff. Its possible we should just scream and shout but fo

[PATCH 2/3] ide: remove redundant comments from ide.h

2007-09-19 Thread Bartlomiej Zolnierkiewicz
There is better documentation for these functions in drivers/ide/. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- include/linux/ide.h | 41 - 1 file changed, 41 deletions(-) Index: b/include/linux/ide.h

[PATCH] MAINTAINERS: mark ide-scsi as Orphan

2007-09-19 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- MAINTAINERS |5 + 1 file changed, 5 insertions(+) Index: b/MAINTAINERS === --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1889,6 +1889,11 @@ M: Gadi Oxman <[EMA

[PATCH 1/3] ide: add ide_find_port() helper

2007-09-19 Thread Bartlomiej Zolnierkiewicz
* Add ide_find_port() helper. * Convert icside, rapide and ide_platform host drivers to use it. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/arm/icside.c | 24 +--- drivers/ide/arm/rapide.c | 25 +

[PATCH 3/3] ide: add CONFIG_IDE_ARCH_OBSOLETE_INIT

2007-09-19 Thread Bartlomiej Zolnierkiewicz
Add CONFIG_IDE_ARCH_OBSOLETE_INIT to drivers/ide/Kconfig and use it instead of defining IDE_ARCH_OBSOLETE_INIT in . Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/Kconfig |3 +++ drivers/ide/setup-pci.c |2 +- include/asm-alpha/id

Re: [PATCH v2] [POWERPC] Fix build errors when BLOCK=n

2007-09-19 Thread Bartlomiej Zolnierkiewicz
On Wednesday 19 September 2007, Emil Medve wrote: > These are the symptom error messages: > > CC arch/powerpc/kernel/setup_32.o > In file included from include/linux/blkdev.h:17, > from include/linux/ide.h:13, > from arch/powerpc/kernel/setup_32.c:13: > inc

[PATCH v2] [POWERPC] Fix build errors when BLOCK=n

2007-09-19 Thread Emil Medve
These are the symptom error messages: CC arch/powerpc/kernel/setup_32.o In file included from include/linux/blkdev.h:17, from include/linux/ide.h:13, from arch/powerpc/kernel/setup_32.c:13: include/linux/bsg.h:67: warning: 'struct request_queue' declared in

Re: [PATCH] libata: Add a drivers/ide style DMA disable

2007-09-19 Thread Alan Cox
> This doesn't help distro installers with modular libata, as there's > no good way to get the parameter to the driver. (libata.pata_dma=0 > just causes "unrecognized parameter" message on boot.) And for how long have people been saying that Fedora needs to sort out passing module parameters from

Re: [PATCH] libata: Add a drivers/ide style DMA disable

2007-09-19 Thread Chuck Ebbert
On 08/22/2007 06:37 PM, Alan Cox wrote: > This is useful when debugging, handling problem systems, or for > distributions just to get the system installed so it can be sorted > out later. > > This is a bit smarter than the old IDE one and lets you do > > libata.pata_dma=0 Disable all

Improper disk shutdown with 2.6.22.6?

2007-09-19 Thread Robert
Hello, When shutting down this system running Linux 2.6.22.6, I get a warning about the possibility that the disks are not properly shut down. When the power is turned off, it sounds like the disks aren't spun down (but I may be mistaken on that point). http://linux-ata.org/shutdown.html claims t