DMA and block mode

2007-09-20 Thread Kantor Zsolt
Hi, the DMA read/write transfers are not influenced by the currently block mode setting only the PIO modes are influenced? because the read/write sectors using multiple mode is made on the PIO protocol, and for DMA is no such read/write multiple sectors Thanks Kantor __

2.6.23-rc6-mm1: Build failure on ppc64 drivers/ata/pata_scc.c

2007-09-20 Thread Mel Gorman
PPC64 building allmodconfig fails to compile drivers/ata/pata_scc.c . It doesn't show up on other arches because this driver is specific to the architecture. drivers/ata/pata_scc.c: In function `scc_bmdma_status': drivers/ata/pata_scc.c:734: error: structure has no member named `active_tag' driver

[PATCH] libata: Update experimental tags to reflect reality better

2007-09-20 Thread Alan Cox
Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23rc6-mm1/drivers/ata/Kconfig linux-2.6.23rc6-mm1/drivers/ata/Kconfig --- linux.vanilla-2.6.23rc6-mm1/drivers/ata/Kconfig 2007-09-18 15:32:51.0 +0100 +++ linu

[PATCH] libata: Set transfer sizes properly for ATAPI

2007-09-20 Thread Alan Cox
In theory this isn't needed. In practice it seems to matter now and then and was also done by the old IDE DMA layer. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23rc6-mm1/drivers/ata/libata-scsi.c linux-2.6.23rc6-m

[PATCH] libata-sff: Fix documentation

2007-09-20 Thread Alan Cox
Code moved to ioread/iowrite but the comment didn't Also note a posting issue Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23rc6-mm1/drivers/ata/libata-sff.c linux-2.6.23rc6-mm1/drivers/ata/libata-sff.c --- linux.va

[PATCH] pata_acpi: Use ata_sff_port_start

2007-09-20 Thread Alan Cox
Purely a stylistic issue currently but best done while I notice it. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23rc6-mm1/drivers/ata/pata_acpi.c linux-2.6.23rc6-mm1/drivers/ata/pata_acpi.c --- linux.vanilla-2.6.23

Re: 2.6.23-rc6-mm1: Build failure on ppc64 drivers/ata/pata_scc.c

2007-09-20 Thread Alan Cox
On Thu, 20 Sep 2007 14:13:15 +0100 [EMAIL PROTECTED] (Mel Gorman) wrote: > PPC64 building allmodconfig fails to compile drivers/ata/pata_scc.c . It > doesn't show up on other arches because this driver is specific to the > architecture. > > drivers/ata/pata_scc.c: In function `scc_bmdma_status'

[PATCH] ide-cd is unmaintained

2007-09-20 Thread Alan Cox
I simply don't have any old IDE systems any more or time to really look after this. Nobody responded to the previous linux-ide mail about maintainers so... Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23rc6-mm1/MAINT

[PATCH] libata: Update the blacklist with a few more devices

2007-09-20 Thread Alan Cox
Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23rc6-mm1/drivers/ata/libata-core.c linux-2.6.23rc6-mm1/drivers/ata/libata-core.c --- linux.vanilla-2.6.23rc6-mm1/drivers/ata/libata-core.c 2007-09-18 15:32:51.

[PATCH] libata: Add a horkage entry for DRQ mishandling (atapi tapes)

2007-09-20 Thread Alan Cox
This will allow us to handle the tape drive problems Mark Lord reported Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23rc6-mm1/include/linux/libata.h linux-2.6.23rc6-mm1/include/linux/libata.h --- linux.vanilla-2.6.

[PATCH] pdc2027x: Switch properly to ioread/iowrite

2007-09-20 Thread Alan Cox
Some iomap functions were still using readl/writel and friends which happens to work on most platforms but is not correct. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23rc6-mm1/drivers/ata/pata_pdc2027x.c linux-2.6

[PATCH] hpt37x updates for comment

2007-09-20 Thread Alan Cox
Split the tuning up so it is a lot more readable Don't try and tune the HPT374 twice diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23rc6-mm1/drivers/ata/pata_hpt37x.c linux-2.6.23rc6-mm1/drivers/ata/pata_hpt37x.c --- linux.vanilla-2.6.23rc6-mm1/drivers/ata/pata

Re: 2.6.23-rc6-mm1: Build failure on ppc64 drivers/ata/pata_scc.c

2007-09-20 Thread Mel Gorman
On (20/09/07 15:09), Alan Cox didst pronounce: > On Thu, 20 Sep 2007 14:13:15 +0100 > [EMAIL PROTECTED] (Mel Gorman) wrote: > > > PPC64 building allmodconfig fails to compile drivers/ata/pata_scc.c . It > > doesn't show up on other arches because this driver is specific to the > > architecture. >

Re: [PATCH] ide-cd is unmaintained

2007-09-20 Thread Stefan Richter
Alan Cox wrote: > IDE/ATAPI CDROM DRIVER > -P: Alan Cox > -M: [EMAIL PROTECTED] > L: linux-ide@vger.kernel.org > -S: Maintained > +S: Unmaintained Should be "Orphan", not Unmaintained. -- Stefan Richter -=-=-=== =--= =-=-- http://arcgraph.de/sr/ - To unsubscribe from this list: se

Re: 2.6.23-rc6-mm1: Build failure on ppc64 drivers/ata/pata_scc.c

2007-09-20 Thread Kamalesh Babulal
Alan Cox wrote: On Thu, 20 Sep 2007 14:13:15 +0100 [EMAIL PROTECTED] (Mel Gorman) wrote: PPC64 building allmodconfig fails to compile drivers/ata/pata_scc.c . It doesn't show up on other arches because this driver is specific to the architecture. drivers/ata/pata_scc.c: In function `scc_bmd

Re: [PATCH] ide-cd is unmaintained

2007-09-20 Thread Jens Axboe
On Thu, Sep 20 2007, Alan Cox wrote: > I simply don't have any old IDE systems any more or time to really look > after this. Nobody responded to the previous linux-ide mail about > maintainers so... > > Signed-off-by: Alan Cox <[EMAIL PROTECTED]> Just fold it in with the IDE system in general? Wo

Re: [PATCH] pata_acpi: Use ata_sff_port_start

2007-09-20 Thread Jeff Garzik
Alan Cox wrote: Purely a stylistic issue currently but best done while I notice it. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23rc6-mm1/drivers/ata/pata_acpi.c linux-2.6.23rc6-mm1/drivers/ata/pata_acpi.c --- li

Re: [PATCH] libata: Update the blacklist with a few more devices

2007-09-20 Thread Jeff Garzik
Alan Cox wrote: Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied first two chunks to #upstream-fixes - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] libata-sff: Fix documentation

2007-09-20 Thread Jeff Garzik
Alan Cox wrote: Code moved to ioread/iowrite but the comment didn't Also note a posting issue Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --exclude-from /usr/src/exclude --new-file --recursive linux.vanilla-2.6.23rc6-mm1/drivers/ata/libata-sff.c linux-2.6.23rc6-mm1/drivers/ata/libata-

[git patches] libata fixes

2007-09-20 Thread Jeff Garzik
Fixes from Alan, PCI IDs from ATI/AMD. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/ahci.c| 10 ++ drivers/ata/libata-core.c |4 drivers/at

Re: [PATCH] pata_acpi: Use ata_sff_port_start

2007-09-20 Thread Andrew Morton
On Thu, 20 Sep 2007 15:47:05 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Alan Cox wrote: > > Purely a stylistic issue currently but best done while I notice it. > > > > Signed-off-by: Alan Cox <[EMAIL PROTECTED]> > > > > diff -u --exclude-from /usr/src/exclude --new-file --recursive > > linu

Re: [PATCH] libata-core: support wildcard matching in ata_blacklist_entry

2007-09-20 Thread Jeff Garzik
David Milburn wrote: Support the use of '*' in model_num and model_rev entries in ata_device_blacklist[]. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: David Milburn <[EMAIL PROTECTED]> applied a modified version (attached) commit 6d7fdd50ff25e6997ab581a2eff0a53f9228829a Author:

Re: [PATCH] libata: Update experimental tags to reflect reality better

2007-09-20 Thread Jeff Garzik
Alan Cox wrote: Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] pdc2027x: Switch properly to ioread/iowrite

2007-09-20 Thread Jeff Garzik
Alan Cox wrote: Some iomap functions were still using readl/writel and friends which happens to work on most platforms but is not correct. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [E

Re: [PATCH] libata: Set transfer sizes properly for ATAPI

2007-09-20 Thread Jeff Garzik
Alan Cox wrote: In theory this isn't needed. In practice it seems to matter now and then and was also done by the old IDE DMA layer. Signed-off-by: Alan Cox <[EMAIL PROTECTED]> applied a modified version (attached) commit 8dcab000d7a3b114a3434129d1d6437263835c87 Author: Jeff Garzik <[EMAIL PR

Re: [PATCH] libata: First cut at verifying and validating all the id checks.

2007-09-20 Thread Jeff Garzik
Alan Cox wrote: - Fix those which require a word is checked for validity - Note limits on version information with ancient ATA - Correct EIDE dword_io check ready for adding 32bit PIO Signed-off-by: Alan Cox <[EMAIL PROTECTED]> any update on this? I definitely agree we should be checking the

Re: [PATCH] libata: Add a horkage entry for DRQ mishandling (atapi tapes)

2007-09-20 Thread Jeff Garzik
Alan Cox wrote: This will allow us to handle the tape drive problems Mark Lord reported Signed-off-by: Alan Cox <[EMAIL PROTECTED]> According to information I have received, some ATA (and possibly ATAPI?) devices intentionally return some data in these cases. In the case of certain ATA devi

Re: [patch] ata: increase allowed config flags

2007-09-20 Thread Jeff Garzik
Kristen Carlson Accardi wrote: In anticipation of more features, increase number of config flags allowed, and move the init flags. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Cc: Hugh Dickens <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscr

Re: [PATCH 2.6.23-rc5] ata_piix: replace spaces with tabs

2007-09-20 Thread Jeff Garzik
Jason Gaston wrote: This patch removes some incorrect formatting spaces and replaces them with tabs. Signed-off-by: Jason Gaston <[EMAIL PROTECTED]> applied - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo inf

Re: [PATCH 1/3] libata: move ata_id_n_sectors() upward

2007-09-20 Thread Jeff Garzik
Tejun Heo wrote: Move ata_id_n_sectors() upward right below ata_id_c_string(). This is to accomodate later changes. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- drivers/ata/libata-core.c | 30 +++--- 1 files changed, 15 insertions(+), 15 deletions(-) applied 1-3

Re: [PATCH REGENERATED] ahci: reimplement port_map handling

2007-09-20 Thread Jeff Garzik
Tejun Heo wrote: Reimplement port_map handling such that 1. Non-zero PORTS_IMPL value is always examined and used if consistent with cap.n_ports. 2. When PI and cat.n_ports are inconsistent, honor cap.n_ports and force port_map to be ((1 << cap.n_ports) - 1). 3. There were two separate p

Re: [PATCH 1/2 #upstream,REGENERATED] libata: udpate ata_dev_try_classify() arguments

2007-09-20 Thread Jeff Garzik
Tejun Heo wrote: Make ata_dev_try_classify() take a pointer to ata_device instead of ata_port/port_number combination for consistency and add @present argument. @present indicates whether the device seems present during reset. It's the result of TF access during softreset and link onlineness du

Re: [PATCH 2.6.23-rc4][reRESEND] ahci: RAID mode SATA patch for Intel Tolapai

2007-09-20 Thread Jeff Garzik
Jason Gaston wrote: Resend trying to remove 8-bit characters in the email. This patch adds the Intel Tolapai RAID controller DID's for SATA support. Signed-off-by: Jason Gaston <[EMAIL PROTECTED]> --- linux-2.6.23-rc4/drivers/ata/ahci.c.orig2007-08-27 18:32:35.0 -0700 +++ linux-2

Re: [PATCH] libata: Add a horkage entry for DRQ mishandling (atapi tapes)

2007-09-20 Thread Alan Cox
> According to information I have received, some ATA (and possibly ATAPI?) > devices intentionally return some data in these cases. In the case of > certain ATA devices, this returned data permits inspection of the > incorrected data. News to me. ATA like ST-506/ST-412 exposes error data on I/

Re: [PATCH] libata: First cut at verifying and validating all the id checks.

2007-09-20 Thread Alan Cox
On Thu, 20 Sep 2007 16:55:37 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Alan Cox wrote: > > - Fix those which require a word is checked for validity > > - Note limits on version information with ancient ATA > > - Correct EIDE dword_io check ready for adding 32bit PIO > > > > Signed-off-by: Al

Re: [PATCH] ST340823A, HPA and libata

2007-09-20 Thread Jeff Garzik
Alan Cox wrote: Ok this is a different approach to handling it - knowing it is an off by one so we can handle the drive if clipped Signed-off-by: Alan Cox <[EMAIL PROTECTED]> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.23rc1-mm1/drivers/ata/libata-core.c l

Re: [PATCH] libata: Set transfer sizes properly for ATAPI

2007-09-20 Thread Alan Cox
On Thu, 20 Sep 2007 16:47:16 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Alan Cox wrote: > > In theory this isn't needed. In practice it seems to matter now and then > > and was also done by the old IDE DMA layer. > > > > Signed-off-by: Alan Cox <[EMAIL PROTECTED]> > > applied a modified vers

Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-09-20 Thread Jeff Garzik
Shaohua Li wrote: ACPI spec (ver 3.0a, p289) requires IDE power on/off executes ACPI _PSx methods. As recently most PATA drivers use libata, this patch adds _PSx method support in libata. ACPI spec doesn't mention if SATA requires the same _PSx method, but executing _PSx for SATA should be ok I t

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 2

2007-09-20 Thread Jeff Garzik
Matthew Garrett wrote: Modern laptops with hotswap bays still tend to utilise a PATA interface on a SATA bridge, generally with the host controller in some legacy emulation mode rather than AHCI. This means that the existing hotplug code in libata is unable to work. The ACPI specification state

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 2

2007-09-20 Thread Matthew Garrett
On Thu, Sep 20, 2007 at 06:04:22PM -0400, Jeff Garzik wrote: > the code looks correct. I have one main reservation. > > how can we be sure that this is active only where other hand-programmed > hotplug code is absent? Yes, that's difficult. As Tejun pointed out, there's missing locking here a

Re: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-09-20 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Kuan Luo <[EMAIL PROTECTED]> Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. NCQ function is disable by default, you can enable it with 'swncq=1'. NCQ will be turned off if the drive is Maxtor on MCP51 or MCP55 rev 0xa2 platform.

[PATCH] ide: remove ->ide_dma_check (take 2)

2007-09-20 Thread Bartlomiej Zolnierkiewicz
* Add IDE_HFLAG_TRUST_BIOS_FOR_DMA host flag for host drivers that depend on BIOS for programming device/controller for DMA. Set it in cy82c693, generic, ns87415, opti621 and trm290 host drivers. * Add IDE_HFLAG_VDMA host flag for host drivers using VDMA. Set it in cs5520 host driver. *

[PATCH] ide: add ->mwdma_mask and ->swdma_mask to ide_pci_device_t (take 2)

2007-09-20 Thread Bartlomiej Zolnierkiewicz
* Add ->mwdma_mask and ->swdma_mask to ide_pci_device_t. * Set ide_hwif_t DMA masks using DMA masks from ide_pci_device_t in setup-pci.c::ide_pci_setup_ports() (iff DMA base is valid and ->init_hwif method may still override them). * Convert IDE PCI host drivers to use ide_pci_device_t DMA m

[PATCH] ide: move ide_rate_filter() calls to the upper layer (take 2)

2007-09-20 Thread Bartlomiej Zolnierkiewicz
* Move ide_rate_filter() calls from host drivers to IDE core. * Make ide_rate_filter() static. * Make 'speed' argument of ->speedproc const. v2: * Fix it8213_tune_chipset() comment. There should be no functionality changes caused by this patch. Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]> Si

[PATCH] ide: use only ->set_pio_mode method for programming PIO modes (take 2)

2007-09-20 Thread Bartlomiej Zolnierkiewicz
Use ->set_pio_mode method to program PIO modes in ide_set_xfer_rate() (the only place which used ->speedproc to program PIO modes) and remove handling of PIO modes from all ->speedproc implementations. v2: * Fix pmac_ide_tune_chipset() comment. There should be no functionality changes caused by

Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-09-20 Thread Shaohua Li
On Thu, 2007-09-20 at 18:00 -0400, Jeff Garzik wrote: > Shaohua Li wrote: > > ACPI spec (ver 3.0a, p289) requires IDE power on/off executes ACPI _PSx > > methods. As recently most PATA drivers use libata, this patch adds _PSx > > method support in libata. ACPI spec doesn't mention if SATA requires

Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-09-20 Thread Tejun Heo
Hello, Shaohua Li wrote: > + /* channel first and then drives for power on and verse versa for power > off */ > + if (state.event == PM_EVENT_ON) > + acpi_bus_set_power(ap->acpi_handle, ACPI_STATE_D0); > + > + if (ap->flags & ATA_FLAG_SLAVE_POSS) > + max_device

Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-09-20 Thread Shaohua Li
On Fri, 2007-09-21 at 11:20 +0900, Tejun Heo wrote: > Hello, > > Shaohua Li wrote: > > + /* channel first and then drives for power on and verse versa for power > > off */ > > + if (state.event == PM_EVENT_ON) > > + acpi_bus_set_power(ap->acpi_handle, ACPI_STATE_D0); > > + > > + i

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 2

2007-09-20 Thread Tejun Heo
Matthew Garrett wrote: > On Thu, Sep 20, 2007 at 06:04:22PM -0400, Jeff Garzik wrote: > >> the code looks correct. I have one main reservation. >> >> how can we be sure that this is active only where other hand-programmed >> hotplug code is absent? > > Yes, that's difficult. As Tejun pointed ou

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 2

2007-09-20 Thread Matthew Garrett
On Fri, Sep 21, 2007 at 11:35:05AM +0900, Tejun Heo wrote: > Matthew Garrett wrote: > > The alternative would be to add a flag to the ap structure indicating > > whether the hotplugging is handled by the firmware or not. If we find a > > reference to a controller or port in the firmware tables, i

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 2

2007-09-20 Thread Tejun Heo
Matthew Garrett wrote: > On Fri, Sep 21, 2007 at 11:35:05AM +0900, Tejun Heo wrote: >> Matthew Garrett wrote: >>> The alternative would be to add a flag to the ap structure indicating >>> whether the hotplugging is handled by the firmware or not. If we find a >>> reference to a controller or port

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 2

2007-09-20 Thread Matthew Garrett
On Fri, Sep 21, 2007 at 11:53:33AM +0900, Tejun Heo wrote: > Maybe just letting both events in is the best idea. It's not like two > duplicate events are gonna break anything and I don't think many vendors > are gonna implement separate mechanism when the default SATA phy based > one works. Work

Re: ATAPI tape drives broken with libata

2007-09-20 Thread Albert Lee
Mark Lord wrote: > > I can read and write the tape successfully, and the written data matches > what is later read back from it. > > Here's the hack I used. Not ready for mainline, but perhaps it will > help Alan or whomever come up with something nice for Jeff. > > --- 2.6.23-rc6/drivers/ata/l

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 2

2007-09-20 Thread Tejun Heo
Matthew Garrett wrote: > On Fri, Sep 21, 2007 at 11:53:33AM +0900, Tejun Heo wrote: > >> Maybe just letting both events in is the best idea. It's not like two >> duplicate events are gonna break anything and I don't think many vendors >> are gonna implement separate mechanism when the default SAT

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 2

2007-09-20 Thread Matthew Garrett
On Fri, Sep 21, 2007 at 12:08:07PM +0900, Tejun Heo wrote: > Yeah, that's the intended behavior. SATA PHY link can break from time > to time (have ever seen a SATA storage box going through ECC testing? > PHY goes offline as soon as you begin to hit it with some EM pulses) and > you don't really

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 2

2007-09-20 Thread Tejun Heo
Matthew Garrett wrote: > On Fri, Sep 21, 2007 at 12:08:07PM +0900, Tejun Heo wrote: > >> Yeah, that's the intended behavior. SATA PHY link can break from time >> to time (have ever seen a SATA storage box going through ECC testing? >> PHY goes offline as soon as you begin to hit it with some EM p

[PATCH] ahci: enable GHC.AE bit before set GHC.HR

2007-09-20 Thread Peer Chen
According to the description of section 5.2.2.1 and 10.1.2 of AHCI specification rev1_1/rev1_2, GHC.HR shall only be set to ¡®1¡¯ by software when GHC.AE is set to ¡®1¡¯. Signed-off-by: Peer Chen <[EMAIL PROTECTED]> --- --- linux-2.6.23-rc7/drivers/ata/ahci.c.orig2007-09-20 11:01:55.0

Re: [patch 05/25] ata: add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-09-20 Thread Zoltan Boszormenyi
Hi, Jeff Garzik írta: [EMAIL PROTECTED] wrote: From: Kuan Luo <[EMAIL PROTECTED]> Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. NCQ function is disable by default, you can enable it with 'swncq=1'. NCQ will be turned off if the drive is Maxtor on MCP51 or

[PATCH] ahci: Add MCP79 support to AHCI driver

2007-09-20 Thread Peer Chen
Add the MCP79 support to ahci driver. The patch base on kernel 2.6.23-rc7 Signed-off-by: Peer Chen <[EMAIL PROTECTED]> --- --- linux-2.6.23-rc7/drivers/ata/ahci.c.orig2007-09-20 11:01:55.0 -0400 +++ linux-2.6.23-rc7/drivers/ata/ahci.c 2007-09-21 13:54:58.0 -0400 @@ -472,6 +47