2.6.23-rc7 - _random_ IRQ23 : nobody cared

2007-09-24 Thread ポール・ ロラン
Hello, I already reported kernel 2.6.23-rcX warning about irq X : nobody cared, and it seemed to have been fixed in 2.6.23-rc6... Unfortunately, just rebooting with my 2.6.23-rc7, I got it appearing again, though the previous boot was just fine, and I didn't change/recompile my kernel in between.

Re: 2.6.23-rc6-mm1: Build failure on ppc64 drivers/ata/pata_scc.c

2007-09-24 Thread Mel Gorman
On (22/09/07 08:20), Satyam Sharma didst pronounce: Hi, On Thu, 20 Sep 2007, Alan Cox wrote: On Thu, 20 Sep 2007 14:13:15 +0100 [EMAIL PROTECTED] (Mel Gorman) wrote: PPC64 building allmodconfig fails to compile drivers/ata/pata_scc.c . It doesn't show up on other arches

Re: [PATCH] ahci: Add MCP79 support to AHCI driver

2007-09-24 Thread Sergei Shtylyov
Hello. Peer Chen wrote: Code change, remove some Device IDs. Signed-off-by: Peer Chen [EMAIL PROTECTED] --- --- linux-2.6.23-rc7/drivers/ata/ahci.c.orig2007-09-20 11:01:55.0 -0400 +++ linux-2.6.23-rc7/drivers/ata/ahci.c 2007-09-24 10:08:03.0 -0400 @@ -472,6 +472,14 @@

Re: 2.6.23-rc7 - _random_ IRQ23 : nobody cared

2007-09-24 Thread David Newall
Paul Rolland (???) wrote: Hell, IRQ 23 is shared between libata and my modem !!! Tried using the modem? - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] ide: remove -ide_dma_check (take 2)

2007-09-24 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Add IDE_HFLAG_TRUST_BIOS_FOR_DMA host flag for host drivers that depend on BIOS for programming device/controller for DMA. Set it in cy82c693, generic, ns87415, opti621 and trm290 host drivers. * Add IDE_HFLAG_VDMA host flag for host drivers using

Re: [PATCH 3/4] ide: make ide_rate_filter() also respect PIO and SW/MW DMA mode masks (take 2)

2007-09-24 Thread Bartlomiej Zolnierkiewicz
On Monday 24 September 2007, Sergei Shtylyov wrote: Once I quothed: Make ide_rate_filter() also respect PIO/SWDMA/MWDMA mode masks. While at it, make the udma_filter() method calls take precedence over using the mode masks. This one not looking to pretty -- I've geve some

Re: What's in linux-2.6-block.git for 2.6.24

2007-09-24 Thread Torsten Kaiser
On 9/23/07, Torsten Kaiser [EMAIL PROTECTED] wrote: On 9/23/07, FUJITA Tomonori [EMAIL PROTECTED] wrote: Can you try Jens's sglist-arch branch? If it works, probably libata in -mm has bugs. For your convenience, I put a sglist-arch branch patch against v2.6.23-rc7:

IDE broken on Pegasos PPC platform

2007-09-24 Thread Chuck Ebbert
Without this patch, taken from a Suse 2.6.22 kernel, the Pegasos PPC machines can't use their IDE interface. Is this the right fix? Bug: https://bugzilla.redhat.com/show_bug.cgi?id=247602 Patch (also below): https://bugzilla.redhat.com/attachment.cgi?id=167747 === The built-in IDE

Re: IDE broken on Pegasos PPC platform

2007-09-24 Thread Alan Cox
On Mon, 24 Sep 2007 15:10:41 -0400 Chuck Ebbert [EMAIL PROTECTED] wrote: Without this patch, taken from a Suse 2.6.22 kernel, the Pegasos PPC machines can't use their IDE interface. Is this the right fix? I believe so yes - To unsubscribe from this list: send the line unsubscribe linux-ide in

ICH9 2 port SATA controller port map?

2007-09-24 Thread Gaston, Jason D
Hello, ICH9 has DeviceID's for 2 port, IDE mode, SATA controllers. The current port map in ata_piix is setup for the 4 port controllers. This seems to work ok, but I wonder if a new port map should be defined for the 2 port controllers, where the two ports are PM, SM? You can refer to the ICH9

Re: [PATCH] ide: remove -ide_dma_check (take 2)

2007-09-24 Thread Bartlomiej Zolnierkiewicz
On Monday 24 September 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: [...] @@ -783,6 +783,23 @@ int ide_tune_dma(ide_drive_t *drive) EXPORT_SYMBOL_GPL(ide_tune_dma); You're converting it to static and yet leaving exportable -- what for? Oversight, export should

[PATCH 1/9] ide_platform: set hwif-chipset

2007-09-24 Thread Bartlomiej Zolnierkiewicz
We need to set hwif-chipset or IDE PCI host drivers may try to claim our ide_hwifs[] slot. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/ide_platform.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/ide/legacy/ide_platform.c

[PATCH 2/9] ide: fix ide_register_hw() to check hwif-io_ports[]

2007-09-24 Thread Bartlomiej Zolnierkiewicz
hwif-hw.io_ports[] and hwif-io_ports[] should be the same but 4drives support and scc_pata host driver set only hwif-io_ports[]. To compensate for this check hwif-io_ports[] instead of hwif-hw.io_ports[] in ide_register_hw() (instead of fixing 4drives and scc_pata because hwif-hw is to be

[PATCH 3/9] icside: use ec-dma directly

2007-09-24 Thread Bartlomiej Zolnierkiewicz
* hwif-hwif_data contains pointer to struct expansion_card so use ec-dma directly instead of caching it in hwif-hw.dma. * Remove no longer needed hw_regs_t.dma and NO_DMA define. Cc: Russell King [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] ---

[PATCH 4/9] ide: remove write-only hwif-hw

2007-09-24 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/icside.c |5 - drivers/ide/arm/rapide.c |4 +--- drivers/ide/ide.c | 15 --- drivers/ide/legacy/ide_platform.c | 11 +--

[PATCH 5/9] au1xxx-ide: set -autotune and -no_io_32bit also for the slave device

2007-09-24 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/mips/au1xxx-ide.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: b/drivers/ide/mips/au1xxx-ide.c === --- a/drivers/ide/mips/au1xxx-ide.c

[PATCH 6/9] dtc2278: set -pio_mask also for the second port

2007-09-24 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/dtc2278.c |1 + 1 file changed, 1 insertion(+) Index: b/drivers/ide/legacy/dtc2278.c === --- a/drivers/ide/legacy/dtc2278.c +++

[PATCH 8/9] ide: replace ide_pci_device_t by struct ide_port_info

2007-09-24 Thread Bartlomiej Zolnierkiewicz
* Rename struct ide_pci_device_s to struct ide_port_info. * Remove ide_pci_device_t typedef. While at it: * Fix __ide_pci_register_driver() comment. * Fix aec62xx_init_one() comment. * Remove unused 'cds' field from ide_hwgroup_t. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]

[PATCH 7/9] via82cxxx: keep local ide_pci_device_t copy

2007-09-24 Thread Bartlomiej Zolnierkiewicz
* Keep local ide_pci_device_t copy in via_init_one(). * Adjust ide_pci_device_t copy according to id-driver_data in via_init_one() and remove no longer needed second via82cxxx_chipsets[] entry. * via82cxxx_chipsets[] - via82cxxx_chipset. * Remove IDE_HFLAGS_VIA define. * Bump driver

[PATCH 9/9] ide: constify struct ide_port_info

2007-09-24 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/aec62xx.c |2 +- drivers/ide/pci/alim15x3.c |2 +- drivers/ide/pci/amd74xx.c |4 ++-- drivers/ide/pci/atiixp.c |2 +- drivers/ide/pci/cmd64x.c |2 +-

libata broken on Pegasos PPC platform (was: Re: IDE broken on Pegasos PPC platform)

2007-09-24 Thread Bartlomiej Zolnierkiewicz
On Monday 24 September 2007, Chuck Ebbert wrote: Without this patch, taken from a Suse 2.6.22 kernel, the Pegasos PPC machines can't use their IDE interface. Is this the right fix? This or use IDE via82cxxx driver. Bug: https://bugzilla.redhat.com/show_bug.cgi?id=247602 Patch (also below):

Re: libata broken on Pegasos PPC platform (was: Re: IDE broken on Pegasos PPC platform)

2007-09-24 Thread Alan Cox
On Mon, 24 Sep 2007 22:58:28 +0200 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: On Monday 24 September 2007, Chuck Ebbert wrote: Without this patch, taken from a Suse 2.6.22 kernel, the Pegasos PPC machines can't use their IDE interface. Is this the right fix? This or use IDE

Re: IDE broken on Pegasos PPC platform

2007-09-24 Thread Matt Sealey
Yeah I'll ack it if it matters, although I'd make a nit about the fixing of device tree entries in prom_init and have it moved to nvramrc or a Forth script or boot loader.. Pegasos IDE quirks have been fixed so many times now in Linux, this code's going to get reshuffled again in other changes,

Re: HSM violation with ahci+WDC WD1600BEVS-22RST0

2007-09-24 Thread Maurizio Monge
No, i did not manage to improve (it should NOT be a dangerous error BTW). I simply think that this issue is because of buggy firmware, so i posted to linux-ide a patch to blacklist this hard disk from using NCQ (because it is triggering spurious completions). I don't know what the blacklisting

Re: CompactFlash and HD unhappy together on the same IDE channel

2007-09-24 Thread Mark Lord
Alan Cox wrote: The solution is beginning to look more and more obvious: default to not use MDMA modes for CF devices at boot. And eventually provide a sysfs or libata parameter (or support/snoop SET_XFER_MODE) to change the mode later. I strongly disagree. We need to understand *why*, we

[patch 0/2] SATA Link Power Management patches

2007-09-24 Thread Kristen Carlson Accardi
Here's a set of patches which implement link power management for SATA. We had talked at kernel summit of moving sysfs interface for setting the link power management policy to the block layer, but after a lot of consideration, I think this doesn't make sense. Mainly because I feel for SATA the

[patch 1/2] Enable link power management for ata drivers

2007-09-24 Thread Kristen Carlson Accardi
Device Initiated Power Management, which is defined in SATA 2.5 can be enabled for disks which support it. This patch enables DIPM when the user sets the link power management policy to min_power. Additionally, libata drivers can define a function (enable_pm) that will perform hardware specific

[patch 2/2] Enable Aggressive Link Power management for AHCI controllers.

2007-09-24 Thread Kristen Carlson Accardi
This patch will set the correct bits to turn on Aggressive Link Power Management (ALPM) for the ahci driver. This will cause the controller and disk to negotiate a lower power state for the link when there is no activity (see the AHCI 1.x spec for details). This feature is mutually exclusive

Re: CompactFlash and HD unhappy together on the same IDE channel

2007-09-24 Thread Alan Cox
But when we see a CF card on a *SATA* controller, we *know* there's a bridge chip in there someplace, and we know that the common bridges don't do MWDMA. If we see CF on SATA we already should kill the MWDMA modes as we'll see word 95 showing SATA if the bridge is properly implemented. I

[PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 3

2007-09-24 Thread Matthew Garrett
Modern laptops with hotswap bays still tend to utilise a PATA interface on a SATA bridge, generally with the host controller in some legacy emulation mode rather than AHCI. This means that the existing hotplug code in libata is unable to work. The ACPI specification states that these devices

[patch] ata: libata: add per device private data

2007-09-24 Thread Kristen Carlson Accardi
Allow host controllers to store private data per device. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] --- include/linux/libata.h |3 +++ 1 file changed, 3 insertions(+) Index: libata-dev/include/linux/libata.h ===

Re: [patch 1/2] Enable link power management for ata drivers

2007-09-24 Thread roel
Kristen Carlson Accardi wrote: Device Initiated Power Management, which is defined in SATA 2.5 can be enabled for disks which support it. This patch enables DIPM when the user sets the link power management policy to min_power. Additionally, libata drivers can define a function

Re: [patch 1/2] Enable link power management for ata drivers

2007-09-24 Thread Davide Libenzi
On Tue, 25 Sep 2007, roel wrote: + if (!(ap-flags ATA_FLAG_IPM) || !ata_dev_enabled(dev)) { if (!((ap-flags ATA_FLAG_IPM) ata_dev_enabled(dev))) { int foo(int i, int j) { return !(i 8) || !j; } int moo(int i, int j) { return !((i 8) j); }

Re: [patch 1/2] Enable link power management for ata drivers

2007-09-24 Thread Kristen Carlson Accardi
On Tue, 25 Sep 2007 01:12:32 +0200 roel [EMAIL PROTECTED] wrote: #define ata_id_cdb_intr(id)(((id)[0] 0x60) == 0x20) +#define ata_id_has_hipm(id)\ + ( (((id)[76] != 0x) ((id)[76] != 0x)) \ + ((id)[76] (1 9)) ) ^ | are you

Re: [patch 1/2] Enable link power management for ata drivers

2007-09-24 Thread Jeff Garzik
Kristen Carlson Accardi wrote: On Tue, 25 Sep 2007 01:12:32 +0200 roel [EMAIL PROTECTED] wrote: #define ata_id_cdb_intr(id)(((id)[0] 0x60) == 0x20) +#define ata_id_has_hipm(id)\ + ( (((id)[76] != 0x) ((id)[76] != 0x)) \ + ((id)[76] (1 9)) )

Re: [patch 1/2] Enable link power management for ata drivers

2007-09-24 Thread roel
Davide Libenzi wrote: On Tue, 25 Sep 2007, roel wrote: + if (!(ap-flags ATA_FLAG_IPM) || !ata_dev_enabled(dev)) { if (!((ap-flags ATA_FLAG_IPM) ata_dev_enabled(dev))) { int foo(int i, int j) { return !(i 8) || !j; } int moo(int i, int j) {

Re: Re: [PATCH] ahci: Add MCP79 support to AHCI driver

2007-09-24 Thread Peer Chen
Yes,they all belong to AHCI controllers, 4 of them use ahci class code and others use RAID class code. -- Peer Chen 2007-09-25 - ·¢¼þÈË£ºSergei Shtylyov ·¢ËÍÈÕÆÚ£º2007-09-24 20:53:44

[PATCH] sata_nv,ahci: add the ahci legacy mode support to sata_nv

2007-09-24 Thread Peer Chen
Add the ahci controller legacy mode support to sata_nv. Move the DIDs of legacy mode from ahci.c to sata_nv.c The patch base on kernel 2.6.23-rc8 Signed-off-by: Peer Chen [EMAIL PROTECTED] --- diff -uprN -X linux-2.6.23-rc8-vanilla/Documentation/dontdiff

Re: What's in linux-2.6-block.git for 2.6.24

2007-09-24 Thread Torsten Kaiser
On 9/24/07, Torsten Kaiser [EMAIL PROTECTED] wrote: I will keep on using 2.6.23-rc7-mm1 and post again, if the error shows up again. On the next boot it did show up again, so 2.6.23-rc7-mm1 still has the bug. [ 33.81] md1: bitmap initialized from disk: read 10/10 pages, set 0 bits [