Re: Serial ATA does not find partitions (Hitachi HD, new? ATI controller) where old SATA works

2007-10-02 Thread Tejun Heo
Hernan Gustavo Solari wrote: Tejun netconsole, pritty nice debunging system... but (yes, there is always a but) it does not get to run. the method was well implemented, adding the acpi=off it sends the information to the receiving machine (I can even see passing a netconsole probing

Re: ICH9 2 port SATA controller port map?

2007-10-02 Thread Tejun Heo
Gaston, Jason D wrote: What is the difference between NA and RV? If the controller only has access to 2 ports, does it matter which I set the nonexistent port values to in the map? NA is used for unimplemented ports of a valid configuration while RV is used to mark invalid MAP value. So, NA

Re: PMP Patchset against 2.6.22.latest 2.6.23.latest

2007-10-02 Thread Tejun Heo
Daniel Schroeder wrote: Hello Tejun, i am stuck with 2.6.22.1 because this is the latest version of your PMP patchset...this is perfectly working but i can not apply these set against newer versions of the kernel...could you update your homepage or post a howto/message/link for instructions

Re: Promise SATA300 TX4: errors, oops in ext3 code

2007-10-02 Thread Clemens Koller
Alexander Sabourenkov schrieb: Have you checked your memory already (memtest86)? [...] Again... sounds like bad memory to me. Nightly memtest86 run : 11 hours, 23 passes, 0 errors. Okay, I have no idea about any bugs there. You have several options: Find a 100% working vanilla kernel for

Re: [PATCH] blacklist NCQ on Seagate Barracuda ST380817AS

2007-10-02 Thread Tejun Heo
Hello, Mark Lord wrote: Mmm.. $66 for open box. But the drive itself has been discontinued by Seagate, Couldn't find any in SUSE and I don't think I can't find any vendor who still carries the drive here. and once claimed to be World's first SATA desktop drive with NCQ.. Probably buggy

Re: Promise SATA300 TX4: errors, oops in ext3 code

2007-10-02 Thread Alexander Sabourenkov
Clemens Koller wrote: Okay, I have no idea about any bugs there. You have several options: Find a 100% working vanilla kernel for your problem (minimal configuration, skip i.e. the sound stuff, ...). And then git bisect with a known bad kernel. I'm afraid there is no 100% working kernel.

Re: Serial ATA does not find partitions (Hitachi HD, new? ATI controller) where old SATA works

2007-10-02 Thread Hernan G Solari
netconsole, pritty nice debunging system... but (yes, there is always a but) it does not get to run. the method was well implemented, adding the acpi=off it sends the information to the receiving machine (I can even see passing a netconsole probing message in the machine under testing), but

Re: [smartmontools-support] sata_sil24 with port multiplier

2007-10-02 Thread Bruce Allen
Jon: always nice when computers act like finite-state machines, not like incomprehensible organic devices. Tejun: thanks again. Cheers, Bruce On Sat, 29 Sep 2007, Jon Chelton wrote: Thanks Bruce and Tejun, I have replaced the hot swap drive tray of the drive in question, rebooted

Re: [PATCH 4/4] hpt366: MWDMA filter for SATA cards (take 2)

2007-10-02 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: The Marvell bridge chips used on HighPoint SATA cards do not seem to support the MWDMA modes (at least that caould be seen in their so-called drivers :-), so the driver needs to account for this -- to achieve this: - add mdma_filter() method from the original

Re: [PATCH 1/15] ali14xx: fix deadlock on error handling

2007-10-02 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Stop abusing ide_lock lock by switching to a private locking. Fixes same issue as fixed by Alan Cox in atiixp host driver with Has been also fixed in the piix driver. commit 6c5f8cc33eb2e10b6ab788bbe259fc142a068627. Heh, I've looked hard at the

Re: Polling (was Re: [PATCHSET 2/2] implement PMP support, take 6)

2007-10-02 Thread Jeff Garzik
Tejun Heo wrote: Jeff Garzik wrote: Mark Lord wrote: Linux kernel development is supposed to happen incrementally nowadays. Get a nice working solution in place, and then enhance/tune it. It's not about enhancing and tuning. It's about me (and/or James B) having to __undo__ the current code,

Re: [PATCH 3/15] qd65xx: fix deadlock on error handling

2007-10-02 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Stop abusing ide_lock lock (switch to a private locking). Fixes same issue as fixed by Alan Cox in atiixp host driver with commit 6c5f8cc33eb2e10b6ab788bbe259fc142a068627. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Index:

Re: [PATCH 9/15] cs5530: remove needless ide_lock taking

2007-10-02 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 5/15] slc90e66: fix deadlock on error handling

2007-10-02 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Stop abusing ide_lock lock (switch to a private locking). Fixes same issue as fixed by Alan Cox in atiixp host driver with commit 6c5f8cc33eb2e10b6ab788bbe259fc142a068627. ... and in the piix as well. Since I failed to see what could lead to this

Re: [PATCH 3/15] qd65xx: fix deadlock on error handling

2007-10-02 Thread Jeff Garzik
Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Stop abusing ide_lock lock (switch to a private locking). Fixes same issue as fixed by Alan Cox in atiixp host driver with commit 6c5f8cc33eb2e10b6ab788bbe259fc142a068627. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]

Re: Polling (was Re: [PATCHSET 2/2] implement PMP support, take 6)

2007-10-02 Thread Mark Lord
Jeff Garzik wrote: Tejun Heo wrote: Jeff Garzik wrote: Mark Lord wrote: Linux kernel development is supposed to happen incrementally nowadays. Get a nice working solution in place, and then enhance/tune it. It's not about enhancing and tuning. It's about me (and/or James B) having to

Re: [PATCH 15/15] ide: remove stale comments from ide-taskfile.c

2007-10-02 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 10/15] ide: enhance ide_setup_pci_noise()

2007-10-02 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Print PCI device Vendor ID, Device ID and revision in ide_setup_pci_noise(). * Remove no longer needed PCI device revision printing from ide_setup_pci_controller(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei

Re: [PATCH 14/15] ide: remove dead code from ide_driveid_update()

2007-10-02 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * Remove dead code from ide_driveid_update(). While at it: * Remove useless comment. * s/HWIF(drive)/drive-hwif/ Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe

Re: Polling (was Re: [PATCHSET 2/2] implement PMP support, take 6)

2007-10-02 Thread Jeff Garzik
Mark Lord wrote: Jeff Garzik wrote: Tejun Heo wrote: Jeff Garzik wrote: Mark Lord wrote: Linux kernel development is supposed to happen incrementally nowadays. Get a nice working solution in place, and then enhance/tune it. It's not about enhancing and tuning. It's about me (and/or James

Re: [PATCH 9/15] cs5530: remove needless ide_lock taking

2007-10-02 Thread Alan Cox
- spin_lock_irqsave(ide_lock, flags); - /* all CPUs (there should only be one CPU with this chipset) */ - NAK What about pre-emptible kernels. Put in a private lock. Alan - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL

Re: [PATCH 1/15] ali14xx: fix deadlock on error handling

2007-10-02 Thread Alan Cox
On Tue, 02 Oct 2007 16:46:28 +0400 Sergei Shtylyov [EMAIL PROTECTED] wrote: Bartlomiej Zolnierkiewicz wrote: Stop abusing ide_lock lock by switching to a private locking. Fixes same issue as fixed by Alan Cox in atiixp host driver with Has been also fixed in the piix driver.

Re: [PATCH] blacklist NCQ on Seagate Barracuda ST380817AS

2007-10-02 Thread Paolo Ornati
On Tue, 02 Oct 2007 18:19:14 +0900 Tejun Heo [EMAIL PROTECTED] wrote: Yeah, World's first is a pretty good clue indicating broken. Blacklisting it seems like a good idea after all. OT: I cannot test anything NCQ related for a while because the Intel Mobo departed yesterday, so I'm on a

Re: [PATCH] pata_hpt3x2n: Clean up DPLL stuff

2007-10-02 Thread Alan Cox
On Mon, 01 Oct 2007 17:12:03 +0400 Sergei Shtylyov [EMAIL PROTECTED] wrote: Hello. Alan Cox wrote: Nobody commented when I asked for review earlier so it must be ok 8) It's not that I've seen this before so it must be ok 8) Not by me at least, so let me NAK it. 8-)

Re: Polling (was Re: [PATCHSET 2/2] implement PMP support, take 6)

2007-10-02 Thread Alan Cox
Polling PMP 2.6.24 is completely unacceptable. It screws the 2.6.24 SAS driver releases out of PMP. No PMP in 2.6.24 screws PMP users, who outnumber SAS users by a few thousand to one I suspect. - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to

Re: [PATCH] pata_hpt3x2n: Clean up DPLL stuff

2007-10-02 Thread Jeff Garzik
Alan Cox wrote: On Mon, 01 Oct 2007 17:12:03 +0400 Sergei Shtylyov [EMAIL PROTECTED] wrote: Hello. Alan Cox wrote: Nobody commented when I asked for review earlier so it must be ok 8) It's not that I've seen this before so it must be ok 8) Not by me at least, so let me NAK

Re: Polling (was Re: [PATCHSET 2/2] implement PMP support, take 6)

2007-10-02 Thread Jeff Garzik
Alan Cox wrote: Polling PMP 2.6.24 is completely unacceptable. It screws the 2.6.24 SAS driver releases out of PMP. No PMP in 2.6.24 screws PMP users, who outnumber SAS users by a few thousand to one I suspect. no-PMP-in-2.6.24 is not happening, so that's rather irrelevant. Jeff

Re: [PATCH] Asynchronous scan support for libata

2007-10-02 Thread Jeff Garzik
Matthew Wilcox wrote: Last December, I posted this: http://lwn.net/Articles/213635/ Here's an updated version. It shaves 5 seconds off boot time on my configuration (qla2xxx, emulex, two ata_piix, dual fusion), but could save more or less on other setups. I think I can remove the 'sync'

Re: [patch] Add more device IDs for supporting ATI SB800 SATA controller

2007-10-02 Thread Jeff Garzik
su henry wrote: From: henry su[EMAIL PROTECTED] ATI/AMD SB800 shares some device IDs with SB700, and SB800 adds two more device IDs:0x4394,0x4395. Signed-off-by: henry su[EMAIL PROTECTED] This patch was already applied, on September 20th. It's already upstream in the official Linux kernel,

Re: [PATCH #upstream-fixes] ata_piix: add another TECRA M3 entry to broken suspend list

2007-10-02 Thread Jeff Garzik
Tejun Heo wrote: There's a different version of DMI table for TECRA M3 where it has proper vendor and product name entry. Add the entry to the broken suspend list. Angus Turnbull reported and provided initial patch. Signed-off-by: Tejun Heo [EMAIL PROTECTED] Cc: Angus Turnbull [EMAIL

Re: [PATCH -mm] libata: add human-readable error value decoding v3

2007-10-02 Thread Jeff Garzik
Robert Hancock wrote: This adds human-readable decoding of the ATA status and error registers (similar to what drivers/ide does) as well as the SATA Serror register to libata error handling output. This prevents the need to pore through standards documents to figure out the meaning of the bits

Re: [PATCH 2/7] sata_promise: pdc_freeze() semantic change

2007-10-02 Thread Jeff Garzik
Albert Lee wrote: After checking the current implementations of freeze()/thaw(), it seems only pdc_freeze() does more than simple irq masking. Remove the DMA stop code from pdc_freeze(). Signed-off-by: Albert Lee [EMAIL PROTECTED] --- diff -Nrup

Re: [PATCH] ahci: Add MCP79 support to AHCI driver

2007-10-02 Thread Jeff Garzik
Peer Chen wrote: Code change, remove some Device IDs. Signed-off-by: Peer Chen [EMAIL PROTECTED] --- --- linux-2.6.23-rc7/drivers/ata/ahci.c.orig2007-09-20 11:01:55.0 -0400 +++ linux-2.6.23-rc7/drivers/ata/ahci.c 2007-09-24 10:08:03.0 -0400 @@ -472,6 +472,14 @@ static const

Re: [PATCH]

2007-10-02 Thread Jeff Garzik
Alan Cox wrote: Correct handling of SRST reset sequences. After an SRST it is undefined whether the drive has gone back to PIO0. In order to talk safely we should talk slowly and carefully until we know. Thus when we do the reset if the controller has a pio setup method we call it to flip back

Re: [PATCH]

2007-10-02 Thread Alan Cox
Should this be queued for 2.6.24? The note I have on this is low priority, make sure it gets testing in -mm first Its been tested without any reports. There are two things it sorts out #1 non x86 systems with firmware that doesn't init the chip into PIO0 (not many as most chips power up

Re: PMP Patchset against 2.6.22.latest 2.6.23.latest

2007-10-02 Thread Daniel Schroeder
Jeff Garzik wrote: Daniel Schroeder wrote: i am stuck with 2.6.22.1 because this is the latest version of your PMP patchset...this is perfectly working but i can not apply these set against newer versions of the kernel...could you update your homepage or post a howto/message/link for

pata_acpi resend?

2007-10-02 Thread Jeff Garzik
As mentioned at the kernel summit... requesting that somebody send me a single patch that adds pata_acpi to the kernel (with all pata_acpi fixes and updates rolled into that patch). Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message

Re: [PATCH]

2007-10-02 Thread Jeff Garzik
Alan Cox wrote: Correct handling of SRST reset sequences. After an SRST it is undefined whether the drive has gone back to PIO0. In order to talk safely we should talk slowly and carefully until we know. Thus when we do the reset if the controller has a pio setup method we call it to flip back

Re: sil24 PMP works with ST3500641AS but not HDS721010KLA330

2007-10-02 Thread Marc MERLIN
On Tue, Oct 02, 2007 at 10:04:45AM -0700, Marc MERLIN wrote: Howdy, I've had a system with 2.6.22.1 for a while, running 10 drives behind a PMP on a sil24 card with no problems. I forgot a couple of details: the PMP is a sil 3726CB the sil24 card is a 3124 Marc -- A mouse is a device used

[git patch] libata fix

2007-10-02 Thread Jeff Garzik
Make another laptop's suspend work. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/ata_piix.c |7 +++ 1 files changed, 7 insertions(+), 0 deletions(-) Tejun

sil24 PMP works with ST3500641AS but not HDS721010KLA330

2007-10-02 Thread Marc MERLIN
Howdy, I've had a system with 2.6.22.1 for a while, running 10 drives behind a PMP on a sil24 card with no problems. Recently, I swapped 5 250GB drives with 5 TB drives. The 5 TB drives eventually get detected, but do not work reliably. Details are below. This is all on

Re: pata_acpi resend?

2007-10-02 Thread Andrew Morton
On Tue, 02 Oct 2007 12:40:10 -0400 Jeff Garzik [EMAIL PROTECTED] wrote: As mentioned at the kernel summit... requesting that somebody send me a single patch that adds pata_acpi to the kernel (with all pata_acpi fixes and updates rolled into that patch). Later today... - To unsubscribe

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 3

2007-10-02 Thread Matthew Garrett
On Tue, Oct 02, 2007 at 11:04:41AM -0400, Jeff Garzik wrote: 1) Check dev-sdev for NULL Ok. 2) remove the unnecessary ata_device loop. If you know the ata_device pointer, you should not throw it away and then do a search to find it again. You need two functions, ata_acpi_ap_notify() and

[PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 4

2007-10-02 Thread Matthew Garrett
Modern laptops with hotswap bays still tend to utilise a PATA interface on a SATA bridge, generally with the host controller in some legacy emulation mode rather than AHCI. This means that the existing hotplug code in libata is unable to work. The ACPI specification states that these devices

Re[2]: Sata Sil3512 bug?

2007-10-02 Thread MisterE
Hello Tejun, I build another setup with almost the same hardware. This motherboard had already the latest bios. I notice that the computer does almost never find the hard drive although the controller is found every time (with lspci). So i get no drive (sda) assigned. I don't always see the bios

Re: [PATCH 3/3] ide: add CONFIG_IDE_ARCH_OBSOLETE_INIT

2007-10-02 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Add CONFIG_IDE_ARCH_OBSOLETE_INIT to drivers/ide/Kconfig and use it instead of defining IDE_ARCH_OBSOLETE_INIT in arch/ide.h. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] include/asm-arm26/ide.h |1 - No such file

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 4

2007-10-02 Thread Jeff Garzik
Jeff Garzik wrote: Matthew Garrett wrote: Modern laptops with hotswap bays still tend to utilise a PATA interface on a SATA bridge, generally with the host controller in some legacy emulation mode rather than AHCI. This means that the existing hotplug code in libata is unable to work. The

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 4

2007-10-02 Thread Matthew Garrett
On Tue, Oct 02, 2007 at 04:38:19PM -0400, Jeff Garzik wrote: Come on, dude! This doesn't even build: Crap, sorry, I've pulled that from the wrong tree. I'll grab you a working one now. -- Matthew Garrett | [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe

[patch 02/10] libata: implement ata_wait_after_reset()

2007-10-02 Thread akpm
From: Tejun Heo [EMAIL PROTECTED] On certain device/controller combination, 0xff status is asserted after reset and doesn't get cleared during 150ms post-reset wait. As 0xff status is interpreted as no device (for good reasons), this can lead to misdetection on such cases. This patch implements

[patch 04/10] Ata: pata_marvell, use ioread* for iomap-ped memory

2007-10-02 Thread akpm
From: Jiri Slaby [EMAIL PROTECTED] pata_marvell, use ioread* for iomap-ped memory read* on pci_iomapped memory is incorrect, fix it Signed-off-by: Jiri Slaby [EMAIL PROTECTED] Acked-by: Alan Cox [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/ata/pata_marvell.c |

[patch 07/10] libata: expose AN to user space

2007-10-02 Thread akpm
From: Kristen Carlson Accardi [EMAIL PROTECTED] If Asynchronous Notification of media change events is supported, pass that information up to the SCSI layer. Signed-off-by: Kristen Carlson Accardi [EMAIL PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Cc: Tejun Heo [EMAIL PROTECTED] Cc: James

[patch 06/10] scsi: expose AN support to user space

2007-10-02 Thread akpm
From: Kristen Carlson Accardi [EMAIL PROTECTED] If a scsi_device supports async notification for media change, then let user space know this capability exists by creating a new sysfs entry media_change_notify, which will be 1 if it is supported, and 0 if not supported. Create a routine which

[patch 05/10] drivers/ata/pata_ixp4xx_cf.c: ioremap return code check

2007-10-02 Thread akpm
From: Scott Thompson [EMAIL PROTECTED] Add missing ioremap return checks. Signed-off-by: Scott Thompson postfail at hushmail.com Acked-by: Tejun Heo [EMAIL PROTECTED] Cc: Alan Cox [EMAIL PROTECTED] Signed-off-by: Andrew Morton [EMAIL PROTECTED] --- drivers/ata/pata_ixp4xx_cf.c |3 +++ 1

[patch 10/10] libata: fix (hopefully) all the remaining problems with devices failing setup/identify

2007-10-02 Thread akpm
From: Alan [EMAIL PROTECTED] Two fixes in this test patch. One of them allows old CF cards to refuse pio mode setting, and one to wait for the drive to settle after a set features changes the speed settings, which is based upon the workarounds used by drivers/ide. Please test and report back if

[patch 09/10] libata_scsi: Fix transfer lengths

2007-10-02 Thread akpm
From: Alan Cox [EMAIL PROTECTED] This should get into the base tree very soon anyway but it fixes a ton of devices so it would be nice to have in -mm so I can get people to test -mm not -mm + a bit when reporting ATAPI problems. Signed-off-by: Alan Cox [EMAIL PROTECTED] Signed-off-by: Andrew

Re: [PATCH 3/3] ide: add CONFIG_IDE_ARCH_OBSOLETE_INIT

2007-10-02 Thread Bartlomiej Zolnierkiewicz
On Tuesday 02 October 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Add CONFIG_IDE_ARCH_OBSOLETE_INIT to drivers/ide/Kconfig and use it instead of defining IDE_ARCH_OBSOLETE_INIT in arch/ide.h. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]

Re: [PATCH 9/15] cs5530: remove needless ide_lock taking

2007-10-02 Thread Bartlomiej Zolnierkiewicz
On Tuesday 02 October 2007, Alan Cox wrote: - spin_lock_irqsave(ide_lock, flags); - /* all CPUs (there should only be one CPU with this chipset) */ - NAK What about pre-emptible kernels. Put in a private lock. All the removed code resided in init_chipset_cs5530() which is

Re: [PATCH 12/15] ide: remove -dma_master field from ide_hwif_t

2007-10-02 Thread Bartlomiej Zolnierkiewicz
On Tuesday 02 October 2007, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: On Monday 01 October 2007, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: * Convert cmd64x, hpt366 and pdc202xx_old host drivers to use pci_resource_start(hwif-pci_dev, 4) instead of hwif-dma_master.

Re: [PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 4

2007-10-02 Thread Matthew Garrett
Fix libata-acpi.c build failure. Signed-off-by: Matthew Garrett [EMAIL PROTECTED] --- Sorry, I'd diffed the original against libata-dev master rather than ALL. This tidies up the changes. diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c index 6896831..5ebbf16 100644 ---

Re: [PATCH 3/15] qd65xx: fix deadlock on error handling

2007-10-02 Thread Jeff Garzik
Bartlomiej Zolnierkiewicz wrote: ACK everything else (that I snipped)... @@ -303,6 +281,7 @@ static void qd6580_set_pio_mode(ide_driv static int __init qd_testreg(int port) { + static DEFINE_SPINLOCK(qd65xx_lock); unsigned long flags; u8 savereg, readreg; At this

Re: [regression] 2.6.23 sata_mv EH updates broke my 7042 controller

2007-10-02 Thread Jeff Garzik
Olof Johansson wrote: On Mon, Oct 01, 2007 at 06:37:44PM -0400, Jeff Garzik wrote: Olof Johansson wrote: Hardware config in my case: Highpoint 2310 controller PPC (big endian) WD Raptor disk Works fine with the other controller I've been using (SIL24), and works fine if I revert the driver. It

Re: [PATCH 9/15] cs5530: remove needless ide_lock taking

2007-10-02 Thread Alan Cox
All the removed code resided in init_chipset_cs5530() which is called only during the controller initialization. Moreover pata_cs5530 also don't have any locking in cs5530_init_chip(). Fair enough, and I haven't found a reason for the locking being needed from doc reviews (hence its not in

[PATCH] libata: Integrate ACPI-based PATA/SATA hotplug - version 5

2007-10-02 Thread Matthew Garrett
Modern laptops with hotswap bays still tend to utilise a PATA interface on a SATA bridge, generally with the host controller in some legacy emulation mode rather than AHCI. This means that the existing hotplug code in libata is unable to work. The ACPI specification states that these devices can

[PATCH] libata: fix for sata_mv 64KB DMA segments

2007-10-02 Thread Olof Johansson
Fix bug in sata_mv for cases where the IOMMU layer has merged SG entries to larger than 64KB. They need to be split up before being sent to the driver. Just for simplicity's sake, split up at 64K boundary instead of 64K size, since that's what the common code does anyway. Signed-off-by: Olof

Re: sil24 PMP works with ST3500641AS but not HDS721010KLA330

2007-10-02 Thread Marc MERLIN
On Tue, Oct 02, 2007 at 10:04:45AM -0700, Marc MERLIN wrote: Howdy, I've had a system with 2.6.22.1 for a while, running 10 drives behind a PMP on a sil24 card with no problems. Recently, I swapped 5 250GB drives with 5 TB drives. The 5 TB drives eventually get detected, but do not work

Re: sil24 PMP works with ST3500641AS but not HDS721010KLA330

2007-10-02 Thread Tejun Heo
Marc MERLIN wrote: Howdy, I've had a system with 2.6.22.1 for a while, running 10 drives behind a PMP on a sil24 card with no problems. Recently, I swapped 5 250GB drives with 5 TB drives. The 5 TB drives eventually get detected, but do not work reliably. 1. Does booting with fewer

Re: [PATCH 2/2] libata: change the last state of pio read to HSM_ST_IDLE

2007-10-02 Thread Albert Lee
Jeff Garzik wrote: Albert Lee wrote: Patch 2/2: After reading the last pio data block, the HSM is waiting for device to be idle, not waiting for the last interrupt. This patch changes the state after PIO data-in to HSM_ST_IDLE instead of HSM_ST_LAST for accuracy. Signed-off-by: Albert

Re: sil24 PMP works with ST3500641AS but not HDS721010KLA330

2007-10-02 Thread Marc MERLIN
On Wed, Oct 03, 2007 at 12:30:08PM +0900, Tejun Heo wrote: 1. Does booting with fewer number of drives (say 5) help? Boot is ok with 10 drives now with your latest code (20070808 instead of 20070803) 2. Does limiting PHY speed to 1.5Gbps using DIP switch on the harddrive help? Those drives