Re: [PATCH] pata_cs5536: ATA driver for Geode companion chip

2007-10-13 Thread Andrew Paprocki
On 10/11/07, Alan Cox <[EMAIL PROTECTED]> wrote: > On Thu, 11 Oct 2007 03:38:19 -0400 > "Martin K. Petersen" <[EMAIL PROTECTED]> wrote: > > > > > This is a driver for the ATA controller on the Geode CS5536 companion > > chip. The PCI device ID for this device was previously claimed by > > pata_amd

Re: [PATCH #upstream 2/2] libata: track SLEEP state and issue SRST to wake it up

2007-10-13 Thread Andrew Paprocki
Tejun, This patch applied on top of your set works for me. It clears the error mask and completes any ATA_CMD_SLEEP when the drive is already sleeping. I tried `hdparm -Y` twice and it didn't loop like before. Thanks, -Andrew diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c ind

marvell 88SX6081 and linux 2.6.23.1

2007-10-13 Thread jeffunit
I built a kernel, 2.6.23.1 today. My motherboard is an intel stl2, dual pentium 933 motherboard, with about 3gb of ram. I also have a promise tx100 controller with an ata hard drive for the os, and a sony dvdrw drive. There is an intel gigabit ethernet card, and an ati pci video card. I have a

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Al Viro
Proposed addition to icside part, provided that ARM folks ACK it - gets icside to build and AFAICS it's correct: diff --git a/drivers/ata/pata_icside.c b/drivers/ata/pata_icside.c index be30923..842fe08 100644 --- a/drivers/ata/pata_icside.c +++ b/drivers/ata/pata_icside.c @@ -332,12 +332,13 @@ st

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Benjamin Herrenschmidt
On Sun, 2007-10-14 at 00:41 +0200, Bartlomiej Zolnierkiewicz wrote: > On Sunday 14 October 2007, Alan Cox wrote: > > > > > /* Probably a PCI interface... */ > > > > > for (i = IDE_DATA_OFFSET; i <= IDE_STATUS_OFFSET; ++i) > > > > > hw->io_ports[i]

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Bartlomiej Zolnierkiewicz
On Sunday 14 October 2007, Alan Cox wrote: > > > > /* Probably a PCI interface... */ > > > > for (i = IDE_DATA_OFFSET; i <= IDE_STATUS_OFFSET; ++i) > > > > hw->io_ports[i] = data_port + i - > > > > IDE_DATA_OFFSET; > > > > hw-

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Alan Cox
> > > /* Probably a PCI interface... */ > > > for (i = IDE_DATA_OFFSET; i <= IDE_STATUS_OFFSET; ++i) > > > hw->io_ports[i] = data_port + i - IDE_DATA_OFFSET; > > > hw->io_ports[IDE_CONTROL_OFFSET] = ctrl_port; Ok so in actual fact - The piece of cod

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Bartlomiej Zolnierkiewicz
On Saturday 13 October 2007, Alan Cox wrote: > > Comment in pmac_ide_init_hwif_ports() is highly misleading as this function > > returns early only for "normal" IDE PCI devices (pmac_ide_init_hwif_ports() > > can be called outside ide-pmac driver through ppc_ide_md). > > Follow the code you pasted

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Alan Cox
> Comment in pmac_ide_init_hwif_ports() is highly misleading as this function > returns early only for "normal" IDE PCI devices (pmac_ide_init_hwif_ports() > can be called outside ide-pmac driver through ppc_ide_md). Follow the code you pasted > pmif->regbase = (unsigned long) base + 0x2000

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Bartlomiej Zolnierkiewicz
On Saturday 13 October 2007, Alan Cox wrote: > On Sat, 13 Oct 2007 18:25:24 +0200 > Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > > > > > Hi, > > > > highlights of this update: > > > > * Rework of IDE PMAC host driver: bugfixes, removal of the code > > duplicated from the IDE core an

sata_via (VT6420) and WDC WD5000AAJS-22YFA0 not playing together

2007-10-13 Thread Roger Heflin
Hello, I have 4 WDC WD5000AAJS-22YFA0 drives (WD 500GB). 2 appear to be found just fine on a promise controller, 2 connected to a via (VT6420) controller don't appear to happy at all. Moving one of the appearing known good drives that worked on the other controller results in this drive not b

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Alan Cox
On Sat, 13 Oct 2007 18:25:24 +0200 Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> wrote: > > Hi, > > highlights of this update: > > * Rework of IDE PMAC host driver: bugfixes, removal of the code > duplicated from the IDE core and conversion to use the generic > DMA tuning code path (the rew

Re: 2.6.23-mm1

2007-10-13 Thread Jeff Garzik
Torsten Kaiser wrote: On 10/13/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: Torsten Kaiser wrote: 3 boots, all worked. So I'm very sure that was the bug, but I will now do a little load testing... The only strange thing about 2.6.23-mm1 is, that it takes ~4 second more to boot. So, you basicall

Re: 2.6.23-mm1

2007-10-13 Thread Andrew Morton
On Sat, 13 Oct 2007 20:05:19 +0200 "Torsten Kaiser" <[EMAIL PROTECTED]> wrote: > The only thing I noted during load testing (updating Gentoo == > compiling and installing) was, that there seems to be memory leak. > After ~2h 2.5 of my 4Gb where gone. But there where to many things > going on to pi

Re: 2.6.23-mm1

2007-10-13 Thread Torsten Kaiser
On 10/13/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Torsten Kaiser wrote: > > 3 boots, all worked. So I'm very sure that was the bug, but I will now > > do a little load testing... > > > > The only strange thing about 2.6.23-mm1 is, that it takes ~4 second > > more to boot. > > So, you basically

Re: 2.6.23-mm1

2007-10-13 Thread Jeff Garzik
Torsten Kaiser wrote: On 10/13/07, Torsten Kaiser <[EMAIL PROTECTED]> wrote: Wait! I think I found the bug: Its a evil interaction between the above patch and the swncq patch that is applied later. The qc_defer patch removes the old ata_scmd_need_defer that was always called for all drivers and

Re[2]: Sata Sil3512 bug?

2007-10-13 Thread MisterE
Hello Tejun, unfortunately. I today tried to build the array (4x500GB, so it is still building) and i got again a error: Oct 13 12:17:56 fileserver kernel: raid5: device sdc1 operational as raid disk 2 Oct 13 12:17:56 fileserver kernel: raid5: device sdb1 operational as raid disk 1 Oct 13 12:17:

Re: Hitachi disk: spurious completions during NCQ

2007-10-13 Thread Luca
On 10/13/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Wed, 10 Oct 2007 21:03:43 +0200 > Luca Tettamanti <[EMAIL PROTECTED]> wrote: > > > Hello, > > sometimes kernel complains about spurious completions on my new > > notebook: > > > > ata3.00: exception Emask 0x2 SAct 0x407fd SErr 0x0 action 0x

Re: 2.6.23-mm1

2007-10-13 Thread Torsten Kaiser
On 10/13/07, Torsten Kaiser <[EMAIL PROTECTED]> wrote: > Wait! > > I think I found the bug: Its a evil interaction between the above > patch and the swncq patch that is applied later. > The qc_defer patch removes the old ata_scmd_need_defer that was always > called for all drivers and substitutes i

Re: 2.6.23-mm1

2007-10-13 Thread Torsten Kaiser
On 10/13/07, Torsten Kaiser <[EMAIL PROTECTED]> wrote: > On 10/13/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > > Torsten Kaiser wrote: > > > Comparing sata_nv.c from 2.6.23-rc8-mm1 and 2.6.23-mm1 I see two > > > changes, that look suspicious: > > > > > > http://git.kernel.org/?p=linux/kernel/git/jg

Re: 2.6.23-mm1

2007-10-13 Thread Torsten Kaiser
On 10/13/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Torsten Kaiser wrote: > > On 10/13/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > >> Torsten Kaiser wrote: > > I can't follow you on SYNCHRONIZE CACHE. > > The only command written to the syslog in the errors where > > 0x60==ATA_CMD_FPDMA_READ and

Re: [PATCH #upstream 2/2] libata: track SLEEP state and issue SRST to wake it up

2007-10-13 Thread Tejun Heo
Andrew Paprocki wrote: > Tejun, > > I'm able to break my system using this patch. I had a hunch this might > be possible.. :) In short, if you issue a sleep command while the > drive is already sleeping, it puts libata into an infinite loop > resetting the port. I've illustrated the working test a

Re: [PATCH #upstream 1/2] libata: move command post processing to __ata_qc_complete()

2007-10-13 Thread Tejun Heo
Jeff Garzik wrote: > Tejun Heo wrote: >> Some commands need post-processing after successful completion. This >> was done in ata_scsi_qc_complete() till now but command post >> processing doesn't belong to SAT layer. Move them to >> __ata_qc_complete() and, while at it, restructure a bit to ease

Re: 2.6.23-mm1

2007-10-13 Thread Jeff Garzik
Torsten Kaiser wrote: On 10/13/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: Torsten Kaiser wrote: On 10/12/07, Andrew Morton <[EMAIL PROTECTED]> wrote: On Fri, 12 Oct 2007 10:31:42 +0200 "Torsten Kaiser" <[EMAIL PROTECTED]> wrote: Oct 12 10:23:03 treogen smartd[6091]: Device: /dev/sdc, not foun

Re: 2.6.23-mm1

2007-10-13 Thread Torsten Kaiser
On 10/13/07, Jeff Garzik <[EMAIL PROTECTED]> wrote: > Torsten Kaiser wrote: > > On 10/12/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > >> On Fri, 12 Oct 2007 10:31:42 +0200 "Torsten Kaiser" <[EMAIL PROTECTED]> > >> wrote: > >>> Oct 12 10:23:03 treogen smartd[6091]: Device: /dev/sdc, not found in

Re: [linux-2.6.git] IDE/ATA fighting over driver name?

2007-10-13 Thread Alan Cox
On Sat, 13 Oct 2007 06:51:06 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Mike Galbraith wrote: > > Greetings, > > > > Perhaps my .config is dainbramaged. When make oldconfig asked me if I > > wanted CONFIG_PATA_PLATFORM, I said "Damned if I know, go for it". > > > > drivers/ide/legacy/ide_pl

Re: [git patches] libata update

2007-10-13 Thread Jeff Garzik
Andrey Borzenkov wrote: Jeff Garzik wrote: * Asynchronous notification -- finally userspace CD-ROM polling can go away! (NOTE: waiting on James B to apply the piece that actually makes this work...) Does it depend on hardware offering suitable support? What are chances for it to work on 5

Re: 2.6.23-mm1

2007-10-13 Thread Jeff Garzik
Torsten Kaiser wrote: On 10/12/07, Andrew Morton <[EMAIL PROTECTED]> wrote: On Fri, 12 Oct 2007 10:31:42 +0200 "Torsten Kaiser" <[EMAIL PROTECTED]> wrote: Oct 12 10:23:03 treogen smartd[6091]: Device: /dev/sdc, not found in smartd database. hm. Oct 12 10:23:03 treogen [ 105.99] WARNING:

Re: [linux-2.6.git] IDE/ATA fighting over driver name?

2007-10-13 Thread Jeff Garzik
Mike Galbraith wrote: Greetings, Perhaps my .config is dainbramaged. When make oldconfig asked me if I wanted CONFIG_PATA_PLATFORM, I said "Damned if I know, go for it". drivers/ide/legacy/ide_platform.c: .name = "pata_platform", drivers/ata/pata_platform.c:#define DRV_NAME "pata_

Re: 2.6.23-mm1

2007-10-13 Thread Torsten Kaiser
On 10/12/07, Andrew Morton <[EMAIL PROTECTED]> wrote: > On Fri, 12 Oct 2007 10:31:42 +0200 "Torsten Kaiser" <[EMAIL PROTECTED]> wrote: > > Oct 12 10:23:03 treogen smartd[6091]: Device: /dev/sdc, not found in > > smartd database. > > hm. > > > Oct 12 10:23:03 treogen [ 105.99] WARNING: at > > d

Re: [git patches] libata update

2007-10-13 Thread Andrey Borzenkov
Jeff Garzik wrote: > * Asynchronous notification -- finally userspace CD-ROM polling can go > away! > (NOTE: waiting on James B to apply the piece that actually makes this > work...) Does it depend on hardware offering suitable support? What are chances for it to work on 5 years old DVD-ROM?