I get this on ICH5, modular kernel build:
libata version 3.00 loaded.
PCI: Enabling device :00:1f.1 (0005 -> 0007)
ACPI: PCI Interrupt :00:1f.1[A] -> GSI 18 (level, low) -> IRQ 18
PCI: Setting latency timer of device :00:1f.1 to 64
ata4294967295: failed to start port (errno=-19)
^
This patch accomplishes the following goals:
* kill the 'pci_enable_device ret val not checked' warning
* eliminate the incorrect mucking with pci_dev::current_state
via the following changes:
* [minor bug fix] eliminate pci_set_power_state() call in resume,
pci_enable_device() does so for us
From: Randy Dunlap <[EMAIL PROTECTED]>
Fix libata docbook warnings.
Warning(linux-2.6.23-git8//drivers/ata/libata-scsi.c:3251): No description
found for parameter 'dev'
Signed-off-by: Randy Dunlap <[EMAIL PROTECTED]>
---
drivers/ata/libata-scsi.c |2 +-
1 file changed, 1 insertion(+), 1 de
Bartlomiej Zolnierkiewicz wrote:
On Friday 12 October 2007, Jeff Garzik wrote:
[ I just sent this upstream to Andrew and Linus ]
Now that I have nailed down the corruption problem, I can attend to
this... Fun stuff:
* port multiplier support (like an ethernet hub, only dumber)
Great to see
And it becomes obvious I normally do my building and testing on x86-64...
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/pata_cs5536.c |2 --
1 files changed, 0 ins
hi, on a friend's laptop, the DVD drive dies after a short while and
takes down the main HD's DMA down with it, hda has to be reinstantiated
with hdparm -d1 /dev/hda, but hdb (DVD drive) cannot be revived.
tried with both kernel 2.6.17 and 2.6.22/23
here is a link to 50kB+ debug info: http://i
>this was full of spaces, and should be converted to tabs (I did this
>manually)
>
>In the future, make sure to run your patch through
>scripts/checkpatch.pl. Some of that script's complaints are a bit
>insane, but most are good.
>
>> static const struct piix_map_db *piix_map_db_table[] = {
>>
> Yes, hence the recent FIFO drain patches.
>
> But that doesn't make sense for SATA devices, where the FIFO is really
> emulated, and it works on older PATA devices.
The FIFO is emulated on PATA. Basically speaking the device prefetches
data and buffers the irq arrival until the right moment. H
Alan Cox wrote:
+ /* Ancient devices may need us to avoid IORDY */
+ if (ata_pio_need_iordy(dev))
+ tf.nsect = dev->xfer_mode;
+ else
+ tf.nsect = 0x01;
This is wrong logic as I've alredy pointed out: according to the ATA-2
setting *any* PIO mo
> > + /* Ancient devices may need us to avoid IORDY */
> > + if (ata_pio_need_iordy(dev))
> > + tf.nsect = dev->xfer_mode;
> > + else
> > + tf.nsect = 0x01;
>
> This is wrong logic as I've alredy pointed out: according to the ATA-2
> setting *any* PIO mode via 0x08..
The sata_nv update has been in -mm for a while, but couldn't make the
last drop due to last minute bugs.
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/Kconfig |
Sergei Shtylyov wrote:
Jeff Garzik wrote:
Some hardware seems to get this wrong in a non-harmful way, and
there are
some devices that seem to do it deliberately for various reasons.
Just take it as a device error not a catastrophic state machine
explosion.
Signed-off-by: Alan Cox <[EMAI
Alan Cox wrote:
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
applied to libata-dev.git#for-testing (and propagated into #ALL)
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majo
Russell King wrote:
On Mon, Oct 15, 2007 at 03:54:16PM -0400, Jeff Garzik wrote:
Al Viro wrote:
Proposed addition to icside part, provided that ARM folks ACK it - gets
icside to build and AFAICS it's correct:
ACK from me too... ARM folks?
Will test tomorrow/Wednesday.
Thanks. Sorry about
Jeff Garzik wrote:
Some hardware seems to get this wrong in a non-harmful way, and there
are
some devices that seem to do it deliberately for various reasons.
Just take it as a device error not a catastrophic state machine
explosion.
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u
On Mon, Oct 15, 2007 at 03:54:16PM -0400, Jeff Garzik wrote:
> Al Viro wrote:
> >Proposed addition to icside part, provided that ARM folks ACK it - gets
> >icside to build and AFAICS it's correct:
>
> ACK from me too... ARM folks?
Will test tomorrow/Wednesday.
--
Russell King
Linux kernel
Sergei Shtylyov wrote:
Alan Cox wrote:
Some hardware seems to get this wrong in a non-harmful way, and there are
some devices that seem to do it deliberately for various reasons.
Just take it as a device error not a catastrophic state machine
explosion.
Signed-off-by: Alan Cox <[EMAIL PR
Al Viro wrote:
Proposed addition to icside part, provided that ARM folks ACK it - gets
icside to build and AFAICS it's correct:
ACK from me too... ARM folks?
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo
Alan Cox wrote:
Some hardware seems to get this wrong in a non-harmful way, and there are
some devices that seem to do it deliberately for various reasons.
Just take it as a device error not a catastrophic state machine
explosion.
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --exc
Alan Cox wrote:
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
should I be adding this to libata-dev.git#for-testing, to reduce
Andrew's libata patching headaches?
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordom
Hello.
Alan Cox wrote:
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --exclude-from /usr/src/exclude --new-file --recursive
linux.vanilla-2.6.23-mm1/drivers/ata/libata-core.c
linux-2.6.23-mm1/drivers/ata/libata-core.c
--- linux.vanilla-2.6.23-mm1/drivers/ata/libata-core.c 2007-10-15
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --exclude-from /usr/src/exclude --new-file --recursive
linux.vanilla-2.6.23-mm1/drivers/ide/legacy/dtc2278.c
linux-2.6.23-mm1/drivers/ide/legacy/dtc2278.c
--- linux.vanilla-2.6.23-mm1/drivers/ide/legacy/dtc2278.c 2007-10-15
15:03:27.
Andrew Paprocki wrote:
The strn_pattern_cmp routine does not handle a blank name parameter
properly. The only patterns which should match a blank name are "*"
and an explicit "". If the function is passed a blank name in current
code, it will always match against the patt parameter. The bug manif
Tejun Heo wrote:
ST9160821AS / 3.CCD does spurious completions too. Blacklist it.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
drivers/ata/libata-core.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index ce8ccb4..5402755 10064
Tejun Heo wrote:
After commands which can change device configuration, EH is scheduled
to revalidate and reconfigure the device. Host link was incorrectly
used unconditionally when scheduling EH action. This resulted in
bogus revalidation request and mismatched configuration between device
and
Martin K. Petersen wrote:
This is a driver for the ATA controller on the Geode CS5536 companion
chip. The PCI device ID for this device was previously claimed by
pata_amd.c but the PIO timings were not correct. This driver also
works around a bug in some BIOSes that handle unaligned access to t
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --exclude-from /usr/src/exclude --new-file --recursive
linux.vanilla-2.6.23-mm1/drivers/ata/pata_pcmcia.c
linux-2.6.23-mm1/drivers/ata/pata_pcmcia.c
--- linux.vanilla-2.6.23-mm1/drivers/ata/pata_pcmcia.c 2007-10-15
15:03:26.0 +0100
++
Jason Gaston wrote:
This patch adds a port map for ICH9 and ICH8 SATA controllers that have only 2
ports available in that mode.
Signed-off-by: Jason Gaston <[EMAIL PROTECTED]>
--- linux-2.6.23/drivers/ata/ata_piix.c.orig2007-10-09 13:31:38.0
-0700
+++ linux-2.6.23/drivers/ata/at
The patch described by the following excerpt from ChangeLog-2.6.22 makes
it impossible to use UDMA on a Tyan S2707 motherboard (SvrWks CSB5):
commit 2d5eaa6dd744a641e75503232a01f52d0768884c
Author: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Date: Thu May 10 00:01:08 2007 +0200
ide: rewor
ata_check_status() does an SFF compliant check
ata_chk_status() does a generic call to ap->ops->check_status (usually
ata_check_status)
libata-sff uses the wrong one. Hardly suprising given the naming here,
which ought to get fixed to ata_sff_check_status() perhaps ?
Signed-off-by: Alan Cox <[EMA
Some hardware seems to get this wrong in a non-harmful way, and there are
some devices that seem to do it deliberately for various reasons.
Just take it as a device error not a catastrophic state machine
explosion.
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --exclude-from /usr/src/excl
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --exclude-from /usr/src/exclude --new-file --recursive
linux.vanilla-2.6.23-mm1/drivers/ata/libata-core.c
linux-2.6.23-mm1/drivers/ata/libata-core.c
--- linux.vanilla-2.6.23-mm1/drivers/ata/libata-core.c 2007-10-15
15:03:26.0 +0100
++
I guess Windows didn't care about the command so neither did they
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --exclude-from /usr/src/exclude --new-file --recursive
linux.vanilla-2.6.23-mm1/drivers/ata/libata-core.c
linux-2.6.23-mm1/drivers/ata/libata-core.c
--- linux.vanilla-2.6.23-mm1
Hi
Mikael Pettersson wrote:
However, I don't see how the sata_promise changes from 2.6.22 to 2.6.23
can explain this. The only functional changes there are a critical fix
for FastTrack TX4200 (not your card), and support for SATA hotplugging
(not happening here).
So I'm suspecting something in
Hello,
I have a Sony laptop SZ series and I get the message
ata_piix :00:1f.2: invalid MAP value 0
even with 'quiet' in the boot command line. I think it's because of a
controller
with no disk attached, but I am a total newb, so I went to #kernelnewbies and
I was told to post this h
Martin Rogge wrote:
Hi Sergei and Bartlomiej,
I have read in the changelog that both of you got linux kernel patches into
2.6.22-rc1 for the cmd64x driver. I found that some patches introduced in
2.6.22-rc1 break the CMD648 operation of one of my machines. (Actually I
discovered it in 2.6.23
On Sun, 14 Oct 2007, Bartlomiej Zolnierkiewicz wrote:
> > CONFIG_BLK_DEV_IDE_SWARM disabled by default -- that should probably be
> > changed; I'll cook a patch). I guess it is not possible to make everyone
> > happy at once though, so please do not treat it as a hard objection. :-)
>
> Hmm, i
On Monday 15 October 2007, Kalra Ashish-B00888 wrote:
> Thanks for your comments and feedback.
>
> Actually, for PowerPC platforms iowrite32/ioread32 internally call
> writel/readl, which are again mapped to out_le32/in_le32,
This is correct on 6xx and e500 for now, but it's a little more
complic
Hello Arnd,
Thanks for your comments and feedback.
Actually, for PowerPC platforms iowrite32/ioread32 internally call
writel/readl, which are again mapped to out_le32/in_le32,
therefore we will modify our code to use of_iomap() to combine
functionalities of both of_address_to_resource() & ioremap
Had a situation where drivers/ide was compiled in, but I wanted to turn
it off to let the drivers/ata drivers take over. I ended up using ide*=noprobe,
but that was somewhat clumpsy because I wasn't sure how many IDE interfaces
the machine really had.
Add a global ide=off switch to handle this s
On Friday 12 October 2007 23:08:21 Jeff Garzik wrote:
> Bernd Schubert wrote:
> > a) 2.6.23 + sil-patch I posted, this is on a customer system (though my
> > former group), I wouldn't like to use -mm there.
> >
> > b) .config is attached
> >
> > c) attached
> >
> > d) attached (don't get irritaded
On 10/15/07, Don Mullis <[EMAIL PROTECTED]> wrote:
>
> > ata3.00: spurious completions during NCQ issue=0x0 SAct=0x407fd
> > FIS=005040a1:0002
> > ata3.00: cmd 61/08:00:c7:5a:82/00:00:1b:00:00/40 tag 0 cdb 0x0 data 4096 out
> > res 50/00:10:07:5b:82/00:00:1b:00:00/40 Emask 0x2 (HSM vi
MisterE wrote:
Hello,
Alexander, does these problems with the Promise SATA300 TX4 happen to
everyone?
Most probably not, as I think it would have been fixed much faster then.
I was waiting for a) release of 2.6.23, and b) me completing the move to
another flat
to retest all the latest deve
On Sun, 14 Oct 2007 11:21:13 +0200, Peter Favrholdt wrote:
> The problem is solved in 2.6.23.1 regarding the "port slow to respond"
> issue.
>
> I'm using sata_promise on Promise Technology, Inc. PDC40718 (SATA 300
> TX4) (rev 02) and 4 Seagate 500GB ES drives.
>
> Using 2.6.23.1 it is possible
> ata3.00: spurious completions during NCQ issue=0x0 SAct=0x407fd
> FIS=005040a1:0002
> ata3.00: cmd 61/08:00:c7:5a:82/00:00:1b:00:00/40 tag 0 cdb 0x0 data 4096 out
> res 50/00:10:07:5b:82/00:00:1b:00:00/40 Emask 0x2 (HSM violation)
This has been seen with several Hitachi drives.
45 matches
Mail list logo