Re: [PATCH 2/3] libata: extend ata_acpi_cbl_80wire() and fix cable detection in pata_via and pata_amd

2007-11-03 Thread Tejun Heo
Alan Cox wrote: detection. We're basically just trying to follow what BIOS did. Maybe we should return ATA_CBL_PATA_MAYBE_80 unconditionally and implement MAYBE_80 = UNK. Yeah, right. I somehow thought it was close to don't really know but treat as 40c but it's more like don't really know

Re: [PATCH 1/3] libata: implement dev-acpi_init_gtm

2007-11-03 Thread Tejun Heo
Tejun Heo wrote: Jeff Garzik wrote: Tejun Heo wrote: Add dev-acpi_init_gtm and store initial GTM values on host initialization. If the field is valid, ATA_PFLAG_INIT_GTM_VALID flag is set. This is to remember BIOS/firmware programmed initial timing for later use before reset and mode

Re: new errors with sata_sil24 with port multiplier

2007-11-03 Thread Tejun Heo
Jon Chelton wrote: ata2.02: irq_stat 0x02020002, device error via SDB FIS ata2.02: cmd 60/50:00:6f:5b:02/00:00:00:00:00/40 tag 0 cdb 0x0 data 40960 in res 50/00:00:00:00:00/00:00:00:00:00/00 Emask 0x1 (device error) Hmmm... Status register value is weird here. It's reporting device

Re: [PATCH 1/3] libata: implement dev-acpi_init_gtm

2007-11-03 Thread Jeff Garzik
Tejun Heo wrote: Tejun Heo wrote: Jeff Garzik wrote: Tejun Heo wrote: Add dev-acpi_init_gtm and store initial GTM values on host initialization. If the field is valid, ATA_PFLAG_INIT_GTM_VALID flag is set. This is to remember BIOS/firmware programmed initial timing for later use before

Re: Fix ATAPI transfer lengths causes CD writing regression

2007-11-03 Thread Jeff Garzik
Tejun Heo wrote: Does this patch fix the problem? [snip] I hope it does... that patch removes a call to sg_last() and in general cleans up the function a bit, which is nice. Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to

Bart's efforts?

2007-11-03 Thread Greg Freemyer
Jeff / Alan, I mostly lurk here, but I know there is a long term effort/ToDo to move libata away from the SCSI infrastructure. I've also seen that Bart has been making a large number of improvements to drivers/ide over the last little while. From my limited perspective, many changes appear to

Re: [PATCH 01/12] ata/sata_fsl: Update for ata_link introduction

2007-11-03 Thread Jeff Garzik
Li Yang wrote: Update the driver to use the newly added ata_link structure. Signed-off-by: Li Yang [EMAIL PROTECTED] --- drivers/ata/sata_fsl.c | 31 ++- 1 files changed, 18 insertions(+), 13 deletions(-) applied patches 1-12 to #upstream-fixes (2.6.24), thanks

Re: [PATCH] libata: suppress two warnings

2007-11-03 Thread Jeff Garzik
Stephen Rothwell wrote: drivers/ata/libata-core.c:768: warning: 'ata_lpm_enable' defined but not used drivers/ata/libata-core.c:784: warning: 'ata_lpm_disable' defined but not used Signed-off-by: Stephen Rothwell [EMAIL PROTECTED] --- drivers/ata/libata-core.c |4 1 files changed, 4

Re: [2.6 patch] make ata_scsi_lpm_get() static

2007-11-03 Thread Jeff Garzik
Adrian Bunk wrote: ata_scsi_lpm_get() can become static. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] --- 380046f657271be470566bb5c762c1599569bac6 diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c index 93bd36c..c4f0c6c 100644 --- a/drivers/ata/libata-scsi.c +++

Re: [PATCH 2.6.24-rc1] sata_promise: fix endianess bug in ASIC PRD bug workaround

2007-11-03 Thread Jeff Garzik
Mikael Pettersson wrote: The original workaround for the Promise ASIC PRD bug contained an endianess bug which I failed to detect: the adjustment of the last PRD entry's length field applied host arithmetic to little-endian data, which is incorrect on big-endian machines. We have the length

Re: [PATCH] libata: increase 128 KB / cmd limit for ATAPI tape drives

2007-11-03 Thread Jeff Garzik
Tony Battersby wrote: Commands sent to ATAPI tape drives via the SCSI generic (sg) driver are limited in the amount of data that they can transfer by the max_sectors value. The max_sectors value is currently calculated according to the command set for disk drives, which doesn't apply to tape

Re: [PATCH 1/6] libata: fix timing computation in ata_eh_reset()

2007-11-03 Thread Jeff Garzik
Tejun Heo wrote: As jiffies changes asynchronously, it needs to be cached if unchanging timestamp is needed. The code in ata_eh_reset() intended to do that with @now but never actually did it. Fix it. Signed-off-by: Tejun Heo [EMAIL PROTECTED] --- drivers/ata/libata-eh.c |2 +- 1 files

Re: Bart's efforts?

2007-11-03 Thread Jeff Garzik
Greg Freemyer wrote: Jeff / Alan, I mostly lurk here, but I know there is a long term effort/ToDo to move libata away from the SCSI infrastructure. I've also seen that Bart has been making a large number of improvements to drivers/ide over the last little while. From my limited perspective,

Re: [PATCH]libata-acpi: add ACPI _PSx method

2007-11-03 Thread Jeff Garzik
Shaohua Li wrote: Not sure, this is just to call a BIOS routine, but a check should be safer. Thanks! ACPI spec (ver 3.0a, p289) requires IDE power on/off executes ACPI _PSx methods. As recently most PATA drivers use libata, this patch adds _PSx method support in libata. ACPI spec doesn't

Re: [PATCH 6/9] ide: remove 'handler' field from ide_task_t

2007-11-03 Thread Bartlomiej Zolnierkiewicz
On Friday 02 November 2007, Bartlomiej Zolnierkiewicz wrote: * Add IDE_TFLAG_CUSTOM_HANDLER taskfile flag and use it for internal requests which require custom handlers. Check the flag in do_rw_taskfile() and set handler accordingly. * Cleanup ide_init_{specify,restore,setmult}_cmd()

Re: Bart's efforts?

2007-11-03 Thread Greg Freemyer
Thanks, I was just curious. On 11/3/07, Jeff Garzik [EMAIL PROTECTED] wrote: Greg Freemyer wrote: Jeff / Alan, I mostly lurk here, but I know there is a long term effort/ToDo to move libata away from the SCSI infrastructure. I've also seen that Bart has been making a large number of

Re: Bart's efforts?

2007-11-03 Thread Alan Cox
My question is if the drivers/ide infrastructure is slowly moving in the direction of being leverageable by libata when/if it moves out of scsi. Or does the drivers/ide code simply have the wrong kind of plumbing for libata to ever use. I don't think there is anything useful in old IDE that

Re: Bart's efforts?

2007-11-03 Thread Mikael Pettersson
On Sat, 3 Nov 2007 14:10:22 +, Alan Cox wrote: My question is if the drivers/ide infrastructure is slowly moving in the direction of being leverageable by libata when/if it moves out of scsi. Or does the drivers/ide code simply have the wrong kind of plumbing for libata to ever use.

Re: Bart's efforts?

2007-11-03 Thread Felix Miata
On 2007/11/03 14:10 (GMT) Alan Cox apparently typed: I don't think there is anything useful in old IDE that isn't in the new. You mean besides being able to access all existing disk partitions? Google can show you I'm not the only multiboot upgrader with far more than 14 filesystems per disk.

Re: Bart's efforts?

2007-11-03 Thread Alan Cox
I don't think there is anything useful in old IDE that isn't in the new. You mean besides being able to access all existing disk partitions? Google Al Viro vetoed this support in the SCSI core. Take it up with him. The libata layer is happy with lots of partitions but it needs a change for

Re: Bart's efforts?

2007-11-03 Thread Alan Cox
1) there's no libata replacement for the IDE pmac driver This is true currently. David Woodhouse loaned me a Pmac to fix that but it died so thats waiting for the PPC people to do something about it. 2) pata_pdc202xx_old can't do UDMA on my 440BX PIII box Bug # ? 3) pata_legacy doesn't

Re: Suspend to ram regression (2.6.24-rc1-git)

2007-11-03 Thread Arjan van de Ven
On Sat, 3 Nov 2007 02:23:04 -0400 Theodore Tso [EMAIL PROTECTED] wrote: Yep, this fixes suspend/resume on my X61 thinkpad. Interestingly I'm not seeing any power savings with ALPM set to min_power, at least not compared to what I get after suspend and resuming (which mysteriously cause the

[git patches] libata fixes

2007-11-03 Thread Jeff Garzik
Fixes, fixes and more fixes. Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/libata-core.c | 38 --- drivers/ata/libata-eh.c| 148

Re: Bart's efforts?

2007-11-03 Thread Mikael Pettersson
Alan Cox wrote: 2) pata_pdc202xx_old can't do UDMA on my 440BX PIII box Bug # ? No bz # yet, but you and I had a private email conversation about this on March 13 and 15 this year. There's been a couple of recent reports to linux-ide with identical (as far as I can see) issues as I get:

Re: Fix ATAPI transfer lengths causes CD writing regression

2007-11-03 Thread Daniel Drake
Tejun Heo wrote: 4ata2.00: HSM violation: eh_analyze_tf: BUSY|DRQ 3ata2.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen 3ata2.00: cmd a0/00:00:00:0a:00/00:00:00:00:00/a0 tag 0 cdb 0x5a data 10 in 4 res 58/00:02:00:0a:00/00:00:00:00:00/a0 Emask 0x2 (HSM violation) 3ata2.00:

Re: Fix ATAPI transfer lengths causes CD writing regression

2007-11-03 Thread Tejun Heo
Daniel Drake wrote: Tejun Heo wrote: 4ata2.00: HSM violation: eh_analyze_tf: BUSY|DRQ 3ata2.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen 3ata2.00: cmd a0/00:00:00:0a:00/00:00:00:00:00/a0 tag 0 cdb 0x5a data 10 in 4 res 58/00:02:00:0a:00/00:00:00:00:00/a0 Emask 0x2 (HSM

RE: new errors with sata_sil24 with port multiplier

2007-11-03 Thread Jon Chelton
Now that the speed of this drive has been at 1.5gbs, the error has not returned under moderate disk load for 20 or so hours. This is odd because 7 other drives on the same controller are working at 3.0gbs. Jon -Original Message- From: Tejun Heo [mailto:[EMAIL PROTECTED] Sent: Saturday,

Re: new errors with sata_sil24 with port multiplier

2007-11-03 Thread Tejun Heo
Jon Chelton wrote: Now that the speed of this drive has been at 1.5gbs, the error has not returned under moderate disk load for 20 or so hours. This is odd because 7 other drives on the same controller are working at 3.0gbs. The drive is faulty or the connector or something else is wrong with

Re: Fix ATAPI transfer lengths causes CD writing regression

2007-11-03 Thread Albert Lee
Tejun Heo wrote: Daniel Drake wrote: Tejun Heo wrote: 4ata2.00: HSM violation: eh_analyze_tf: BUSY|DRQ 3ata2.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen 3ata2.00: cmd a0/00:00:00:0a:00/00:00:00:00:00/a0 tag 0 cdb 0x5a data 10 in 4 res 58/00:02:00:0a:00/00:00:00:00:00/a0