Hi,
On Monday 05 November 2007, Tejun Heo wrote:
Factor out ata_eh_schedule_probe() from ata_eh_handle_dev_fail() and
ata_eh_recover(). This is to improve maintainability and make future
changes easier.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-eh.c | 37
Bartlomiej Zolnierkiewicz wrote:
-if (!ata_dev_enabled(dev)
-((ehc-i.probe_mask (1 dev-devno))
- !(ehc-did_probe_mask (1 dev-devno {
-ata_eh_detach_dev(dev);
-
On Fri, Nov 02 2007, Kristen Carlson Accardi wrote:
On Thu, 1 Nov 2007 09:41:46 +0100
Jens Axboe [EMAIL PROTECTED] wrote:
On Wed, Oct 31 2007, Jens Axboe wrote:
Hi,
My x60 stopped suspending about two days ago. It just freezes after
printing
Suspending console(s)
Jens Axboe wrote:
On Fri, Nov 02 2007, Kristen Carlson Accardi wrote:
On Thu, 1 Nov 2007 09:41:46 +0100
Jens Axboe [EMAIL PROTECTED] wrote:
On Wed, Oct 31 2007, Jens Axboe wrote:
Hi,
My x60 stopped suspending about two days ago. It just freezes after
printing
Suspending console(s)
where
On Mon, 05 Nov 2007 09:05:48 +0900
Tejun Heo [EMAIL PROTECTED] wrote:
Alan Cox wrote:
Maybe we could set a limit here. If the ATAPI device keeps DRQ=1 and
exceeds the limit, we consider it as HSM violation and have EH handle it.
On a DMA transfer its basically out of our control (and a
The driver used the channel not the device number for deciding where to
load some timing parameters. Also change so that we clear the UDMA field
as the old driver did. Not believed neccessary but does no harm.
Signed-off-by: Alan Cox [EMAIL PROTECTED]
diff -u --new-file --recursive
On Wed, 2007-10-31 at 17:58 +, Alan Cox wrote:
kjournald starting Commit interval 5 seconds
VFS: Mounted root (ext3 filesystem) readonly
Freeing unused kernel memory: 168k freed
(keyboard still echoed onscreen, disk parked)
Adding init=/bin/bash is no better.
So its
On Mon, 05 Nov 2007 07:53:58 -0500
Jeff Garzik [EMAIL PROTECTED] wrote:
Yep, works for me! Can we get this expedited upstream?
If everybody's happy with it, I've got it ready for upstream in
libata-dev.git#dlpm-fix
Jeff
Thanks! It'd be great if you could get it in ASAP.
-
To
On Sunday 04 November 2007, Sergei Shtylyov wrote:
Bartlomiej Zolnierkiewicz wrote:
[PATCH] ide: remove atapi_ireason_t (take 2)
Remove atapi_ireason_t.
While at it:
* replace 'HWIF(drive)' by 'drive-hwif' (or just 'hwif' where possible)
v2:
* v1 had CD and IO bits reversed in
commit 33c1002ed912ac9dacedd5d5b166da3b72d18460 incorrectly changed return
value from '0' to '-1', fix it (ns87415 was the only host driver affected
since it uses both IDE_HFLAG_TRUST_BIOS_FOR_DMA and IDE_HFLAG_NO_ATAPI_DMA).
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
Please pull from:
master.kernel.org:/pub/scm/linux/kernel/git/bart/ide-2.6.git/
to receive the following updates:
drivers/ide/Kconfig| 22 ++
drivers/ide/ide-dma.c |5 +++--
drivers/ide/ide-io.c |5 -
drivers/ide/ide-iops.c |8
- Read frequency correctly
- Correct cable detect handling
- Fix wrong filter test
Signed-off-by: Alan Cox [EMAIL PROTECTED]
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.24-rc1/drivers/ata/pata_hpt37x.c
linux-2.6.24-rc1/drivers/ata/pata_hpt37x.c
---
One or two ancient drives predated the cable spec and didn't sent the
valid bits for the field. I had hoped to leave this out of libata as a
piece of historical annoyance but a recent CD drive shows the same bug so
we have to import support for it.
Same concept as Bartlomiej's changes old IDE
Linus Torvalds wrote:
On Sun, 4 Nov 2007, Jeff Garzik wrote:
The end to CD-ROM polling... newer SATA ATAPI hardware will emit
'asynchronous notification' events when media is changed. This adds
support.
I *really* didn't want to pull this.
Not only is it after the -rc1 period, but I also
* Program register 0x40 in sl82c105_resetproc().
* Remove no longer needed sl82c105_selectproc() and pci_set_drvdata() calls.
Cc: Sergei Shtylyov [EMAIL PROTECTED]
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/pci/sl82c105.c | 34
* Program DMA timings in sl82c105_dma_start() (-dma_start method)
before starting DMA transfer.
* Add sl82c105_dma_end() (-ide_dma_end method) to switch back to
PIO timings when DMA transfer is complete.
* In sl82c105_set_pio_mode() program timings regardless of -using_dma
setting and in
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/ata_piix.c |1 +
drivers/ata/libata-core.c | 39 ---
Hi,
I'ld like to add another disk in the blacklist regarding NCQ
(libata-core.c).
It is the disk model HITACHI HTS541616J9SA00 with rev SB4IC7UP.
Currently there is a similar description,
{ Hitachi HTS541616J9SA00, SB4OC70P, ATA_HORKAGE_NONCQ, },
Notice the difference between SB4IC7UP
On Mon, 5 Nov 2007 22:53:38 + Alan Cox [EMAIL PROTECTED] wrote:
+static u32 hpt374_read_freq(struct pci_dev *pdev)
+{
+ u32 freq;
+ unsigned long io_base = pci_resource_start(pdev, 4);
+ if (PCI_FUNC(pdev-devfn) 1) {
+ struct pci_dev *pdev_0 =
Factor out ata_eh_schedule_probe() from ata_eh_handle_dev_fail() and
ata_eh_recover(). This is to improve maintainability and make future
changes easier.
In the previous revision, ata_dev_enabled() test was accidentally
dropped while factoring out. This problem was spotted by Bartlomiej.
Hello,
This patchset cleans up and improves PATA timing related code and fix
pata_amd transfer mode selection on top of the improvements. This
patchset contains the following tweleve patches.
0001-ata_generic-unindent-loop-in-generic_set_mode.patch
Unindent loop body in generic_set_mode(). This is to ease future
change.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/ata_generic.c | 31 ---
1 files changed, 16 insertions(+), 15 deletions(-)
diff --git a/drivers/ata/ata_generic.c
Export the following xfermode related functions.
* ata_pack_xfermask()
* ata_unpack_xfermask()
* ata_xfer_mask2mode()
* ata_xfer_mode2mask()
* ata_xfer_mode2shift()
* ata_mode_string()
* ata_id_xfermask()
* ata_timing_find_mode()
These functions will be used later by LLD updates. While at it,
* s/ATA_BITS_(PIO|MWDMA|UDMA)/ATA_NR_\1_MODES/g
* Consistently use 0xff to indicate invalid transfer mode (0x00 is
valid for PIO_SLOW).
* Make ata_xfer_mode2mask() return proper mode mask instead of just
the highest bit.
* Sort ata_timing table in increasing xfermode order and update
Finding out matching transfer mode from ACPI GTM values is useful for
other purposes too. Separate out the function and timing tables from
pata_acpi::pacpi_discover_modes().
Other than checking shared-configuration bit after doing
ata_acpi_gtm() in pacpi_discover_modes() which should be safe,
ATA_CBL_PATA_UNK indicates that the cable type can't be determined
from the host side and might be either 80c or 40c. libata applies
drive or other generic limit in this case. However, there are
controllers where both host and drive side detections are
misimplemented and the driver has to rely
ata_acpi_gtm_xfermask() as separated out from pacpi_discover_modes()
has various bugs. Fix them.
* The wrong comparison operator is used when finding for matching
cycle resulting totally bogus result.
* With the comparion operator fixed, boundary condtion handling is
clumsy.
* Setting of
Reimplement ata_acpi_cbl_80wire() using ata_acpi_gtm_xfermask() and
while at it relocate the function below ata_acpi_gtm_xfermask().
New ata_acpi_cbl_80wire() implementation takes @gtm, in both pata_via
and pata_amd, use the initial GTM value. Both are trying to peek
initial BIOS configuration,
Add dev-__acpi_init_gtm and store initial GTM values on host
initialization. If the field is valid, ata_acpi_init_gtm() returns
pointer to the saved GTM structure; otherwise, NULL. This is to
remember BIOS/firmware programmed initial timing for later use before
reset and mode configuration
libata-acpi is using separate timing tables for transfer modes
although libata-core has the complete ata_timing table. Implement
ata_timing_cycle2mode() to look for matching mode given transfer type
and cycle duration and use it in libata-acpi and pata_acpi to replace
private timing tables.
xfer_mask is unsigned int not unsigned long. Change -mode_filter to
take and return unsigned int.
While at it, rename @adev of ata_pci_default_filter() to @dev for
consistency.
Signed-off-by: Tejun Heo [EMAIL PROTECTED]
---
drivers/ata/libata-sff.c |5 +++--
drivers/ata/pata_acpi.c
31 matches
Mail list logo
