[PATCH 1/2] libata: Support PIO polling-only hosts.

2007-11-07 Thread Paul Mundt
By default ata_host_activate() expects a valid IRQ in order to successfully register the host. This patch enables a special case for registering polling-only hosts that either don't have IRQs or have buggy IRQ generation (either in terms of handling or sensing), which otherwise work fine. Hosts

[PATCH 2/2] libata: pata_platform: Support polling-mode configuration.

2007-11-07 Thread Paul Mundt
Some SH boards (old R2D-1 boards) have generally not had working CF under libata, due to both buswidth issues (handled by Aoi Shinkai in 43f4b8c7578b928892b6f01d374346ae14e5eb70), and buggy interrupt controllers. For these sorts of boards simply disabling the IRQ and polling ends up working fine.

Re: sata NCQ blacklist entry

2007-11-07 Thread Tejun Heo
Florian La Roche wrote: Hello all, I've taking email addresses from the last NCQ blacklist changes going into the kernel. This Fujitsu drive also gives me spurious command completions. Detailed output also available at https://bugzilla.redhat.com/show_bug.cgi?id=366181. Let me know if

[PATCH 1/4] libata sata_qstor fix oops on rmmod

2007-11-07 Thread Mark Lord
sata_qstor fix oops on rmmod. sata_qstor likes to disable the chip on module unload, so it provides a libata host_stop method to do this. But in recent kernels, this routine is now called too late, after the PCI mmio resources have already been released. Which produces an oops. This really

[PATCH 4/4] libata sata_qstor conversion to new error handling (EH).

2007-11-07 Thread Mark Lord
sata_qstor conversion to new error handling (EH). Convert sata_qstor to use the newer libata EH mechanisms. Based on earlier work by Jeff Garzik. This belongs in 2.6.24. Signed-off-by: Mark Lord [EMAIL PROTECTED] --- --- old/drivers/ata/sata_qstor.c2007-11-07 09:17:41.0 -0500

[PATCH 3/4] libata sata_qstor workaround for spurious interrupts

2007-11-07 Thread Mark Lord
sata_qstor workaround for spurious interrupts. The qstor hardware generates spurious interrupts from time to time when switching in and out of packet mode. These eventually result in the IRQ being disabled, which kills other devices sharing this IRQ with us. This workaround isn't perfect, but

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread James Andrewartha
Denys Fedoryshchenko wrote: On Tue, 6 Nov 2007 22:15:21 -0800, Andrew Morton wrote On Thu, 1 Nov 2007 23:30:13 +0200 Denys [EMAIL PROTECTED] wrote: Finally i got full DMESG with 1GB card till end. Seems not readable too. scsi0 : sc1200 scsi1 : sc1200 ata1: PATA max UDMA/33 cmd 0x1f0 ctl

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Mark Lord
WRAP ~ #./hdparm -I /dev/hda /dev/hda: ATAPI Write-once device, with non-removable media Model Number: SanDisk SDP3B-16 Serial Number: 24313671615 Firmware Revision: vdd 1.00 Standards: Likely used: 3 Configuration: DRQ response: 50us.

Re: [PATCH 1/2] libata: Support PIO polling-only hosts.

2007-11-07 Thread Paul Mundt
On Wed, Nov 07, 2007 at 09:09:30AM -0500, Mark Lord wrote: Paul Mundt wrote: On Wed, Nov 07, 2007 at 01:09:40PM +, Alan Cox wrote: On Wed, 7 Nov 2007 17:10:52 +0900 Paul Mundt [EMAIL PROTECTED] wrote: By default ata_host_activate() expects a valid IRQ in order to successfully register

Re: [PATCH 2/2] libata: pata_platform: Support polling-mode configuration.

2007-11-07 Thread Alan Cox
+ * Use polling mode if there's no IRQ + */ + if (irq 0) { + ap-flags |= ATA_FLAG_PIO_POLLING; + ata_port_desc(ap, no IRQ, using PIO polling); + } + + /* Zero means no IRQ. Not 0. We enforce that policy across the kernel and Linus has been

[PATCH 2/4] libata sata_qstor nuke idle state

2007-11-07 Thread Mark Lord
sata_qstor nuke idle state. We're really only ever in one of two hardware states: packet, or mmio. Get rid of unnecessary qs_state_idle state. This belongs in 2.6.24. Signed-off-by: Mark Lord [EMAIL PROTECTED] --- --- old/drivers/ata/sata_qstor.c2007-11-07 07:41:28.0 -0500

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Denys Fedoryshchenko
On Tue, 6 Nov 2007 22:15:21 -0800, Andrew Morton wrote On Thu, 1 Nov 2007 23:30:13 +0200 Denys [EMAIL PROTECTED] wrote: Finally i got full DMESG with 1GB card till end. Seems not readable too. Linux version 2.6.24-rc1-git10-embedded ([EMAIL PROTECTED]) (gcc version 4.1.2 (Gentoo 4.1.2

Re: 2.6.24-rc1: pata_amd fails to detect 80-pin wire

2007-11-07 Thread Andrew Morton
(cc: linux-ide) (Rafael: please track as a post-2.623 regression) On Wed, 7 Nov 2007 16:14:10 +0100 Thomas Lindroth [EMAIL PROTECTED] wrote: After upgrading to 2.6.24-rc1 I get the message ata6.00: limited to UDMA/33 due to 40-wire cable. The 2.6.23 kernel does not complain and activates

Re: [PATCH 1/4] libata sata_qstor fix oops on rmmod

2007-11-07 Thread Mark Lord
Mark Lord wrote: This belongs in 2.6.24. Note that without these four patches, sata_qstor is not currently functional in 2.6.24. - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 1/2] libata: Support PIO polling-only hosts.

2007-11-07 Thread Alan Cox
Zero is no IRQ, please use that for polling not 0 However, platform_get_irq() will happily return IRQ#0, and it's a valid vector on plenty of machines. NO_IRQ is also 0 on at least FR-V, ARM, blackin, PA-RISC, some PowerPC, and even IDE. No it is not. The platform IRQ code is

Re: [PATCH 1/2] libata: Support PIO polling-only hosts.

2007-11-07 Thread Alan Cox
On Wed, 7 Nov 2007 17:10:52 +0900 Paul Mundt [EMAIL PROTECTED] wrote: By default ata_host_activate() expects a valid IRQ in order to successfully register the host. This patch enables a special case for registering polling-only hosts that either don't have IRQs or have buggy IRQ generation

Re: [PATCH 1/2] libata: Support PIO polling-only hosts.

2007-11-07 Thread Paul Mundt
On Wed, Nov 07, 2007 at 01:09:40PM +, Alan Cox wrote: On Wed, 7 Nov 2007 17:10:52 +0900 Paul Mundt [EMAIL PROTECTED] wrote: By default ata_host_activate() expects a valid IRQ in order to successfully register the host. This patch enables a special case for registering polling-only

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Denys Fedoryshchenko
On Thu, 08 Nov 2007 00:23:10 +0900, James Andrewartha wrote Denys Fedoryshchenko wrote: On Tue, 6 Nov 2007 22:15:21 -0800, Andrew Morton wrote On Thu, 1 Nov 2007 23:30:13 +0200 Denys [EMAIL PROTECTED] wrote: Finally i got full DMESG with 1GB card till end. Seems not readable too. scsi0 :

Re: [PATCH 1/2] libata: Support PIO polling-only hosts.

2007-11-07 Thread Alan Cox
So I'll change the check to IRQ#0 == invalid, but if that's to be enforced kernel-wide, then all of the existing NO_IRQ cases should be ripped out and set to 0. This way at least people are getting screwed consistently, rather than just in particular subsystems. Thats been gradually

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Denys Fedoryshchenko
On Wed, 07 Nov 2007 14:12:55 -0500, Mark Lord wrote WRAP ~ #./hdparm -I /dev/hda /dev/hda: ATAPI Write-once device, with non-removable media Model Number: SanDisk SDP3B-16 Serial Number: 24313671615 Firmware Revision: vdd 1.00 Standards:

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Denys Fedoryshchenko
This is another flash (1GB probably original Sandisk), 16MB one is called SHARP, and it is 2-4 years old. Maybe it is some noname with incorrect identification data. But it works well in USB card reader. [ 12.434864] ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx

Re: [Bugme-new] [Bug 9320] New: PATA scan: ACPI Exception AE_AML_PACKAGE_LIMIT... is beyond end of object

2007-11-07 Thread Andrew Morton
On Wed, 7 Nov 2007 13:35:00 -0800 (PST) [EMAIL PROTECTED] wrote: http://bugzilla.kernel.org/show_bug.cgi?id=9320 Summary: PATA scan: ACPI Exception AE_AML_PACKAGE_LIMIT... is beyond end of object Product: ACPI Version: 2.5

Re: Should be Acard ATP8620 2SATA / 1 IDE driver

2007-11-07 Thread Jeff Garzik
On Tue, Nov 06, 2007 at 07:25:46PM +0800, jameshsu wrote: Hi Jeff, Please help Acard to add this chip spec on the web site in your earlier conveniance. http://gkernel.sourceforge.net/specs/ http://linux-ata.org/driver-status.html#open_chipsets Updated, thanks much! By the way, once you

Re: Should be Acard ATP8620 2SATA / 1 IDE driver

2007-11-07 Thread Jeff Garzik
On Wed, Nov 07, 2007 at 05:13:55PM -0500, Jeff Garzik wrote: On Tue, Nov 06, 2007 at 07:25:46PM +0800, jameshsu wrote: Please help Acard to add this chip spec on the web site in your earlier conveniance. http://gkernel.sourceforge.net/specs/ BTW, I put the doc in

Re: [Bugme-new] [Bug 9320] New: PATA scan: ACPI Exception AE_AML_PACKAGE_LIMIT... is beyond end of object

2007-11-07 Thread Matthew Garrett
On Wed, Nov 07, 2007 at 02:07:54PM -0800, Andrew Morton wrote: Seems to be another post-2.6.23 regression. Is it an acpi thing or an ata thing, of just something which the new acpi+ata stuff exposed?? I suspect that this is just because acpi is enabled by default on ata now. Is it actually

Re: Bart's efforts?

2007-11-07 Thread Mark Lord
delkin_cb is also missing from libata. I was going to port it over once, but no longer have a cardbus slot in either of my notebooks here. Cheers - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

[PATCH] Re: Should be Acard ATP8620 2SATA / 1 IDE driver

2007-11-07 Thread Jeff Garzik
On Tue, Nov 06, 2007 at 07:25:46PM +0800, jameshsu wrote: By the way, once you complete the SATA sample driver , please inform us , so we could modify, test and submit in the near future. If any chip info still missing or need us to involve, please let me know. Any chance the patch below

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Mark Lord
Denys Fedoryshchenko wrote: On Wed, 07 Nov 2007 14:12:55 -0500, Mark Lord wrote WRAP ~ #./hdparm -I /dev/hda /dev/hda: ATAPI Write-once device, with non-removable media Model Number: SanDisk SDP3B-16 Serial Number: 24313671615 Firmware Revision: vdd 1.00

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Alan Cox
CFA spec requires 848a in word[0], not 844a, which explains why hdparm thought it might be ATAPI. I've updated my hdparm source to detect this for hdparm-7.8 (unreleased). That card (16MB) is definitely buggy. But your other (1GB) card looks fine. Thanks. Somebody else may help with the

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Jeff Garzik
On Wed, Nov 07, 2007 at 02:12:55PM -0500, Mark Lord wrote: That cannot be correct (??). Is this with hdparm-7.7 (latest sourceforge) ?? Can you show us the hdparm --Istdout output as well, please. If this is applicable... FWIW hdparm was only recently (in past 72 hours) updated from 6.9 to

Re: Bart's efforts?

2007-11-07 Thread Alan Cox
On Wed, 07 Nov 2007 17:37:07 -0500 Mark Lord [EMAIL PROTECTED] wrote: delkin_cb is also missing from libata. I was going to port it over once, but no longer have a cardbus slot in either of my notebooks here. Yes I looked at it but it didn't have any proper speed setting, so I decided it

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Mark Lord
Jeff Garzik wrote: On Wed, Nov 07, 2007 at 02:12:55PM -0500, Mark Lord wrote: That cannot be correct (??). Is this with hdparm-7.7 (latest sourceforge) ?? Can you show us the hdparm --Istdout output as well, please. If this is applicable... FWIW hdparm was only recently (in past 72 hours)

Re: [PATCH 4/4] libata sata_qstor conversion to new error handling (EH).

2007-11-07 Thread Jeff Garzik
On Wed, Nov 07, 2007 at 10:54:15AM -0500, Mark Lord wrote: sata_qstor conversion to new error handling (EH). Convert sata_qstor to use the newer libata EH mechanisms. Based on earlier work by Jeff Garzik. This belongs in 2.6.24. Signed-off-by: Mark Lord [EMAIL PROTECTED] Did you test

Re: Bart's efforts?

2007-11-07 Thread Mark Lord
Alan Cox wrote: On Wed, 07 Nov 2007 17:37:07 -0500 Mark Lord [EMAIL PROTECTED] wrote: delkin_cb is also missing from libata. I was going to port it over once, but no longer have a cardbus slot in either of my notebooks here. Yes I looked at it but it didn't have any proper speed setting, so

Re: Bart's efforts?

2007-11-07 Thread Alan Cox
Yeah. No docs whatsoever, but there's more than a few users of it out there. So how do we handle devices that don't support PIO4 ? Other than the speed handling mystery the port is trivial. Alan - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to

Re: [PATCH 4/4] libata sata_qstor conversion to new error handling (EH).

2007-11-07 Thread Mark Lord
Jeff Garzik wrote: On Wed, Nov 07, 2007 at 10:54:15AM -0500, Mark Lord wrote: sata_qstor conversion to new error handling (EH). Convert sata_qstor to use the newer libata EH mechanisms. Based on earlier work by Jeff Garzik. This belongs in 2.6.24. Signed-off-by: Mark Lord [EMAIL PROTECTED]

Re: Bart's efforts?

2007-11-07 Thread Mark Lord
Alan Cox wrote: Yeah. No docs whatsoever, but there's more than a few users of it out there. So how do we handle devices that don't support PIO4 ? .. I'm not actually sure that it's even running that fast (PIO4), as the performance is still only half of what Windoze gets. I have a logic

Re: [PATCH 4/4] libata sata_qstor conversion to new error handling (EH).

2007-11-07 Thread Mark Lord
Mark Lord wrote: .. and SG_IO WRITEs don't work. That's really no different from the existing 2.6.24 version. Regular I/O looks fine. ... I should qualify that: SG_IO *PIO* WRITEs don't work. SG_IO PIO READs do work, and SG_IO DMA R/W both work. Cheers - To unsubscribe from this list: send

Re: [PATCH 4/4] libata sata_qstor conversion to new error handling (EH).

2007-11-07 Thread Jeff Garzik
On Wed, Nov 07, 2007 at 06:36:13PM -0500, Mark Lord wrote: Mark Lord wrote: .. and SG_IO WRITEs don't work. That's really no different from the existing 2.6.24 version. Regular I/O looks fine. ... I should qualify that: SG_IO *PIO* WRITEs don't work. SG_IO PIO READs do work, and SG_IO

Re: SATA eating my disk, port reset, destroying unrelated data

2007-11-07 Thread Robert Hancock
Norbert Preining wrote: Dear all! (please Cc me for answers) Since about 5 days I am having serious problems with my SATA drive: kernel 2.6.22 (from Debian/sid) hardware nv Sometimes at boot time, often/always at disk io intense stuff: ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x40

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Bartlomiej Zolnierkiewicz
On Thursday 08 November 2007, Denys Fedoryshchenko wrote: 2.6.24-rc2 not working very well dmesg [ 12.386395] Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2 [ 12.405579] ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx [ 12.430441] SC1200: IDE

Re: sata NCQ blacklist entry

2007-11-07 Thread Robert Hancock
Tejun Heo wrote: Florian La Roche wrote: Hello all, I've taking email addresses from the last NCQ blacklist changes going into the kernel. This Fujitsu drive also gives me spurious command completions. Detailed output also available at https://bugzilla.redhat.com/show_bug.cgi?id=366181. Let

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Denys Fedoryshchenko
2.6.24-rc2 not working very well dmesg [ 12.386395] Uniform Multi-Platform E-IDE driver Revision: 7.00alpha2 [ 12.405579] ide: Assuming 33MHz system bus speed for PIO modes; override with idebus=xx [ 12.430441] SC1200: IDE controller (0x100b:0x0502 rev 0x01) at PCI slot :00:12.2 [

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Denys Fedoryshchenko
I am using Gentoo (and it is custom build of linux, actually only busybox + kernel + uclibc and few other tools), hdparm is vanilla 7.7 I will try to compile now -rc2 to see if there any changes. With 16MB 2.6.24-rc1 works fine, 1GB working also with some errors in dmesg. And IF that all is

[PATCH #upstream-fixes] libata: skip 0xff polling for PATA controllers

2007-11-07 Thread Tejun Heo
In a presentation of true workmanship, pata_ali asserts IRQ permanantly if the TF status register is read more than once when there's no device attached to the port. Avoid waiting polling for !0xff if it's PATA. It's needed only for some rare SATA devices anyway. This problem is reported by

[PATCH #upstream-fixes] libata: port and host should be stopped before hardware resources are released

2007-11-07 Thread Tejun Heo
Port / host stop calls used to be made from ata_host_release() which is called after all hardware resources acquired after host allocation are released. This is wrong as port and host stop routines often access the hardware. Add separate devres for port / host stop which is invoked right after

Re: [PATCH 13/15] ide: remove hwif-intrproc

2007-11-07 Thread Tejun Heo
Mark Lord wrote: Bartlomiej Zolnierkiewicz wrote: * hpt366.c::hpt3xx_intrproc() is the only user of hwif-intrproc .. Speaking of which.. I believe I have a small PCI card here with an HPT366 chip on it. Does anyone there want it before I throw it away? I already have a 372. It should

[PATCH 2/2 take #2] libata: pata_platform: Support polling-mode configuration.

2007-11-07 Thread Paul Mundt
Some SH boards (old R2D-1 boards) have generally not had working CF under libata, due to both buswidth issues (handled by Aoi Shinkai in 43f4b8c7578b928892b6f01d374346ae14e5eb70), and buggy interrupt controllers. For these sorts of boards simply disabling the IRQ and polling ends up working fine.

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Denys Fedoryshchenko
You are right, seems no dma lines in adapter. hda=nodma helped, no errors anymore. I will try now also libata_dma_mask and will mail result. Btw there is no notes in Documentation/kernel-parameters.txt about it. In any case it is complete board, WRAP.2C made by PCEngines in 2003. Kind of

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-07 Thread Robert Hancock
Denys wrote: Finally i got full DMESG with 1GB card till end. Seems not readable too. .. ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 frozen ata1.00: cmd c8/00:08:00:00:00/00:00:00:00:00/e0 tag 0 cdb 0x0 data 4096 in res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4

Re: [PATCH 13/15] ide: remove hwif-intrproc

2007-11-07 Thread Mark Lord
Bartlomiej Zolnierkiewicz wrote: * hpt366.c::hpt3xx_intrproc() is the only user of hwif-intrproc .. Speaking of which.. I believe I have a small PCI card here with an HPT366 chip on it. Does anyone there want it before I throw it away? -ml - To unsubscribe from this list: send the line

Re: [PATCH 4/4] libata sata_qstor conversion to new error handling (EH).

2007-11-07 Thread Mark Lord
Jeff Garzik wrote: On Wed, Nov 07, 2007 at 06:36:13PM -0500, Mark Lord wrote: Mark Lord wrote: .. and SG_IO WRITEs don't work. That's really no different from the existing 2.6.24 version. Regular I/O looks fine. ... I should qualify that: SG_IO *PIO* WRITEs don't work. SG_IO PIO READs do

[PATCH 1/2 take #2] libata: Support PIO polling-only hosts.

2007-11-07 Thread Paul Mundt
By default ata_host_activate() expects a valid IRQ in order to successfully register the host. This patch enables a special case for registering polling-only hosts that either don't have IRQs or have buggy IRQ generation (either in terms of handling or sensing), which otherwise work fine. Hosts

Re: [PATCH 1/4] libata sata_qstor fix oops on rmmod

2007-11-07 Thread Tejun Heo
Mark Lord wrote: sata_qstor fix oops on rmmod. sata_qstor likes to disable the chip on module unload, so it provides a libata host_stop method to do this. But in recent kernels, this routine is now called too late, after the PCI mmio resources have already been released. Which produces an