Re: [PATCH 13/15] ide: remove hwif-intrproc

2007-11-08 Thread Alan Cox
On Thu, Nov 08, 2007 at 11:43:45AM +0900, Tejun Heo wrote: I believe I have a small PCI card here with an HPT366 chip on it. Does anyone there want it before I throw it away? I already have a 372. It should be almost the same, right? They are not very similar no. HPT37x is a progression

Re: [PATCH] Re: Should be Acard ATP8620 2SATA / 1 IDE driver

2007-11-08 Thread jameshsu
RESEND as TEXT FORMAT - Original Message - From: jameshsu To: Jeff Garzik Cc: Andrew Morton ; IDE/ATA development list ; [EMAIL PROTECTED] ; Matti Aarnio ; James Bottomley ; Jason Wu ; [EMAIL PROTECTED] ; Daniel Weng Sent: Thursday, November 08, 2007 7:28 PM Subject: Re: [PATCH] Re: Should

Re: [PATCH 13/15] ide: remove hwif-intrproc

2007-11-08 Thread Tejun Heo
Alan Cox wrote: On Thu, Nov 08, 2007 at 11:43:45AM +0900, Tejun Heo wrote: I believe I have a small PCI card here with an HPT366 chip on it. Does anyone there want it before I throw it away? I already have a 372. It should be almost the same, right? They are not very similar no. HPT37x is

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-08 Thread Alan Cox
On Thu, 8 Nov 2007 09:16:35 +0200 Denys Fedoryshchenko [EMAIL PROTECTED] wrote: Does it work as kernel parameter? I tried libata_dma_mask=0x4 and to set 0xf or 0xff - doesn't help. How to disable DMA in libata, if it is compiled in kernel? libata.dma_mask=3 will leave you with CD and disk

Re: [PATCH 1/2 take #2] libata: Support PIO polling-only hosts.

2007-11-08 Thread Alan Cox
On Thu, 8 Nov 2007 11:14:56 +0900 Paul Mundt [EMAIL PROTECTED] wrote: By default ata_host_activate() expects a valid IRQ in order to successfully register the host. This patch enables a special case for registering polling-only hosts that either don't have IRQs or have buggy IRQ generation

Re: [PATCH #upstream-fixes] libata: skip 0xff polling for PATA controllers

2007-11-08 Thread Alan Cox
On Thu, 08 Nov 2007 11:20:18 +0900 Tejun Heo [EMAIL PROTECTED] wrote: In a presentation of true workmanship, pata_ali asserts IRQ permanantly if the TF status register is read more than once when there's no device attached to the port. Avoid waiting polling for !0xff if it's PATA. It's

Re:Acard ATP8620 2SATA / 1 IDE driver - AHCI.C Nov082007

2007-11-08 Thread jameshsu
FYI - Original Message - From: LaurenceWu To: jameshsu Cc: Jason Wu ; DerweiChen (陳德威) Sent: Thursday, November 08, 2007 4:34 PM Subject: Re: Should be Acard ATP8620 2SATA / 1 IDE driver Hi James, We didn't study about ata/ahci.c, but it should be based on AHCI1.0 or 1.1 spec. That is,

Re: [PATCH 17/18] ide: cleanup ide_set_dma()

2007-11-08 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: * -dma_off_quietly is always called before ide_set_dma() so the call can be moved inside ide_set_dma(). * ide_dma_check() doesn't touch hardware so -dma_off_quietly call for 'rc == -1' case is redundant, remove it. * '0' and '-1' are the only values

Re: [PATCH 15/18] sc1200: move DMA timings to timing tables

2007-11-08 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: Based on pata_sc1200.c. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Acked-by: Sergei Shtylyov [EMAIL PROTECTED] MBR, Sergei - To unsubscribe from this list: send the line

Re: [PATCH 1/4] libata sata_qstor fix oops on rmmod

2007-11-08 Thread Mark Lord
Mark Lord wrote: sata_qstor fix oops on rmmod. sata_qstor likes to disable the chip on module unload, so it provides a libata host_stop method to do this. But in recent kernels, this routine is now called too late, after the PCI mmio resources have already been released. Which produces an oops.

Re: [PATCH] Re: Should be Acard ATP8620 2SATA / 1 IDE driver

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 07:28:38PM +0800, jameshsu wrote: Not really understand your patch listed below. We do not provide ahci.c file to you, so we don't know where the patch came from(diff from where)?? Who create this and how can we get ahci.c file?? Can you tell us?? The file is found

Re: Acard ATP8620 2SATA / 1 IDE driver - AHCI.C Nov082007

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 07:34:22PM +0800, jameshsu wrote: From: LaurenceWu We didn't study about ata/ahci.c, but it should be based on AHCI1.0 or 1.1 spec. That is, NO P.M. FIS base switching, but supports both non-NCQ and NCQ protocols. For NCQ or nonNCQ, 8620 is very AHCI-like, although

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 06:44:31PM +0200, Denys Fedoryshchenko wrote: Doesn't help WRAP ~ #cat /proc/cmdline console=ttyS0,38400n8 libata.dma_mask=3 It's libata.dma if its built into the kernel, or 'dma' module option if built as a kernel module. Jeff - To unsubscribe from this

Re: libata: cdrw/dvdrom disabed after s2ram (2.6.24-rc2)

2007-11-08 Thread Roberto Oppedisano
Andrew Morton wrote, On 11/07/2007 09:13 PM: On Wed, 07 Nov 2007 15:15:07 +0100 Roberto Oppedisano [EMAIL PROTECTED] wrote: Hello. I noticed that after suspending to ram the DVD-ROM/CDRW drive in no more recognized on my laptop. Looking at dmesg after suspend i found: [5.313446]

Re: libata: cdrw/dvdrom disabed after s2ram (2.6.24-rc2)

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 09:49:58AM -0800, Andrew Morton wrote: On Thu, 08 Nov 2007 17:43:59 +0100 Roberto Oppedisano [EMAIL PROTECTED] wrote: Andrew Morton wrote, On 11/07/2007 09:13 PM: On Wed, 07 Nov 2007 15:15:07 +0100 Roberto Oppedisano [EMAIL PROTECTED] wrote: Hello. I

Re: [PATCH] ata_piix: add SATELLITE PRO U200 to broken suspend list

2007-11-08 Thread Jeff Garzik
On Wed, Nov 07, 2007 at 12:02:27PM +0900, Tejun Heo wrote: From: Yann Chachkoff [EMAIL PROTECTED] Please warmly welcome the PRO variant of Satellite U200 to the broken suspend list. Original patch is from Yann Chachkoff. Patch reformatted and forwarded by Tejun Heo. Signed-off-by:

Re: libata: cdrw/dvdrom disabed after s2ram (2.6.24-rc2)

2007-11-08 Thread Andrew Morton
On Thu, 8 Nov 2007 13:02:56 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: On Thu, Nov 08, 2007 at 09:49:58AM -0800, Andrew Morton wrote: On Thu, 08 Nov 2007 17:43:59 +0100 Roberto Oppedisano [EMAIL PROTECTED] wrote: Andrew Morton wrote, On 11/07/2007 09:13 PM: On Wed, 07 Nov 2007

Re: [PATCH 2/4] libata sata_qstor nuke idle state

2007-11-08 Thread Jeff Garzik
On Wed, Nov 07, 2007 at 10:52:55AM -0500, Mark Lord wrote: sata_qstor nuke idle state. We're really only ever in one of two hardware states: packet, or mmio. Get rid of unnecessary qs_state_idle state. This belongs in 2.6.24. Signed-off-by: Mark Lord [EMAIL PROTECTED] applied patches

Re: [PATCH 1/2 take #2] libata: Support PIO polling-only hosts.

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 11:14:56AM +0900, Paul Mundt wrote: By default ata_host_activate() expects a valid IRQ in order to successfully register the host. This patch enables a special case for registering polling-only hosts that either don't have IRQs or have buggy IRQ generation (either in

Re: [PATCH #upstream-fixes] libata: skip 0xff polling for PATA controllers

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 11:20:18AM +0900, Tejun Heo wrote: In a presentation of true workmanship, pata_ali asserts IRQ permanantly if the TF status register is read more than once when there's no device attached to the port. Avoid waiting polling for !0xff if it's PATA. It's needed only for

Re: [PATCH #upstream-fixes] libata: port and host should be stopped before hardware resources are released

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 01:09:00PM +0900, Tejun Heo wrote: Port / host stop calls used to be made from ata_host_release() which is called after all hardware resources acquired after host allocation are released. This is wrong as port and host stop routines often access the hardware. Add

Re: libata: cdrw/dvdrom disabed after s2ram (2.6.24-rc2)

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 10:13:41AM -0800, Andrew Morton wrote: On Thu, 8 Nov 2007 13:02:56 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: On Thu, Nov 08, 2007 at 09:49:58AM -0800, Andrew Morton wrote: On Thu, 08 Nov 2007 17:43:59 +0100 Roberto Oppedisano [EMAIL PROTECTED] wrote:

Re: libata: cdrw/dvdrom disabed after s2ram (2.6.24-rc2)

2007-11-08 Thread Matthew Garrett
On Thu, Nov 08, 2007 at 10:13:41AM -0800, Andrew Morton wrote: I suspect it wold be best to disable the feature for the 2.6.24 release, then reenable it afterwards and keep doing this until the code is sufficiently stable. GTF method execution failure currently looks like it's fatal, when it

Re: libata: cdrw/dvdrom disabed after s2ram (2.6.24-rc2)

2007-11-08 Thread Andrew Morton
On Thu, 08 Nov 2007 17:43:59 +0100 Roberto Oppedisano [EMAIL PROTECTED] wrote: Andrew Morton wrote, On 11/07/2007 09:13 PM: On Wed, 07 Nov 2007 15:15:07 +0100 Roberto Oppedisano [EMAIL PROTECTED] wrote: Hello. I noticed that after suspending to ram the DVD-ROM/CDRW drive in no more

2.6.24-rc SB600 AHCI no go on =4GB of RAM

2007-11-08 Thread Srihari Vijayaraghavan
(Same symptoms/behaviour as before: http://marc.info/?l=linux-idem=117949823328798w=2 http://marc.info/?t=11781097043r=1w=2) With mem=3500M all is well, otherwise it goes on reseting the ports in a loop not booting :-( Thanks Hari Feel safe with award winning spam

Re: sata NCQ blacklist entry

2007-11-08 Thread Robert Hancock
Luca Tettamanti wrote: On Nov 7, 2007 1:55 PM, Tejun Heo [EMAIL PROTECTED] wrote: Florian La Roche wrote: Hello all, I've taking email addresses from the last NCQ blacklist changes going into the kernel. This Fujitsu drive also gives me spurious command completions. Detailed output also

Re: sata NCQ blacklist entry

2007-11-08 Thread Luca Tettamanti
On Nov 9, 2007 12:32 AM, Robert Hancock [EMAIL PROTECTED] wrote: Luca Tettamanti wrote: On Nov 7, 2007 1:55 PM, Tejun Heo [EMAIL PROTECTED] wrote: Florian La Roche wrote: Hello all, I've taking email addresses from the last NCQ blacklist changes going into the kernel. This Fujitsu

Re: [PATCH #upstream-fixes] libata: skip 0xff polling for PATA controllers

2007-11-08 Thread Tejun Heo
Mark Lord wrote: Tejun Heo wrote: In a presentation of true workmanship, pata_ali asserts IRQ permanantly if the TF status register is read more than once when there's no device attached to the port. .. Is using the altstatus reg (rather than status reg), when possible, a better idea

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-08 Thread Alan Cox
On Thu, 8 Nov 2007 21:56:32 +0200 Denys Fedoryshchenko [EMAIL PROTECTED] wrote: Thanks, it works like that. Seems in libata there is no fall-back to non-DMA mode, if DMA didn't work. It should be falling back from UDMA or MWDMA to PIO, if not please file a bug Alan - To unsubscribe from

Re: Acard ATP8620 2SATA / 1 IDE driver - AHCI.C Nov082007

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 03:19:52PM -0500, Mark Lord wrote: Jeff Garzik wrote: On Thu, Nov 08, 2007 at 02:52:26PM -0500, Mark Lord wrote: Jeff Garzik wrote: .. 2) This chip includes target mode support. Very nice, well done! I hope that standard AHCI eventually supports this nice feature!

Re: sata NCQ blacklist entry

2007-11-08 Thread Luca Tettamanti
On Nov 7, 2007 1:55 PM, Tejun Heo [EMAIL PROTECTED] wrote: Florian La Roche wrote: Hello all, I've taking email addresses from the last NCQ blacklist changes going into the kernel. This Fujitsu drive also gives me spurious command completions. Detailed output also available at

Re: Acard ATP8620 2SATA / 1 IDE driver - AHCI.C Nov082007

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 02:52:26PM -0500, Mark Lord wrote: Jeff Garzik wrote: .. 2) This chip includes target mode support. Very nice, well done! I hope that standard AHCI eventually supports this nice feature! .. Speaking of which. Do we have a strategy as to how to implement/support

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-08 Thread Denys Fedoryshchenko
Thanks, it works like that. Seems in libata there is no fall-back to non-DMA mode, if DMA didn't work. On Thu, 8 Nov 2007 12:31:39 -0500, Jeff Garzik wrote On Thu, Nov 08, 2007 at 06:44:31PM +0200, Denys Fedoryshchenko wrote: Doesn't help WRAP ~ #cat /proc/cmdline console=ttyS0,38400n8

Re: libata: cdrw/dvdrom disabed after s2ram (2.6.24-rc2)

2007-11-08 Thread Mark Lord
Andrew Morton wrote: On Thu, 8 Nov 2007 13:19:05 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: On Thu, Nov 08, 2007 at 10:13:41AM -0800, Andrew Morton wrote: On Thu, 8 Nov 2007 13:02:56 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: On Thu, Nov 08, 2007 at 09:49:58AM -0800, Andrew Morton wrote: .. I

Re: Acard ATP8620 2SATA / 1 IDE driver - AHCI.C Nov082007

2007-11-08 Thread Mark Lord
Jeff Garzik wrote: .. 2) This chip includes target mode support. Very nice, well done! I hope that standard AHCI eventually supports this nice feature! .. Speaking of which. Do we have a strategy as to how to implement/support the target side of target mode on controllers which can do it?

Re: libata: cdrw/dvdrom disabed after s2ram (2.6.24-rc2)

2007-11-08 Thread Andrew Morton
On Thu, 8 Nov 2007 13:19:05 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: On Thu, Nov 08, 2007 at 10:13:41AM -0800, Andrew Morton wrote: On Thu, 8 Nov 2007 13:02:56 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: On Thu, Nov 08, 2007 at 09:49:58AM -0800, Andrew Morton wrote: On Thu, 08 Nov

[PATCH] Don't fail ata device revalidation for bad _GTF methods

2007-11-08 Thread Matthew Garrett
Experience suggests that the _GTF method may be bad. We currently fail device revalidation in that case, which seems excessive. Signed-off-by: Matthew Garrett [EMAIL PROTECTED] --- diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c index 08a52dd..545ea86 100644 ---

Re: SC1200 failure in 2.6.23 and 2.6.24-rc1-git10

2007-11-08 Thread Tejun Heo
Denys Fedoryshchenko wrote: Thanks, it works like that. Seems in libata there is no fall-back to non-DMA mode, if DMA didn't work. There is, it's just too conservative about that. With improvements pending for 2.6.24, it should be quite snappy at falling back to PIO if configured transfer

Re: libata: cdrw/dvdrom disabed after s2ram (2.6.24-rc2)

2007-11-08 Thread Andrew Morton
On Thu, 08 Nov 2007 14:49:33 -0500 Mark Lord [EMAIL PROTECTED] wrote: Andrew Morton wrote: On Thu, 8 Nov 2007 13:19:05 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: On Thu, Nov 08, 2007 at 10:13:41AM -0800, Andrew Morton wrote: On Thu, 8 Nov 2007 13:02:56 -0500 Jeff Garzik [EMAIL PROTECTED]

SATA Target mode libata

2007-11-08 Thread Mark Lord
Jeff Garzik wrote: On Thu, Nov 08, 2007 at 03:19:52PM -0500, Mark Lord wrote: .. MMmm.. I wonder what the most common use case is for target mode? Everybody I've dealt with thus far uses it as a high-speed local comms interface, which would suggest that it might be done as a network

Re: SATA Target mode libata

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 03:49:17PM -0500, Mark Lord wrote: Jeff Garzik wrote: On Thu, Nov 08, 2007 at 03:19:52PM -0500, Mark Lord wrote: .. MMmm.. I wonder what the most common use case is for target mode? Everybody I've dealt with thus far uses it as a high-speed local comms interface,

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-08 Thread Jeff Garzik
On Fri, Nov 09, 2007 at 09:02:35AM +0700, Riki Oktarianto wrote: Some BIOSen map AHCI ABAR but lock the SATA controller to IDE mode. This patch add quirk to set AHCI mode on ICH board with such case. Tested on Macbook2,1 (ICH7M) Intel will complain but it's awful tempting... Jeff

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-08 Thread Mark Lord
Jeff Garzik wrote: On Fri, Nov 09, 2007 at 09:02:35AM +0700, Riki Oktarianto wrote: Some BIOSen map AHCI ABAR but lock the SATA controller to IDE mode. This patch add quirk to set AHCI mode on ICH board with such case. Tested on Macbook2,1 (ICH7M) Intel will complain but it's awful

FIS structure and Command List structure for AHCI SATA controller

2007-11-08 Thread mike zheng
Hi All, I am working on an AHCI SATA controller. For each port, there is one FIS descriptor and one Command List, which points to a Received FIS structure and Command List structure. So what is Received FIS structure? The Command List structure points to Command Table, that has Command FIS field

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 10:29:37PM -0500, Mark Lord wrote: And I might even privately patch my own kernels to map the ACHI BAR in the cases where the BIOS didn't... The inability to do this in the general case is the main reason why AHCI was not unconditionally enabled, even in IDE mode, when

Re: FIS structure and Command List structure for AHCI SATA controller

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 10:38:25PM -0500, mike zheng wrote: I am working on an AHCI SATA controller. For each port, there is one FIS descriptor and one Command List, which points to a Received FIS structure and Command List structure. So what is Received FIS structure? The Command List

Re: 2.6.24-rc SB600 AHCI no go on =4GB of RAM

2007-11-08 Thread Tejun Heo
Srihari Vijayaraghavan wrote: (Same symptoms/behaviour as before: http://marc.info/?l=linux-idem=117949823328798w=2 http://marc.info/?t=11781097043r=1w=2) With mem=3500M all is well, otherwise it goes on reseting the ports in a loop not booting :-( Hmmm.. weird. The workaround

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-08 Thread Mark Lord
Jeff Garzik wrote: On Thu, Nov 08, 2007 at 10:29:37PM -0500, Mark Lord wrote: And I might even privately patch my own kernels to map the ACHI BAR in the cases where the BIOS didn't... The inability to do this in the general case is the main reason why AHCI was not unconditionally enabled,

Re: [PATCH] Add quirk to set AHCI mode on ICH boards

2007-11-08 Thread Jeff Garzik
On Thu, Nov 08, 2007 at 11:44:22PM -0500, Mark Lord wrote: Jeff Garzik wrote: On Thu, Nov 08, 2007 at 10:29:37PM -0500, Mark Lord wrote: And I might even privately patch my own kernels to map the ACHI BAR in the cases where the BIOS didn't... The inability to do this in the general case is