Re: [PATCH RFC] sata_promise: make pdc_atapi_pkt() use values from qc-tf

2007-12-03 Thread Mikael Pettersson
On Mon, 03 Dec 2007 13:49:36 +0900, Tejun Heo wrote: Mikael Pettersson wrote: what was the outcome of this discussion? I haven't looked over the Promise datasheet nor checked my brain for details, hoping Mikael would do that for me ;-) I've now tested this on top of 2.6.24-rc3, with

problems with packet command

2007-12-03 Thread Kantor Zsolt
Hi, I'm developing an application that uses cd-rom IOCTL's. All is fine but I have one problem I can not set up a packet command, because I don't know exactly how to fill out the 12 byte command field. I searched the internet, looked in the cdrom.c driver, some other programs source code, but

RE: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Morrison, Tom
Ack - works in my 'unique' setup as well...:-)... Thank you Mark! Tom Morrison -Original Message- From: Mark Lord [mailto:[EMAIL PROTECTED] Sent: Saturday, December 01, 2007 1:07 PM To: IDE/ATA development list; Jeff Garzik Cc: Tejun Heo; Alan Cox; Morrison, Tom; Hein-Pieter van Braam

[PATCH] ahci: add the Device IDs of MCP79 AHCI controller to ahci.c

2007-12-03 Thread peerchen
Add the device IDs of legacy mode of MCP79 AHCI controller to ahci.c The patch base on kernel 2.6.24-rc3 Signed-off-by: Peer Chen [EMAIL PROTECTED] --- --- linux-2.6.24-rc3/drivers/ata/ahci.c.orig2007-12-03 16:20:15.0 -0500 +++ linux-2.6.24-rc3/drivers/ata/ahci.c 2007-12-03

RE: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Morrison, Tom
I should've added that I am working with a 2.6.23.x (x=8 right now) kernel/sata_mv.c. Which unless I am mistaken - has not change any until this patch - so I didn't have a problem...I need to work on the 2.6.23.x - because I am trying to stabilize my build to release a kernel for my developers to

RE: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread hp
It doesn't quite work for me, the system locks up without discernible error messages (Highpoint RocketRaid 2300 PCIe) . The drives come up, and immediately get hyper active, and I get dumped in an initrd busybox shell, when I try to tail /dev/sda it hangs, pvscan doesn't find any physical

Re: [PATCH 26/28] blk_end_request: changing ide-cd (take 3)

2007-12-03 Thread Sergei Shtylyov
Bartlomiej Zolnierkiewicz wrote: [PATCH] ide-cd: remove dead post_transform_command() post_transform_command() call in cdrom_newpc_intr() has no effect because it is done after the request has already been fully completed (rq-bio and rq-data are always NULL). It was verified to be true

Re: Possibly SATA related freeze killed networking and RAID

2007-12-03 Thread Phillip Susi
Tejun Heo wrote: Surprise, surprise. There's no way to tell whether the controller raised interrupt or not if command is not in progress. As I said before, there's no IRQ pending bit. While processing commands, you can tell by looking at other status registers but when there's nothing in

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Mark Lord
[EMAIL PROTECTED] wrote: It doesn't quite work for me, the system locks up without discernible error messages (Highpoint RocketRaid 2300 PCIe) . The drives come up, and immediately get hyper active, and I get dumped in an initrd busybox shell, when I try to tail /dev/sda it hangs, pvscan

Re: Enabling MSI in sata_nv

2007-12-03 Thread Mark Lord
Philip Langdale wrote: Hi all, At least for my hardware (MCP55), the sata controller supports MSI and it seems that turning it on is as simple as inserting the call to pci_enable_msi - after that it Just Works(tm). Are there any gotchas that I'm missing? Would a patch to do this be accepted?

Re: [patch] ata: ahci: Enclosure Management via LED rev2

2007-12-03 Thread Kristen Carlson Accardi
On Sat, 01 Dec 2007 18:28:54 -0500 Jeff Garzik [EMAIL PROTECTED] wrote: Kristen Carlson Accardi wrote: Enclosure Management via LED This patch implements Enclosure Management via the LED protocol as specified in AHCI specification. Signed-off-by: Kristen Carlson Accardi [EMAIL

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Mark Lord
Mark Lord wrote: [EMAIL PROTECTED] wrote: It doesn't quite work for me, the system locks up without discernible error messages (Highpoint RocketRaid 2300 PCIe) . The drives come up, and immediately get hyper active, and I get dumped in an initrd busybox shell, when I try to tail /dev/sda it

Re: Enabling MSI in sata_nv

2007-12-03 Thread Mark Lord
Mark Lord wrote: Philip Langdale wrote: Hi all, At least for my hardware (MCP55), the sata controller supports MSI and it seems that turning it on is as simple as inserting the call to pci_enable_msi - after that it Just Works(tm). Are there any gotchas that I'm missing? Would a patch to do

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Mark Lord
Jeff Garzik wrote: Mark Lord wrote: The BIOS on the Highpoint RR 2300 *corrupts* the GRUB image, so GRUB won't boot for me there. I actually have to re-install GRUB after each attempt so that the drive is usable again with the onboard Intel (ahci) ports. So one then wonders exactly what the

RE: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Morrison, Tom
Fwiw, I'm not running an add-on card or anything like it - no raid - nothing except a 7042 chip as the the front-end to 2-4 harddrives in my box) - in this case - I am not having a problem... I write this as perhaps a hint to the 'right' direction to go looking for the trouble... all the

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Mark Lord
Mark Lord wrote: ... Okay, I've attempted to boot from the RocketRAID 2300 card using a known-good boot hard disk. No such luck. The BIOS on the Highpoint RR 2300 *corrupts* the GRUB image, so GRUB won't boot for me there. I actually have to re-install GRUB after each attempt so that the

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Jeff Garzik
Mark Lord wrote: The BIOS on the Highpoint RR 2300 *corrupts* the GRUB image, so GRUB won't boot for me there. I actually have to re-install GRUB after each attempt so that the drive is usable again with the onboard Intel (ahci) ports. So one then wonders exactly what the Highpoint BIOS is

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Mark Lord
Morrison, Tom wrote: Fwiw, I'm not running an add-on card or anything like it - no raid - nothing except a 7042 chip as the the front-end to 2-4 harddrives in my box) - in this case - I am not having a problem... I write this as perhaps a hint to the 'right' direction to go looking for the

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Mark Lord
Mark Lord wrote: Morrison, Tom wrote: Fwiw, I'm not running an add-on card or anything like it - no raid - nothing except a 7042 chip as the the front-end to 2-4 harddrives in my box) - in this case - I am not having a problem... I write this as perhaps a hint to the 'right' direction to go

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Alan Cox
Confirmed. It writes lgcy + stuff into the 9th sector of the drive (for my Legacy drive). Thats quite nasty. Given that users putting volumes unpartitioned on drives may see actual data corruption and loss perhaps we should blacklist that controller variant with a large warning ? Alan - To

Re: Enabling MSI in sata_nv

2007-12-03 Thread Greg Freemyer
On Dec 2, 2007 10:07 PM, Philip Langdale [EMAIL PROTECTED] wrote: Hi all, At least for my hardware (MCP55), the sata controller supports MSI and it seems that turning it on is as simple as inserting the call to pci_enable_msi - after that it Just Works(tm). Are there any gotchas that I'm

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Mark Lord
Alan Cox wrote: Confirmed. It writes lgcy + stuff into the 9th sector of the drive (for my Legacy drive). Thats quite nasty. Given that users putting volumes unpartitioned on drives may see actual data corruption and loss perhaps we should blacklist that controller variant with a large

Re: Enabling MSI in sata_nv

2007-12-03 Thread Jeff Garzik
Greg Freemyer wrote: On Dec 2, 2007 10:07 PM, Philip Langdale [EMAIL PROTECTED] wrote: Hi all, At least for my hardware (MCP55), the sata controller supports MSI and it seems that turning it on is as simple as inserting the call to pci_enable_msi - after that it Just Works(tm). Are there any

Re: Enabling MSI in sata_nv

2007-12-03 Thread Jeff Garzik
Mark Lord wrote: Mark Lord wrote: Philip Langdale wrote: Hi all, At least for my hardware (MCP55), the sata controller supports MSI and it seems that turning it on is as simple as inserting the call to pci_enable_msi - after that it Just Works(tm). Are there any gotchas that I'm missing?

Re: [PATCH 2/2] [libata] sata_mv: Support integrated controllers

2007-12-03 Thread Jeff Garzik
Mark Lord wrote: Also, I'm not sure I understand why there's a need for the new sata_mv.h file ? The embedded platform includes that, similar to include/linux/pata_platform.h. Jeff - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Hein-Pieter van Braam
On Mon, 2007-12-03 at 13:30 -0500, Mark Lord wrote: Mark Lord wrote: ... Okay, I've attempted to boot from the RocketRAID 2300 card using a known-good boot hard disk. No such luck. The BIOS on the Highpoint RR 2300 *corrupts* the GRUB image, so GRUB won't boot for me there. I

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Mark Lord
Hein-Pieter van Braam wrote: Personally, I put all the disks in JBOD mode, but I never had these disks connected to anything but my highpoint cards. Perhaps I should tell you what my setup's like: * In the system I've put 3 Highpoint RocketRaid 2300 cards. * Two of the cards each have 4

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Hein-Pieter van Braam
I'll try and make a bootable USB stick with my patched 2.6.23.9 and see what the results are then. .. How are you booting without the USB stick? Are you booting from the Highpoint card drives? What bootloader ? Thanks - Right now I just boot using GRUB really, perhaps the BIOS

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Mark Lord
Mark Lord wrote: Alan Cox wrote: Confirmed. It writes lgcy + stuff into the 9th sector of the drive (for my Legacy drive). Thats quite nasty. Given that users putting volumes unpartitioned on drives may see actual data corruption and loss perhaps we should blacklist that controller variant

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Mark Lord
Hein-Pieter van Braam wrote: I'll try and make a bootable USB stick with my patched 2.6.23.9 and see what the results are then. .. How are you booting without the USB stick? Are you booting from the Highpoint card drives? What bootloader ? Thanks - Right now I just boot using GRUB really,

[Fwd: Reminder: Last day for submissions to the Storage and Filesystem Workshop.]

2007-12-03 Thread Mark Lord
Original Message Subject: Reminder: Last day for submissions to the Storage and Filesystem Workshop. Date: Mon, 3 Dec 2007 09:00:17 -0500 From: Chris Mason [EMAIL PROTECTED] To: [EMAIL PROTECTED], [EMAIL PROTECTED] Hello everyone, The deadline for position statements to the

[PATCH 2/6] ide: remove stale changelog from ide-disk.c

2007-12-03 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c | 26 -- 1 file changed, 26 deletions(-) Index: b/drivers/ide/ide-disk.c === --- a/drivers/ide/ide-disk.c +++

[PATCH 3/6] ide: remove stale changelog from ide-probe.c

2007-12-03 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c | 18 ++ 1 file changed, 2 insertions(+), 16 deletions(-) Index: b/drivers/ide/ide-probe.c === --- a/drivers/ide/ide-probe.c

[PATCH 4/6] ide: add ide_busy_sleep() helper

2007-12-03 Thread Bartlomiej Zolnierkiewicz
Add ide_busy_sleep() helper and use it in do_probe(), enable_nest() and probe_hwif(). As a nice side-effect this fixes a minor bug in enable_nest() (the code was reading status register without any delay). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c |

[PATCH 5/6] ide: remove broken disk byte-swapping support

2007-12-03 Thread Bartlomiej Zolnierkiewicz
Remove broken disk byte-swapping support: - it can cause a data corruption on SMP (or if using PREEMPT on UP) - all data coming from disk are byte-swapped by taskfile_*_data() which results in incorrect identify data being reported by /proc/ide/ and IOCTLs - hdx=bswap/byteswap kernel parameter

[PATCH 6/6] cmd64x: remove /proc/ide/cmd64x

2007-12-03 Thread Bartlomiej Zolnierkiewicz
This belongs to user-space (and only if really needed). textdata bss dec hex filename 3874 180 284082 ff2 drivers/ide/pci/cmd64x.o.before 2231 180 02411 96b drivers/ide/pci/cmd64x.o.after Additionaly to being bloat the code contained

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Hein-Pieter van Braam
Man, what a quirky BIOS! Okay, so if I connect a drive and don't do anything in the Highpoint BIOS setup, it then corrupts the drive by overwriting the 9th sector on every reboot. But.. if I connect a drive and go into the Highpoint BIOS setup, and initialize the drive there, and then

Re: [PATCH 26/28] blk_end_request: changing ide-cd (take 3)

2007-12-03 Thread Kiyoshi Ueda
Hi Bartlomiej, On Sat, 1 Dec 2007 23:42:51 +0100, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: On Saturday 01 December 2007, Kiyoshi Ueda wrote: This patch converts ide-cd (cdrom_newpc_intr()) to use blk_end_request(). ide-cd (cdrom_newpc_intr()) has some tricky behaviors below

reset IOCTLs

2007-12-03 Thread Kantor Zsolt
Can somebody tell me what is the difference between these reset commands (I'm developing an open source application and I would like to know this): one is in the cdrom.h (CDROMRESET - 0x5312), and the second with the third are in the hdreg.h (HDIO_DRIVE_RESET - 0x031c, WIN_DEVICE_RESET - 0x08)

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Hein-Pieter van Braam
Man, what a quirky BIOS! Hum... I can pvcreate on the md device just fine, but after that, pvscan won't find it... I have a suspicion that there's a BIOS doing some sector hiding or replacement of sorts... *facepalm* -- This message has been scanned for viruses and dangerous content by

Re: [PATCH 09/28] blk_end_request: changing ps3disk (take 3)

2007-12-03 Thread Kiyoshi Ueda
Hi Geert, On Sun, 2 Dec 2007 10:34:56 +0100 (CET), Geert Uytterhoeven [EMAIL PROTECTED] wrote: On Fri, 30 Nov 2007, Kiyoshi Ueda wrote: This patch converts ps3disk to use blk_end_request(). ^^^ Patch subject and description are inconsistent

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Alan Cox
On Mon, 03 Dec 2007 23:48:44 +0100 Hein-Pieter van Braam [EMAIL PROTECTED] wrote: Man, what a quirky BIOS! Hum... I can pvcreate on the md device just fine, but after that, pvscan won't find it... I have a suspicion that there's a BIOS doing some sector hiding or replacement of

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Hein-Pieter van Braam
On Mon, 2007-12-03 at 23:10 +, Alan Cox wrote: On Mon, 03 Dec 2007 23:48:44 +0100 Hein-Pieter van Braam [EMAIL PROTECTED] wrote: Man, what a quirky BIOS! Hum... I can pvcreate on the md device just fine, but after that, pvscan won't find it... I have a suspicion that

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Mark Lord
Hein-Pieter van Braam wrote: I did some testing: First I zero'd the first 80 meg of the md device, then read it back and compared, still all zero's. Then I rebooted and compared again, still all zero's Then I got 8MB of stuff from /dev/urandom, wrote it to a file then wrote it to md device,

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Mark Lord
Alan Cox wrote: On Mon, 03 Dec 2007 23:48:44 +0100 Hein-Pieter van Braam [EMAIL PROTECTED] wrote: Man, what a quirky BIOS! Hum... I can pvcreate on the md device just fine, but after that, pvscan won't find it... I have a suspicion that there's a BIOS doing some sector hiding or

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Alan Cox
On Mon, 03 Dec 2007 18:33:10 -0500 Mark Lord [EMAIL PROTECTED] wrote: Alan Cox wrote: On Mon, 03 Dec 2007 23:48:44 +0100 Hein-Pieter van Braam [EMAIL PROTECTED] wrote: Man, what a quirky BIOS! Hum... I can pvcreate on the md device just fine, but after that, pvscan won't find it...

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Mark Lord
Hein-Pieter van Braam wrote: Man, what a quirky BIOS! Okay, so if I connect a drive and don't do anything in the Highpoint BIOS setup, it then corrupts the drive by overwriting the 9th sector on every reboot. But.. if I connect a drive and go into the Highpoint BIOS setup, and initialize the

Re: [PATCH 24/28] blk_end_request: changing ide normal caller (take 3)

2007-12-03 Thread Kiyoshi Ueda
Hi Bartlomiej, On Sat, 1 Dec 2007 23:53:05 +0100, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: On Saturday 01 December 2007, Kiyoshi Ueda wrote: This patch converts normal parts of ide to use blk_end_request(). Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Mark Lord
Mark Lord wrote: Hein-Pieter van Braam wrote: .. also: on a side note, let me state again, that I'm extremely displeased with highpoint at this point... their whole 'open source linux drivers' thing is beginning to piss me off more and more. There must be something that can be done about this?

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Hein-Pieter van Braam
Their stuff has always seemed more than a little screwy to me. The solution for us here, is sata_mv, which will replace their drivers for this series of boards. It just seriously pisses me off that because of their advertising 'Open Source drivers' they now sold ELEVEN of their boards

Re: Issuing a vendor specific ATA cmd on SATA Disk via ATA Pass Thru

2007-12-03 Thread sam song
sam song wrote: [USI]: ata pass through(16) cdb: 85 0b 06 00 41 00 00 00 00 00 00 00 00 e0 fd 00 [unknown opcode: 85 0b 06 00 41 00 00 00 00 00 00 00 00 e0 fd 00 ] scsi_status=0x2, host_status=0x0, driver_status=0x8 info=0x1 duration=8184280 milliseconds [--snip--] ata2.00:

Re: Possibly SATA related freeze killed networking and RAID

2007-12-03 Thread Tejun Heo
Phillip Susi wrote: Tejun Heo wrote: Surprise, surprise. There's no way to tell whether the controller raised interrupt or not if command is not in progress. As I said before, there's no IRQ pending bit. While processing commands, you can tell by looking at other status registers but when

Re: [PATCH] sata_mv: Fix broken Marvell 7042 support.

2007-12-03 Thread Mark Lord
Mark Lord wrote: So to boot from a 7042 the only theoretical choice is the Highpoint board, and for that we need to somehow coax it into not overwriting GRUB every time the onboard BIOS reinitializes. .. With the drive set-up as a JBOD volume in the HighPoint BIOS, I've now got a system that

Re: Enabling MSI in sata_nv

2007-12-03 Thread Philip Langdale
Jeff Garzik wrote: MSI is pretty flaky, but we default it to 'on' for AHCI, which is the enhanced mode side of the sata_nv chip. If it's new enough. MCP55 has no ahci mode. So it is likely that it works on newer boards -- but even though Mark Lord's response was mistaken (he thought

Re: Issuing a vendor specific ATA cmd on SATA Disk via ATA Pass Thru

2007-12-03 Thread Tejun Heo
sam song wrote: = Hmmm... It's timeout. How long does the command take? It's a bit weird because 36000s but the reported command duration is 136s. How long did the command take actually? The command did actually take 136minutes25seconds. I set the timeout in app as 36000seconds(10-hour).

a question about interrupt of IDE controller( bug 5637)

2007-12-03 Thread Zhao Yakui
Hi, All I have a question about the interrupt of IDE controller. There is a regression between 2.6.13 and 2.6.12. More details can be found in the following link: http://bugzilla.kernel.org/show_bug.cgi?id=5637 When the IDE controller works in legacy mode, the

Re: Is BIO_RW_FAILFAST really usable?

2007-12-03 Thread Jeff Garzik
Neil Brown wrote: I've been looking at use BIO_RW_FAILFAST in md/raid to improve handling of some error cases. This is particularly significant for the DASD driver (s390 specific). I believe it uses optic fibre to connect to the drives. When one of these paths is unplugged, IO requests will

Re: Is BIO_RW_FAILFAST really usable?

2007-12-03 Thread Andrey Borzenkov
Jeff Garzik wrote: Neil Brown wrote: I've been looking at use BIO_RW_FAILFAST in md/raid to improve handling of some error cases. This is particularly significant for the DASD driver (s390 specific). I believe it uses optic fibre to connect to the drives. When one of these paths is