Re: [PATCH 0/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-15 Thread Paul Mundt
On Sun, Dec 16, 2007 at 12:20:54AM +, Adrian McMenamin wrote: > This device is electrically compatible with ATA-3 IDE CD drives but > implements a proprietary packet interface. There have been previous > Dreamcast CD drivers around but this is new code and uses DMA as > opposed to PIO for reads

[PATCH 2/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-15 Thread Adrian McMenamin
diff -ruN ./linux-2.6-orig/drivers/sh/gdrom/gdrom.c ./linux-2.6/drivers/sh/gdrom/gdrom.c --- ./linux-2.6-orig/drivers/sh/gdrom/gdrom.c 1970-01-01 01:00:00.0 +0100 +++ ./linux-2.6/drivers/sh/gdrom/gdrom.c2007-12-15 22:58:17.0 + @@ -0,0 +1,793 @@ +/* GD ROM driver for t

Re: [PATCH 0/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-15 Thread Adrian McMenamin
On Sun, 2007-12-16 at 00:20 +, Adrian McMenamin wrote: > (Apologies if you've already had this. I sent it to lkml etc an hour > ago but it just disappeated into the ether - trying it in smaller > packets this time.) > vger/lkml's spam filtering is trapping the main part of the patch as spam.

[PATCH 1/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-15 Thread Adrian McMenamin
diff -ruN ./linux-2.6-orig/drivers/block/Kconfig ./linux-2.6/drivers/block/Kconfig --- ./linux-2.6-orig/drivers/block/Kconfig 2007-12-15 22:23:47.0 + +++ ./linux-2.6/drivers/block/Kconfig 2007-12-15 22:18:28.0 + @@ -105,6 +105,18 @@ "MicroSolutions backpack

[PATCH 3/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-15 Thread Adrian McMenamin
diff -ruN ./linux-2.6-orig/drivers/sh/Makefile ./linux-2.6/drivers/sh/Makefile --- ./linux-2.6-orig/drivers/sh/Makefile2007-12-15 22:23:59.0 + +++ ./linux-2.6/drivers/sh/Makefile 2007-12-15 22:18:45.0 + @@ -4,3 +4,4 @@ obj-$(CONFIG_SUPERHYWAY) += superhy

[PATCH 0/3] Add GD-Rom support to the SEGA Dreamcast

2007-12-15 Thread Adrian McMenamin
(Apologies if you've already had this. I sent it to lkml etc an hour ago but it just disappeated into the ether - trying it in smaller packets this time.) This patch adds support for the CD drive on the SEGA Dreamcast - the so-called GD Rom drive. This device is electrically compatible with ATA-3

Re: [PATCH] ata.h: Don't do a SATA check for 40wire_relaxed

2007-12-15 Thread Alan Cox
On Sat, Dec 15, 2007 at 06:35:32PM +0100, Peter Missel wrote: > Pinging ... don't take this personal guys, but are we going to keep the > original, dangerously broken implementation in 2.6.24, or will my patch go > upstream in time? Up to Jeff/Linus. Alan (on holiday) - To unsubscribe from thi

Re: [PATCH] ata.h: Don't do a SATA check for 40wire_relaxed

2007-12-15 Thread Peter Missel
Pinging ... don't take this personal guys, but are we going to keep the original, dangerously broken implementation in 2.6.24, or will my patch go upstream in time? cheers, Peter --- Hi all! As the originator of this patch, please let me comment. Jeff Garzik wrote: >Alan Cox wrote

Re: [PATCH] drivers/ata/ahci.c, kernel 2.6.23.10

2007-12-15 Thread Mark Lord
Michael Kühn wrote: Hmm... but why we shouldn't integrate this fix in 2.6.23* branch? I thought 2.6.23 and 2.6.24 are indepented from each other and get their own fixes. So it's just a nice have-to-be in the next Bugfix release. .. You can forward it to GregK, who looks after the backported fi

Re: [PATCH] drivers/ata/ahci.c, kernel 2.6.23.10

2007-12-15 Thread Michael Kühn
Hmm... but why we shouldn't integrate this fix in 2.6.23* branch? I thought 2.6.23 and 2.6.24 are indepented from each other and get their own fixes. So it's just a nice have-to-be in the next Bugfix release. Yours sincerly Michael Kühn Mark Lord schrieb: Michael Kühn wrote: This patch remov

Re: [PATCH] drivers/ata/ahci.c, kernel 2.6.23.10

2007-12-15 Thread Mark Lord
Michael Kühn wrote: This patch remove a unused variable in the ahci_port_intr function and therewith a compiler warning. Signed-off-by: Michael Kühn <[EMAIL PROTECTED]> --- linux-2.6.23.10/drivers/ata/ahci.c 2007-12-14 19:01:59.0 +0100 +++ linux-2.6.23.10.new/drivers/ata/ahci.c 2

Re: [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-15 Thread Anton Vorontsov
On Sun, Dec 16, 2007 at 01:09:22AM +1100, Stephen Rothwell wrote: > On Fri, 14 Dec 2007 21:24:38 +0300 Anton Vorontsov <[EMAIL PROTECTED]> wrote: > > > > + prop = (u32 *)of_get_property(dn, "reg-shift", NULL); > > This cast is unnecessary. > > > + if (prop) > > + reg_shift = *prop;

[PATCH] drivers/ata/ahci.c, kernel 2.6.23.10

2007-12-15 Thread Michael Kühn
This patch remove a unused variable in the ahci_port_intr function and therewith a compiler warning. Signed-off-by: Michael Kühn <[EMAIL PROTECTED]> --- linux-2.6.23.10/drivers/ata/ahci.c 2007-12-14 19:01:59.0 +0100 +++ linux-2.6.23.10.new/drivers/ata/ahci.c 2007-12-15 01:03:41.000

Re: [PATCH 2/3] [libata] pata_of_platform: OF-Platform PATA device driver

2007-12-15 Thread Stephen Rothwell
On Fri, 14 Dec 2007 21:24:38 +0300 Anton Vorontsov <[EMAIL PROTECTED]> wrote: > > + prop = (u32 *)of_get_property(dn, "reg-shift", NULL); This cast is unnecessary. > + if (prop) > + reg_shift = *prop; > + > + prop = (u32 *)of_get_property(dn, "pio-mode", NULL); So is this