Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-06 Thread Tejun Heo
Rusty Russell wrote: > On Monday 07 January 2008 16:01:40 Tejun Heo wrote: >>> But we hit the same problems: >>> >>> 1) sg_chain loses information. The clever chain packaging makes reading >>> easy, but manipulation is severely limited. You can append to your own >>> chains by padding, but not so

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-06 Thread Rusty Russell
On Monday 07 January 2008 16:01:40 Tejun Heo wrote: > > But we hit the same problems: > > > > 1) sg_chain loses information. The clever chain packaging makes reading > > easy, but manipulation is severely limited. You can append to your own > > chains by padding, but not someone elses. This work

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-06 Thread Tejun Heo
Hello, Rusty Russell wrote: >> The other thing I note is that the problem you're claiming to solve with >> sg_ring (the ability to add extra scatterlists to the front or the back >> of an existing one) is already solved with sg_chain, so the only real >> advantage of sg_ring was that it contains e

Re: [PATCH 0/7] sg_ring: a ring of scatterlist arrays

2008-01-06 Thread Rusty Russell
On Sunday 06 January 2008 02:31:12 James Bottomley wrote: > On Wed, 2007-12-19 at 17:31 +1100, Rusty Russell wrote: > > This patch series is the start of my attempt to simplify and make > > explicit the chained scatterlist logic. > > > > It's not complete: my SATA box boots and seems happy, but all

Re: Believed resolved: SATA kern-buffRd read slow: based on promise driver bug

2008-01-06 Thread Robert Hancock
Linda Walsh wrote: Mikael Pettersson wrote: Linda Walsh writes: > Mikael Pettersson wrote: > > Linda Walsh writes: > > > > Linda Walsh wrote: > > > read rate began falling; (.25 - .3); > > > more importantly; a chronic error message associated > > > with drive may be causing som

Re: SATA kernel-buffered read VERY slow (not raid, Promise TX300 card); 2.6.23.1(vanilla)

2008-01-06 Thread Alan Cox
On Sun, 06 Jan 2008 12:25:10 -0800 Linda Walsh <[EMAIL PROTECTED]> wrote: > Robert Hancock wrote: > > > > If this is a Seagate, I believe that they don't have AAM enabled on > > any of their newer drives (something about a lawsuit for patent > > infringement on that feature, or something). Quite

Re: SATA kernel-buffered read VERY slow (not raid, Promise TX300 card); 2.6.23.1(vanilla)

2008-01-06 Thread Mehmet Kemal EROL
Linda Walsh: > > Seagate would > remove those features -- especially since they are mentioned on > Seagate's drive > information page as being supported features. > Since you're there ... you might want to download `Seagate's SeaTools' and (if) give the hdd's controller a try ... ;) -- Esenl

Re: SATA kernel-buffered read VERY slow (not raid, Promise TX300 card); 2.6.23.1(vanilla)

2008-01-06 Thread Linda Walsh
Robert Hancock wrote: If this is a Seagate, I believe that they don't have AAM enabled on any of their newer drives (something about a lawsuit for patent infringement on that feature, or something). Quite likely they don't support that power management command, either. -- Do you have a so

Re: Believed resolved: SATA kern-buffRd read slow: based on promise driver bug

2008-01-06 Thread Linda Walsh
Mikael Pettersson wrote: Linda Walsh writes: > Mikael Pettersson wrote: > > Linda Walsh writes: > > > > Linda Walsh wrote: > > > read rate began falling; (.25 - .3); > > > more importantly; a chronic error message associated > > > with drive may be causing some or all of the prob

Re: 80 wire cable detection patch

2008-01-06 Thread George Kibardin
Signed-off-by: George Kibardin <[EMAIL PROTECTED]> --- drivers/ide/ide-iops.c.orig 2008-01-03 18:35:23.0 +0300 +++ drivers/ide/ide-iops.c 2008-01-03 18:12:29.0 +0300 @@ -612,12 +612,12 @@ printk(KERN_DEBUG "%s: skipping word 93 validity check\n",

Re: Still having problems after sata_promise: ASIC PRD table bug workaround

2008-01-06 Thread Volker Sauer
On Sa, 05 Jan 2008, Volker Sauer <[EMAIL PROTECTED]> wrote: > I'm running a Promise Technology PDC20318 (SATA150 TX4) (rev 02) > controller in on of my servers and I gettig the following error from time > to time - espacially when there's high load on the disks: [...] > /dev/sda: Seagate ST32506

[PATCH 7/8] ide: add struct ide_port_info instances to legacy host drivers

2008-01-06 Thread Bartlomiej Zolnierkiewicz
* Remove 'struct pci_dev *dev' argument from ide_hwif_setup_dma(). * Un-static ide_hwif_setup_dma() and add CONFIG_BLK_DEV_IDEDMA_PCI=n version. * Add 'const struct ide_port_info *d' argument to ide_device_add[_all](). * Factor out generic ports init from ide_pci_setup_ports() to ide_init_port()

[PATCH 8/8] ide: add ->cable_detect method to ide_hwif_t

2008-01-06 Thread Bartlomiej Zolnierkiewicz
* Add ->cable_detect method to ide_hwif_t. * Call the new method in ide_init_port() if: - the host supports UDMA modes > UDMA2 ('hwif->ultra_mask & 78') - DMA initialization was successful (if hwif->dma_base is not set ide_init_port() sets hwif->ultra_mask to zero) - "idex=ata66" is not

[PATCH 6/8] ide: separate PCI specific init from generic init in ide_pci_setup_ports()

2008-01-06 Thread Bartlomiej Zolnierkiewicz
* Setup ->mate and ->channel in ide_pci_setup_ports() instead of in ide_hwif_configure(). * Make 'port' parameter for ide_hwif_configure() 'unsigned int'. * Separate PCI specific init from generic init in ide_pci_setup_ports(). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- +

[PATCH 4/8] macide: remove drive->capacity64 quirk

2008-01-06 Thread Bartlomiej Zolnierkiewicz
Nowadays IDE core always provides drive ID and ide-disk always setups drive->capacity64 so this quirk is no longer needed. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/legacy/macide.c | 10 -- 1 file changed, 10 deletions(-) Index: b/drivers/ide/legacy/m

[PATCH 5/8] ide: always set DMA masks in ide_pci_setup_ports()

2008-01-06 Thread Bartlomiej Zolnierkiewicz
Always set DMA masks in ide_pci_setup_ports() to make sure that the valid masks for a host are set. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- +34 bytes drivers/ide/setup-pci.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) Index: b/drivers/ide/setup-

[PATCH 3/8] atiixp/cs5535/scc_pata: fix "idex=ata66" parameter handling

2008-01-06 Thread Bartlomiej Zolnierkiewicz
Don't override the cable type if the "idex=ata66" parameter was used. While at it: * atiixp.c: factor out cable detection to atiixp_cable_detect() from init_hwif_atiixp(). * cs5535.c: pass 'ide_hwif_t *hwif' instead of 'struct pci_dev *dev' to cs5535_cable_detect(). * scc_pata.c: factor out

[PATCH 2/8] au1xxx-ide: fix ->io_32bit handling

2008-01-06 Thread Bartlomiej Zolnierkiewicz
The host driver must set hwif's ->no_io_32bit setting not drive's one (ide_port_tune_devices() overrides drive's setting). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/mips/au1xxx-ide.c |3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) Index: b/drivers/id

[PATCH 0/8] ide: more IDE probing code rework

2008-01-06 Thread Bartlomiej Zolnierkiewicz
* Convert legacy host drivers to use struct ide_port_info + ide_device_add() instead of open-coding initialization of IDE port data structures. * Add ->cable_detect method for cable detection + use it in PCI host drivers. * Fix some bugs in the process (handling of "idex=ata66" in atiixp, cs55

[PATCH 1/8] dtc2278: fix ->io_32bit handling

2008-01-06 Thread Bartlomiej Zolnierkiewicz
On DTC2278 32-bit I/O has to be enabled for both devices on the port so always enable it during init time and disallow further changes. Cc: Alan Cox <[EMAIL PROTECTED]> Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide.c|4 drivers/ide/legacy/dt

Re: [RFC PATCH] ide-floppy: remove struct idefloppy_capabilities_page

2008-01-06 Thread Bartlomiej Zolnierkiewicz
On Sunday 06 January 2008, Borislav Petkov wrote: > Hi Bart, > > before removing all those typedefs in ide-floppy i wanted to check with you > whether what > i have in mind is in the right direction before doing all the work for > nothing. > Here's the first patch removing struct idefloppy_capab

Re: [RESEND PATCH 06/10] ide-floppy: report DMA handling in idefloppy_pc_intr() properly

2008-01-06 Thread Bartlomiej Zolnierkiewicz
On Saturday 05 January 2008, Borislav Petkov wrote: > On Sat, Jan 05, 2008 at 04:46:05PM +0100, Bartlomiej Zolnierkiewicz wrote: > > Hmm, no. The driver is called ide-floppy (ide_floppy) and it is more > > readable this way. > > > > > { > > > idefloppy_t *floppy = drive->driver_data; > > > s

Re: [Fwd: Re: libata , Silicon Image 3124]

2008-01-06 Thread Kasimir Müller
Hi Tejun, Old communication appended below. I wish you a Happy Xmas and a successful New Year. I spent some time during Christmas to further investigate the problem. I bought a new 500GB disk and put all data on this disk. This is also contineously watched by nagios and cacti Then 1.) All 5 disk

[RFC PATCH] ide-floppy: remove struct idefloppy_capabilities_page

2008-01-06 Thread Borislav Petkov
Hi Bart, before removing all those typedefs in ide-floppy i wanted to check with you whether what i have in mind is in the right direction before doing all the work for nothing. Here's the first patch removing struct idefloppy_capabilities_page. Please, tell me whether it is similar to what you g