Re: [PATCH v4 0/3] OF-platform PATA driver

2008-01-15 Thread Anton Vorontsov
On Tue, Jan 15, 2008 at 10:40:22AM -0600, Olof Johansson wrote: > Hi, > > I've applied 1/3 and 2/3 together with my electra_ide move to pasemi.git > for-2.6.25, and will ask Paul to pull that. Kumar said he'd take 3/3. > > I also added the const to the match table as spotted by Stephen. Great ne

Re: [PATCH 3/4] printk: implement merging printk

2008-01-15 Thread Tejun Heo
Randy Dunlap wrote: > On Wed, 16 Jan 2008 10:00:09 +0900 Tejun Heo wrote: > > >> --- >> include/linux/kernel.h | 71 >> kernel/printk.c| 215 >> >> 2 files changed, 286 insertions(+), 0 deletions(-) >> >> diff --git a/

Re: [PATCH 3/4] printk: implement merging printk

2008-01-15 Thread Randy Dunlap
On Wed, 16 Jan 2008 10:00:09 +0900 Tejun Heo wrote: > --- > include/linux/kernel.h | 71 > kernel/printk.c| 215 > > 2 files changed, 286 insertions(+), 0 deletions(-) > > diff --git a/include/linux/kernel.h b/include

Re: [PATCHSET] printk: implement printk_header() and merging printk

2008-01-15 Thread Tejun Heo
Hello, Randy Dunlap wrote: >> mprintk_set_header(&mp, KERN_INFO "ata%u.%2u: ", 1, 0); >> mprintk_push(&mp, "ATA %d", 7); >> mprintk_push(&mp, ", %u sectors\n", 1024); >> mprintk(&mp, "everything seems dandy\n"); > > Looks pretty good to me except that I would change mprintk_push to > mpri

Re: [PATCH 4/4] libata: make libata use printk_header() and mprintk

2008-01-15 Thread Tejun Heo
Randy Dunlap wrote: >> -ata_dev_printk(dev, KERN_WARNING, >> -"Drive reports diagnostics failure. This may indicate a drive\n"); >> -ata_dev_printk(dev, KERN_WARNING, >> -"fault or invalid emulation. Contact drive vendor for information.\n"); >> -

Re: [PATCHSET] printk: implement printk_header() and merging printk

2008-01-15 Thread Randy Dunlap
On Wed, 16 Jan 2008 10:00:06 +0900 Tejun Heo wrote: > Hello, all. > > This patchset implements printk_header() and mprintk - merging printk > - to make printing multiline messages and assembling message > piece-by-piece easier. > > In a nutshell, printk_header() lets you do the following atomica

Re: [PATCH 4/4] libata: make libata use printk_header() and mprintk

2008-01-15 Thread Randy Dunlap
On Wed, 16 Jan 2008 10:00:10 +0900 Tejun Heo wrote: > Reimplement libata printk helpers using printk_header, implement > helpers to initialize mprintk and use mprintk during device > configuration and EH reporting. > > This fixes various formatting related problems of libata messages such > as mi

Re: [PATCHSET] printk: implement printk_header() and merging printk

2008-01-15 Thread Tejun Heo
Tejun Heo wrote: > Hello, all. > > This patchset implements printk_header() and mprintk - merging printk > - to make printing multiline messages and assembling message > piece-by-piece easier. > > In a nutshell, printk_header() lets you do the following atomically > (against other messages). > >

[PATCH 3/4] printk: implement merging printk

2008-01-15 Thread Tejun Heo
There often are times printk messages need to be assembled piece by piece and it's usually done using one of the following methods. * Calling printk() on partial message segments. This used to be quite common but has a problem - the message can break up if someone else prints something in the

[PATCH 4/4] libata: make libata use printk_header() and mprintk

2008-01-15 Thread Tejun Heo
Reimplement libata printk helpers using printk_header, implement helpers to initialize mprintk and use mprintk during device configuration and EH reporting. This fixes various formatting related problems of libata messages such as misaligned multiline messages, decoded register lines with leading

[PATCH 2/4] printk: implement [v]printk_header()

2008-01-15 Thread Tejun Heo
Implement [v]printk_header() which takes @header argument and automatically prints header in front of or indents multiline messages. For example, if @header is "<7>ata1.00: " and the formatted message is "<6>line0\nline1\n", the following gets written to the console. <6>ata1.00: line0 <6>

[PATCHSET] printk: implement printk_header() and merging printk

2008-01-15 Thread Tejun Heo
Hello, all. This patchset implements printk_header() and mprintk - merging printk - to make printing multiline messages and assembling message piece-by-piece easier. In a nutshell, printk_header() lets you do the following atomically (against other messages). code: printk(KERN_INFO "ata1.00:

[PATCH 1/4] printk: keep log level on multiline messages

2008-01-15 Thread Tejun Heo
When printing multiline messages, printk() resets log level to default_message_loglevel after the first line. This changes log level unexpectedly when printing multiline messages. For example, libata error messages are printed like the following. <3>ata8.00: cmd 60/01:00:e0:71:02/00:00:00:00:00/

[PATCH] libata: add enclosure management support

2008-01-15 Thread Kristen Carlson Accardi
Add Enclosure Management support to libata and ahci. This patch adds support for the LED protocol, as defined in the AHCI spec. It adds a generic em_message and em_type sysfs entry per host. It also adds a sw_activity field per existing drive. The em_message field can be used by the driver to ta

[git patches] libata fixes

2008-01-15 Thread Jeff Garzik
Open issues for 2.6.24: sata_nv ADMA, sata_nv 32/64bit DMA Please pull from 'upstream-linus' branch of master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git upstream-linus to receive the following updates: drivers/ata/libata-core.c |4 +++- drivers/ata/pata_bf54x.c |3

Re: [patch for 2.6.24? 1/1] libata: correct handling of TSS DVD

2008-01-15 Thread Alan Cox
On Tue, Jan 15, 2008 at 03:52:09PM -0500, Jeff Garzik wrote: > > { > >-if (ata_id_is_sata(dev_id)) > >-return 0; /* SATA */ > > if ((dev_id[93] & 0x2000) == 0x2000) > > return 0; /* 80 wire */ > > return 1; > > > Alan, is this .24 material? > > The

Re: [patch for 2.6.24? 1/1] libata: correct handling of TSS DVD

2008-01-15 Thread Jeff Garzik
[EMAIL PROTECTED] wrote: From: Alan Cox <[EMAIL PROTECTED]> Devices that misreport the validity bit for word 93 look like SATA. If they are on the blacklist then we must not test for SATA but assume 40 wire in the 40 wire case (The TSSCorp reports 80 wire on SATA it seems!) Signed-off-by: Alan

(was: Re:...) [PATCH 12/12] ide-floppy: fix most of the remaining checkpatch.pl issues-v2

2008-01-15 Thread Borislav Petkov
... and finally the last one. Whew! I think we're done here for now. :) -- From: Borislav Petkov <[EMAIL PROTECTED]> Date: Tue, 15 Jan 2008 21:01:04 +0100 Subject: ide-floppy: fix most of the remaining checkpatch.pl issues-v2 such as ERROR: switch and case should be at the same indent ERROR: need

Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros

2008-01-15 Thread Borislav Petkov
On Mon, Jan 14, 2008 at 10:50:58PM +0100, Bartlomiej Zolnierkiewicz wrote: > On Sunday 13 January 2008, Borislav Petkov wrote: > > ..and replace them with flag enums. > > > > Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> > > --- > > drivers/ide/ide-floppy.c | 132 > > ++

Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros

2008-01-15 Thread Borislav Petkov
On Mon, Jan 14, 2008 at 11:32:58PM +0100, Bartlomiej Zolnierkiewicz wrote: > On Monday 14 January 2008, Bartlomiej Zolnierkiewicz wrote: > > On Sunday 13 January 2008, Borislav Petkov wrote: > > > ..and replace them with flag enums. > > > > > > Signed-off-by: Borislav Petkov <[EMAIL PROTECTED]> >

Re: [PATCH] [POWERPC] pasemi: Move electra-ide to pata_of_platform

2008-01-15 Thread Jeff Garzik
Olof Johansson wrote: Move electra-ide glue over to the new pata_of_platform framework, and add the quirks needed to that driver. --- Applied with the rest of the patches to pasemi.git for-2.6.25 arch/powerpc/platforms/pasemi/electra_ide.c | 96 b/arch/powe

Re: Trouble with hdparm -d on Dell D610

2008-01-15 Thread Kristin Vadas Marsicano
I've tried the following configurations, none of which ended up in DMA functioning on the D610. # CONFIG_BLK_DEV_PIIX is not set CONFIG_ATA_PIIX=y CONFIG_PATA_MPIIX=y CONFIG_PATA_OLDPIIX=y # CONFIG_BLK_DEV_PIIX is not set CONFIG_ATA_PIIX=y CONFIG_PATA_MPIIX=y # CONFIG_PATA_OLDPIIX is not set Ult

ata error codes

2008-01-15 Thread Raz
Mr Garzik Hello ata errors are some times cryptic. I am refering to this line, in the ata_qc_timeout which holds lots of information. printk(KERN_ERR "ata%u: command 0x%x timeout, stat 0x%x host_stat 0x%x\n", ap->id, qc->tf.command, drv_stat, host_stat) These errors varries , and many times SM

Re: sata_promise: Keeps saying SATA link down (SStatus 0 SControl 0)

2008-01-15 Thread Kurt Roeckx
On Tue, Jan 15, 2008 at 10:28:06AM +0100, Mikael Pettersson wrote: > > 00:08.0 RAID bus controller: Promise Technology, Inc. PDC20376 (FastTrak > 376) (rev 02) > ... > > 00:08.0 0104: 105a:3376 (rev 02) > > Let me guess, this is a Promise chip included on the mainboard > as a RAID controller, a

[PATCH] [POWERPC] pasemi: Move electra-ide to pata_of_platform

2008-01-15 Thread Olof Johansson
Move electra-ide glue over to the new pata_of_platform framework, and add the quirks needed to that driver. --- Applied with the rest of the patches to pasemi.git for-2.6.25 arch/powerpc/platforms/pasemi/electra_ide.c | 96 b/arch/powerpc/configs/pasemi_defcon

Re: [PATCH v4 0/3] OF-platform PATA driver

2008-01-15 Thread Olof Johansson
Hi, I've applied 1/3 and 2/3 together with my electra_ide move to pasemi.git for-2.6.25, and will ask Paul to pull that. Kumar said he'd take 3/3. I also added the const to the match table as spotted by Stephen. -Olof On Wed, Jan 09, 2008 at 10:08:52PM +0300, Anton Vorontsov wrote: > Hi all, >

Re: ATA device reset, shoud I be concerned?

2008-01-15 Thread Alan Cox
> > [ 9031.028000] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 action 0x2 > > frozen > > [ 9031.028000] ata1.00: cmd c8/00:08:90:ca:ce/00:00:00:00:00/e0 tag 0 cdb > > 0x0 > > data 4096 in > > [ 9031.028000] res 40/00:00:00:00:00/00:00:00:00:00/00 Emask 0x4 > > (timeout) We got bore

Re: unable to use cdrom/dvd drive after some usage

2008-01-15 Thread Alan Cox
On Mon, 14 Jan 2008 20:46:08 -0800 Johnny Luong <[EMAIL PROTECTED]> wrote: > Hi, > > If possible, I would like to know if its worthwhile simply just to get another > SATA drive / different controller / cable rather than trying to figure out > this PATA drive on SATA/PATA controller... see attach

Re: ATA device reset, shoud I be concerned?

2008-01-15 Thread Andrew Morton
On Mon, 14 Jan 2008 00:19:20 +0200 Georgi Chulkov <[EMAIL PROTECTED]> wrote: > Hello, > > During heavy disk load on my laptop, sometimes the IDE disk will pause for a > second and then continue. I get this in my kernel log: > > [ 9031.028000] ata1.00: exception Emask 0x0 SAct 0x0 SErr 0x0 actio

Re: sata_promise: Keeps saying SATA link down (SStatus 0 SControl 0)

2008-01-15 Thread Mikael Pettersson
Kurt Roeckx writes: > On Mon, Jan 14, 2008 at 09:30:07AM +0100, Mikael Pettersson wrote: > > > > The chip repeatedly signals plug and unplug events on its second > > ATA port. This is not a common error. > > > > I need a lot more information to debug this: > > - the output of /sbin/lspci