Re: [PATCH #upstream-fixes] ata_piix: Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.

2008-01-16 Thread Tejun Heo
Peter Schwenke wrote: > Tejun Heo wrote: >> If Toshiba is still doing this for their new products. We either need a >> better way to blacklist them or contact and tell them to stop what >> they're doing. Does anyone have a Toshiba contact? >> > > I've been thinking the same thing. It appears th

Re: [PATCH #upstream-fixes] ata_piix: Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.

2008-01-16 Thread Peter Schwenke
Tejun Heo wrote: > If Toshiba is still doing this for their new products. We either need a > better way to blacklist them or contact and tell them to stop what > they're doing. Does anyone have a Toshiba contact? > I've been thinking the same thing. It appears that all their newer laptops are

Re: [PATCH #upstream-fixes] ata_piix: Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.

2008-01-16 Thread Tejun Heo
Peter Schwenke wrote: > From: Peter Schwenke <[EMAIL PROTECTED]> > > Add Toshiba Satellite R20 and Tecra M6 to broken suspend list. This is > from OSDL bug 7780. > > Signed-off-by: Peter Schwenke <[EMAIL PROTECTED]> Acked-by: Tejun Heo <[EMAIL PROTECTED]> If Toshiba is still doing this for the

[PATCH #upstream-fixes] ata_piix: Add Toshiba Satellite R20 and Tecra M6 to broken suspend list.

2008-01-16 Thread Peter Schwenke
From: Peter Schwenke <[EMAIL PROTECTED]> Add Toshiba Satellite R20 and Tecra M6 to broken suspend list. This is from OSDL bug 7780. Signed-off-by: Peter Schwenke <[EMAIL PROTECTED]> --- drivers/ata/ata_piix.c | 14 ++ 1 files changed, 14 insertions(+), 0 deletions(-) diff --git a

Re: [sata] Anybody have a PDF converter?

2008-01-16 Thread Jeff Garzik
Posted as http://gkernel.sourceforge.net/specs/promise/pdc20621-pguide-1.2.pdf.bz2 Thanks all! Jeff - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [sata] Anybody have a PDF converter?

2008-01-16 Thread Mark Lord
Jeff Garzik wrote: Promise got me an open, non-NDA'd version of the SX4 (sata_sx4) docs: http://gtf.org/garzik/misc/PDC20621%20Programming%20Guide%20for%20Fastrak%20SX4_1.2_no_water_mark.doc.bz2 Unfortunately, they are in MS Word format and my OpenOffice refuses to import it. Would anyone

Re: The SX4 challenge

2008-01-16 Thread Mark Lord
Jeff Garzik wrote: .. Thus, the "SX4 challenge" is a challenge to developers to figure out the most optimal configuration for this hardware, given the existing MD and DM work going on. .. This sort of RAID optimization hardware is not unique to the SX4, so hopefully we can work out a way to ta

The SX4 challenge

2008-01-16 Thread Jeff Garzik
Promise just gave permission to post the docs for their PDC20621 (i.e. SX4) hardware: http://gkernel.sourceforge.net/specs/promise/pdc20621-pguide-1.2.pdf.bz2 joining the existing PDC20621 DIMM and PLL docs: http://gkernel.sourceforge.net/specs/promise/pdc20621-pguide-dimm-1.6.pdf.bz2 http://g

[PATCH 22/22] ide: move create_proc_ide_drives() call to ide_device_add_all()

2008-01-16 Thread Bartlomiej Zolnierkiewicz
* Un-static create_proc_ide_drives() and call it from ide_device_add_all(). While at it: * Rename create_proc_ide_drives() to ide_proc_port_register_devices(). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-probe.c |4 +++- drivers/ide/ide-proc.c |4 +--

[PATCH 19/22] ide-acpi: remove dead code from do_drive_get_GTF()

2008-01-16 Thread Bartlomiej Zolnierkiewicz
These pointers are always setup in ide_acpi_init(). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-acpi.c | 10 -- 1 file changed, 10 deletions(-) Index: b/drivers/ide/ide-acpi.c === --- a

[PATCH 20/22] ide: factor out devices setup from ide_acpi_init()

2008-01-16 Thread Bartlomiej Zolnierkiewicz
* Factor out devices setup from ide_acpi_init() to ide_acpi_port_init_devices(). * Call ide_acpi_port_init_devices() in ide_device_add_all(). While at it: * Remove no longer needed 'drive' field from struct ide_acpi_drive_link. There should be no functionality changes caused by this patch. Si

[PATCH 21/22] ide: move hwif->present check out from ide_proc_register_port()

2008-01-16 Thread Bartlomiej Zolnierkiewicz
Move hwif->present check out from ide_proc_register_port() to ide_device_add_all(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-probe.c |9 +++-- drivers/ide/ide-proc.c |3 --- 2 file

[PATCH 18/22] ide-acpi: remove needless exports

2008-01-16 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-acpi.c |4 1 file changed, 4 deletions(-) Index: b/drivers/ide/ide-acpi.c === --- a/drivers/ide/ide-acpi.c +++ b/drivers/ide/ide-acpi.c @@ -494

[PATCH 17/22] ide: move ide_acpi_init() call to ide_device_add_all()

2008-01-16 Thread Bartlomiej Zolnierkiewicz
There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-probe.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: b/drivers/ide/ide-probe.c

[PATCH 15/22] ide: factor out adding drive to hwgroup from init_irq()

2008-01-16 Thread Bartlomiej Zolnierkiewicz
Factor out adding drive to hwgroup from init_irq() to ide_add_drive_to_hwgroup(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-probe.c | 29 ++--- 1 file changed, 18 inser

[PATCH 16/22] ide: factor out devices setup from init_irq()

2008-01-16 Thread Bartlomiej Zolnierkiewicz
* Factor out devices setup from init_irq() to ide_port_setup_devices(). While at it: * Do devices setup after printing port information. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-probe.c | 44 1 file changed, 2

[PATCH 13/22] ide: merge init_gendisk() into hwif_register_devices()

2008-01-16 Thread Bartlomiej Zolnierkiewicz
There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-probe.c | 44 1 file changed, 16 insertions(+), 28 deletions(-) Index: b/drivers/ide/ide-probe.c

[PATCH 14/22] ide: move hwif->rqsize init from ide_init_queue() to init_irq()

2008-01-16 Thread Bartlomiej Zolnierkiewicz
Move hwif->rqsize init from ide_init_queue() to init_irq(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-probe.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) Index: b/dr

[PATCH 12/22] ide: call init_gendisk() after ide_acpi_init()

2008-01-16 Thread Bartlomiej Zolnierkiewicz
There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-probe.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/ide/ide-probe.c ==

[PATCH 10/22] ide: skip not present devices in init_gendisk()

2008-01-16 Thread Bartlomiej Zolnierkiewicz
No need to initialize drive->gendev and waste memory on IDE settings for not present devices. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-probe.c |4 1 file changed, 4 insertions(+) Index: b/drivers/ide/ide-probe.c ===

[PATCH 11/22] ide: move blk_register_region() call out from init_gendisk()

2008-01-16 Thread Bartlomiej Zolnierkiewicz
Move blk_register_region() call out from init_gendisk() to hwif_init(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-probe.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/d

[PATCH 09/22] ide: remove incorrect init_gendisk() comment

2008-01-16 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-probe.c |6 -- 1 file changed, 6 deletions(-) Index: b/drivers/ide/ide-probe.c === --- a/drivers/ide/ide-probe.c +++ b/drivers/ide/ide-probe.c @

[PATCH 07/22] ide: add IDE_HFLAG_NO_{IO32_BIT,UNMASK_IRQS} host flags

2008-01-16 Thread Bartlomiej Zolnierkiewicz
* Use the same bit for IDE_HFLAG_CS5520 and IDE_HFLAG_VDMA host flags (both are used only by cs5520 host driver currently). * Add IDE_HFLAG_NO_IO32_BIT host flag and use it instead of ->no_io_32bit ide_hwif_t field. * Add IDE_HFLAG_NO_UNMASK_IRQS host flag, then convert dtc2278 and rz1000 h

[PATCH 08/22] ide: add ->init_port_devs method to ide_hwif_t

2008-01-16 Thread Bartlomiej Zolnierkiewicz
* Add ->init_port_devs method to ide_hwif_t for a host specific initialization of devices on a port. Call the new method from ide_port_init_devices(). * Convert ht6560b, qd65xx and opti621 host drivers to use the new ->init_port_devs method. There should be no functionality changes caused

[PATCH 06/22] ide: factor out code initializing devices from ide_init_port()

2008-01-16 Thread Bartlomiej Zolnierkiewicz
* Factor out code initializing devices from ide_init_port() to ide_port_init_devices(). * Call the new function from ide_device_add_all(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide-probe.c |

[PATCH 04/22] ide: add ide_deprecated_find_port() helper

2008-01-16 Thread Bartlomiej Zolnierkiewicz
* Factor out code for finding ide_hwifs[] slot from ide_register_hw() to ide_deprecated_find_port(). * Convert bast-ide, ide-cs and delkin_cb host drivers to use ide_device_add() instead of ide_register_hw() (while at it drop doing "ide_unregister()" loop which tries to unregister _all_ IDE

[PATCH 05/22] ide: fix ide_unregister() usage in host drivers

2008-01-16 Thread Bartlomiej Zolnierkiewicz
bast-ide.c/ide-cs.c/delkin_cb.c: * Don't set 'restore' flag for ide_unregister() when initializing new interface. rapide.c/ide-pnp.c/ide-cs.c/ide_platform.c/au1xxx-ide.c/delkin_cb.c/scc_pata.c: * Don't set 'init_default' and 'restore' flags for ide_unregister() when removing interface. Sign

[PATCH 02/22] ide: remove redundant init_hwif_default() call from ide_register_hw()

2008-01-16 Thread Bartlomiej Zolnierkiewicz
ide_init_port_hw() call overrides setup done by init_hwif_default(). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Index: b/drivers/ide/ide.c =

[PATCH 03/22] ide: add 'init_default' and 'restore' arguments to ide_unregister()

2008-01-16 Thread Bartlomiej Zolnierkiewicz
* Add 'init_default' (flag for calling init_hwif_default()) and 'restore' (flag for calling ide_hwif_restore()) arguments to ide_unregister(). * Update ide_unregister() users to set 'init_default' and 'restore' flags. * No need to set 'init_default' flag in ide_register_hw() if the setup done

[PATCH 01/22] ide: remove redundant hwif->present check from ide_register_hw()

2008-01-16 Thread Bartlomiej Zolnierkiewicz
We check earlier for hwif->present and call ide_unregister() if necessary (after ide_unregister() hwif->present will be always cleared). Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]> --- drivers/ide/ide.c |2 -- 1 file changed, 2 deletions(-) Index: b/drivers/ide/ide.c ===

[PATCH 00/22] ide: even more IDE probing code rework

2008-01-16 Thread Bartlomiej Zolnierkiewicz
Just another bunch of small fixes/cleanups... diffstat: drivers/ide/arm/bast-ide.c| 22 +++- drivers/ide/arm/rapide.c |4 drivers/ide/ide-acpi.c| 60 +++ drivers/ide/ide-pnp.c |9 - drivers/ide/ide-probe.c | 204 +++

[sata] Anybody have a PDF converter?

2008-01-16 Thread Jeff Garzik
Promise got me an open, non-NDA'd version of the SX4 (sata_sx4) docs: http://gtf.org/garzik/misc/PDC20621%20Programming%20Guide%20for%20Fastrak%20SX4_1.2_no_water_mark.doc.bz2 Unfortunately, they are in MS Word format and my OpenOffice refuses to import it. Would anyone out there be willing to

Re: (was: Re:...) [PATCH 12/12] ide-floppy: fix most of the remaining checkpatch.pl issues-v2

2008-01-16 Thread Bartlomiej Zolnierkiewicz
On Tuesday 15 January 2008, Borislav Petkov wrote: > ... and finally the last one. Whew! I think we're done here for now. :) > > -- > From: Borislav Petkov <[EMAIL PROTECTED]> > Date: Tue, 15 Jan 2008 21:01:04 +0100 > Subject: ide-floppy: fix most of the remaining checkpatch.pl issues-v2 > > such

Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros

2008-01-16 Thread Bartlomiej Zolnierkiewicz
On Tuesday 15 January 2008, Borislav Petkov wrote: [...] > .. this is the second one... > > > From: Borislav Petkov <[EMAIL PROTECTED]> > Date: Tue, 15 Jan 2008 20:49:18 +0100 > Subject: [PATCH 16/18] ide-floppy: remove atomic test_*bit macros > > ..and replace them with flag enums. > > Signe

Re: [PATCH 10/12] ide-floppy: remove atomic test_*bit macros

2008-01-16 Thread Bartlomiej Zolnierkiewicz
On Tuesday 15 January 2008, Borislav Petkov wrote: > On Mon, Jan 14, 2008 at 11:32:58PM +0100, Bartlomiej Zolnierkiewicz wrote: > > On Monday 14 January 2008, Bartlomiej Zolnierkiewicz wrote: > > > On Sunday 13 January 2008, Borislav Petkov wrote: > > > > ..and replace them with flag enums. > > > >

Re: [PATCH 1/2] [libata] sata_mv: Remove PCI dependency

2008-01-16 Thread Mark Lord
saeed bishara wrote: I attached the new patch .. Try again, please. This time, post the patch *inline* in the body of the email, so that it can more easily be seen, read, and commented on. Beware of many email clients that mangle inline patches, though. Cheers - To unsubscribe from this list

Re: [PATCH 1/2] [libata] sata_mv: Remove PCI dependency

2008-01-16 Thread saeed bishara
On 1/16/08, Jeff Garzik <[EMAIL PROTECTED]> wrote: > saeed bishara wrote: > > - if (unlikely(irq_stat & PCI_ERR)) { > > + if (unlikely(irq_stat & PCI_ERR) && HAS_PCI(host)) { > > mv_pci_error(host, mmio); > > handled = 1; > > goto out_unlock;/* skip a

ATA, SATA Disk Problems

2008-01-16 Thread rgheck
Hi, and sorry if this turns out to be a known issue. Actually, I'll be thrilled if this turns out to be a known issue. But I've searched on it forever, and although I've found some information, I've not found a definite fix. Possibly my fault, but this is driving me nuts. System: Asus P5N32E

Re: [PATCH 1/4] sata_qstor: convert to new data_xfer prototype

2008-01-16 Thread Jeff Garzik
Tejun Heo wrote: While merging data_xfer prototype change, pata_pcmcia was left out. Convert it. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- drivers/ata/pata_pcmcia.c | 19 +++ 1 files changed, 11 insertions(+), 8 deletions(-) applied - To unsubscribe from this list:

Re: [PATCH 3/5] libata: factor out ata_pci_activate_sff_host() from ata_pci_one()

2008-01-16 Thread Jeff Garzik
Tejun Heo wrote: Factor out ata_pci_activate_sff_host() from ata_pci_one(). This does about the same thing as ata_host_activate() but needs to be separate because SFF controllers use different and multiple IRQs in legacy mode. This will be used to make SFF LLD initialization more flexible. Sig

Re: [PATCH 1/5] ata_piix: kill unused constants and flags

2008-01-16 Thread Jeff Garzik
Tejun Heo wrote: Kill PIIX_FLAG_SCR, PIIX_PORT_ENABLED and PIIX_PORT_PRESENT. These are unused. Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> --- drivers/ata/ata_piix.c | 27 +++ 1 files changed, 7 insertions(+), 20 deletions(-) applied 1-2 - To unsubscribe from th

Re: [PATCH 1/2] [libata] sata_mv: Remove PCI dependency

2008-01-16 Thread Jeff Garzik
saeed bishara wrote: - if (unlikely(irq_stat & PCI_ERR)) { + if (unlikely(irq_stat & PCI_ERR) && HAS_PCI(host)) { mv_pci_error(host, mmio); handled = 1; goto out_unlock;/* skip all other HC irq handling */ the unlikely() should

Re: sata_promise: Keeps saying SATA link down (SStatus 0 SControl 0)

2008-01-16 Thread Mikael Pettersson
Kurt Roeckx writes: > On Tue, Jan 15, 2008 at 10:28:06AM +0100, Mikael Pettersson wrote: > > > 00:08.0 RAID bus controller: Promise Technology, Inc. PDC20376 > > (FastTrak 376) (rev 02) > > ... > > > 00:08.0 0104: 105a:3376 (rev 02) > > > > Let me guess, this is a Promise chip included o