> > +static inline u32 ioread(u32 reg)
> > +{
> > + return ioread32(base + reg);
> > +}
> > +
> > +static inline void iowrite(u32 val, u32 reg)
> > +{
> > + iowrite32(val, base + reg);
> > +}
>
> Why not just use ioread32/iowrite32 directly ?
Because this increases readability and does not af
Bartlomiej Zolnierkiewicz wrote:
* ->nice0 and ->nice2 ide_drive_t fields are always zero so remove them.
* IDE_NICE_0 and IDE_NICE_2 defines from are no longer
used by any kernel code so cover them with #ifndef/#endif __KERNEL__.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECT
Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Bartlomiej Zolnierkiewicz wrote:
* Use __ide_set_handler() in ide_execute_command().
While at it:
* Fix whitespace damage in ide_execute_command().
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
MBR, Sergei
-
To unsubscribe
Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
On Tue, 22 Jan 2008 15:11:37 +0300
Anton Salnikov <[EMAIL PROTECTED]> wrote:
> > > +static inline u32 ioread(u32 reg)
> > > +{
> > > + return ioread32(base + reg);
> > > +}
> > > +
> > > +static inline void iowrite(u32 val, u32 reg)
> > > +{
> > > + iowrite32(val, base + reg);
> > > +}
> >
> > Wh
Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Bartlomiej Zolnierkiewicz wrote:
While at it:
* Remove needless '!drive->crc_count' check.
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
th
Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Bartlomiej Zolnierkiewicz wrote:
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
MBR, Sergei
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
2.6.24-rc8-mm1 is corrupting. smartd does some sg_ioctl into its stack,
and depending on how its stack randomization worked out, this is liable
to end up writing into the adjacent physical page too. If you're lucky
you have highmem, and ioread16_rep oopses on the virtual address beyond
what ata_p
Added linux-scsi to the cc.
On Tue, 2008-01-22 at 17:11 +, Hugh Dickins wrote:
> 2.6.24-rc8-mm1 is corrupting. smartd does some sg_ioctl into its stack,
> and depending on how its stack randomization worked out, this is liable
> to end up writing into the adjacent physical page too. If you'r
On Tue, 22 Jan 2008, James Bottomley wrote:
> > --- 2.6.24-rc8-mm1/drivers/ata/libata-scsi.c2008-01-17
> > 16:49:47.0 +
> > +++ linux/drivers/ata/libata-scsi.c 2008-01-22 15:45:40.0 +
> > @@ -826,7 +826,7 @@ static void ata_scsi_sdev_config(struct
> > sdev->max
Anton Salnikov wrote:
+static inline u32 ioread(u32 reg)
+{
+ return ioread32(base + reg);
+}
+
+static inline void iowrite(u32 val, u32 reg)
+{
+ iowrite32(val, base + reg);
+}
Why not just use ioread32/iowrite32 directly ?
Because this increases readability and does not affect fu
On Tue, 2008-01-22 at 18:36 +, Hugh Dickins wrote:
> On Tue, 22 Jan 2008, James Bottomley wrote:
> > > --- 2.6.24-rc8-mm1/drivers/ata/libata-scsi.c 2008-01-17
> > > 16:49:47.0 +
> > > +++ linux/drivers/ata/libata-scsi.c 2008-01-22 15:45:40.0
> > > +
> > > @@
On Tue, 22 Jan 2008, James Bottomley wrote:
>
> Actually, I don't think it's a smaller I/O issue. The SMART protocol
> specifically mandates that the transfers for SMART READ DATA and SMART
> READ LOG shall be 512 bytes). However, the pio transfer routine does
> seem to be assuming sector alignm
Hello.
Anton Salnikov wrote:
This is Palmchip BK3710 IDE controller support for kernel version 2.6.24-rc8.
The IDE controller logic supports PIO, multiword DMA and ultra-DMA modes.
Supports interface to compact Flash (CF) configured in True-IDE mode.
Use ide_setup_dma() since BLK_DEV_PALMCHI
It appears that the problem was caused by a faulty power supply. Thanks
anyway!
On Tuesday 15 January 2008 11:54:35 Andrew Morton wrote:
> On Mon, 14 Jan 2008 00:19:20 +0200 Georgi Chulkov
<[EMAIL PROTECTED]> wrote:
> > Hello,
> >
> > During heavy disk load on my laptop, sometimes the IDE disk w
James Bottomley wrote:
Actually, I don't think it's a smaller I/O issue. The SMART protocol
specifically mandates that the transfers for SMART READ DATA and SMART
READ LOG shall be 512 bytes). However, the pio transfer routine does
seem to be assuming sector alignment as well, which will be whe
Dan Nica wrote:
hello
I have a problem with a serial ata controller
that uses a SiI 3512 chip.
A complete dmesg, complete lspci would be helpful.
when I'm trying to add a device thats on the 3512 controller
to the array that I have, it give me lots of errors in dmesg
like this:
ata3.00: e
On Tue, 2008-01-22 at 20:20 +, Hugh Dickins wrote:
> On Tue, 22 Jan 2008, James Bottomley wrote:
> >
> > Actually, I don't think it's a smaller I/O issue. The SMART protocol
> > specifically mandates that the transfers for SMART READ DATA and SMART
> > READ LOG shall be 512 bytes). However,
> However, I'd like to see if we can track the problem through the SG_IO
> direct path ... how many adjacent page bytes are corrupt? Just a few or
> a large number (I'm wondering if it's an off by one or off by alignment
> type bug)?
Which ATA controller is involved - in theory ATA DMA is byte al
> Why you chose to use ioread32() and iowrite32() if your device is
> strictly
> memory mapped? Those functions add some overhead, and boil down to readl()
> and
There are distinct portability advantages but you shouldn't mix
ioread32/iowrite32 with ioremap as that isn't guaranteed to work
On Tue, 22 Jan 2008, Alan Cox wrote:
> > However, I'd like to see if we can track the problem through the SG_IO
> > direct path ... how many adjacent page bytes are corrupt? Just a few or
> > a large number (I'm wondering if it's an off by one or off by alignment
> > type bug)?
We moved away from
No reason to use ide_init_hwif_ports() in ide-cs (as a nice side-effect
this makes ide-cs work on archs that don't define IDE_ARCH_OBSOLETE_INIT).
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
---
drivers/ide/legacy/ide-cs.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
* Replace incorrect CONFIG_BLK_DEV_IDE #ifdef in
check_media_bay() by CONFIG_MAC_FLOPPY one.
* Replace incorrect CONFIG_BLK_DEV_IDE #ifdef-s by
CONFIG_BLK_DEV_IDE_PMAC ones.
* check_media_bay() is used only by drivers/block/swim3.c
so make this function available only if CONFIG_MAC_FLOPPY
On Tue, 22 Jan 2008, James Bottomley wrote:
>
> libsas looks to be OK because it specifically kmallocs a 512 byte buffer
> which should (for off slab data) be 512 byte aligned.
I don't remember the various SLAB and SLOB and SLUB rules offhand:
I'm not sure it's safe to rely on such alignment on a
On Tue, 2008-01-22 at 15:32 -0500, Jeff Garzik wrote:
> James Bottomley wrote:
> > Actually, I don't think it's a smaller I/O issue. The SMART protocol
> > specifically mandates that the transfers for SMART READ DATA and SMART
> > READ LOG shall be 512 bytes). However, the pio transfer routine do
On Tue, 2008-01-22 at 22:59 +, Hugh Dickins wrote:
> On Tue, 22 Jan 2008, James Bottomley wrote:
> >
> > libsas looks to be OK because it specifically kmallocs a 512 byte buffer
> > which should (for off slab data) be 512 byte aligned.
>
> I don't remember the various SLAB and SLOB and SLUB
mikp wrote:
>>> The JMB361 controller is more quirky. I had to reboot and replug 3 or 4
>>> times before the PMP box started working normal. Here is syslog and dmesg
>>> of boot
>>> and reboot to finally get JMB361 working:
>> The log messages are truncated. Can you please post a clean kernel lo
On Jan 21 2008 05:48, Matthew Wilcox wrote:
>On Mon, Jan 21, 2008 at 02:13:52PM +0900, Tejun Heo wrote:
>> In a nutshell, printk_header() lets you do the following atomically
>> (against other messages).
>>
>> code:
>> printk(KERN_INFO "ata1.00: ", "line0\nline1\nline2\n");
>>
>> output:
>>
Jan Engelhardt wrote:
> On Jan 21 2008 05:48, Matthew Wilcox wrote:
>> On Mon, Jan 21, 2008 at 02:13:52PM +0900, Tejun Heo wrote:
>>> In a nutshell, printk_header() lets you do the following atomically
>>> (against other messages).
>>>
>>> code:
>>> printk(KERN_INFO "ata1.00: ", "line0\nline1\nl
On Jan 23 2008 08:51, Tejun Heo wrote:
>
>What do you think about the second suggestion then?
>
>ata1.00: line0
>ata1.00 line1
>ata1.00 line2
>
>It allows you to grab for the header && has indication for message
>boundaries.
Then again, why not "[ata1.00] line0", then it matches what sd_mod doe
On Tue, 2008-01-22 at 22:59 +, Hugh Dickins wrote:
> On Tue, 22 Jan 2008, James Bottomley wrote:
> >
> > libsas looks to be OK because it specifically kmallocs a 512 byte buffer
> > which should (for off slab data) be 512 byte aligned.
>
> I don't remember the various SLAB and SLOB and SLUB
On Wed, 2008-01-23 at 00:12 +0100, Bartlomiej Zolnierkiewicz wrote:
> * Replace incorrect CONFIG_BLK_DEV_IDE #ifdef in
> check_media_bay() by CONFIG_MAC_FLOPPY one.
>
> * Replace incorrect CONFIG_BLK_DEV_IDE #ifdef-s by
> CONFIG_BLK_DEV_IDE_PMAC ones.
>
> * check_media_bay() is used only by
Jan Engelhardt wrote:
> On Jan 23 2008 08:51, Tejun Heo wrote:
>> What do you think about the second suggestion then?
>>
>> ata1.00: line0
>> ata1.00 line1
>> ata1.00 line2
>>
>> It allows you to grab for the header && has indication for message
>> boundaries.
>
> Then again, why not "[ata1.00]
Hi,
On Wednesday 23 January 2008, Benjamin Herrenschmidt wrote:
>
> On Wed, 2008-01-23 at 00:12 +0100, Bartlomiej Zolnierkiewicz wrote:
> > * Replace incorrect CONFIG_BLK_DEV_IDE #ifdef in
> > check_media_bay() by CONFIG_MAC_FLOPPY one.
> >
> > * Replace incorrect CONFIG_BLK_DEV_IDE #ifdef-s
Tejun Heo wrote:
Jeff Garzik wrote:
saeed bishara wrote:
-if (unlikely(irq_stat & PCI_ERR)) {
+if (unlikely(irq_stat & PCI_ERR) && HAS_PCI(host)) {
mv_pci_error(host, mmio);
handled = 1;
goto out_unlock;/* skip all other HC irq handling */
the unlikely()
Jeff Garzik wrote:
> Tejun Heo wrote:
>> Jeff Garzik wrote:
>>> saeed bishara wrote:
-if (unlikely(irq_stat & PCI_ERR)) {
+if (unlikely(irq_stat & PCI_ERR) && HAS_PCI(host)) {
mv_pci_error(host, mmio);
handled = 1;
goto out_unlock;/* s
On Wed, 2008-01-23 at 01:58 +0100, Bartlomiej Zolnierkiewicz wrote:
> I'm more worried about breaking automatic build checking (make randconfig)
> than a few extra bytes so if you remove all #ifdefs you'll have to either
> make BLK_DEV_IDE_PMAC select PMAC_MEDIABAY or make PMAC_MEDIABAY depend
> o
On 1/21/08, Tejun Heo <[EMAIL PROTECTED]> wrote:
> Hello, Thomas.
Hi -
> Can you install linux on a x86 machine and see whether anything is
> different?
Did that today - it mostly works. There is some sort of conflict with
the card on the PC I am using. During POST I sometimes get a "Plug
and P
Hello,
Thomas Evans wrote:
> On 1/21/08, Tejun Heo <[EMAIL PROTECTED]> wrote:
>> Can you install linux on a x86 machine and see whether anything is
>> different?
>
> Did that today - it mostly works. There is some sort of conflict with
> the card on the PC I am using. During POST I sometimes ge
Resending this mail and adding linux-ide mail list...
Quoting Tejun:
> Uh-oh, wait a bit. Nope. Until we figure out what the something else
is
> and positively verify 64bit DMA works fine, the quirk stays in.
Our HW engineer has confirmed that our SB600 SATA controller indeed has
some MSI issue,
48 matches
Mail list logo
