Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 34 --
1 files changed, 0 insertions(+), 34 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 552cfed..3bedeb8 100644
--- a/drivers/ide/ide-tape.c
+++
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 40 +++-
1 files changed, 15 insertions(+), 25 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 173ac0d..0542b07 100644
--- a/drivers/ide/ide-tape.c
Hi Bart,
after a lot of hammering ide-tape got pimped pretty considerably (ca. 600 lines
shorter and slicker :)). I'm sure there's more to be done like, e.g. replacing
the BKL in idetape_write_release() with finer-grained locking etc, probably also
some pipeline improvements, removal of OnStream
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 83 +++
1 files changed, 27 insertions(+), 56 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 3bedeb8..173ac0d 100644
---
The device capabilities are probed for during device initialization so this
info is available through proc/ioctl() und it is redundant here.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 74
1 files changed, 0
Also, cleanup whitespace and update comments.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
Documentation/ide/ChangeLog.ide-tape.1995-2002 | 405 +++
drivers/ide/ide-tape.c | 414 +---
2 files changed, 409 insertions(+),
From: Borislav Petkov [EMAIL PROTECTED]
This function was being used only at one place so fold it in there.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 36
1 files changed, 16 insertions(+), 20 deletions(-)
diff --git
From: Borislav Petkov [EMAIL PROTECTED]
Those are already in mtio.h.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 96 +++
1 files changed, 15 insertions(+), 81 deletions(-)
diff --git a/drivers/ide/ide-tape.c
From: Borislav Petkov [EMAIL PROTECTED]
Also, remove those which weren't used.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 80 ++--
1 files changed, 30 insertions(+), 50 deletions(-)
diff --git
From: Borislav Petkov [EMAIL PROTECTED]
Also, shorten function name idetape_get_blocksize_from_block_descriptor() and
move its definition up thereby getting rid of its forward declaration.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 68
From: Borislav Petkov [EMAIL PROTECTED]
There should be no functional changes resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 19 ---
1 files changed, 0 insertions(+), 19 deletions(-)
diff --git a/drivers/ide/ide-tape.c
From: Borislav Petkov [EMAIL PROTECTED]
There should be no functional changes resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 51 ---
1 files changed, 13 insertions(+), 38 deletions(-)
diff
From: Borislav Petkov [EMAIL PROTECTED]
There should be no functional changes resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 49 +--
1 files changed, 18 insertions(+), 31 deletions(-)
diff
From: Borislav Petkov [EMAIL PROTECTED]
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 42 ++
1 files changed, 2 insertions(+), 40 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index
From: Borislav Petkov [EMAIL PROTECTED]
All those 2-byte values denoting the different capabilities are being written to
the local copy of the caps buffer without being converted to big endian for
simplicity of usage and shorter code later. Also, we add some comments stating
which are the fields
From: Borislav Petkov [EMAIL PROTECTED]
Teach the debug logging macro to differentiate different log levels based on the
type of debug level enabled specifically instead of a threshold-based one.
Thus, convert tape-debug_level to a bitmask that is written to over /proc.
Also,
- Cleanup and
From: Borislav Petkov [EMAIL PROTECTED]
There should be no functional changes resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 19 ---
1 files changed, 0 insertions(+), 19 deletions(-)
diff --git a/drivers/ide/ide-tape.c
From: Borislav Petkov [EMAIL PROTECTED]
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 18 --
1 files changed, 0 insertions(+), 18 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 02f5d5e..0708049 100644
---
From: Borislav Petkov [EMAIL PROTECTED]
They seem just to sit there completely unused.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 37 -
1 files changed, 0 insertions(+), 37 deletions(-)
diff --git a/drivers/ide/ide-tape.c
From: Borislav Petkov [EMAIL PROTECTED]
ide-tape has depended on EXPERIMENTAL for ages. Change that since the driver is
being only maintained now.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/Kconfig |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git
From: Borislav Petkov [EMAIL PROTECTED]
This is not a network driver.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index
From: Borislav Petkov [EMAIL PROTECTED]
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 60 ---
1 files changed, 31 insertions(+), 29 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index
From: Borislav Petkov [EMAIL PROTECTED]
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c |9 +
1 files changed, 1 insertions(+), 8 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index 5a18158..fd7eeea 100644
---
From: Borislav Petkov [EMAIL PROTECTED]
idetape_active_next_stage() was rather ambiguous wrt its purpose. Make that
more explicit and remove superfluous comment.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c |9 +++--
1 files changed, 3 insertions(+), 6
From: Borislav Petkov [EMAIL PROTECTED]
Since this is used only in idetape_blkdev_ioctl(), remove the typedef and make
the struct function-local.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 23 +++
1 files changed, 11 insertions(+), 12
From: Borislav Petkov [EMAIL PROTECTED]
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 29 +++--
1 files changed, 15 insertions(+), 14 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index f8a4b27..d4c4255 100644
From: Borislav Petkov [EMAIL PROTECTED]
Bart,
this one is rather intrusive so please doublecheck it wrt to kzalloc/kfree
balancing on all the codepaths so that we don't leak memory all over the place.
I free all the alloc'd pc's and rq's in idetape_end_request() which is called
from the callback
From: Borislav Petkov [EMAIL PROTECTED]
Some member names are self-explanatory, so remove their respective
comments. Also, explain the exact purpose of struct members in comments
in the struct definition instead of using excessively long member names
thus replacing then with a shorter, more handy
From: Borislav Petkov [EMAIL PROTECTED]
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 88 ---
1 files changed, 45 insertions(+), 43 deletions(-)
diff --git a/drivers/ide/ide-tape.c b/drivers/ide/ide-tape.c
index
From: Borislav Petkov [EMAIL PROTECTED]
tape-speed_ctl is set to 1 in idetape_setup(), but, in calculate_speeds() its
value is tested for being 0, 1, or 2. Remove the if-branches where
tape-speed_ctl != 1 since they are never executed.
Also, rename calculate_speeds() by adding driver's prefix as
From: Borislav Petkov [EMAIL PROTECTED]
Also remove flag IDETAPE_READ_ERROR since it is unused.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 222 +---
1 files changed, 117 insertions(+), 105 deletions(-)
diff --git
Hi Bart,
sorry for that thread split but i had to resend those remaining patches with
gmail because yahoo have a restriction on the number of mails one can send per
day :(
--
Regards/Gruß,
Boris.
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message
On Saturday 26 January 2008, Bartlomiej Zolnierkiewicz wrote:
On Saturday 26 January 2008, Jan Engelhardt wrote:
On Jan 26 2008 21:31, Frans Pop wrote:
config BLK_DEV_IDE_PMAC
- bool Builtin PowerMac IDE support
+ tristate Builtin PowerMac IDE support
this change is
Hi,
I'm having problems with my disk on a Latitude D820 after upgrading
kernel to any 2.6.20 No DMA support can be activated, giving me a very
poor I/O performance.
I'm using ata_piix driver on a ICH7 system with no AHCI support AFAIK
I opened a thread[1] on gentoo-forums (the distro I use)
Mikel Olasagasti wrote:
Hi,
I'm having problems with my disk on a Latitude D820 after upgrading
kernel to any 2.6.20 No DMA support can be activated, giving me a very
poor I/O performance.
I'm using ata_piix driver on a ICH7 system with no AHCI support AFAIK
..
Actually, no. You are really
Hi Mikael,
Thanks!
It works perfectly at 1.5Gbps :-)
I think that because it fails at 3Gbps it might eventually fail at
1.5Gbps also... And the error handling was not robust (in my setup with
these drives at 3Gbps).
If I can help investigate further, I'm happy to do that. I have a spare
I've been noticing something strange on an AMD Geode LX board that I
have.. I have two SATA drives connected to the onboard Sil3114 chip,
and the drives appear to be continually restarting (soft resetting?)
during normal operation when nothing at all is happening on the
machine. You can hear the
Andrew Paprocki wrote:
I've been noticing something strange on an AMD Geode LX board that I
have.. I have two SATA drives connected to the onboard Sil3114 chip,
and the drives appear to be continually restarting (soft resetting?)
during normal operation when nothing at all is happening on the
Both drives already had PM disabled, visible in hdparm -i:
AdvancedPM=yes: disabled (255) WriteCache=enabled
Looking at the smart reporting, it is showing both drives have a
FAILING_NOW condition for Seek_Error_Rate. I don't know what to
believe, because it seems like whatever drives I attach to
On Sunday 27 January 2008, Borislav Petkov wrote:
Also, cleanup whitespace and update comments.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
applied with some changes
---
Documentation/ide/ChangeLog.ide-tape.1995-2002 | 405 +++
drivers/ide/ide-tape.c
On Sunday 27 January 2008, Borislav Petkov wrote:
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 83 +++
1 files changed, 27 insertions(+), 56 deletions(-)
applied with minor changes
diff --git
On Sunday 27 January 2008, Borislav Petkov wrote:
From: Borislav Petkov [EMAIL PROTECTED]
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
applied
---
drivers/ide/ide-tape.c | 42 ++
1 files changed, 2 insertions(+), 40 deletions(-)
diff --git
On Sunday 27 January 2008, Borislav Petkov wrote:
From: Borislav Petkov [EMAIL PROTECTED]
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 88 ---
1 files changed, 45 insertions(+), 43 deletions(-)
diff --git
On Sunday 27 January 2008, Borislav Petkov wrote:
From: Borislav Petkov [EMAIL PROTECTED]
There should be no functional changes resulting from this patch.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 49 +--
Hi,
On Sunday 27 January 2008, Borislav Petkov wrote:
Hi Bart,
after a lot of hammering ide-tape got pimped pretty considerably (ca. 600
lines
shorter and slicker :)). I'm sure there's more to be done like, e.g. replacing
Good work. :)
the BKL in idetape_write_release() with
On Sunday 27 January 2008, Borislav Petkov wrote:
From: Borislav Petkov [EMAIL PROTECTED]
... by adding a new typedef function pointer idetape_io_buf in order to call
the proper buffer i/o handler depending on the data direction.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
On Sunday 27 January 2008, Borislav Petkov wrote:
From: Borislav Petkov [EMAIL PROTECTED]
Since this is used only in idetape_blkdev_ioctl(), remove the typedef and make
the struct function-local.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
applied
---
drivers/ide/ide-tape.c |
On Sunday 27 January 2008, Borislav Petkov wrote:
From: Borislav Petkov [EMAIL PROTECTED]
Teach the debug logging macro to differentiate different log levels based on
the
type of debug level enabled specifically instead of a threshold-based one.
Thus, convert tape-debug_level to a bitmask
On Sunday 27 January 2008, Borislav Petkov wrote:
From: Borislav Petkov [EMAIL PROTECTED]
All those 2-byte values denoting the different capabilities are being written
to
the local copy of the caps buffer without being converted to big endian for
simplicity of usage and shorter code later.
On Sunday 27 January 2008, Borislav Petkov wrote:
From: Borislav Petkov [EMAIL PROTECTED]
Those are already in mtio.h.
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
applied
---
drivers/ide/ide-tape.c | 96 +++
1 files changed, 15
On Sunday 27 January 2008, Borislav Petkov wrote:
From: Borislav Petkov [EMAIL PROTECTED]
tape-speed_ctl is set to 1 in idetape_setup(), but, in calculate_speeds() its
value is tested for being 0, 1, or 2. Remove the if-branches where
tape-speed_ctl != 1 since they are never executed.
On Sunday 27 January 2008, Borislav Petkov wrote:
From: Borislav Petkov [EMAIL PROTECTED]
Signed-off-by: Borislav Petkov [EMAIL PROTECTED]
---
drivers/ide/ide-tape.c | 60 ---
1 files changed, 31 insertions(+), 29 deletions(-)
diff --git
Am So, 27.01.2008, 01:38, schrieb [EMAIL PROTECTED]:
Am Sa, 26.01.2008, 23:33, schrieb Tejun Heo:
[EMAIL PROTECTED] wrote:
I could solve the problem by ncq blacklisting the Maxtor 6V300F0
devices in libata-core.c
That's a strange story. The reported error was PHY readiness changed
and
Thomas Evans wrote:
Tejun and all -
I have a new log - I got somewhat further by setting this bit when
init'd via HOST_CTRL:
Bit [28]: PERR Rpt Dsbl (R/W) – PERR Report Disable. This bit, when set
to one, disables reporting of PCI bus
parity errors to the Command Execution State Machine
Tejun Heo wrote:
- /* prereset() might have modified ehc-i.action */
- if (ehc-i.action ATA_EH_HARDRESET)
- reset = hardreset;
- else if (ehc-i.action ATA_EH_SOFTRESET)
- reset = softreset;
- else {
Seems we'll need this chunk. Will post updated
Tejun Heo wrote:
Tejun Heo wrote:
-/* prereset() might have modified ehc-i.action */
-if (ehc-i.action ATA_EH_HARDRESET)
-reset = hardreset;
-else if (ehc-i.action ATA_EH_SOFTRESET)
-reset = softreset;
-else {
Seems we'll need this chunk. Will
I hate blasting the the list with every minute detail.
On 1/27/08, Tejun Heo [EMAIL PROTECTED] wrote:
Hmmm... That's strange. If PERR makes a difference, it means PCI bus
side is contributing to the problem but only when PMP is attached while
directly attached drive works just fine?
I need
57 matches
Mail list logo
