http://bugzilla.kernel.org/show_bug.cgi?id=9921
Summary: Problem burning DVDs with Marvell 88SE6121 on
pata_marvell
Product: IO/Storage
Version: 2.5
KernelVersion: 2.6.24
Platform: All
OS/Version: Linux
Tree:
Tejun Heo wrote:
>>> * No reason to set ata_pci_default_filter() for PIO-only drivers.
>> and your patches add the calls for the CS5520 ?
>>
>>> diff --git a/drivers/ata/pata_cs5520.c b/drivers/ata/pata_cs5520.c
>>> index 972ed9f..5614e76 100644
>>> --- a/drivers/ata/pata_cs5520.c
>>> +++ b/drivers
Alan Cox wrote:
>> * Every driver for SFF controllers now uses ata_pci_default_filter()
>> unless the driver has custom implementation.
>
> That is only needed for DMA capable devices. I guess it does no harm to
> be consistent and call it anyway but you then say ..
Yeah, it's kind of fuzzy to
Alan Cox wrote:
> On Wed, 30 Jan 2008 18:29:01 +0900
> Tejun Heo <[EMAIL PROTECTED]> wrote:
>
>> port_info->private_data is currently used for two purposes - to record
>> private data about the port_info or to specify host->private_data to
>> use when allocating ata_host.
>
> Sensible point, horr
Jeff Garzik wrote:
> Tejun Heo wrote:
>> diff --git a/drivers/ata/ahci.c b/drivers/ata/ahci.c
>> index 07dcaf6..08301ca 100644
>> --- a/drivers/ata/ahci.c
>> +++ b/drivers/ata/ahci.c
>> @@ -351,6 +351,8 @@ static const struct ata_port_operations
>> ahci_vt8251_ops = {
>> .port_suspend=
Akira Iguchi wrote:
> Tejun Heo wrote:
>> The following drivers need specific platform to build, so they need
>> verification. If you work on one of the following drivers, please
>> verify that the driver builds and works fine. It would be best if you
>> can verify that the sht and ops don't chan
From: James Bottomley <[EMAIL PROTECTED]>
ATA requires that all DMA transfers begin and end on word boundaries.
Because of this, a large amount of machinery grew up in ide to adjust
scatterlists on this basis. However, as of 2.5, the block layer has a
dma_alignment variable which ensures both the
From: James Bottomley <[EMAIL PROTECTED]>
This just updates the libata slave configure routine to take advantage
of the block layer drain buffers. It also adjusts the size lengths in
the atapi code to add the drain buffer to the DMA length so the driver
knows it can rely on it.
I suspect I shoul
Clear drain buffer before chaining if the command in question is a
write.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
---
block/blk-merge.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/block/blk-merge.c b/block/blk-merge.c
index d50cfc8..d0b9031 100644
--- a/block/b
For misc ATAPI commands which transfer variable length data to the
host, overflow can occur due to application or hardware bug. Such
overflows can be ignored safely as long as overflow data is properly
drained. libata HSM implementation has this implemented in
__atapi_pio_bytes() and recently upd
With padding and draining moved into it, block layer now may extend
requests as directed by queue parameters, so now a request has two
sizes - the original request size and the extended size which matches
the size of area pointed to by bios and later by sgs. The latter size
is what lower layers ar
This is the second take of blk-layer-padding-and-draining patchset.
Changes from the last take[L] are...
* libata-update-ATAPI-overflow-draining patch added. This patch fixes
up ATAPI PIO handling before updating it to use block layer
draining. consumed accounting and atapi_qc_may_overflow(
Draining shouldn't be done for commands where overflow may indicate
data integrity issues. Add dma_drain_needed callback to
request_queue. Drain buffer is appened iff this function returns
non-zero.
Signed-off-by: Tejun Heo <[EMAIL PROTECTED]>
Cc: James Bottomley <[EMAIL PROTECTED]>
---
block/b
DMA start address and transfer size alignment for PC requests are
achieved using bio_copy_user() instead of bio_map_user(). This works
because bio_copy_user() always uses full pages and block DMA alignment
isn't allowed to go over PAGE_SIZE.
However, the implementation didn't update the last bio
Jeff Garzik wrote:
> Jens Axboe wrote:
>> On Fri, Feb 08 2008, Jeff Garzik wrote:
>>> Jeff Garzik wrote:
Tejun Heo wrote:
> This patchset updates block layer padding and draining support and
> make libata use it. It's based on James Bottomley's initial work and,
> of the five, the
Commit 9e016a719209d95338e314b46c3012cc7feaaeec causes the following
compile error:
<-- snip -->
...
CC drivers/ide/arm/bast-ide.o
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide/arm/bast-ide.c: In
function 'bastide_register':
/home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/ide
Hi,
I've just tried booting the 2.6.24.1 kernel, except without nmi_watchdog being
enabled. It looks
like there are IRQs still not being enabled.
Cheers,
Chris
Linux version 2.6.24.1 ([EMAIL PROTECTED]) (gcc version 4.1.2 20070925 (Red Hat
4.1.2-33))
#1 SMP PREEMPT Fri Feb 8 22:41:10 GMT 2008
Alan Cox wrote:
On Fri, 8 Feb 2008 16:25:08 +0100
Christoph Hellwig <[EMAIL PROTECTED]> wrote:
When trying to put some stress on qemu by running the xfs testsuite
I get the following:
debian:~/xfs-cmds/xfstests# sh check
[ 438.166822] SGI XFS with ACLs, security attributes, realtime, large b
Jens Axboe wrote:
On Fri, Feb 08 2008, Jeff Garzik wrote:
Jeff Garzik wrote:
Tejun Heo wrote:
This patchset updates block layer padding and draining support and
make libata use it. It's based on James Bottomley's initial work and,
of the five, the last two patches are from James with some
mod
On Thu, 07 Feb 2008 23:30:42 -0500
Mark Lord <[EMAIL PROTECTED]> wrote:
> > Signed-off-by: Yinghai Lu <[EMAIL PROTECTED]>
> ..
>
> Yup, obvious bug fixes, thanks.
> Signed-off-by: Mark Lord <[EMAIL PROTECTED]>
Typically we'll use Acked-by: here. Because Signed-off-by: implies that
you were in t
On Fri, Feb 08 2008, Jeff Garzik wrote:
> Jeff Garzik wrote:
> >Tejun Heo wrote:
> >>This patchset updates block layer padding and draining support and
> >>make libata use it. It's based on James Bottomley's initial work and,
> >>of the five, the last two patches are from James with some
> >>modif
On Friday 08 February 2008, Adrian Bunk wrote:
> Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]>
applied
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Friday 08 February 2008, Borislav Petkov wrote:
> commit d41c6bc739e7ea7880f7f5983a9694f2e0214d92
> Author: Borislav Petkov <[EMAIL PROTECTED]>
> Date: Fri Feb 8 07:25:44 2008 +0100
>
> ide-cd: replace ntohs with generic byteorder macro be16_to_cpu
>
> Signed-off-by: Borislav Pet
Jeff Garzik wrote:
Tejun Heo wrote:
This patchset updates block layer padding and draining support and
make libata use it. It's based on James Bottomley's initial work and,
of the five, the last two patches are from James with some
modifications.
Please read the following thread for more info.
Hi,
On Friday 08 February 2008, Sam Ravnborg wrote:
> Hi Bartlomiej.
>
> Do you have any opinion on this patch?
Acked-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
> I can push it via kbuild.git if you prefer but not without an
Fine with me.
> acknowledge from you.
Thanks,
Bart
-
To uns
Hi Bartlomiej.
Do you have any opinion on this patch?
I can push it via kbuild.git if you prefer but not without an
acknowledge from you.
Sam
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http:/
Bartlomiej Zolnierkiewicz wrote:
From: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Subject: [PATCH] palm_bk3710: use struct ide_port_info
* Factor out cable detection to palm_bk3710_cable_detect().
* Add palm_bk3710_init_hwif() (->init_hwif method implementation).
* Remove needless ->
Bartlomiej Zolnierkiewicz wrote:
Probe port _after_ it is fully initialized.
Hm, I thought the usual sequence is vice versa: you first probe and then
initialize. :-)
Cc: Anton Salnikov <[EMAIL PROTECTED]>
Cc: Sergei Shtylyov <[EMAIL PROTECTED]>
Signed-off-by: Bartlomiej Zolnierkiewicz <
Bartlomiej Zolnierkiewicz wrote:
Alan has noticed that distros always enabled burst mode
(+ datasheet confirms that it is the right thing to do).
Thus fix pdc202xx_old host driver to do it unconditionally
and remove no longer needed CONFIG_PDC202XX_BURST option.
Cc: Alan Cox <[EMAIL PROTEC
Bartlomiej Zolnierkiewicz wrote:
* Instead of checking for '->io_ports[IDE_DATA_OFFSET] == 0' check for
'->chipset == ide_unknown' when looking for an empty ide_hwifs[] slot.
* Do ide-pnp initialization after ide-generic when IDE is built-in
(ide-pnp is the only user of ide_find_port() wh
Bartlomiej Zolnierkiewicz wrote:
Add ide_cfg_mtx lock/unlock to ide_port_setup_devices() and then move
ide_port_setup_devices() call from init_irq() to ide_device_add_all().
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
MBR, Serg
Bartlomiej Zolnierkiewicz wrote:
* Factor out cable detection from ide_init_port() to ide_port_cable_detect().
* Move ide_port_cable_detect() call to ide_device_add_all().
Signed-off-by: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Acked-by: Sergei Shtylyov <[EMAIL PROTECTED]>
MBR, Ser
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.24-mm1/drivers/ata/libata-core.c
linux-2.6.24-mm1/drivers/ata/libata-core.c
--- linux.vanilla-2.6.24-mm1/drivers/ata/libata-core.c 2008-02-06
14:14:39.0 +
++
On Fri, 08 Feb 2008 10:45:21 -0500
Chuck Ebbert <[EMAIL PROTECTED]> wrote:
> On 02/08/2008 10:21 AM, Alan Cox wrote:
> > + ata_link_for_each_dev(dev, link) {
> > + if (!ata_is_40wire(dev))
> > + return 1;
> > + }
>
>
On Fri, 8 Feb 2008 16:25:08 +0100
Christoph Hellwig <[EMAIL PROTECTED]> wrote:
> When trying to put some stress on qemu by running the xfs testsuite
> I get the following:
>
> debian:~/xfs-cmds/xfstests# sh check
> [ 438.166822] SGI XFS with ACLs, security attributes, realtime, large block
> n
On 02/08/2008 10:21 AM, Alan Cox wrote:
> + ata_link_for_each_dev(dev, link) {
> + if (!ata_is_40wire(dev))
> + return 1;
> + }
return 0; ???
-
To unsubscribe from this list: send the line "u
Alan Cox wrote:
Forcibly set more of the configuration at init time. This seems to fix at
least one problem reported. We don't know what most of these bits do, but
we do know what windows stuffs there.
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --new-file --recursive --exclude-fro
Forcibly set more of the configuration at init time. This seems to fix at
least one problem reported. We don't know what most of these bits do, but
we do know what windows stuffs there.
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --new-file --recursive --exclude-from /usr/src/exclude
lin
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.24-mm1/drivers/ata/pata_legacy.c
linux-2.6.24-mm1/drivers/ata/pata_legacy.c
--- linux.vanilla-2.6.24-mm1/drivers/ata/pata_legacy.c 2008-02-06
14:14:39.0 +
++
This isolates the cable strategy into one routine and implements some
changes that together seem to sort the failure reports we are still
getting
- If the controller says it knows, believe it
- Otherwise if *any* drive sees 80wire believe it
The obvious approach of taking the worst drive view doe
This has confused a few people so fix it
Signed-off-by: Alan Cox <[EMAIL PROTECTED]>
diff -u --new-file --recursive --exclude-from /usr/src/exclude
linux.vanilla-2.6.24-mm1/drivers/ata/pata_amd.c
linux-2.6.24-mm1/drivers/ata/pata_amd.c
--- linux.vanilla-2.6.24-mm1/drivers/ata/pata_amd.c 200
When trying to put some stress on qemu by running the xfs testsuite
I get the following:
debian:~/xfs-cmds/xfstests# sh check
[ 438.166822] SGI XFS with ACLs, security attributes, realtime, large block
numbers, no debug enabled
[ 438.185557] SGI XFS Quota Management subsystem
[ 438.193150] hd
On Thu, Feb 07, 2008 at 10:13:42PM +0100, Bart Champagne wrote:
> Backporting the fix for 2.6.23 to the Debian 2.6.18 kernel hasn't
> succeeded yet, my C has gone very rusty it seems.
> In attachment a dmesg log for this drive. When/if I get a working
> patch I'll let you know.
I think this shou
Sam Ravnborg wrote:
> I have lost the actual patch.
> But what you see is what happens when you mix const and non-const data
> in the same section.
>
> Look for use of __initdata for const data and replace it with __initconst.
>
> And modpost cannot warn about it as gcc errors out before we look
On Fri, Feb 08 2008, S, Chandrakala (STSD) wrote:
> Hi,
>
> Thanks for the information!
> We would like to know when does the 2.6.25 kernel will be available at
> kernel.org.
So would I, if I locate my crystal ball I'll be sure to let you know :-)
Seriously, given past experience, it's probably
On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote:
> - couple of fixes and preparatory patches
>
> - rework of PowerMac media-bay support ([un]register IDE devices instead of
> [un]registering IDE interface) [ it is the main reason for spamming PPC ML ]
Interesting... I was th
46 matches
Mail list logo
