About 300 errors and warnings fixed.
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED]
---
drivers/ide/pci/sis5513.c | 190 ++---
1 files changed, 93 insertions(+), 97 deletions(-)
diff --git
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED]
---
drivers/ide/legacy/umc8672.c | 53 -
1 files changed, 26 insertions(+), 27 deletions(-)
diff --git a/drivers/ide/legacy/umc8672.c
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED]
---
drivers/ide/ide-pnp.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/ide/ide-pnp.c b/drivers/ide/ide-pnp.c
index c125b05..479663d 100644
---
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED]
---
drivers/ide/setup-pci.c | 45 -
1 files changed, 20 insertions(+), 25 deletions(-)
diff --git a/drivers/ide/setup-pci.c b/drivers/ide/setup-pci.c
index
Lot of errors and warnings removed.
Compile tested.
Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED]
---
drivers/ide/ide-proc.c | 175 +++
1 files changed, 86 insertions(+), 89 deletions(-)
diff --git a/drivers/ide/ide-proc.c
File is now error and warning free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED]
---
drivers/ide/legacy/ide-4drives.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/ide/legacy/ide-4drives.c b/drivers/ide/legacy/ide-4drives.c
index
File is now error free, only 1 warning left.
Compile tested.
Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED]
---
drivers/ide/pci/slc90e66.c |6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/ide/pci/slc90e66.c b/drivers/ide/pci/slc90e66.c
index
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED]
---
drivers/ide/pci/generic.c | 50 ++--
1 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/ide/pci/generic.c b/drivers/ide/pci/generic.c
File is now error and warning free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED]
---
drivers/ide/pci/tc86c001.c | 28 ++--
1 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/drivers/ide/pci/tc86c001.c b/drivers/ide/pci/tc86c001.c
On Sat, Feb 23, 2008 at 3:04 PM, Paolo Ciarrocchi
[EMAIL PROTECTED] wrote:
Hi Bartlomiej,
The following 10 patches remove a huge number of errors and warnings
reported by checkpatch.pl from the IDE subsystem.
All the patches have been compile tested.
I forgot to mention that the series is
On Sat, Feb 23, 2008 at 03:05:47PM +0100, Paolo Ciarrocchi wrote:
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED]
---
drivers/ide/pci/generic.c | 50 ++--
1 files changed, 25 insertions(+), 25
[Paolo Ciarrocchi - Sat, Feb 23, 2008 at 03:05:47PM +0100]
| File is now error free.
| Compile tested.
|
|
| Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED]
| ---
| drivers/ide/pci/generic.c | 50 ++--
| 1 files changed, 25 insertions(+), 25
| -/**
| +/*
^^^
Hi Paolo, it seems you just broke kdoc structure
thank you for your comment, i didn't know that.
Won't happen in future patches.
Bart, can you fix that or do you want me to re-create the series?
Ciao,
--
Paolo
http://paolo.ciarrocchi.googlepages.com/
-
To unsubscribe
[Paolo Ciarrocchi - Sat, Feb 23, 2008 at 06:07:01PM +0330]
| | -/**
| | +/*
| ^^^
|
| Hi Paolo, it seems you just broke kdoc structure
|
| thank you for your comment, i didn't know that.
| Won't happen in future patches.
no problem ;)
| Bart, can you fix that or do you want me to
Bart,
here is a new series of patches that remove some errors
and warnings reported by checkpatch.pl from the IDE subsystem.
All the patches have been compile tested and are against this morning (CET time
:-)
linux-next
Paolo Ciarrocchi (6):
IDE: Coding Style fixes to
Compile tested.
Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED]
---
drivers/ide/pci/opti621.c | 50 ++--
1 files changed, 25 insertions(+), 25 deletions(-)
diff --git a/drivers/ide/pci/opti621.c b/drivers/ide/pci/opti621.c
index cfd46ae..3df74b7
Fix a lot of errors and warnings.
Compile tested.
Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED]
---
drivers/ide/legacy/hd.c | 79 ---
1 files changed, 40 insertions(+), 39 deletions(-)
diff --git a/drivers/ide/legacy/hd.c
File is now error free, 2 warnings left.
Compile tested.
Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED]
---
drivers/ide/legacy/ali14xx.c | 11 ++-
1 files changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/ide/legacy/ali14xx.c b/drivers/ide/legacy/ali14xx.c
index
File is now error free.
Compile tested.
Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED]
---
drivers/ide/ide-floppy.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/ide/ide-floppy.c b/drivers/ide/ide-floppy.c
index 5f133df..cea77e0 100644
---
Fix all the errors and a few warnings.
Compile tested.
Signed-off-by: Paolo Ciarrocchi [EMAIL PROTECTED]
---
drivers/ide/pci/cmd640.c | 90 +++---
1 files changed, 45 insertions(+), 45 deletions(-)
diff --git a/drivers/ide/pci/cmd640.c
Hi,
I am experiencing a strange problem with 2.6.23.15-137.fc8 (Fedora 8)
kernel. Everything works fine, but if I provide the nosmp option to
the kernel, I get some (S)ATA errors and the system does not boot.
Here is a screenshot:
http://folk.uio.no/vegardno/DSCF2543.JPG
Handwritten summary:
O I don't see the connection between (no-)smp and ata. Something with
interrupt routing/IPI, missing irq ack? Booting another !SMP kernel
works fine. The problem also exists in 2.6.24-rc2.
Almost certainly interrupt routing try smp but with noapic and see if it
fails as well ?
-
To unsubscribe
On Sat, Feb 23, 2008 at 7:31 PM, Alan Cox [EMAIL PROTECTED] wrote:
O I don't see the connection between (no-)smp and ata. Something with
interrupt routing/IPI, missing irq ack? Booting another !SMP kernel
works fine. The problem also exists in 2.6.24-rc2.
Almost certainly interrupt
On Sat, Feb 23, 2008 at 7:31 PM, Alan Cox [EMAIL PROTECTED] wrote:
O I don't see the connection between (no-)smp and ata. Something with
interrupt routing/IPI, missing irq ack? Booting another !SMP kernel
works fine. The problem also exists in 2.6.24-rc2.
Almost certainly interrupt
Control register of QD6580 should be setup before probing for devices.
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
goes after ide: skip probing port if hdx=noprobe was used for both
devices on it patch in the IDE quilt tree
drivers/ide/legacy/qd65xx.c |6 ++
1 file
qd_select() checks itself whether timings should be reprogrammed so
remove superfluous qd_timing_ok() and always use -selectproc method
(rename qd_select() to qd65xx_select() while at it).
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
drivers/ide/legacy/qd65xx.c | 37
* Set IDE_HFLAG_SINGLE host flag in qd_probe() for QD6500 and QD6580
with the second port disabled.
* Check for IDE_HFLAG_SINGLE in qd6580_port_init_devs() instead of
using cached value of QD6580 Control register.
* Don't cache QD6580 Control register value in hwif-config_data
(bits 8-15)
Allocate 'struct it821x_dev' objects for both ports in it821x_init_one().
Fixes potential OOPS in it821x_quirkproc() (uses 'itdev' unconditionally)
and other problems ('itdev' is needed for correct operation of the driver).
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED]
---
* Factor out chipset family detection from init_chipset_sis5513()
to sis_find_family().
* Use sis_find_family() in sis5513_init_one() to fail early if the
chipset is unsupported.
* Keep a local copy sis5513_chipset in sis5513_init_one()
and set .udma_mask according to chipset family.
*
* Check for IDE_HFLAG_NO_SET_MODE host flag in ide_set_pio(),
ide_set_[pio,dma]_mode(), ide_set_xfer_rate() and set_pio_mode().
* Remove no longer needed IDE_HFLAG_NO_SET_MODE host flag checking
from ide_tune_dma().
* Remove superfluous -set_pio_mode checking from do_special().
This is a
hpt366: fix section mismatch warnings
Fix following warnings:
WARNING: o-sparc64/vmlinux.o(.data+0x195a38): Section mismatch in reference
from the variable hpt37x_info.0 to the variable .devinit.data:hpt370
WARNING: o-sparc64/vmlinux.o(.data+0x195a40): Section mismatch in reference
from the
[EMAIL PROTECTED] said:
the comment on the very top of drivers/ata says:
tristate Serial ATA (prod) and Parallel ATA (experimental) drivers
That's the one I was referring to.
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the body of a message to [EMAIL PROTECTED]
[EMAIL PROTECTED] said:
But at this point libata is working much better than the old IDE stuff, and
it really is worth moving things over if you can.
Ok, I'll take a stab at that tomorrow. Two things...
Having switched to ata_piix i can confirm that smartd doesn't hand the system
anymore.
Hi,
On Saturday 23 February 2008, Anders Eriksson wrote:
[EMAIL PROTECTED] said:
But at this point libata is working much better than the old IDE stuff, and
it really is worth moving things over if you can.
Ok, I'll take a stab at that tomorrow. Two things...
Having switched to
Pavel Machek wrote:
power_state is scheduled for removal, and libata uses it in write-only
mode. Remove it.
Signed-off-by: Pavel Machek [EMAIL PROTECTED]
diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index b4985bc..a31572d 100644
--- a/drivers/ata/libata-core.c
+++
Tejun Heo wrote:
Back in 2.6.17-rc2, a libata module parameter was added for atapi_dmadir.
That's nice, but most SATA devices which need it will tell us about it
in their IDENTIFY PACKET response, as bit-15 of word-62 of the
returned data (as per ATA7, ATA8 specifications).
So for those which
Mark Lord wrote:
Mark Lord wrote:
Tejun Heo wrote:
Hello, Mark.
Mark Lord wrote:
Tejun, I've added PMP to sata_mv, and am now trying to get it
to work with a Marvell PM attached.
And the behaviour I see is very bizarre.
After hard+soft resets, the PM signature is found,
and libata
Shane Huang wrote:
Jeff and Tejun:
I'm using my private mailbox to submit it before I set up
the connection to our exchange mail server under linux.
Please check whether this patch can be accepted.
Thanks
Shane
CUT HERE
SB700 SATA controller can support 64 bit DMA, the previous
Anton Vorontsov wrote:
This patch fixes build and few warnings when ATA_VERBOSE_DEBUG
is defined:
CC drivers/ata/sata_fsl.o
drivers/ata/sata_fsl.c: In function ‘sata_fsl_fill_sg’:
drivers/ata/sata_fsl.c:338: warning: format ‘%x’ expects type ‘unsigned int’,
but argument 3 has type ‘void
Randy Dunlap wrote:
From: Randy Dunlap [EMAIL PROTECTED]
Fix libata-core kernel-doc warning:
Warning(linux-2.6.25-rc2-git6//drivers/ata/libata-core.c:168): No description
found for parameter 'ap'
Signed-off-by: Randy Dunlap [EMAIL PROTECTED]
---
drivers/ata/libata-core.c |2 +-
1 file
Please pull from 'upstream-linus' branch of
master.kernel.org:/pub/scm/linux/kernel/git/jgarzik/libata-dev.git
upstream-linus
to receive the following updates:
drivers/ata/ahci.c| 23 +--
drivers/ata/libata-core.c | 16 ++--
drivers/ata/libata-pmp.c
Hello, Mark.
Mark Lord wrote:
Mark Lord wrote:
An alternative to all this, might be to expose the select_pmp()
function shown in the sample code, and have libata-pmp.c call that,
instead of having the new new .pmp_{read,write} functions.
..
I wonder if this might be more viable than
Tejun Heo wrote:
Yeah, exactly. I think what needs to be done is to separate out SFF
assumptions from core layer, factor out SFF-proper helpers and use them
to implement LLDs for quasi-SFF controllers.
Thinking long term, I continue to hope that SFF support can eventually
be separate into a
Hi!
So that's using the old IDE drivers.
And the network and USB are sharing IRQ#11 with each
other.
If you are going to be using newer kernels like this
(2.6.23+),
then you might consider shifting those drives over to
libata drivers.
Yes, that will probably fix it for him, but
44 matches
Mail list logo
