Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-13 Thread Bartlomiej Zolnierkiewicz
On Wednesday 13 February 2008, Greg KH wrote: On Wed, Feb 13, 2008 at 09:28:24AM -0800, Greg KH wrote: On Wed, Feb 13, 2008 at 01:34:12PM +0100, Bartlomiej Zolnierkiewicz wrote: On Wednesday 13 February 2008, Greg KH wrote: On Wed, Feb 13, 2008 at 02:17:37AM +, Alan Cox wrote

Re: 2.6.26-git0: IDE oops during boot

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 12 February 2008, Kamalesh Babulal wrote: Bartlomiej Zolnierkiewicz wrote: Hi, On Monday 11 February 2008, Kamalesh Babulal wrote: Nish Aravamudan wrote: On 2/7/08, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: On Thursday 07 February 2008, Kamalesh Babulal

Re: pci_get_device_reverse(), why does Calgary need this?

2008-02-13 Thread Bartlomiej Zolnierkiewicz
On Thursday 14 February 2008, Greg KH wrote: On Wed, Feb 13, 2008 at 11:20:36PM +0100, Bartlomiej Zolnierkiewicz wrote: On Wednesday 13 February 2008, Greg KH wrote: On Wed, Feb 13, 2008 at 09:28:24AM -0800, Greg KH wrote: On Wed, Feb 13, 2008 at 01:34:12PM +0100, Bartlomiej

[PATCH 00/11] ide/ppc: remove PPC specific IDE hacks

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Previous patchset adding warm-plug support allows the removal of PPC specific IDE hacks (500 LOC gone)... [ Ben, please take a look when you have some time, thanks! ] diffstat: arch/powerpc/kernel/setup_32.c |8 -- arch/powerpc/platforms/powermac/pci.c | 22 ---

[PATCH 01/11] ide-pmac: remove dead code

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Remove unused pmac_ide_{check_base,get_irq}() and pmac_find_ide_boot(), then remove no longer needed ide_majors[] and pmac_ide_count. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ppc/pmac.c | 47

[PATCH 02/11] ppc/hdpu: remove dead IDE code

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Also remove now not needed linux/ide.h include. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/ppc/platforms/hdpu.c | 36 1 file changed, 36 deletions(-) Index: b/arch/ppc/platforms/hdpu.c

[PATCH 03/11] ppc/ppc4xx: remove ppc_ide_md hooks

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/ppc/syslib/ppc4xx_setup.c | 23 --- 1 file changed, 23 deletions(-) Index: b/arch/ppc/syslib/ppc4xx_setup.c

[PATCH 04/11] ppc/pmac: remove ppc_ide_md hooks

2008-02-13 Thread Bartlomiej Zolnierkiewicz
: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/powerpc/platforms/powermac/pmac.h |5 --- arch/powerpc/platforms/powermac/setup.c |8 - drivers/ide/ppc/pmac.c | 50 +++- 3 files

[PATCH 10/11] ppc: don't include linux/ide.h

2008-02-13 Thread Bartlomiej Zolnierkiewicz
Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/ppc/platforms/4xx/bamboo.c |1 - arch/ppc/platforms/4xx/ebony.c |1 - arch/ppc/platforms/4xx/luan.c |1 - arch/ppc/platforms/4xx/ocotea.c |1 - arch

[PATCH 09/11] ppc: remove ppc_ide_md

2008-02-13 Thread Bartlomiej Zolnierkiewicz
/kernel/ppc_ksyms.c - arch/ppc/kernel/setup.c - arch/ppc/platforms/pplus.c - arch/ppc/platforms/prep_setup.c There should be no functional changes caused by this patch. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/powerpc

[PATCH 07/11] ppc/sandpoint: remove ppc_ide_md hooks

2008-02-13 Thread Bartlomiej Zolnierkiewicz
is superior over ide_generic. ] Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/ppc/configs/sandpoint_defconfig |2 arch/ppc/platforms/sandpoint.c | 94 --- arch/ppc/platforms/sandpoint.h

[PATCH 06/11] ppc/lopec: remove ppc_ide_md hooks

2008-02-13 Thread Bartlomiej Zolnierkiewicz
. Thanks. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/ppc/platforms/lopec.c | 85 - drivers/ide/pci/sl82c105.c |4 ++ 2 files changed, 4 insertions(+), 85 deletions(-) Index: b/arch

[PATCH 05/11] ppc/mpc8xx: remove ppc_ide_md hooks

2008-02-13 Thread Bartlomiej Zolnierkiewicz
in ide.c. There should be no other functional changes. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/ppc/syslib/m8xx_setup.c |6 --- drivers/ide/ppc/mpc8xx.c | 86 +++ 2 files

[PATCH 08/11] ppc/pplus: remove ppc_ide_md.ide_init_hwif hook

2008-02-13 Thread Bartlomiej Zolnierkiewicz
* Call ide_init_default_irq() for pplus in init_ide_data(). * Remove no longer needed pplus_ide_init_hwif_ports(). There should be no functional changes caused by this patch. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/ppc

[PATCH 11/11] ppc/pmac: remove no longer needed IDE quirk

2008-02-13 Thread Bartlomiej Zolnierkiewicz
IDE PMAC host driver and all IDE PCI host drivers use pci_enable_device() nowadays so the following quirk in pmac_pcibios_after_init() can be removed. Cc: Benjamin Herrenschmidt [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- arch/powerpc/platforms/powermac/pci.c

Re: [PATCH 00/18] ide: warm-plug support for IDE devices and other goodies

2008-02-12 Thread Bartlomiej Zolnierkiewicz
On Tuesday 12 February 2008, Benjamin Herrenschmidt wrote: On Fri, 2008-02-08 at 19:40 +1100, Benjamin Herrenschmidt wrote: On Fri, 2008-02-08 at 01:44 +0100, Bartlomiej Zolnierkiewicz wrote: - couple of fixes and preparatory patches - rework of PowerMac media-bay support ([un

Re: [RFC PATCH] ide-floppy: use rq-cmd for preparing and sending packet cmds to the drive

2008-02-12 Thread Bartlomiej Zolnierkiewicz
Hi Borislav, On Tuesday 12 February 2008, Borislav Petkov wrote: Hi Bart, here's a first go at converting ide-floppy to using rq-cmd for packet commands. The code below is pretty rough and from what i can tell needs to be hammered a lot more, for it raises a lot of issues: I think that

Re: [PATCH] ide-scsi: do non-atomic pc-flags testing

2008-02-12 Thread Bartlomiej Zolnierkiewicz
On Tuesday 12 February 2008, Borislav Petkov wrote: commit 272976f0f5754707f9e41da315717a6eb8d9d536 Author: Borislav Petkov [EMAIL PROTECTED] Date: Tue Feb 12 16:22:44 2008 +0100 ide-scsi: do non-atomic pc-flags testing Signed-off-by: Borislav Petkov [EMAIL PROTECTED] diff

Re: [PATCH] ide-floppy: rename end_request handler properly

2008-02-12 Thread Bartlomiej Zolnierkiewicz
On Tuesday 12 February 2008, Borislav Petkov wrote: commit 48f9b88d491aa478ffcf21e2f523e3665db0770b Author: Borislav Petkov [EMAIL PROTECTED] Date: Tue Feb 12 09:42:19 2008 +0100 ide-floppy: rename end_request handler properly mv idefloppy_do_end_request -

Re: [PATCH] Prevent IDE boot ops on NUMA system in mainline

2008-02-11 Thread Bartlomiej Zolnierkiewicz
On Monday 11 February 2008, Andi Kleen wrote: Without this patch a Opteron test system here oopses at boot with currentg git. Calling to_pci_dev() on a NULL pointer gives a negative value so the following NULL pointer check never triggers and then an illegal address is referenced.

Re: 2.6.25 Regression: DriveStatusError

2008-02-11 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday 11 February 2008, Daniel Exner wrote: Hi! Please CC me as I'm not subscribed to any list, thx in advance. I tried all -git Kernels since begining of cycle and starting when they finaly compiled fine, they weren't able to mount my root. As my laptop with the serial

Re: Current git -- kaboom [bisect] seems IDE related.

2008-02-11 Thread Bartlomiej Zolnierkiewicz
On Monday 11 February 2008, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: From: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Subject: [PATCH] ide-disk: fix flush requests (take 2) commit 813a0eb233ee67d7166241a8b389b6a76f2247f9 Author: Bartlomiej Zolnierkiewicz [EMAIL

Re: [PATCH] ide: Add missing base addresses for falconide and macide

2008-02-11 Thread Bartlomiej Zolnierkiewicz
On Monday 11 February 2008, Geert Uytterhoeven wrote: commit 29dd59755a849cc6475faa6a75f3b804e23a6fc2 (ide: remove ide_setup_ports) forgot to take into account the base addresses for the CONTROL registers for falconide and macide, as pointed out by Michael Schmitz. Falconide was tested on

Re: [PATCH 2/2] ide-tape: remove atomic test/set macros for packet commands

2008-02-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 09 February 2008, Borislav Petkov wrote: From 92dd5c1cfb27c0945894a3a055098290047d1ff0 Mon Sep 17 00:00:00 2001 From: Borislav Petkov [EMAIL PROTECTED] Date: Sat, 9 Feb 2008 20:33:48 +0100 Subject: [PATCH 2/2] ide-tape: remove atomic test/set macros for packet commands

Re: [PATCH 0/4] ide: generic packet command representation

2008-02-11 Thread Bartlomiej Zolnierkiewicz
On Monday 11 February 2008, Borislav Petkov wrote: Hi Bart, here's the ide_atapi_pc unification series. It all went pretty smoothly along the search replace line. Using driver-specific members in ide_atapi_pc like idefloppy_callback and idetape_callback is kinda dumb but this approach

Re: [PATCH 1/2] ide-tape: move all struct and other defs at the top

2008-02-11 Thread Bartlomiej Zolnierkiewicz
On Saturday 09 February 2008, Borislav Petkov wrote: Hi Bart, thanks for the update earlier. I'll look into blk_{get,put}_request later and try it on idefloppy. In the meantime, here are the patches as requested: Thanks. --- From 0d91862fc802d6f5aa79947b2685de6c209236f2 Mon Sep 17

Re: Current git -- kaboom [bisect] seems IDE related.

2008-02-10 Thread Bartlomiej Zolnierkiewicz
On Sunday 10 February 2008, Christoph Hellwig wrote: On Sun, Feb 10, 2008 at 12:06:10AM +0100, Bartlomiej Zolnierkiewicz wrote: Please try booting with hdx=noflush kernel parameter or please try the attached patch which should fix the issue (if my theory is correct). hda=noflush hdb

Re: [PATCH 7/8] ide: add struct ide_port_info instances to legacy host drivers

2008-02-10 Thread Bartlomiej Zolnierkiewicz
On Sunday 10 February 2008, Atsushi Nemoto wrote: On Sun, 06 Jan 2008 18:03:10 +0100, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: + /* reset DMA masks only for SFF-style DMA controllers */ + if ((d-host_flags IDE_HFLAG_NO_DMA) == 0 hwif-dma_base == 0) + hwif

Re: Current git -- kaboom [bisect] seems IDE related.

2008-02-10 Thread Bartlomiej Zolnierkiewicz
On Sunday 10 February 2008, James Bottomley wrote: On Sun, 2008-02-10 at 14:38 +0100, Bartlomiej Zolnierkiewicz wrote: On Sunday 10 February 2008, Christoph Hellwig wrote: On Sun, Feb 10, 2008 at 12:06:10AM +0100, Bartlomiej Zolnierkiewicz wrote: Please try booting with hdx=noflush

Re: [PATCH] ide: introduce CONFIG_BLK_DEV_IDEDMA_SFF option

2008-02-10 Thread Bartlomiej Zolnierkiewicz
On Saturday 09 February 2008, Sergei Shtylyov wrote: Introduce new option CONFIG_BLK_DEV_IDEDMA_SFF for non-PCI SFF-8038i compatible bus mastering IDE controllers (which there are a few known), thus fixing a hack made for Palmchip BK3710 controller... Signed-off-by: Sergei Shtylyov

Re: [PATCH 7/8] ide: add struct ide_port_info instances to legacy host drivers

2008-02-10 Thread Bartlomiej Zolnierkiewicz
On Sunday 10 February 2008, Bartlomiej Zolnierkiewicz wrote: On Sunday 10 February 2008, Atsushi Nemoto wrote: On Sun, 06 Jan 2008 18:03:10 +0100, Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: + /* reset DMA masks only for SFF-style DMA controllers */ + if ((d-host_flags

[PATCH] ide: fix comment in init_irq()

2008-02-10 Thread Bartlomiej Zolnierkiewicz
APUS support is gone... Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/ide/ide-probe.c === --- a/drivers/ide/ide

Re: Current git -- kaboom [bisect] seems IDE related.

2008-02-10 Thread Bartlomiej Zolnierkiewicz
On Sunday 10 February 2008, Sebastian Siewior wrote: * Bartlomiej Zolnierkiewicz | 2008-02-10 19:32:06 [+0100]: Sebastian/Christoph, please test the final patch (after your ACK I'll push it to Linus together with the rest of pending IDE fixes). This seems to work. Thanks. - To unsubscribe

[PATCH] ide: remove stale comment from ide-lib.c

2008-02-10 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-lib.c |9 - 1 file changed, 9 deletions(-) Index: b/drivers/ide/ide-lib.c === --- a/drivers/ide/ide-lib.c +++ b/drivers/ide/ide-lib.c

[git patches] IDE fixes

2008-02-10 Thread Bartlomiej Zolnierkiewicz
--- drivers/ide/pci/pdc202xx_old.c | 22 include/linux/ide.h| 11 +++--- 16 files changed, 107 insertions(+), 159 deletions(-) Adrian Bunk (1): ide: fix ide/legacy/gayle.c compilation Bartlomiej Zolnierkiewicz (12): palm_bk3710: ide_register_hw

[PATCH 2/3] ide: add ide_atapi_{discard_data,write_zeros} inline helpers

2008-02-09 Thread Bartlomiej Zolnierkiewicz
Add ide_atapi_{discard_data,write_zeros} inline helpers to linux/ide.h and use them instead of home-brewn helpers in ide-{floppy,tape,scsi}. There should be no functional changes caused by this patch. Cc: Borislav Petkov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH 1/3] ide-tape: remove never executed code

2008-02-09 Thread Bartlomiej Zolnierkiewicz
by this patch. Cc: Borislav Petkov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 34 -- 1 file changed, 34 deletions(-) Index: b/drivers/ide/ide-tape.c

Re: [PATCH] ide-floppy: remove struct idefloppy_id_gcw

2008-02-09 Thread Bartlomiej Zolnierkiewicz
On Saturday 09 February 2008, Borislav Petkov wrote: commit a6aaf3dd3e88d1bd1e85fb4329042ecb9247e0eb Author: Borislav Petkov [EMAIL PROTECTED] Date: Fri Feb 8 18:21:47 2008 +0100 ide-floppy: remove struct idefloppy_id_gcw Signed-off-by: Borislav Petkov [EMAIL PROTECTED]

[PATCH 3/3] ide: remove IDE_*_REG macros

2008-02-09 Thread Bartlomiej Zolnierkiewicz
* Add IDE_{ALTSTATUS,IREASON,BCOUNTL,BCOUNTH}_OFFSET defines. * Remove IDE_*_REG macros - this results in more readable and slightly smaller code. There should be no functional changes caused by this patch. Cc: Borislav Petkov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

Re: ide-tape redux (was: Re:)

2008-02-09 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 06 February 2008, Borislav Petkov wrote: On Tue, Feb 05, 2008 at 02:20:22AM +0100, Bartlomiej Zolnierkiewicz wrote: [...] w.r.t. #11 ide-tape uses char devices and supports DSC so it is not as obvious as in ide-floppy case that all atomic bitops can be just removed

Re: ide-tape redux (was: Re:)

2008-02-09 Thread Bartlomiej Zolnierkiewicz
On Wednesday 06 February 2008, Borislav Petkov wrote: ... and while we're at it ... commit c824f79fe4040f7541d7e35c546bb57a22d2fe11 Author: Borislav Petkov [EMAIL PROTECTED] Date: Wed Feb 6 06:23:10 2008 +0100 ide-tape: move all struct and other defs to the top

[PATCH] ide: remove -hold field from ide_hwif_t (take 2)

2008-02-09 Thread Bartlomiej Zolnierkiewicz
-hold is write-only now, remove it. v2: * v1 missed bast-ide, palm_bk3710, ide-cs and delkin_cb host drivers. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/bast-ide.c|2 +- drivers/ide/arm/palm_bk3710.c |2 +- drivers/ide/legacy/ide-cs.c |2

Re: ide/arm/bast-ide.c compile error

2008-02-09 Thread Bartlomiej Zolnierkiewicz
definition of 'hwif' was here make[4]: *** [drivers/ide/arm/bast-ide.o] Error 1 -- snip -- Remove 'ide_hwif_t **hwif' argument from bastide_register() (together with write-only ifs[]). Cc: Adrian Bunk [EMAIL PROTECTED] Cc: Russell King [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz

Re: Current git -- kaboom [bisect] seems IDE related.

2008-02-09 Thread Bartlomiej Zolnierkiewicz
on my rootfs partition. After this, I started to bisect. During the bisect process I stepped into two things. The commit |commit 813a0eb233ee67d7166241a8b389b6a76f2247f9 |Author: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] |Date: Fri Jan 25 22:17:10 2008 +0100 | |ide: switch

Re: Current git -- kaboom [bisect] seems IDE related.

2008-02-09 Thread Bartlomiej Zolnierkiewicz
On Saturday 09 February 2008, Sebastian Siewior wrote: * Bartlomiej Zolnierkiewicz | 2008-02-09 21:28:39 [+0100]: It could be that due to block layer changes to I/O barrier handling allocating ATA command structure on the stack is no longer safe. Update: it was never a very brilliant idea

Re: [RFC] Introduce HAVE_IDE to support flexible IDE per arch configuration

2008-02-08 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 08 February 2008, Sam Ravnborg wrote: Hi Bartlomiej. Do you have any opinion on this patch? Acked-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] I can push it via kbuild.git if you prefer but not without an Fine with me. acknowledge from you. Thanks, Bart

Re: [PATCH] ide-cd: replace ntohs with generic byteorder macro be16_to_cpu

2008-02-08 Thread Bartlomiej Zolnierkiewicz
On Friday 08 February 2008, Borislav Petkov wrote: commit d41c6bc739e7ea7880f7f5983a9694f2e0214d92 Author: Borislav Petkov [EMAIL PROTECTED] Date: Fri Feb 8 07:25:44 2008 +0100 ide-cd: replace ntohs with generic byteorder macro be16_to_cpu Signed-off-by: Borislav Petkov

Re: [2.6 patch] fix ide/legacy/gayle.c compilation

2008-02-08 Thread Bartlomiej Zolnierkiewicz
On Friday 08 February 2008, Adrian Bunk wrote: Signed-off-by: Adrian Bunk [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: 2.6.26-git0: IDE oops during boot

2008-02-07 Thread Bartlomiej Zolnierkiewicz
On Thursday 07 February 2008, Kamalesh Babulal wrote: Bartlomiej Zolnierkiewicz wrote: Hi, On Wednesday 06 February 2008, Pavel Machek wrote: On Wed 2008-02-06 11:53:34, Pavel Machek wrote: Hi! Trying to boot 2.6.25-git0 (few days old), I get BUG: unable to handle kernel

[PATCH 2.5/3] palm_bk3710: port initialization/probing bugfix

2008-02-07 Thread Bartlomiej Zolnierkiewicz
Probe port _after_ it is fully initialized. Cc: Anton Salnikov [EMAIL PROTECTED] Cc: Sergei Shtylyov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/palm_bk3710.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) Index: b

[PATCH 3/3] palm_bk3710: factor out cable detection

2008-02-07 Thread Bartlomiej Zolnierkiewicz
Factor out cable detection to palm_bk3710_cable_detect(). Cc: Anton Salnikov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/palm_bk3710.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) Index: b/drivers/ide/arm/palm_bk3710.c

Re: [PATCH 3/3] palm_bk3710: factor out cable detection

2008-02-07 Thread Bartlomiej Zolnierkiewicz
On Thursday 07 February 2008, Bartlomiej Zolnierkiewicz wrote: On Feb 7, 2008 3:41 PM, Sergei Shtylyov [EMAIL PROTECTED] wrote: Bartlomiej Zolnierkiewicz wrote: Factor out cable detection to palm_bk3710_cable_detect(). Cc: Anton Salnikov [EMAIL PROTECTED] Signed-off-by: Bartlomiej

[PATCH] ide: remove stale version number

2008-02-07 Thread Bartlomiej Zolnierkiewicz
for god knows how long, so clearly this version number is not useful.. Cc: Robert Hancock [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c |4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) Index: b/drivers/ide/ide.c

Re: [PATCH 3/3] palm_bk3710: factor out cable detection

2008-02-07 Thread Bartlomiej Zolnierkiewicz
On Feb 7, 2008 3:41 PM, Sergei Shtylyov [EMAIL PROTECTED] wrote: Bartlomiej Zolnierkiewicz wrote: Factor out cable detection to palm_bk3710_cable_detect(). Cc: Anton Salnikov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Index: b/drivers/ide/arm

[PATCH 2/3] palm_bk3710: fix ide_unregister() usage

2008-02-07 Thread Bartlomiej Zolnierkiewicz
Don't set 'restore' flag for ide_unregister() when initializing new interface. [ identical change as done to bast-ide/ide-cs/delkin_cb host drivers by commit 909f4369bca30f9a186316a3bf2b4a9c1e702a25 ] Cc: Anton Salnikov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH 1/3] palm_bk3710: ide_register_hw() - ide_device_add()

2008-02-07 Thread Bartlomiej Zolnierkiewicz
drivers by commit 9e016a719209d95338e314b46c3012cc7feaaeec ] * Rename 'ide_ctlr_info' to 'hw' and 'index' to 'i' while at it. Cc: Anton Salnikov [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- this patch series applies some recent IDE changes (post 2.6.24

[PATCH] pdc202xx_old: always enable burst mode

2008-02-07 Thread Bartlomiej Zolnierkiewicz
. * Copyright (C) 2007 Bartlomiej Zolnierkiewicz * - * Promise Ultra33 cards with BIOS v1.20 through 1.28 will need this - * compiled into the kernel if you have more than one card installed. - * Note that BIOS v1.29 is reported to fix the problem. Since this is - * safe chipset

[PATCH 01/18] ide-generic: set hwif-chipset

2008-02-07 Thread Bartlomiej Zolnierkiewicz
This hwif-chipset fixup is already present in ide_device_add_all() but for warm-plug support we also need to reserve not currently present interfaces. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-generic.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion

[PATCH 02/18] ide: fix ide_find_port()

2008-02-07 Thread Bartlomiej Zolnierkiewicz
-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Makefile |2 +- drivers/ide/ide.c|2 +- 2 files changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/ide/Makefile === --- a/drivers/ide/Makefile +++ b

[PATCH 04/18] ide-acpi: add missing drive-acpidata zeroing

2008-02-07 Thread Bartlomiej Zolnierkiewicz
There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-acpi.c |2 ++ 1 file changed, 2 insertions(+) Index: b/drivers/ide/ide-acpi.c

[PATCH 05/18] ide: factor out cable detection from ide_init_port()

2008-02-07 Thread Bartlomiej Zolnierkiewicz
* Factor out cable detection from ide_init_port() to ide_port_cable_detect(). * Move ide_port_cable_detect() call to ide_device_add_all(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c |4 1 file changed, 4 insertions(+) Index: b/drivers/ide

[PATCH 06/18] ide: factor out code unregistering devices from ide_unregister()

2008-02-07 Thread Bartlomiej Zolnierkiewicz
Factor out code unregistering devices from ide_unregister() to ide_port_unregister_devices(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c | 30 +++--- 1 file changed, 19 insertions(+), 11 deletions(-) Index: b/drivers/ide/ide.c

[PATCH 07/18] ide: factor out devices init from ide_init_port_data()

2008-02-07 Thread Bartlomiej Zolnierkiewicz
* Factor out devices init from ide_init_port_data() to ide_port_init_devices_data(). While at it: * Add explicit clearing of IDE device structure. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c

[PATCH 08/18] ide: move ide_port_setup_devices() call to ide_device_add_all()

2008-02-07 Thread Bartlomiej Zolnierkiewicz
Add ide_cfg_mtx lock/unlock to ide_port_setup_devices() and then move ide_port_setup_devices() call from init_irq() to ide_device_add_all(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c |6 -- 1 file changed, 4 insertions(+), 2 deletions

[PATCH 09/18] ide: rework PowerMac media-bay support

2008-02-07 Thread Bartlomiej Zolnierkiewicz
() instead of ide_register_hw() in media_bay_step(). * Unexport ide_register_hw() and make it static. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c| 18 ++ drivers/ide/ide.c | 22 -- drivers/ide/ppc

[PATCH 10/18] ide: add warm-plug support for IDE devices

2008-02-07 Thread Bartlomiej Zolnierkiewicz
and scan attributes with -classdev. Call it in ide_device_add_all(). * Document IDE warm-plug support in Documentation/ide/warm-plug-howto.txt. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- +540 bytes (x86-32) After seeing some 'class device' conversion patches from Greg I tried

[PATCH 11/18] ide-generic: add ide_generic class and attribute for adding new interfaces

2008-02-07 Thread Bartlomiej Zolnierkiewicz
for obsoleted idex=base[,ctl[,irq]] kernel parameters). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- +391 bytes (x86-32) I also tried interface based on kernel parameters but it sucked (more complex, bigger source code + resulting binary). drivers/ide/ide-generic.c | 78

[PATCH 12/18] ide: remove needless CONFIG_BLK_DEV_HD hack from init_hwif()

2008-02-07 Thread Bartlomiej Zolnierkiewicz
request_irq() will fail if there is already another IRQ handler registered and IRQ flags are mismatched. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c |7 --- 1 file changed, 7 deletions(-) Index: b/drivers/ide/ide-probe.c

[PATCH 13/18] ide: remove CONFIG_BLK_DEV_HD_IDE config option

2008-02-07 Thread Bartlomiej Zolnierkiewicz
needed CONFIG_BLK_DEV_HD_IDE config option. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/Kconfig | 25 + drivers/ide/ide.c |4 2 files changed, 5 insertions(+), 24 deletions(-) Index: b/drivers/ide/Kconfig

[PATCH 14/18] ide: remove obsoleted idex=base[,ctl[,irq]] kernel parameters

2008-02-07 Thread Bartlomiej Zolnierkiewicz
* Remove obsoleted idex=base[,ctl[,irq]] kernel parameters and update Documentation/ide.txt. * Remove no longer needed ide_forced chipset type. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- -244 bytes (x86-32) Documentation/ide.txt | 31

[PATCH 15/18] ide: remove broken/dangerous HDIO_[UNREGISTER,SCAN]_HWIF ioctls

2008-02-07 Thread Bartlomiej Zolnierkiewicz
(x86-32). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- block/compat_ioctl.c |1 drivers/ide/arm/bast-ide.c|2 drivers/ide/arm/rapide.c |2 drivers/ide/ide-pnp.c |2 drivers/ide/ide.c | 198

[PATCH 16/18] ide: remove -hold field from ide_hwif_t

2008-02-07 Thread Bartlomiej Zolnierkiewicz
-hold is write-only now, remove it. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/mips/au1xxx-ide.c |3 --- drivers/ide/ppc/pmac.c|1 - include/linux/ide.h |1 - 3 files changed, 5 deletions(-) Index: b/drivers/ide/mips/au1xxx-ide.c

[PATCH 17/18] ide: remove init_hwif_default()

2008-02-07 Thread Bartlomiej Zolnierkiewicz
init_hwif_default() is only used by init_ide_data() now, inline it there. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) Index: b/drivers/ide/ide.c

[PATCH 18/18] ide: remove ide_init_hwif_ports()

2008-02-07 Thread Bartlomiej Zolnierkiewicz
ide_init_hwif_ports() is only used by init_ide_data() now, inline it there. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c | 11 +-- include/linux/ide.h | 32 2 files changed, 9 insertions(+), 34 deletions(-) Index

Re: 2.6.26-git0: IDE oops during boot

2008-02-06 Thread Bartlomiej Zolnierkiewicz
Hi, On Wednesday 06 February 2008, Pavel Machek wrote: On Wed 2008-02-06 11:53:34, Pavel Machek wrote: Hi! Trying to boot 2.6.25-git0 (few days old), I get BUG: unable to handle kernel paging request at ..ffb0 IP at init_irq+0x42e init_irq? hmm... Call trace:

Re: [PATCH 2/5] ide: remove redundant BUG_ON() from [atapi_]reset_pollfunc()

2008-02-06 Thread Bartlomiej Zolnierkiewicz
On Wednesday 06 February 2008, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Same BUG_ON() is present inside ide_set_handler(). There is no BUG_ON there -- __ide_set_handler() has a check for the same condition and a printk(KERN_CRIT)... myabe it should be replaced

Re: [PATCH] ide: another possible ide panic fix for blk-end-request

2008-02-06 Thread Bartlomiej Zolnierkiewicz
. The following patch fixes the bug and should be applied on top of Linus' git. Please review and apply. Cc: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Cc: Borislav Petkov [EMAIL PROTECTED] Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED] Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED

Re: [git patches] IDE updates part #4

2008-02-05 Thread Bartlomiej Zolnierkiewicz
Hi Linus, On Tuesday 05 February 2008, Linus Torvalds wrote: On Sat, 2 Feb 2008, Bartlomiej Zolnierkiewicz wrote: * next part of IDE probing code re-organization saga (that would be me) This seems to cause very irritating and bogus messages for me: Probing IDE interface

Re: [PATCH] ide-pci-generic: kill the unused ifdef/endif/MODULE code

2008-02-05 Thread Bartlomiej Zolnierkiewicz
On Saturday 02 February 2008, Denis Cheng wrote: with module_param macro, the __setup code can be killed now: const __setup(all-generic-ide, ide_generic_all_on); and the module name generic.ko is not descriptive to its functionality, can be changed in Makefile, the ide-pci-generic.ko

Re: [PATCH] Palmchip BK3710 IDE driver

2008-02-05 Thread Bartlomiej Zolnierkiewicz
On Tuesday 05 February 2008, Anton Salnikov wrote: I've tested the driver on 2.6.24. I've made the changes you asked for. But when I tested them on arm/mach-davinci Thanks! architecture on the current Linus' git there was link error undefined reference to symbol ide_hwif_setup_dma().

ide-tape redux (was: Re:)

2008-02-04 Thread Bartlomiej Zolnierkiewicz
Hi Borislav, On Monday 04 February 2008, Borislav Petkov wrote: Hi Bart, here are the pending ide-tape patches reworked which incorporate all review points raised so far. Several new patches are appended to the original series which i thought would be reasonable to sumbit along with the

[PATCH] ppc: fix #ifdef-s in mediabay driver (take 2)

2008-02-04 Thread Bartlomiej Zolnierkiewicz
] Cc: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/macintosh/mediabay.c | 46 ++--- include/asm-powerpc/mediabay.h |8 +++ 2 files changed, 25 insertions(+), 29 deletions(-) Index: b/drivers

Re: [PATCH 02/22] ide-tape: remove struct idetape_read_position_result_t

2008-02-04 Thread Bartlomiej Zolnierkiewicz
On Monday 04 February 2008, Borislav Petkov wrote: There should be no functional changes resulting from this patch. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 49 +-- 1 files changed, 18 insertions(+), 31

[PATCH] ide-scsi: remove needless SELECT_DRIVE() call

2008-02-02 Thread Bartlomiej Zolnierkiewicz
SELECT_DRIVE() is called by IDE core code in start_request() before device driver's -do_request method. In ide-scsi case -do_request is implemented by idescsi_do_request() which is also the only user of idescsi_issue_pc(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- goes

Re: PCI: Remove users of pci_enable_device_bars()

2008-02-02 Thread Bartlomiej Zolnierkiewicz
On Saturday 02 February 2008, Jeff Garzik wrote: Linux Kernel Mailing List wrote: Commit: 0948391641918b95d8d96c15089eb5ac156850b3 PCI: Remove users of pci_enable_device_bars() This patch converts users of pci_enable_device_bars() to the new

Re: [PATCH 23/32] ide-tape: struct idetape_tape_t: shorten member names

2008-02-02 Thread Bartlomiej Zolnierkiewicz
Hi, On Sunday 27 January 2008, Borislav Petkov wrote: From: Borislav Petkov [EMAIL PROTECTED] Some member names are self-explanatory, so remove their respective comments. Also, explain the exact purpose of struct members in comments in the struct definition instead of using excessively

Re: [RFC PATCH 26/32] ide-tape: remove packet command and struct request memory buffers

2008-02-02 Thread Bartlomiej Zolnierkiewicz
On Sunday 27 January 2008, Borislav Petkov wrote: From: Borislav Petkov [EMAIL PROTECTED] Bart, this one is rather intrusive so please doublecheck it wrt to kzalloc/kfree balancing on all the codepaths so that we don't leak memory all over the place. I free all the alloc'd pc's and rq's

Re: [PATCH 27/32] ide-tape: remove idetape_increase_max_pipeline_stages()

2008-02-02 Thread Bartlomiej Zolnierkiewicz
On Sunday 27 January 2008, Borislav Petkov wrote: From: Borislav Petkov [EMAIL PROTECTED] This function was being used only at one place so fold it in there. Signed-off-by: Borislav Petkov [EMAIL PROTECTED] This change is fine but depends on previous patches so I can't apply it. Please

Re: [PATCH 28/32] ide-tape: shorten some function names

2008-02-02 Thread Bartlomiej Zolnierkiewicz
On Sunday 27 January 2008, Borislav Petkov wrote: From: Borislav Petkov [EMAIL PROTECTED] Signed-off-by: Borislav Petkov [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 29 +++-- 1 files changed, 15 insertions(+), 14 deletions(-) diff --git

Re: [PATCH #upstream] libata: implement libata.force module parameter

2008-02-01 Thread Bartlomiej Zolnierkiewicz
On Feb 1, 2008 6:28 PM, Jeff Garzik [EMAIL PROTECTED] wrote: Tejun Heo wrote: This patch implements libata.force module parameter which can selectively override ATA port, link and device configurations including cable type, SATA PHY SPD limit, transfer mode and NCQ. For example, you can

Re: [2.6 patch] unexport ide_dma_on

2008-02-01 Thread Bartlomiej Zolnierkiewicz
On Monday 28 January 2008, Adrian Bunk wrote: ide_dma_on can be unexported. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [2.6 patch] small ide-scan-pci.c cleanup

2008-02-01 Thread Bartlomiej Zolnierkiewicz
On Monday 28 January 2008, Adrian Bunk wrote: - ide_scan_pcibus() can become static - instead of ide_scan_pci() we can use ide_scan_pcibus() directly in module_init() Signed-off-by: Adrian Bunk [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide

Re: [2.6 patch] ide: make wait_drive_not_busy() static again

2008-02-01 Thread Bartlomiej Zolnierkiewicz
On Monday 28 January 2008, Adrian Bunk wrote: After commit 7267c3377443322588cddaf457cf106839a60463 wait_drive_not_busy() can become static again. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a

Re: [2.6 patch] ide/ppc/pmac.c section fixes

2008-02-01 Thread Bartlomiej Zolnierkiewicz
On Wednesday 30 January 2008, Adrian Bunk wrote: This patch fixes the following section mismatch: -- snip -- ... WARNING: vmlinux.o(.text+0x3b641c): Section mismatch in reference from the function .pmac_ide_setup_device() to the function .init.text:.pmac_ide_setup_dma() ... --

Re: [PATCH 7/8] ide: add struct ide_port_info instances to legacy host drivers

2008-02-01 Thread Bartlomiej Zolnierkiewicz
Hi, On Monday 28 January 2008, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: * Remove 'struct pci_dev *dev' argument from ide_hwif_setup_dma(). * Un-static ide_hwif_setup_dma() and add CONFIG_BLK_DEV_IDEDMA_PCI=n version. * Add 'const struct ide_port_info *d

Re: [PATCH] Palmchip BK3710 IDE driver

2008-02-01 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 25 January 2008, Anton Salnikov wrote: This is Palmchip BK3710 IDE controller support for kernel version 2.6.24. The IDE controller logic supports PIO, multiword DMA and ultra-DMA modes. Supports interface to compact Flash (CF) configured in True-IDE mode. Unfortunately some

[PATCH 1/5] ide: remove write-only -sata_misc[] from ide_hwif_t

2008-02-01 Thread Bartlomiej Zolnierkiewicz
* Remove write-only -sata_misc[] from ide_hwif_t. * Remove no longer used SATA_{MISC,PHY,IEN}_OFFSET defines. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/siimage.c |3 --- include/linux/ide.h |5 - 2 files changed, 8 deletions(-) Index: b

[PATCH 5/5] ide: add ide_read_error() inline helper

2008-02-01 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-cd.c |2 +- drivers/ide/ide-floppy.c |2 +- drivers/ide/ide-io.c |4 ++-- drivers/ide/ide-iops.c |4 +++- drivers/ide/ide-lib.c |2 +- drivers/ide/ide-tape.c |2

Re: [PATCH 0/32] ide-tape redux v1

2008-01-29 Thread Bartlomiej Zolnierkiewicz
On Monday 28 January 2008, Borislav Petkov wrote: Hi Bart, [...] the BKL in idetape_write_release() with finer-grained locking etc, probably also some pipeline improvements, removal of OnStream support, etc. but that'll come later. On-Stream support has been long gone

Re: [PATCH 0/32] ide-tape redux v1

2008-01-28 Thread Bartlomiej Zolnierkiewicz
On Sunday 27 January 2008, Bartlomiej Zolnierkiewicz wrote: BTW what happend to patch #23? my bad, the patch got eaten by gmail's spam filter... - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http

<    1   2   3   4   5   6   7   8   9   10   >