Re: [PATCH 8/9] ide: replace ide_pci_device_t by struct ide_port_info

2007-10-27 Thread Bartlomiej Zolnierkiewicz
On Saturday 27 October 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Rename struct ide_pci_device_s to struct ide_port_info. I'm not sure that ide_port_info name fits the data indeed, as those are not applicable only to the ports but to a chip as a whole, so

[PATCH 1/15] ide: check rq-cmd_type in drive_cmd_intr()

2007-10-27 Thread Bartlomiej Zolnierkiewicz
to use non-zero values for IDE_SECTOR_REG (args[3]). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) Index: b/drivers/ide/ide-io.c

[PATCH 2/15] ide: clear HOB bit for REQ_TYPE_ATA_TASK requests in ide_end_drive_cmd()

2007-10-27 Thread Bartlomiej Zolnierkiewicz
ide_dump_ata_status() may set HOB bit before ide_end_drive_cmd() is called. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c |2 ++ 1 file changed, 2 insertions(+) Index: b/drivers/ide/ide-io.c

[PATCH 3/15] ide: add missing rq.ref_count initialization to ide_diag_taskfile()

2007-10-27 Thread Bartlomiej Zolnierkiewicz
Noticed by Tejun Heo. Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-taskfile.c |1 + 1 file changed, 1 insertion(+) Index: b/drivers/ide/ide-taskfile.c

[PATCH 4/15] ide: use drive-select.all for REQ_TYPE_ATA_TASK in execute_drive_cmd()

2007-10-27 Thread Bartlomiej Zolnierkiewicz
Use drive-select.all for REQ_TYPE_ATA_TASK requests in execute_drive_cmd() (the obsolete bits 7 and 5 of the Device register need to be set). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c |6 +- 1 file changed, 1 insertion(+), 5 deletions(-) Index

[PATCH 5/15] ide: fix registers loading order for WIN_SMART in execute_drive_cmd()

2007-10-27 Thread Bartlomiej Zolnierkiewicz
hardware is accessed from code cleanups). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/ide/ide-io.c === --- a/drivers

[PATCH 6/15] ide: fix registers loading order for IDE_NSECTOR_REG in execute_drive_cmd()

2007-10-27 Thread Bartlomiej Zolnierkiewicz
a usual paranoia to separate changes which change the way in which hardware is accessed from code cleanups). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c | 19 --- 1 file changed, 8 insertions(+), 11 deletions(-) Index: b/drivers/ide/ide-io.c

[PATCH 7/15] ide: execute_drive_cmd() cleanup

2007-10-27 Thread Bartlomiej Zolnierkiewicz
)' blocks. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c | 42 -- 1 file changed, 20 insertions(+), 22 deletions(-) Index: b/drivers/ide/ide-io.c

[PATCH 8/15] ide: remove ide_cmd() helper

2007-10-27 Thread Bartlomiej Zolnierkiewicz
* Remove ide_cmd() helper. * Clear nIEN and call SELECT_MASK() before writing taskfile registers. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) Index: b/drivers/ide/ide

[PATCH 9/15] ide: use ide_tf_load() in execute_drive_cmd()

2007-10-27 Thread Bartlomiej Zolnierkiewicz
dump all taskfile registers for both REQ_ATA_TYPE_{CMD,TASK} requests and move it to ide_tf_load() so it also covers REQ_ATA_TYPE_TASKFILE requests. There should be no functionality changes caused by this patch (unless DEBUG is defined). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH 10/15] ide: use IDE_TFLAG_LBA48 for REQ_TYPE_ATA_TASKFILE requests

2007-10-27 Thread Bartlomiej Zolnierkiewicz
commands. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) Index: b/drivers/ide/ide-io.c === --- a/drivers/ide/ide-io.c +++ b/drivers

[PATCH 11/15] ide: remove unnecessary writes to HOB taskfile registers

2007-10-27 Thread Bartlomiej Zolnierkiewicz
, WIN_DOORUNLOCK) - /proc/ide/hd?/identify support (WIN_IDENTIFY) - ACPI _GTF taskfiles Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-acpi.c |1 + drivers/ide/ide-disk.c | 13 + drivers/ide/ide-io.c | 12 drivers/ide

[PATCH 13/15] ide: switch idedisk_prepare_flush() to use REQ_TYPE_ATA_TASKFILE requests

2007-10-27 Thread Bartlomiej Zolnierkiewicz
Based on the earlier work by Tejun Heo. There should be no functionality changes caused by this patch. Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions

[PATCH 14/15] ide: switch ide_task_ioctl() to use REQ_TYPE_ATA_TASKFILE requests

2007-10-27 Thread Bartlomiej Zolnierkiewicz
Based on the earlier work by Tejun Heo. There should be no functionality changes caused by this patch. Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-taskfile.c | 29 +++-- 1 file changed, 15 insertions

[PATCH 12/15] ide: extend timeout for REQ_TYPE_ATA_{CMD,TASK} requests

2007-10-27 Thread Bartlomiej Zolnierkiewicz
Extend timeout for REQ_TYPE_ATA_{CMD,TASK} requests from WAIT_CMD (10sec) to WAIT_WORSTCASE (30sec, already used for REQ_TYPE_ATA_TASKFILE). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b

[PATCH 15/15] ide: remove REQ_TYPE_ATA_TASK

2007-10-27 Thread Bartlomiej Zolnierkiewicz
Based on the earlier work by Tejun Heo. All users are gone so we can finally remove it. Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c | 25 + drivers/ide/ide-lib.c |3 +-- include/linux

Re: 2.6.24-rc1 IDE regression on PMAC?

2007-10-27 Thread Bartlomiej Zolnierkiewicz
On Saturday 27 October 2007, Mikael Pettersson wrote: As shown by this dmesg diff between 2.6.23 and 2.6.24-rc1, IDE's PMAC driver now decides to downgrade itself to PIO2 on this box. Is this intensional or a bug? This drive still uses MWDMA1 according to the dmesg diff (only the debug message

[git patches] IDE fixes

2007-10-26 Thread Bartlomiej Zolnierkiewicz
drivers/ide/pci/sc1200.c |9 + 5 files changed, 28 insertions(+), 24 deletions(-) Bartlomiej Zolnierkiewicz (4): cy82c693: fix build for CONFIG_HOTPLUG=n hpt366: fix build for CONFIG_HOTPLUG=n drivers/ide/pci/generic: fix build for CONFIG_HOTPLUG=n ide

Re: [PATCH]ata: sata_nv fix mcp51 timeout with SWNCQ

2007-10-26 Thread Bartlomiej Zolnierkiewicz
[ added Andrew to cc: ] Hi, On Friday 26 October 2007, Kuan Luo wrote: From Kuan Luo [EMAIL PROTECTED] The patch will avoid ncq function use of sata_nv when swncq is zero by default. It also completely removes SWNCQ support for MPC61 (something like that should be mentioned in the patch

Re: [PATCH] ide: remove stale ide.h configuration options

2007-10-26 Thread Bartlomiej Zolnierkiewicz
noticed this after hitting the Send button: On Friday 26 October 2007, Bartlomiej Zolnierkiewicz wrote: * OK_TO_RESET_CONTROLLER - always defined to 0 s/0/1/ [ the patch is OK, the mistake was only in the description ] - To unsubscribe from this list: send the line unsubscribe linux-ide

[PATCH] ide-tape: remove dead USE_IOTRACE code

2007-10-26 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-tape.c | 22 -- 1 file changed, 22 deletions(-) Index: b/drivers/ide/ide-tape.c === --- a/drivers/ide/ide-tape.c +++ b/drivers/ide

Re: [PATCH] ide: add IDEDISK_MULTI_MODE text adapted from hdparm manual page

2007-10-26 Thread Bartlomiej Zolnierkiewicz
On Friday 26 October 2007, Matti Linnanvuori wrote: From: Matti Linnanvuori [EMAIL PROTECTED] Add IDEDISK_MULTI_MODE text adapted from hdparm manual page. Signed-off-by: Matti Linnanvuori [EMAIL PROTECTED] applied (by hand since the mail was encoded in some strange way) Thanks, Bart - To

[PATCH] ide: remove stale ide.h configuration options

2007-10-26 Thread Bartlomiej Zolnierkiewicz
but disallow overriding it by asm/ide.h. There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c|4 drivers/ide/ide-iops.c |9 ++--- drivers/ide/ide-probe.c |4

Re: 2.6.24-rc1, sata_nv: MCP51 is boned with SWNCQ too

2007-10-25 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 25 October 2007, Jeff Garzik wrote: Andrew wrote: Hi, I've noticed a thread reporting that SWNCQ can't be disabled on the sata_nv. Gerhard Dirschl * BUG: sata_nv swncq cannot be disabled and another with a patch switching MCP61 to GENERIC instead of

[PATCH 1/3] ide: remove IRQF_DISABLED from IRQ flags for IDE IRQ handler

2007-10-25 Thread Bartlomiej Zolnierkiewicz
-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-probe.c | 13 ++--- 1 file changed, 2 insertions(+), 11 deletions(-) Index: b/drivers/ide/ide-probe.c === --- a/drivers/ide/ide-probe.c +++ b/drivers/ide/ide

[PATCH 2/3] ide: fix drive_is_ready() for non-PCI hosts and CONFIG_IDEPCI_SHARE_IRQ=y

2007-10-25 Thread Bartlomiej Zolnierkiewicz
Need to check if the host is a PCI one before reading IDE_ALTSTATUS_REG. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-iops.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/ide/ide-iops.c

Re: [PATCH 2/3] ide: fix drive_is_ready() for non-PCI hosts and CONFIG_IDEPCI_SHARE_IRQ=y

2007-10-25 Thread Bartlomiej Zolnierkiewicz
On Friday 26 October 2007, Alan Cox wrote: On Fri, 26 Oct 2007 01:36:37 +0200 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: Need to check if the host is a PCI one before reading IDE_ALTSTATUS_REG. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Umm why

Re: [PATCH 12/15] ide: remove -dma_master field from ide_hwif_t

2007-10-24 Thread Bartlomiej Zolnierkiewicz
Hi, On Thursday 18 October 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: Index: b/drivers/ide/pci/hpt366.c === --- a/drivers/ide/pci/hpt366.c +++ b/drivers/ide/pci/hpt366.c @@ -845,32 +845,33

Re: [PATCH 5/12] ide: remove task_ioreg_t typedef

2007-10-24 Thread Bartlomiej Zolnierkiewicz
On Wednesday 17 October 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Remove task_ioreg_t typedef from the kernel code (but leave it in linux/hdreg.h for #ifndef/#endif __KERNEL__ case). While at it also move sata_ioreg_t typedef under #ifndef/#endif __KERNEL__

Re: [PATCH 6/12] ide: add struct ide_taskfile

2007-10-24 Thread Bartlomiej Zolnierkiewicz
On Wednesday 17 October 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: * Don't set write-only ide_task_t.hobRegister[6] and ide_task_t.hobRegister[7] in idedisk_set_max_address_ext(). * Add struct ide_taskfile and use it in ide_task_t instead of tfRegister

Re: [PATCH 7/12] ide-disk: merge LBA28 and LBA48 Host Protected Area support code

2007-10-24 Thread Bartlomiej Zolnierkiewicz
On Thursday 18 October 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: * Merge idedisk_{read_native,set}_max_address_ext() into idedisk_{read_native,set}_max_address(). There should be no functionality changes caused by this patch. This is unfortunately

[PATCH] cy82c693: fix build for CONFIG_HOTPLUG=n

2007-10-23 Thread Bartlomiej Zolnierkiewicz
to: 8562043606430185cad26d085d46adcc7ad67fd1 is first bad commit commit 8562043606430185cad26d085d46adcc7ad67fd1 Author: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Date: Sat Oct 20 00:32:34 2007 +0200 ide: constify struct ide_port_info Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] It turns out that const

[PATCH] hpt366: fix build for CONFIG_HOTPLUG=n

2007-10-23 Thread Bartlomiej Zolnierkiewicz
to: 8562043606430185cad26d085d46adcc7ad67fd1 is first bad commit commit 8562043606430185cad26d085d46adcc7ad67fd1 Author: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] Date: Sat Oct 20 00:32:34 2007 +0200 ide: constify struct ide_port_info Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] It turns out that const

Re: New CD/DVD drive - 80-wire cable detection failure

2007-10-23 Thread Bartlomiej Zolnierkiewicz
Hi, On Saturday 20 October 2007, Nick Warne wrote: Hi all, SOLVED! On Saturday 20 October 2007 10:37:31 Nick Warne wrote: On Friday 19 October 2007 23:28:21 Bartlomiej Zolnierkiewicz wrote: On Saturday 20 October 2007, Nick Warne wrote: On Friday 19 October 2007 22:44:27

Re: New CD/DVD drive - 80-wire cable detection failure

2007-10-19 Thread Bartlomiej Zolnierkiewicz
On Friday 19 October 2007, Nick Warne wrote: On Friday 19 October 2007 22:07:43 Lennart Sorensen wrote: On Fri, Oct 19, 2007 at 10:03:09PM +0100, Nick Warne wrote: No change: ide_setup: hdd=ide-cd ide1: BM-DMA at 0xd008-0xd00f, BIOS settings: hdc:DMA, hdd:DMA hdd: TSSTcorp

[PATCH] ide: add hwif-ack_intr hook

2007-10-19 Thread Bartlomiej Zolnierkiewicz
* Add hwif-ack_intr hook and use it instead of hwif-hw.ack_intr. * Add missing brackets to cris-v32 and powerpc ide_ack_intr() macros. Cc: Roman Zippel [EMAIL PROTECTED] Cc: Geert Uytterhoeven [EMAIL PROTECTED] Cc: Andrew Morton [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

Re: New CD/DVD drive - 80-wire cable detection failure

2007-10-19 Thread Bartlomiej Zolnierkiewicz
On Saturday 20 October 2007, Nick Warne wrote: On Friday 19 October 2007 22:44:27 Bartlomiej Zolnierkiewicz wrote: hdparm -I It should have been hdparm --Istdout (sorry, once again). [ It is definitevely not my day, or rather trying to debug the problem while preparing the next IDE pull

Re: [PATCH] IDE: Remove inclusion of non-existent io_trace.h.

2007-10-19 Thread Bartlomiej Zolnierkiewicz
On Monday 08 October 2007, Bartlomiej Zolnierkiewicz wrote: Hi, On Sunday 07 October 2007, Robert P. J. Day wrote: Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] applied --- the fact that this header file doesn't exist has apparently been known for quite some time

Re: [2.6 patch] ide/pci/sis5513.c: add missing else

2007-10-19 Thread Bartlomiej Zolnierkiewicz
On Friday 19 October 2007, Adrian Bunk wrote: This patch adds a missing else that was missing in commit c77a89cd98d99819f23a4a08e5e17ee1f13f6e4d. Spotted by the Coverity checker. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] applied, thanks! --- 2e4b8d4f58ea45e55c87ba5563b0d0e135cac2b4

Re: New CD/DVD drive - 80-wire cable detection failure

2007-10-19 Thread Bartlomiej Zolnierkiewicz
Hi, On Friday 19 October 2007, Nick Warne wrote: On Thursday 18 October 2007 18:32:42 Nick Warne wrote: Hi all, Please CC, not subscribed. kernel 2.6.23 My DVD/CDrom stopped reading DVD's, so I purchased a new one today. Old: Oct 10 21:01:01 linuxamd kernel: ide0: BM-DMA

Re: [PATCH] ide: fix serverworks.c UDMA regression

2007-10-16 Thread Bartlomiej Zolnierkiewicz
On Monday 15 October 2007, Tony Battersby wrote: The patch described by the following excerpt from ChangeLog-2.6.22 makes it impossible to use UDMA on a Tyan S2707 motherboard (SvrWks CSB5): commit 2d5eaa6dd744a641e75503232a01f52d0768884c Author: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

Re: [PATCH] : IDE-CS Add additional id string (corsair, 1GB)

2007-10-16 Thread Bartlomiej Zolnierkiewicz
On Monday 15 October 2007, Kristoffer Ericson wrote: Greetings, The manf string looks weird (0x0 + 0x0), but I assume its correct. Also, whitespaces seems almost intentional, so am I missing something? Nope, thanks for cleaning this. Shortlog: This patch adds id strings for Corsair 1GB

Re: [git patches] IDE updates (part 2)

2007-10-16 Thread Bartlomiej Zolnierkiewicz
On Sunday 14 October 2007, Benjamin Herrenschmidt wrote: How's about this patch? [PATCH] ide-pmac: fix pmac_ide_init_hwif_ports() * pmac_ide_init_hwif_ports() can be called by ide_init_hwif_ports() (through ppc_ide_md.ide_init_hwif hook) for non IDE PMAC interfaces. If this

Re: [PATCH] dtc2278: note on docs

2007-10-16 Thread Bartlomiej Zolnierkiewicz
On Monday 15 October 2007, Alan Cox wrote: Signed-off-by: Alan Cox [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Fwd: CMD 64x regression from 2.6.21 to 2.6.22 and 2.6.23?

2007-10-16 Thread Bartlomiej Zolnierkiewicz
Hi, On Tuesday 16 October 2007, Mark Lord wrote: Sergei Shtylyov wrote: Martin Rogge wrote: Could you git-bisect this? Although I have a couple of patch suspects (dealing with interrupts), all worked fine with PCI-649 just fine. PCI-648 is not really much different from 649

Re: [PATCH] Update libata driver for bf548 atapi controller against the 2.6.24 tree.

2007-10-16 Thread Bartlomiej Zolnierkiewicz
, looks good Acked-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [git patch] libata build fix

2007-10-16 Thread Bartlomiej Zolnierkiewicz
PROTECTED] Cc: Jeff Garzik [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ata/pata_cs5536.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/ata/pata_cs5536.c

Re: [git patches] IDE updates (part 1)

2007-10-14 Thread Bartlomiej Zolnierkiewicz
On Friday 12 October 2007, Maciej W. Rozycki wrote: On Fri, 12 Oct 2007, Bartlomiej Zolnierkiewicz wrote: * Kconfig facelift - as a result of this change users have three less config options to worry about (BLK_DEV_IDEPCI, BLK_DEV_IDEDMA_PCI and IDE_CHIPSETS) and can just select host

Re: [git patches] IDE updates (part 2)

2007-10-14 Thread Bartlomiej Zolnierkiewicz
On Sunday 14 October 2007, Benjamin Herrenschmidt wrote: On Sun, 2007-10-14 at 00:41 +0200, Bartlomiej Zolnierkiewicz wrote: On Sunday 14 October 2007, Alan Cox wrote: /* Probably a PCI interface... */ for (i = IDE_DATA_OFFSET; i = IDE_STATUS_OFFSET; ++i

Re: [git patches] IDE updates (part 2)

2007-10-14 Thread Bartlomiej Zolnierkiewicz
On Sunday 14 October 2007, Al Viro wrote: Proposed addition to icside part, provided that ARM folks ACK it - gets icside to build and AFAICS it's correct: the patch looks good and gets my ACK but it is for Jeff ;) diff --git a/drivers/ata/pata_icside.c b/drivers/ata/pata_icside.c index

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Bartlomiej Zolnierkiewicz
On Saturday 13 October 2007, Alan Cox wrote: On Sat, 13 Oct 2007 18:25:24 +0200 Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] wrote: Hi, highlights of this update: * Rework of IDE PMAC host driver: bugfixes, removal of the code duplicated from the IDE core and conversion

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Bartlomiej Zolnierkiewicz
On Saturday 13 October 2007, Alan Cox wrote: Comment in pmac_ide_init_hwif_ports() is highly misleading as this function returns early only for normal IDE PCI devices (pmac_ide_init_hwif_ports() can be called outside ide-pmac driver through ppc_ide_md). Follow the code you pasted

Re: [git patches] IDE updates (part 2)

2007-10-13 Thread Bartlomiej Zolnierkiewicz
On Sunday 14 October 2007, Alan Cox wrote: /* Probably a PCI interface... */ for (i = IDE_DATA_OFFSET; i = IDE_STATUS_OFFSET; ++i) hw-io_ports[i] = data_port + i - IDE_DATA_OFFSET;

Re: [git patches] libata update

2007-10-12 Thread Bartlomiej Zolnierkiewicz
On Friday 12 October 2007, Jeff Garzik wrote: [ I just sent this upstream to Andrew and Linus ] Now that I have nailed down the corruption problem, I can attend to this... Fun stuff: * port multiplier support (like an ethernet hub, only dumber) Great to see this here. * Asynchronous

Re: [PATCH] IDE: Remove inclusion of non-existent io_trace.h.

2007-10-08 Thread Bartlomiej Zolnierkiewicz
Hi, On Sunday 07 October 2007, Robert P. J. Day wrote: Signed-off-by: Robert P. J. Day [EMAIL PROTECTED] --- the fact that this header file doesn't exist has apparently been known for quite some time: http://osdir.com/ml/linux.tape/2005-07/msg1.html diff --git

Re: [PATCH] ide: make jmicron match vendor and device class

2007-10-08 Thread Bartlomiej Zolnierkiewicz
On Monday 08 October 2007, Tejun Heo wrote: PATA part of all current JMB controllers behave the same way and JMicron confirms that all future ones will stay compatible. Matching vendor and device class is enough. For backward compatibility, jmicron still needs to match 361,3,5,6,8 DIDs

Re: [PATCH 12/15] ide: remove -dma_master field from ide_hwif_t

2007-10-08 Thread Bartlomiej Zolnierkiewicz
PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-dma.c |7 --- drivers/ide/ide.c |2 -- drivers/ide/pci/cmd64x.c |8 +--- drivers/ide/pci/hpt366.c | 21 +++-- drivers/ide/pci

[PATCH 1/12] ide: check -dma_setup() return value in flagged_taskfile()

2007-10-08 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-taskfile.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) Index: b/drivers/ide/ide-taskfile.c === --- a/drivers/ide/ide-taskfile.c

[PATCH 2/12] ide: check drive-using_dma in flagged_taskfile()

2007-10-08 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-taskfile.c |3 +++ 1 file changed, 3 insertions(+) Index: b/drivers/ide/ide-taskfile.c === --- a/drivers/ide/ide-taskfile.c +++ b/drivers/ide/ide

[PATCH 3/12] ide: fix -data_phase in taskfile_load_raw()

2007-10-08 Thread Bartlomiej Zolnierkiewicz
It should be TASKFILE_NO_DATA, not TASKFILE_IN. Luckily ATM -data_phase is unused if -command_type == IDE_DRIVE_TASK_NO_DATA but this may change in the future. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-acpi.c |2 +- 1 file changed, 1 insertion(+), 1

[PATCH 6/12] ide: add struct ide_taskfile

2007-10-08 Thread Bartlomiej Zolnierkiewicz
__KERNEL__ around definitions of {task,hob}_struct_t. While at it: * Use ATA_LBA define for LBA bit (0x40) as suggested by Tejun Heo. There should be no functionality changes caused by this patch. Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers

[PATCH 7/12] ide-disk: merge LBA28 and LBA48 Host Protected Area support code

2007-10-08 Thread Bartlomiej Zolnierkiewicz
* Merge idedisk_{read_native,set}_max_address_ext() into idedisk_{read_native,set}_max_address(). There should be no functionality changes caused by this patch. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c | 102

[PATCH 5/12] ide: remove task_ioreg_t typedef

2007-10-08 Thread Bartlomiej Zolnierkiewicz
Remove task_ioreg_t typedef from the kernel code (but leave it in linux/hdreg.h for #ifndef/#endif __KERNEL__ case). While at it also move sata_ioreg_t typedef under #ifndef/#endif __KERNEL__. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c | 20

[PATCH 8/12] ide-disk: fix taskfile registers loading order in __ide_do_rw_disk()

2007-10-08 Thread Bartlomiej Zolnierkiewicz
in which hardware is accessed from code cleanups). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/ide/ide-disk.c

[PATCH 9/12] ide-disk: use struct ide_taskfile in __ide_do_rw_disk()

2007-10-08 Thread Bartlomiej Zolnierkiewicz
Based on the earlier work by Tejun Heo. There should be no functionality changes caused by this patch. Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c | 87 - 1 file changed

[PATCH 10/12] ide: add ide_tf_load() helper

2007-10-08 Thread Bartlomiej Zolnierkiewicz
some more investigation). * Split off ide_tf_load() helper from do_rw_taskfile(). * Convert __ide_do_rw_disk() to use ide_tf_load(). There should be no functionality changes caused by this patch. Cc: Tejun Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 11/12] ide: add ide_no_data_taskfile() helper

2007-10-08 Thread Bartlomiej Zolnierkiewicz
* Add ide_no_data_taskfile() helper and convert ide_raw_taskfile() w/ NO DATA protocol users to use it instead. * Set -data_phase explicitly in ide_no_data_taskfile() (TASKFILE_NO_DATA is defined as 0x). * Unexport task_no_data_intr(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL

[PATCH 12/12] ide: use do_rw_taskfile() in flagged_taskfile()

2007-10-08 Thread Bartlomiej Zolnierkiewicz
Heo [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-disk.c |3 drivers/ide/ide-io.c | 31 +-- drivers/ide/ide-taskfile.c | 180 ++--- include/linux/ide.h| 25 +- 4 files

Re: Bug #4580: hda: lost interrupt when resuming from S3 - Sony VGN-T1XP

2007-10-08 Thread Bartlomiej Zolnierkiewicz
Hi, On Sunday 07 October 2007, Rafael J. Wysocki wrote: Hi, IDE/ATA wizzards are kindly requested to have a look at: http://bugzilla.kernel.org/show_bug.cgi?id=4580#c21 as I have no idea of what we can do about the hard drive password vs suspend problem, if anything.

Re: [-mm patch] unexport noautodma

2007-10-03 Thread Bartlomiej Zolnierkiewicz
On Sunday 09 September 2007, Adrian Bunk wrote: noautodma can now be unexported. Signed-off-by: Adrian Bunk [EMAIL PROTECTED] applied - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 11/15] ide: PCI BMDMA initialization fixes

2007-10-03 Thread Bartlomiej Zolnierkiewicz
On Wednesday 03 October 2007, Sergei Shtylyov wrote: Hello. Bartlomiej Zolnierkiewicz wrote: * Set hwif-dma_base only if allocation of extra ports succeeds. * Allocate hwif-dmatable_cpu before reserving I/O ports. Looks like a bit of teardown code was missed with that change

Re: [PATCH 3/3] ide: add CONFIG_IDE_ARCH_OBSOLETE_INIT

2007-10-02 Thread Bartlomiej Zolnierkiewicz
On Tuesday 02 October 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: Add CONFIG_IDE_ARCH_OBSOLETE_INIT to drivers/ide/Kconfig and use it instead of defining IDE_ARCH_OBSOLETE_INIT in arch/ide.h. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] include/asm

Re: [PATCH 9/15] cs5530: remove needless ide_lock taking

2007-10-02 Thread Bartlomiej Zolnierkiewicz
On Tuesday 02 October 2007, Alan Cox wrote: - spin_lock_irqsave(ide_lock, flags); - /* all CPUs (there should only be one CPU with this chipset) */ - NAK What about pre-emptible kernels. Put in a private lock. All the removed code resided in init_chipset_cs5530() which is

Re: [PATCH 12/15] ide: remove -dma_master field from ide_hwif_t

2007-10-02 Thread Bartlomiej Zolnierkiewicz
On Tuesday 02 October 2007, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: On Monday 01 October 2007, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: * Convert cmd64x, hpt366 and pdc202xx_old host drivers to use pci_resource_start(hwif-pci_dev, 4) instead of hwif-dma_master

Re: [patch] SB700 contains more than one IDE channel

2007-10-01 Thread Bartlomiej Zolnierkiewicz
On Thursday 27 September 2007, Shane Huang wrote: From: [EMAIL PROTECTED] SB700 supports one physical IDE channel, but SB700 SATA controller supports combined mode. When the SATA combined mode is enabled, two SATA ports(port4 and port5) share one IDE channel from IDE controller, and PATA

Re: [PATCH 4/4] hpt366: MWDMA filter for SATA cards (take 2)

2007-10-01 Thread Bartlomiej Zolnierkiewicz
On Saturday 29 September 2007, Sergei Shtylyov wrote: The Marvell bridge chips used on HighPoint SATA cards do not seem to support the MWDMA modes (at least that caould be seen in their so-called drivers :-), so the driver needs to account for this -- to achieve this: - add mdma_filter()

[PATCH 1/15] ali14xx: fix deadlock on error handling

2007-10-01 Thread Bartlomiej Zolnierkiewicz
Stop abusing ide_lock lock by switching to a private locking. Fixes same issue as fixed by Alan Cox in atiixp host driver with commit 6c5f8cc33eb2e10b6ab788bbe259fc142a068627. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/ali14xx.c |6 -- 1 file

[PATCH 2/15] dtc2278: fix deadlock on error handling

2007-10-01 Thread Bartlomiej Zolnierkiewicz
Stop abusing ide_lock lock (switch to a private locking). Fixes same issue as fixed by Alan Cox in atiixp host driver with commit 6c5f8cc33eb2e10b6ab788bbe259fc142a068627. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/dtc2278.c |6 -- 1 file changed

[PATCH 3/15] qd65xx: fix deadlock on error handling

2007-10-01 Thread Bartlomiej Zolnierkiewicz
Stop abusing ide_lock lock (switch to a private locking). Fixes same issue as fixed by Alan Cox in atiixp host driver with commit 6c5f8cc33eb2e10b6ab788bbe259fc142a068627. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/qd65xx.c | 17 + 1

[PATCH 5/15] slc90e66: fix deadlock on error handling

2007-10-01 Thread Bartlomiej Zolnierkiewicz
* Stop abusing ide_lock lock (switch to a private locking). Fixes same issue as fixed by Alan Cox in atiixp host driver with commit 6c5f8cc33eb2e10b6ab788bbe259fc142a068627. * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/slc90e66.c

[PATCH 4/15] opti621: fix deadlock on error handling

2007-10-01 Thread Bartlomiej Zolnierkiewicz
* Stop abusing ide_lock lock (switch to a private locking). Fixes same issue as fixed by Alan Cox in atiixp host driver with commit 6c5f8cc33eb2e10b6ab788bbe259fc142a068627. * Bump driver version. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/opti621.c

[PATCH 6/15] cmd640: fix deadlock on error handling

2007-10-01 Thread Bartlomiej Zolnierkiewicz
disable/enable). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cmd640.c | 48 +++ 1 file changed, 28 insertions(+), 20 deletions(-) Index: b/drivers/ide/pci/cmd640.c

[PATCH 9/15] cs5530: remove needless ide_lock taking

2007-10-01 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/cs5530.c |8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) Index: b/drivers/ide/pci/cs5530.c === --- a/drivers/ide/pci/cs5530.c +++ b

[PATCH 10/15] ide: enhance ide_setup_pci_noise()

2007-10-01 Thread Bartlomiej Zolnierkiewicz
* Print PCI device Vendor ID, Device ID and revision in ide_setup_pci_noise(). * Remove no longer needed PCI device revision printing from ide_setup_pci_controller(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/setup-pci.c |8 +++- 1 file changed, 3

[PATCH 13/15] ide: use __ide_end_request() in ide_end_dequeued_request()

2007-10-01 Thread Bartlomiej Zolnierkiewicz
* Remove dead code for handling IDE TCQ from ide_end_dequeued_request(). * Add 'dequeue' parameter to __ide_end_request(). * Use __ide_end_request() in ide_end_dequeued_request(). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-io.c | 44

[PATCH 15/15] ide: remove stale comments from ide-taskfile.c

2007-10-01 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-taskfile.c | 23 --- 1 file changed, 23 deletions(-) Index: b/drivers/ide/ide-taskfile.c === --- a/drivers/ide/ide-taskfile.c

[PATCH 12/15] ide: remove -dma_master field from ide_hwif_t

2007-10-01 Thread Bartlomiej Zolnierkiewicz
* Convert cmd64x, hpt366 and pdc202xx_old host drivers to use pci_resource_start(hwif-pci_dev, 4) instead of hwif-dma_master. * Remove no longer needed -dma_master field from ide_hwif_t. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-dma.c |7

[PATCH 14/15] ide: remove dead code from ide_driveid_update()

2007-10-01 Thread Bartlomiej Zolnierkiewicz
* Remove dead code from ide_driveid_update(). While at it: * Remove useless comment. * s/HWIF(drive)/drive-hwif/ Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide-iops.c | 26 +++--- 1 file changed, 3 insertions(+), 23 deletions(-) Index: b

Re: [PATCH 12/15] ide: remove -dma_master field from ide_hwif_t

2007-10-01 Thread Bartlomiej Zolnierkiewicz
On Monday 01 October 2007, Jeff Garzik wrote: Bartlomiej Zolnierkiewicz wrote: * Convert cmd64x, hpt366 and pdc202xx_old host drivers to use pci_resource_start(hwif-pci_dev, 4) instead of hwif-dma_master. Before using pci_resource_start(), the code should check pci_resource_len

Re: [PATCH 3/4] ide: make ide_rate_filter() also respect PIO and SW/MW DMA mode masks (take 2)

2007-09-24 Thread Bartlomiej Zolnierkiewicz
On Monday 24 September 2007, Sergei Shtylyov wrote: Once I quothed: Make ide_rate_filter() also respect PIO/SWDMA/MWDMA mode masks. While at it, make the udma_filter() method calls take precedence over using the mode masks. This one not looking to pretty -- I've geve some

Re: [PATCH] ide: remove -ide_dma_check (take 2)

2007-09-24 Thread Bartlomiej Zolnierkiewicz
On Monday 24 September 2007, Sergei Shtylyov wrote: Bartlomiej Zolnierkiewicz wrote: [...] @@ -783,6 +783,23 @@ int ide_tune_dma(ide_drive_t *drive) EXPORT_SYMBOL_GPL(ide_tune_dma); You're converting it to static and yet leaving exportable -- what for? Oversight, export should

[PATCH 1/9] ide_platform: set hwif-chipset

2007-09-24 Thread Bartlomiej Zolnierkiewicz
We need to set hwif-chipset or IDE PCI host drivers may try to claim our ide_hwifs[] slot. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/ide_platform.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Index: b/drivers/ide/legacy/ide_platform.c

[PATCH 2/9] ide: fix ide_register_hw() to check hwif-io_ports[]

2007-09-24 Thread Bartlomiej Zolnierkiewicz
is to be removed). Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/ide.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: b/drivers/ide/ide.c === --- a/drivers/ide/ide.c +++ b/drivers/ide/ide.c

[PATCH 3/9] icside: use ec-dma directly

2007-09-24 Thread Bartlomiej Zolnierkiewicz
* hwif-hwif_data contains pointer to struct expansion_card so use ec-dma directly instead of caching it in hwif-hw.dma. * Remove no longer needed hw_regs_t.dma and NO_DMA define. Cc: Russell King [EMAIL PROTECTED] Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm

[PATCH 4/9] ide: remove write-only hwif-hw

2007-09-24 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/arm/icside.c |5 - drivers/ide/arm/rapide.c |4 +--- drivers/ide/ide.c | 15 --- drivers/ide/legacy/ide_platform.c | 11 +-- drivers/ide/mips/au1xxx

[PATCH 5/9] au1xxx-ide: set -autotune and -no_io_32bit also for the slave device

2007-09-24 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/mips/au1xxx-ide.c |4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: b/drivers/ide/mips/au1xxx-ide.c === --- a/drivers/ide/mips/au1xxx-ide.c

[PATCH 6/9] dtc2278: set -pio_mask also for the second port

2007-09-24 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/legacy/dtc2278.c |1 + 1 file changed, 1 insertion(+) Index: b/drivers/ide/legacy/dtc2278.c === --- a/drivers/ide/legacy/dtc2278.c +++ b/drivers/ide

[PATCH 8/9] ide: replace ide_pci_device_t by struct ide_port_info

2007-09-24 Thread Bartlomiej Zolnierkiewicz
* Rename struct ide_pci_device_s to struct ide_port_info. * Remove ide_pci_device_t typedef. While at it: * Fix __ide_pci_register_driver() comment. * Fix aec62xx_init_one() comment. * Remove unused 'cds' field from ide_hwgroup_t. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED

[PATCH 7/9] via82cxxx: keep local ide_pci_device_t copy

2007-09-24 Thread Bartlomiej Zolnierkiewicz
. Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/via82cxxx.c | 62 +++- 1 file changed, 27 insertions(+), 35 deletions(-) Index: b/drivers/ide/pci/via82cxxx.c

[PATCH 9/9] ide: constify struct ide_port_info

2007-09-24 Thread Bartlomiej Zolnierkiewicz
Signed-off-by: Bartlomiej Zolnierkiewicz [EMAIL PROTECTED] --- drivers/ide/pci/aec62xx.c |2 +- drivers/ide/pci/alim15x3.c |2 +- drivers/ide/pci/amd74xx.c |4 ++-- drivers/ide/pci/atiixp.c |2 +- drivers/ide/pci/cmd64x.c |2 +- drivers/ide/pci

<    2   3   4   5   6   7   8   9   10   11   >