eset and default to PIO mode
only. Any DMA transfer that is attempted simply hangs.
The other issue is PMP support. The more that gets pushed into libsas,
the more libsas needs to know about things such as PMP.
-Brian
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
This patch converts ipr to use the new libata EH API. This simplifies
a lot of the code, should make it more maintainable, and also provides
more robust error handling.
Signed-off-by: Brian King <[EMAIL PROTECTED]>
---
linux-2.6-bjking1/drivers/scsi/ipr.c
should hopefully
make is easier to support PMP on SAS.
3. SATA rphy's have their own scsi_host, which makes SAS much more
like all the other SATA drivers.
4. It eliminates tying scsi_target object lifetimes to ata_port lifetimes
and introduces a cleaner API.
Signed-off-by: Brian
r to the ata_port. This allows for ap->dev to be
any arbitrary struct device. This is to be used by the libata SAS
LLDDs.
Signed-off-by: Brian King <[EMAIL PROTECTED]>
---
linux-2.6-bjking1/drivers/ata/libata-core.c | 13 -
linux-2.6-bjking1/include/linux/libata.h|2 ++
added some code to
ipr. Longer term, block layer queue groups might be another way to do this.
I'm still polishing this up, but it is up and running and seems to work with
what testing I've done so far.
-Brian
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
-
To u
ler(), ->freeze(), ->thaw().
I'll look into this.
-Brian
--
Brian King
Linux on Power Virtualization
IBM Linux Technology Center
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Jeff Garzik wrote:
> This has been testing in -mm for a while, but I wanted to send it
> separated from the main libata update, since it has a chance of
> breakage.
>
> Most notably, a cumulative timeout (deadline) helps the code from diving
> into overly-long reset sequences.
>
> Please pull fro
hanks,
Brian
--
Brian King
eServer Storage I/O
IBM Linux Technology Center
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Tejun Heo wrote:
> Brian King wrote:
>> For SAS, the scsi_host pointer in the ata port is NULL today, since libata
>> is really not managing the scsi host, the LLDD is. I think the initialization
>> model we want for SAS is a little different than the one you are heading
&g
t
sense for these devices for SAS is done without entering eh today. Would
you want to move this into eh as well?
Brian
--
Brian King
eServer Storage I/O
IBM Linux Technology Center
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAI
eing used in the current
implementation. My guess is that aic94xx will have similar issues/concerns.
Brian
--
Brian King
eServer Storage I/O
IBM Linux Technology Center
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTE
Some LLDDs, like ipr, use nbytes and pad_len to determine
the total data transfer length of a command. Make sure
nbytes gets initialized for internally generated commands.
Signed-off-by: Brian King <[EMAIL PROTECTED]>
---
Jeff,
This bug is already fixed in #upstream, with Tejun's p
Jeff Garzik wrote:
> All fixes for ugly bugs and/or regressions.
>
> Brian King (2):
> libata: Fixup n_elem initialization
> libata: Initialize qc->pad_len
Thanks for pulling this in. There is one patch outstanding preventing
ipr SATA from working:
http://marc.t
Brian King wrote:
> Tejun Heo wrote:
>> Brian King wrote:
>>> Some LLDDs, like ipr, use nbytes and pad_len to determine
>>> the total data transfer length of a command. Make sure
>>> nbytes gets initialized for internally generated commands.
>> I thin
Tejun Heo wrote:
> Brian King wrote:
>> Some LLDDs, like ipr, use nbytes and pad_len to determine
>> the total data transfer length of a command. Make sure
>> nbytes gets initialized for internally generated commands.
>
> I think it's better to apply the fol
Brian King wrote:
> Jeff Garzik wrote:
>> Brian King wrote:
>>> ACK
>> Does this response mean that you've tested it, and successfully verified
>> your problem is gone?
>
> Yes, I have tested it, but all my problems are not gone with this
> one patch. T
Initialize qc->pad_len for each new command. This ensures
that pad_len is not set to a stale value for zero data
length commands.
Signed-off-by: Brian King <[EMAIL PROTECTED]>
---
linux-2.6-bjking1/include/linux/libata.h |1 +
1 files changed, 1 insertion(+)
diff -puN incl
ipr adapters.
Signed-off-by: Brian King <[EMAIL PROTECTED]>
---
linux-2.6-bjking1/drivers/ata/libata-scsi.c |2 +-
linux-2.6-bjking1/include/linux/libata.h|1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff -puN drivers/ata/libata-scsi.c~libata_fixup_nelem drivers/ata/liba
Some LLDDs, like ipr, use nbytes and pad_len to determine
the total data transfer length of a command. Make sure
nbytes gets initialized for internally generated commands.
Signed-off-by: Brian King <[EMAIL PROTECTED]>
---
linux-2.6-bjking1/drivers/ata/libata-core.c |1 +
1 files chan
Jeff Garzik wrote:
> Brian King wrote:
>> ACK
>
> Does this response mean that you've tested it, and successfully verified
> your problem is gone?
Yes, I have tested it, but all my problems are not gone with this
one patch. This fixes the problem I was seeing where the
ed_cmd *qc)
> {
> + qc->dma_dir = DMA_NONE;
> qc->__sg = NULL;
> qc->flags = 0;
> qc->cursect = qc->cursg = qc->cursg_ofs = 0;
> -
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a mess
Brian King wrote:
> James Bottomley wrote:
>> On Tue, 2007-01-16 at 17:45 -0500, Jeff Garzik wrote:
>>> Tejun recently updated the CDB length areas of the code. I bet it's
>>> either a bug somewhere in there, or the SCSI layer isn't passing us
>&g
ection like ata_scsi_translate() does?
I think we are OK here since atapi_xlate is only ever called by
ata_scsi_translate.
Brian
--
Brian King
eServer Storage I/O
IBM Linux Technology Center
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
7;ve been seeing is that I am getting zero length commands,
such as TEST_UNIT_READY with a dma_dir of DMA_FROM_DEVICE. Shouldn't this be
DMA_NONE? I'm still tracking this down.
Brian
--
Brian King
eServer Storage I/O
IBM Linux Technology Center
-
To unsubscribe from this list: send th
24 matches
Mail list logo
