Re: [PATCH] libata: track spindown status and skip spindown_compat if possible

2007-05-15 Thread Francesco Pretto
2007/5/15, Tejun Heo <[EMAIL PROTECTED]>: Yeah, it's a big mess. With this patch applied, what happens is... * If your shutdown(8) does issue STANDBYNOW : you get the big fat warning and kernel won't issue STANDBYNOW. * If your shutdown(8) doesn't issue STANDBYNOW : kernel issues FLUSH CACHE f

Re: [PATCH] libata: track spindown status and skip spindown_compat if possible

2007-05-15 Thread Francesco Pretto
Tejun Heo gmail.com> writes: > > Our assumption that most distros issue STANDBYNOW seems wrong. The > upstream sysvinit and thus many distros including gentoo and opensuse > don't take any action for libata disks on spindown. We can skip > compat handling for these distros so that they don't n

Re: Fixing halt/shutdown for libata spindown handling

2007-05-15 Thread Francesco Pretto
Tejun Heo gmail.com> writes: > > > Final question: should spindown_compat be set to 0 for both shutdown and > > reboot, or just shutdown? > > It doesn't really matter. It just needs to be set while powering down. > You can set it anywhere, during boot, in shutdown. > > Thanks. > Hibernate/s