Re: [PATCH] SCSI: Add the SGPIO support for sata_nv.c

2007-01-31 Thread Kristen Carlson Accardi
On Fri, 17 Nov 2006 13:04:30 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Peer Chen wrote: > > I didn't get any comment from you guys for new patch, does someone take > > care this patch, do we still need some modification upon it? Or do we > > need re-submit it in other thread? > > For my part

Re: [PATCH] SCSI: Add the SGPIO support for sata_nv.c

2007-02-01 Thread Kristen Carlson Accardi
ldn't bank on it. > > Andy > > -----Original Message- > From: [EMAIL PROTECTED] > [mailto:[EMAIL PROTECTED] On Behalf Of Kristen Carlson > Accardi > Sent: Wednesday, January 31, 2007 15:22 > To: Jeff Garzik > Cc: Peer Chen; Christoph Hellwig; Prakash Punnoor; A

[patch] ata: ahci: Enclosure Management via LED

2007-11-29 Thread Kristen Carlson Accardi
This patch implements Enclosure Management via the LED protocol. See the AHCI 1.1 spec for details. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> --- Here's a new version of the Enclosure management patch I sent a few weeks ago. I tried to incorporate all the feedback, a

Re: [patch] ata: ahci: Enclosure Management via LED

2007-11-29 Thread Kristen Carlson Accardi
On Thu, 29 Nov 2007 09:48:02 -0800 Kristen Carlson Accardi <[EMAIL PROTECTED]> wrote: > This patch implements Enclosure Management via the LED protocol. See > the AHCI 1.1 spec for details. Whoops, I totally messed up and sent the wrong version of this patch. I'll send an up

Re: [patch] ata: ahci: Enclosure Management via LED

2007-11-29 Thread Kristen Carlson Accardi
On Thu, 29 Nov 2007 13:16:07 -0500 Mark Lord <[EMAIL PROTECTED]> wrote: > Kristen wrote: > ... > >+ * XXX will need Port Multiplier support > > What's that all about ? > I didn't have any hardware that had LED support as well as Port Multiplier, so I didn't implement port multiplier support

[patch] ata: ahci: Enclosure Management via LED

2007-11-29 Thread Kristen Carlson Accardi
This patch implements Enclosure Management via the LED protocol. See the AHCI 1.1 spec for details. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> --- Ok, here's one that actually compiles... drivers/ata/ahci.c| 154 +++

Re: [patch] ata: ahci: Enclosure Management via LED rev2

2007-11-30 Thread Kristen Carlson Accardi
Enclosure Management via LED This patch implements Enclosure Management via the LED protocol as specified in AHCI specification. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> --- This revision makes the change to the comment requested by Mark Lord, fixes some bugs in t

Re: [patch] ata: ahci: Enclosure Management via LED rev2

2007-12-03 Thread Kristen Carlson Accardi
On Sat, 01 Dec 2007 18:28:54 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Kristen Carlson Accardi wrote: > > Enclosure Management via LED > > > > This patch implements Enclosure Management via the LED protocol as > > specified in AHCI specification. > &

Re: [patch 7/9] ata: ahci: Enclosure Management via LED

2007-12-14 Thread Kristen Carlson Accardi
On Thu, 13 Dec 2007 16:01:42 -0800 [EMAIL PROTECTED] wrote: > From: Kristen Carlson Accardi <[EMAIL PROTECTED]> > > Implement Enclosure Management via the LED protocol. See the AHCI > 1.1 spec for details. Hi Andrew and Jeff, I am working on a revised version of this patch, s

[PATCH] libata: add enclosure management support

2008-01-15 Thread Kristen Carlson Accardi
blinks off every 10ms when activity is detected. It's important to note that the user must turn sw_activity OFF it they wish to control the activity LED via the em_message file. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> --- I'm concerned about my

Re: [PATCH] libata: add enclosure management support

2008-01-17 Thread Kristen Carlson Accardi
On Thu, 17 Jan 2008 16:50:42 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > On Tue, 2008-01-15 at 16:44 -0800, Kristen Carlson Accardi wrote: > > Add Enclosure Management support to libata and ahci. > > > > This patch adds support for the LED protocol, as defin

Re: [PATCH] libata: add enclosure management support

2008-01-18 Thread Kristen Carlson Accardi
On Thu, 17 Jan 2008 16:50:42 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > On Tue, 2008-01-15 at 16:44 -0800, Kristen Carlson Accardi wrote: > > Add Enclosure Management support to libata and ahci. > > > > This patch adds support for the LED protocol, as defin

Re: [PATCH] libata: add enclosure management support

2008-01-18 Thread Kristen Carlson Accardi
On Fri, 18 Jan 2008 18:16:34 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > On Fri, 2008-01-18 at 09:41 -0800, Kristen Carlson Accardi wrote: > > On Fri, 18 Jan 2008 11:11:21 -0600 > > James Bottomley <[EMAIL PROTECTED]> wrote: > > > > > > &

Re: [PATCH] libata: add enclosure management support

2008-01-18 Thread Kristen Carlson Accardi
On Fri, 18 Jan 2008 18:47:18 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > On Fri, 2008-01-18 at 16:35 -0800, Kristen Carlson Accardi wrote: > > > Unfortunately, all the dual SAS/SATA enclosures seem to be coming > > > with either SGPIO devices or full f

Re: [PATCH] libata: add enclosure management support

2008-01-18 Thread Kristen Carlson Accardi
On Fri, 18 Jan 2008 18:16:34 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > On Fri, 2008-01-18 at 09:41 -0800, Kristen Carlson Accardi wrote: > > On Fri, 18 Jan 2008 11:11:21 -0600 > > James Bottomley <[EMAIL PROTECTED]> wrote: > > > > > > &

Re: [PATCH] libata: add enclosure management support

2008-01-18 Thread Kristen Carlson Accardi
On Fri, 18 Jan 2008 11:11:21 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > > On Fri, 2008-01-18 at 08:52 -0800, Kristen Carlson Accardi wrote: > > On Thu, 17 Jan 2008 16:50:42 -0600 > > James Bottomley <[EMAIL PROTECTED]> wrote: > > > > > On Tu

Re: [PATCH] enclosure: add support for enclosure services

2008-02-12 Thread Kristen Carlson Accardi
On Tue, 12 Feb 2008 12:45:35 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > On Tue, 2008-02-12 at 10:22 -0800, Kristen Carlson Accardi wrote: > > I apologize for taking so long to review this patch. I obviously > > agree wholeheartedly with Luben. The problem I ran int

Re: [PATCH] enclosure: add support for enclosure services

2008-02-12 Thread Kristen Carlson Accardi
On Mon, 4 Feb 2008 18:01:36 -0800 (PST) Luben Tuikov <[EMAIL PROTECTED]> wrote: > --- On Mon, 2/4/08, James Bottomley > <[EMAIL PROTECTED]> wrote: > > > > The enclosure misc device is really just a > > library providing > > > > sysfs > > > > support for physical enclosure devices and their > > > >

Re: [PATCH] enclosure: add support for enclosure services

2008-02-13 Thread Kristen Carlson Accardi
On Tue, 12 Feb 2008 13:28:15 -0600 James Bottomley <[EMAIL PROTECTED]> wrote: > On Tue, 2008-02-12 at 11:07 -0800, Kristen Carlson Accardi wrote: > > I understand what you are trying to do - I guess I just doubt the > > value you've added by doing this. I think that

Re: libata-acpi: allow _GTF on SATA, but disable on PATA for now

2007-03-12 Thread Kristen Carlson Accardi
On Sat, 10 Mar 2007 16:40:59 + Alan Cox <[EMAIL PROTECTED]> wrote: > Instead merge the one that fixe the non PCI > crashes and we might get further. In bugzilla #7907 you could post your patch and see if the reporters there can at least confirm that it fixes their problem. Meanwhile, to solv

Re: libata-acpi: allow _GTF on SATA, but disable on PATA for now

2007-03-12 Thread Kristen Carlson Accardi
On Mon, 12 Mar 2007 22:00:15 + Alan Cox <[EMAIL PROTECTED]> wrote: > > Meanwhile, to solve the problem for these people, and without introducing > > a lot of new code at this stage in the release, perhaps you can suggest > > a more accurate way to detect PATA vs. SATA so we can fix the bug?

Re: CONFIG_IBM_BAY

2007-03-15 Thread Kristen Carlson Accardi
On Thu, 15 Mar 2007 16:31:24 -0300 Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Thu, 15 Mar 2007, Kristen Carlson Accardi wrote: > > I think we should focus our efforts on a generic (non platform specific) > > solution that can work across many laptops (i.e. A

Re: CONFIG_IBM_BAY

2007-03-19 Thread Kristen Carlson Accardi
On Mon, 19 Mar 2007 13:22:43 + Matthew Garrett <[EMAIL PROTECTED]> wrote: > On Sun, Mar 18, 2007 at 09:27:51AM +0100, Holger Macht wrote: > > > I don't prefer any solution, whether doing it inside the kernel, or doing > > it in userspace. What would be good would be to know what's the 'right'

Re: CONFIG_IBM_BAY

2007-03-19 Thread Kristen Carlson Accardi
On Sun, 18 Mar 2007 19:55:30 +0100 Holger Macht <[EMAIL PROTECTED]> wrote: > On Sun 18. Mar - 15:36:52, Henrique de Moraes Holschuh wrote: > > On Sun, 18 Mar 2007, Holger Macht wrote: > > > those ThinkPads where it is needed. Afterwards it does the corresponding > > > dock/undock request on ibm_ac

Re: CONFIG_IBM_BAY

2007-03-19 Thread Kristen Carlson Accardi
On Mon, 19 Mar 2007 15:37:46 +0100 Holger Macht <[EMAIL PROTECTED]> wrote: > Sure. What actually bothers me is that in its current state, the dock > station driver signals 'green' on the dock station as soon as the user > presses the hardware undock button, but regardlessly of anything else. I > t

Re: CONFIG_IBM_BAY

2007-03-19 Thread Kristen Carlson Accardi
On Sun, 18 Mar 2007 15:36:52 -0300 Henrique de Moraes Holschuh <[EMAIL PROTECTED]> wrote: > On Sun, 18 Mar 2007, Holger Macht wrote: > > those ThinkPads where it is needed. Afterwards it does the corresponding > > dock/undock request on ibm_acpi. And this works reliably good what I can > > see fro

problem detecting ATAPI device with ahci on 2.6.21-rcx

2007-03-20 Thread Kristen Carlson Accardi
Hi, I upgrade a machine from 2.6.20->2.6.21-rc4 and am now having problems with my ATAPI device getting detected properly. Back tracking to 2.6.21-rc1, I find the problem existed there too, but not in 2.6.20. ahci :00:1f.2: version 2.0 ACPI: PCI Interrupt :00:1f.2[C] -> GSI 19 (level, low

[patch 0/3] [RFC] SATA Asynchronous Notification for ATAPI devices

2007-03-20 Thread Kristen Carlson Accardi
Hi! I was hoping you could give me some feedback on this partial implementation of Asynchronous Notification for ATAPI devices as defined in SATA 2.5 and AHCI 1.1. I am specifically concerned about the method I used to expose this functionality to user space (so that hal can stop polling if it f

[patch 1/3] libata: check for AN support

2007-03-20 Thread Kristen Carlson Accardi
Check to see if an ATAPI device supports Asynchronous Notification. If so, enable it. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/libata-core.c === --- 2.6-git.orig/drivers/ata/libata-

[patch 2/3] libata: expose AN support to user space via sysfs

2007-03-20 Thread Kristen Carlson Accardi
set in the generic disk to indicate whether or not AN is supported. This flag is set by the SCSI subsystem when it registers with add_disk. The SCSI system gets information from libata on whether the device supports AN during dev_configure. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTE

[patch 3/3] libata: handle AN interrupt

2007-03-20 Thread Kristen Carlson Accardi
When we get an SDB FIS with the 'N' bit set, we should send an event to user space to indicate that there has been a media change. The ahci host controller will send the event via KOBJ_CHANGE uevent. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/dr

Re: CONFIG_IBM_BAY

2007-03-20 Thread Kristen Carlson Accardi
On Tue, 20 Mar 2007 16:53:21 +0100 Holger Macht <[EMAIL PROTECTED]> wrote: > On Mon 19. Mar - 11:04:12, Kristen Carlson Accardi wrote: > > On Sun, 18 Mar 2007 19:55:30 +0100 > > Holger Macht <[EMAIL PROTECTED]> wrote: > > > > > On Sun 18. Mar - 1

[patch 0/3] Asynchronous Notification for SATA ATAPI devices

2007-03-28 Thread Kristen Carlson Accardi
This patch series implements Asynchronous Notification (AN) for SATA ATAPI devices as defined in SATA 2.5 and AHCI 1.1. Drives which support this feature will send a notification when new media is inserted into the drive, preventing the need for user space to poll for new media. This support is e

[patch 2/3] libata: expose AN support to user space via sysfs

2007-03-28 Thread Kristen Carlson Accardi
set in the generic disk to indicate whether or not AN is supported. This flag is set by the SCSI subsystem when it registers with add_disk. The SCSI system gets information from libata on whether the device supports AN during dev_configure. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTE

[patch 1/3] libata: check for AN support

2007-03-28 Thread Kristen Carlson Accardi
Check to see if an ATAPI device supports Asynchronous Notification. If so, enable it. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-mm/drivers/ata/libata-core.c === --- 2.6-mm.orig/drivers/ata/libata-

[patch 3/3] libata: handle AN interrupt

2007-03-28 Thread Kristen Carlson Accardi
When we get an SDB FIS with the 'N' bit set, we should send an event to user space to indicate that there has been a media change. The ahci host controller will send the event via KOBJ_CHANGE uevent. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-mm/dr

Re: problem detecting ATAPI device with ahci on 2.6.21-rcx

2007-03-29 Thread Kristen Carlson Accardi
On Tue, 20 Mar 2007 16:49:20 -0700 Kristen Carlson Accardi <[EMAIL PROTECTED]> wrote: > Hi, I upgrade a machine from 2.6.20->2.6.21-rc4 and am now having problems > with my ATAPI device getting detected properly. Back tracking to 2.6.21-rc1, > I find the problem existed the

[patch 1/7] libata: check for AN support

2007-04-23 Thread Kristen Carlson Accardi
Check to see if an ATAPI device supports Asynchronous Notification. If so, enable it. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/libata-core.c === --- 2.6-git.orig/drivers/ata/libata-

[patch 0/7] Asynchronous Notification for ATAPI devices (v2)

2007-04-23 Thread Kristen Carlson Accardi
This patch series implements Asynchronous Notification (AN) for SATA ATAPI devices as defined in SATA 2.5 and AHCI 1.1 and higher. Drives which support this feature will send a notification when new media is inserted and removed, preventing the need for user space to poll for new media. This supp

[patch 2/7] genhd: expose AN to user space

2007-04-23 Thread Kristen Carlson Accardi
ew flag to define the media change notification capability. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/block/genhd.c === --- 2.6-git.orig/block/genhd.c +++ 2.6-git/block/genhd.c @@ -370,7 +370,10 @

[patch 5/7] genhd: send async notification on media change

2007-04-23 Thread Kristen Carlson Accardi
Send an uevent to user space to indicate that a media change event has occurred. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/block/genhd.c === --- 2.6-git.orig/block/genhd.c +++ 2.6-git/block/g

[patch 3/7] scsi: expose AN to user space

2007-04-23 Thread Kristen Carlson Accardi
Get media change notification capability from disk and pass this information to genhd by setting appropriate flag. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/scsi/sr.c === --- 2.6-gi

[patch 4/7] libata: expose AN to user space

2007-04-23 Thread Kristen Carlson Accardi
If Asynchronous Notification of media change events is supported, pass that information up to the SCSI layer. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/libata-scsi.c === --- 2.6-gi

[patch 6/7] SCSI: save disk in scsi_device

2007-04-23 Thread Kristen Carlson Accardi
Give anyone who has access to scsi_device access to the genhd struct as well. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/scsi/sd.c === --- 2.6-git.orig/drivers/scsi/sd.c +++ 2.6-git/driver

[patch 7/7] libata: send event when AN received

2007-04-23 Thread Kristen Carlson Accardi
When we get an SDB FIS with the 'N' bit set, we should send an event to user space to indicate that there has been a media change. This will be done via the block device. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/dr

Re: [patch 1/7] libata: check for AN support

2007-04-24 Thread Kristen Carlson Accardi
On Tue, 24 Apr 2007 12:23:04 +0200 Olivier Galibert <[EMAIL PROTECTED]> wrote: > Sorry for replying to Alan's reply, I missed the original mail. > > > > +#define ata_id_has_AN(id)\ > > > + ((id[76] && (~id[76])) & ((id)[78] & (1 << 5))) > > (a && ~a) & (b & 32) > > I don't think that do

Re: [patch 1/7] libata: check for AN support

2007-04-24 Thread Kristen Carlson Accardi
On Tue, 24 Apr 2007 17:03:29 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > Hello, > > Kristen Carlson Accardi wrote: > > static unsigned int ata_print_id = 1; > > @@ -1744,6 +1745,23 @@ int ata_dev_configure(struct ata_device > > } > >

Re: [patch 1/7] libata: check for AN support

2007-04-24 Thread Kristen Carlson Accardi
On Tue, 24 Apr 2007 20:05:52 +0200 Olivier Galibert <[EMAIL PROTECTED]> wrote: > On Tue, Apr 24, 2007 at 08:49:04AM -0700, Kristen Carlson Accardi wrote: > > On Tue, 24 Apr 2007 12:23:04 +0200 > > Olivier Galibert <[EMAIL PROTECTED]> wrote: > > > > > So

Re: [patch 1/7] libata: check for AN support

2007-04-24 Thread Kristen Carlson Accardi
Check to see if an ATAPI device supports Asynchronous Notification. If so, enable it. changes from last version: * fix typo in ata_id_has_AN and make word 76 test more clear * If we fail to set the AN feature, just print a warning and continue Signed-off-by: Kristen Carlson Accardi <[EM

Re: [patch 2/7] genhd: expose AN to user space

2007-04-24 Thread Kristen Carlson Accardi
ew flag to define the media change notification capability. Changed from last version: * changed sysfs filename to "capability" from "capability_flags" Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTE

Re: [patch 5/7] genhd: send async notification on media change

2007-04-24 Thread Kristen Carlson Accardi
Send an uevent to user space to indicate that a media change event has occurred. Changes from last version: * use get/put_device to increment reference count on the device struct Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/block/g

Re: [patch 7/7] libata: send event when AN received

2007-04-24 Thread Kristen Carlson Accardi
When we get an SDB FIS with the 'N' bit set, we should send an event to user space to indicate that there has been a media change. This will be done via the block device. changed from last version: * Make sure that port_addr is within ATA_MAX_DEVICES Signed-off-by: Kristen Carls

Re: [patch 1/7] libata: check for AN support

2007-04-25 Thread Kristen Carlson Accardi
On Wed, 25 Apr 2007 02:49:46 +0200 Olivier Galibert <[EMAIL PROTECTED]> wrote: > On Tue, Apr 24, 2007 at 01:53:27PM -0700, Kristen Carlson Accardi wrote: > > Check to see if an ATAPI device supports Asynchronous Notification. > > If so, enable it. > > > > chan

Re: [patch 1/7] libata: check for AN support

2007-04-25 Thread Kristen Carlson Accardi
Check to see if an ATAPI device supports Asynchronous Notification. If so, enable it. Changes from last version: * use parens around id in ata.h Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/libata-

Re: [patch 1/7] libata: check for AN support

2007-04-25 Thread Kristen Carlson Accardi
On Wed, 25 Apr 2007 20:16:51 +0100 Matt Sealey <[EMAIL PROTECTED]> wrote: > > +#define ata_id_has_AN(id) \ > > + ( (((id)[76] != 0x) && ((id)[76] != 0x)) && \ > > + ((id)[78] & (1 << 5)) ) > > ?? > > > --- 2.6-git.orig/include/linux/libata.h > > +++ 2.6-git/include/linux/libata.h

[patch 0/7] Asynchronous Notification for ATAPI devices (v2) - resend

2007-05-04 Thread Kristen Carlson Accardi
This patch series implements Asynchronous Notification (AN) for SATA ATAPI devices as defined in SATA 2.5 and AHCI 1.1 and higher. Drives which support this feature will send a notification when new media is inserted and removed, preventing the need for user space to poll for new media. This supp

[patch 1/7] libata: check for AN support - resend

2007-05-04 Thread Kristen Carlson Accardi
Check to see if an ATAPI device supports Asynchronous Notification. If so, enable it. Changes from last version: * use parens around id in ata.h Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/libata-

[patch 2/7] genhd: expose AN to user space - resend

2007-05-04 Thread Kristen Carlson Accardi
ew flag to define the media change notification capability. Changed from last version: * changed sysfs filename to "capability" from "capability_flags" Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTE

[patch 3/7] scsi: expose AN to user space - resend

2007-05-04 Thread Kristen Carlson Accardi
Get media change notification capability from disk and pass this information to genhd by setting appropriate flag. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/scsi/sr.c === --- 2.6-gi

[patch 4/7] libata: expose AN to user space - resend

2007-05-04 Thread Kristen Carlson Accardi
If Asynchronous Notification of media change events is supported, pass that information up to the SCSI layer. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/libata-scsi.c === --- 2.6-gi

[patch 6/7] SCSI: save disk in scsi_device - resend

2007-05-04 Thread Kristen Carlson Accardi
Give anyone who has access to scsi_device access to the genhd struct as well. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/scsi/sd.c === --- 2.6-git.orig/drivers/scsi/sd.c +++ 2.6-git/driver

[patch 7/7] libata: send event when AN received - resend

2007-05-04 Thread Kristen Carlson Accardi
When we get an SDB FIS with the 'N' bit set, we should send an event to user space to indicate that there has been a media change. This will be done via the block device. changed from last version: * Make sure that port_addr is within ATA_MAX_DEVICES Signed-off-by: Kristen Carls

Re: [patch 5/7] genhd: send async notification on media change

2007-05-04 Thread Kristen Carlson Accardi
Send an uevent to user space to indicate that a media change event has occurred. Changes from last version: * use get/put_device to increment reference count on the device struct Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/block/g

Re: [patch 0/7] Asynchronous Notification for ATAPI devices (v2) - resend

2007-05-04 Thread Kristen Carlson Accardi
On Fri, 04 May 2007 15:30:03 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > On Fri, 2007-05-04 at 11:12 -0700, Kristen Carlson Accardi wrote: > > This patch series implements Asynchronous Notification (AN) for SATA > > ATAPI devices as defined in SATA 2.5 and AHCI 1.

Re: [patch 0/7] Asynchronous Notification for ATAPI devices (v2) - resend

2007-05-07 Thread Kristen Carlson Accardi
On Sun, 06 May 2007 12:15:34 +0200 Tejun Heo <[EMAIL PROTECTED]> wrote: > Kristen Carlson Accardi wrote: > > This patch series implements Asynchronous Notification (AN) for SATA > > ATAPI devices as defined in SATA 2.5 and AHCI 1.1 and higher. Drives > > which suppo

Re: [patch 6/7] SCSI: save disk in scsi_device - resend

2007-05-07 Thread Kristen Carlson Accardi
On Fri, 04 May 2007 15:30:48 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > On Fri, 2007-05-04 at 11:17 -0700, Kristen Carlson Accardi wrote: > > Give anyone who has access to scsi_device access to the genhd struct as > > well. > > > > Signed-off-by

Re: [patch 6/7] SCSI: save disk in scsi_device - resend

2007-05-09 Thread Kristen Carlson Accardi
On Mon, 7 May 2007 08:29:28 -0700 Kristen Carlson Accardi <[EMAIL PROTECTED]> wrote: > On Fri, 04 May 2007 15:30:48 -0500 > James Bottomley <[EMAIL PROTECTED]> wrote: > > > On Fri, 2007-05-04 at 11:17 -0700, Kristen Carlson Accardi wrote: > > > Give anyone who

[patch 0/7] Asynchronous Notification for ATAPI devices (resend)

2007-05-09 Thread Kristen Carlson Accardi
Hi Jeff, Here are the AN patches again, they have not changed with the exception of patch #1, which does set the host flag in board_ahci and board_ahci_pi now (thanks Tejun). This patch series implements Asynchronous Notification (AN) for SATA ATAPI devices as defined in SATA 2.5 and AHCI 1.1 and

[patch 1/7] libata: check for AN support

2007-05-09 Thread Kristen Carlson Accardi
Check to see if an ATAPI device supports Asynchronous Notification. If so, enable it. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/libata-core.c === --- 2.6-git.orig/drivers/ata/libata-

[patch 2/7] genhd: expose AN to user space

2007-05-09 Thread Kristen Carlson Accardi
ew flag to define the media change notification capability. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/block/genhd.c === --- 2.6-git.orig/block/genhd.c +++ 2.6-git/block/genhd.c @@ -370,7 +370,10 @

[patch 3/7] scsi: expose AN to user space

2007-05-09 Thread Kristen Carlson Accardi
Get media change notification capability from disk and pass this information to genhd by setting appropriate flag. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/scsi/sr.c === --- 2.6-gi

[patch 4/7] libata: expose AN to user space

2007-05-09 Thread Kristen Carlson Accardi
If Asynchronous Notification of media change events is supported, pass that information up to the SCSI layer. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/libata-scsi.c === --- 2.6-gi

[patch 5/7] genhd: send async notification on media change

2007-05-09 Thread Kristen Carlson Accardi
Send an uevent to user space to indicate that a media change event has occurred. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/block/genhd.c === --- 2.6-git.orig/block/genhd.c +++ 2.6-git/block/g

[patch 6/7] SCSI: save disk in scsi_device

2007-05-09 Thread Kristen Carlson Accardi
Give anyone who has access to scsi_device access to the genhd struct as well. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/scsi/sd.c === --- 2.6-git.orig/drivers/scsi/sd.c +++ 2.6-git/driver

[patch 7/7] libata: send event when AN received

2007-05-09 Thread Kristen Carlson Accardi
When we get an SDB FIS with the 'N' bit set, we should send an event to user space to indicate that there has been a media change. This will be done via the block device. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/dr

Re: [patch 1/7] libata: check for AN support

2007-05-10 Thread Kristen Carlson Accardi
Check to see if an ATAPI device supports Asynchronous Notification. If so, enable it. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> --- Andrew, I cleaned up the function header to properly comply with kernel doc requirements. Other than that, this patch is the same. Index:

Re: [patch 5/7] genhd: send async notification on media change

2007-05-23 Thread Kristen Carlson Accardi
On Tue, 22 May 2007 14:12:11 -0700 Andrew Morton <[EMAIL PROTECTED]> wrote: > On Wed, 9 May 2007 16:38:35 -0700 > Kristen Carlson Accardi <[EMAIL PROTECTED]> wrote: > > > Send an uevent to user space to indicate that a media change event has > > occurred. > &

Re: [patch 5/7] genhd: send async notification on media change

2007-05-23 Thread Kristen Carlson Accardi
On Wed, 23 May 2007 12:03:55 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > On Wed, 2007-05-23 at 09:31 -0700, Kristen Carlson Accardi wrote: > > On Tue, 22 May 2007 14:12:11 -0700 > > Andrew Morton <[EMAIL PROTECTED]> wrote: > > > > > On Wed, 9 May

Re: [patch 5/7] genhd: send async notification on media change

2007-05-23 Thread Kristen Carlson Accardi
On Wed, 23 May 2007 13:51:51 -0500 James Bottomley <[EMAIL PROTECTED]> wrote: > On Wed, 2007-05-23 at 11:26 -0700, Kristen Carlson Accardi wrote: > > On Wed, 23 May 2007 12:03:55 -0500 > > James Bottomley <[EMAIL PROTECTED]> wrote: > > > > > On Wed,

[patch 0/3] AHCI Link Power Management

2007-06-11 Thread Kristen Carlson Accardi
Hi, This series of patches enables Aggressive Link Power Management for AHCI devices, as documented in the AHCI spec. On my laptop (a Lenovo X60), this saves me a full watt of power. On other systems, reported power savings range from .5-1.5 Watts. It has been tested by the kind folks at #power

[patch 1/3] Store interrupt value

2007-06-11 Thread Kristen Carlson Accardi
Use a stored value for which interrupts to enable. Changing this allows us to selectively turn off certain interrupts later and have them stay off. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/

[patch 2/3] Expose Power Management Policy option to users

2007-06-11 Thread Kristen Carlson Accardi
erUser wants power savings, with less performance cost than min_power (but less power savings as well). Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/libata-scsi.c ===

[patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-11 Thread Kristen Carlson Accardi
idle. Hot plug not allowed. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/ahci.c === --- 2.6-git.orig/drivers/ata/ahci.c +++ 2.6-git/drivers/ata/ahci.c @@ -48,6 +48,9 @@ #define DR

Re: [PATCH] AHCI powersaving and port-stopping (2.6.22-rc4)

2007-06-11 Thread Kristen Carlson Accardi
On Mon, 11 Jun 2007 07:05:38 -0700 Arjan van de Ven <[EMAIL PROTECTED]> wrote: > > This is very different from the patch I posted a while ago turning on > > a few bits in the CMD register (ALPE and ASP) and which Intel is > > we've not seen a patch that actually works in this area unfortunately.

Re: [patch 1/7] libata: check for AN support

2007-06-11 Thread Kristen Carlson Accardi
On Thu, 24 May 2007 23:15:56 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Kristen Carlson Accardi wrote: > > Check to see if an ATAPI device supports Asynchronous Notification. > > If so, enable it. > > > > Signed-off-by: Kristen Carlson Accardi <[EMA

Re: [patch 0/3] AHCI Link Power Management

2007-06-12 Thread Kristen Carlson Accardi
On Tue, 12 Jun 2007 00:43:12 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > We will do AHCI link PM -- presuming that I can be convinced that it > does not repeatedly park the hard drive heads, or something similarly > annoying on PATA<->SATA bridges and similar setups. > > IF it works as adver

Re: [patch 0/3] AHCI Link Power Management

2007-06-12 Thread Kristen Carlson Accardi
On Tue, 12 Jun 2007 13:40:15 +0900 Tejun Heo <[EMAIL PROTECTED]> wrote: > I don't think the end result will vary in any significant way. My > biggest argument for sw implementation is it can be used for other > controllers. What I had in mind when I created the new port operation "enable_pm" was

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-12 Thread Kristen Carlson Accardi
On Tue, 12 Jun 2007 11:46:56 -0400 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Matthew Garrett wrote: > > On Tue, Jun 12, 2007 at 11:17:14AM -0300, Henrique de Moraes Holschuh wrote: > >> On Tue, 12 Jun 2007, Matthew Garrett wrote: > >>> Laptop bays are designed to deal with hotplugging PATA - I don'

Re: [patch 2a/3] Expose Power Management Policy option to users

2007-06-12 Thread Kristen Carlson Accardi
erformance, not power savings medium_powerUser wants power savings, with less performance cost than min_power (but less power savings as well). Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/driv

Re: [patch 2b/3] Expose Power Management Policy option to users

2007-06-12 Thread Kristen Carlson Accardi
activated after all disks have been enumerated and intialized. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/libata-scsi.c === --- 2.6-git.orig/drivers/ata/libata-scsi.c +++ 2.6-git/drive

Re: [patch 0/3] AHCI Link Power Management

2007-06-13 Thread Kristen Carlson Accardi
On Wed, 13 Jun 2007 11:04:30 +0200 Pavel Machek <[EMAIL PROTECTED]> wrote: > Hi! > > > >> I'm not sure about this. We need better PM framework to support > > >> powersaving in other controllers and some ahcis don't save much > > >> when only link power management is used, > > > > > > do you ha

Re: [patch 2a/3] Expose Power Management Policy option to users

2007-06-14 Thread Kristen Carlson Accardi
On Wed, 13 Jun 2007 08:26:48 -0700 James Bottomley <[EMAIL PROTECTED]> wrote: > On Tue, 2007-06-12 at 10:46 -0700, Kristen Carlson Accardi wrote: > > Expose Power Management Policy option to users > > > > This patch will modify the scsi subsystem to allow > >

Re: [patch 2b/3] Expose Power Management Policy option to users

2007-06-20 Thread Kristen Carlson Accardi
activated after all disks have been enumerated and initialized. Drivers should also define disable_pm, which will turn off link power management, but not change link power management policy. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> --- I've updated this patch to fi

[patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-20 Thread Kristen Carlson Accardi
second lowest power state (PARTIAL) when idle. Hot plug not allowed. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> --- I've changed this patch to define "disable_pm", and to change the behavior of ahci_disable_alpm() to not change th

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-22 Thread Kristen Carlson Accardi
On Thu, 21 Jun 2007 15:08:32 +0200 Jens Axboe <[EMAIL PROTECTED]> wrote: > On Wed, Jun 20 2007, Kristen Carlson Accardi wrote: > > Enable Aggressive Link Power management for AHCI controllers. > > > > This patch will set the correct bits to turn on Aggressive > >

Re: [patch 3/3] Enable Aggressive Link Power management for AHCI controllers.

2007-06-26 Thread Kristen Carlson Accardi
> > > Acked-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> > > Will you integrate it into the next posting? yes, I will do that. Kristen - To unsubscribe from this list: send the line "unsubscribe linux-ide" in the body of a message to [EMAIL PROTECTED] More major

Re: ALPM on devices not supporting HIPM?

2007-06-26 Thread Kristen Carlson Accardi
On Sat, 23 Jun 2007 14:23:12 +0300 "Török Edvin" <[EMAIL PROTECTED]> wrote: > Hi, > > With the ALPM patches I get: Unable to set link PM policy. > [until now I've tested only the combination of your, and Tejun's > port-stopping patch, as I already reported in a past thread] > It looks like my dev

[patch 0/4] SATA power savings patches (ALPM)

2007-07-05 Thread Kristen Carlson Accardi
Hi Jeff, Here's the most recent patches for ALPM. These are also located at: http://www.kernel.org/pub/linux/kernel/people/kristen/patches/SATA/alpm These patches implement Aggressive Link Power management for AHCI controllers. This feature is described in detail in the AHCI 1.x spec. It provid

[patch 1/4] Store interrupt value

2007-07-05 Thread Kristen Carlson Accardi
Use a stored value for which interrupts to enable. Changing this allows us to selectively turn off certain interrupts later and have them stay off. Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/ata/

[patch 2/4] Expose Power Management Policy option to users

2007-07-05 Thread Kristen Carlson Accardi
dium_powerUser wants power savings, with less performance cost than min_power (but less power savings as well). Signed-off-by: Kristen Carlson Accardi <[EMAIL PROTECTED]> Index: 2.6-git/drivers/scsi/hosts.c ===

  1   2   >