IDE resume code?
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
do
> idedisk_check_hpa() only when kernel parameter explicitly says so?
I'm not sure why we're doing it, but reverting this behaviour is likely
to make some systems unbootable (install with kernel which disables HPA,
format entire drive, put filesystem on it).
--
Matthew Garre
ny sign of that code ending up anywhere. What's the current
status with this?
Thanks,
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
nd/resume of machines with SATA interfaces) - is any work going on
in that area at the moment?
Thanks,
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
gt; > ata1.01: _GTF evaluation failed (AE 0x300d)
037f6bb79f753c014bc84bca0de9bf98bb5ab169 ought to have fixed this?
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
s to run a userspace helper to
detach the hardware.
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
ething like 'save removal'
> triggered from userspace like you maybe know from 'the other' operating
> system?
Yes, there's a need for a mechanism to deal with all of this safely, but
the same is true of any storage device that can be hotplugged (USB,
firewire, any
-source-2.6.20/+bug/91940
gives the traces we have.
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
HPA code - reverting it results in that failure
vanishing.
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
quot; appears to mean
"Explicitly disable the HPA", which I guess is one interpretation of
"ignore" - however, naively I'd expect "Ignore HPA" to mean "Don't touch
the HPA" with the result that it would remain inaccessible to userspace.
--
was aiming
for...
Signed-off-by: Matthew Garrett <[EMAIL PROTECTED]>
---
diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
index c428a56..0e542ea 100644
--- a/drivers/ata/libata-acpi.c
+++ b/drivers/ata/libata-acpi.c
@@ -34,6 +34,19 @@ struct taskfile_array {
u8
ly this doesn't actually match reality either. I'll send a
tidied up patch when I've actually slept.
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Mon, Mar 26, 2007 at 11:58:07AM +0100, Alan Cox wrote:
> On Mon, 26 Mar 2007 04:22:23 +0100
> Matthew Garrett <[EMAIL PROTECTED]> wrote:
>
> > I've ported the drivers/ide code for handling _GTM and _STM to libata.
> > I'm not utterly convinced that I
template ata_scsi_transport_template;
diff --git a/include/linux/libata.h b/include/linux/libata.h
index e3f32f3..4774c08 100644
--- a/include/linux/libata.h
+++ b/include/linux/libata.h
@@ -590,6 +590,10 @@ struct ata_port {
void*private_data;
u8 sector_buf[ATA_SECT_SIZE]; /* owned by EH */
+ struct acpi_gtm *gtm;
+#ifdef CONFIG_SATA_ACPI
+ struct ata_acpi_port_link *acpi_port_link;
+#endif
};
struct ata_port_operations {
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
line int ata_acpi_push_id(struct ata_port *ap, unsigned int ix)
-{
- return 0;
-}
-#endif
-
/* libata-scsi.c */
extern struct scsi_transport_template ata_scsi_transport_template;
diff --git a/include/linux/libata.h b/include/linux/libata.h
index e3f32f3..4774c08 100644
--- a/include/linux
000140c7
and I end up with no root filesystem. Reverting the patch leaves things
working. This is the ubuntu tree - I can try libata-dev if you think
there's likely to be any relevant difference.
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "un
On Wed, Mar 28, 2007 at 01:08:52AM +0100, Matthew Garrett wrote:
> ata3.01: ata_hpa_resize 1: sectors = 234441648, hpa_sectors = 0
^
Does this just indicate the lack of an hpa? If so, the
/* if no hpa, both should be eq
On Wed, Mar 28, 2007 at 01:16:10AM +0100, Matthew Garrett wrote:
> comment seems to be wrong (or, alternatively, it's the
> ata_read_native_max_address_ext call that's failing and returning
> garbage? I'll look into that)
It's ata_read_native_max_address_ext fa
On Wed, Mar 28, 2007 at 02:16:08AM +0100, Matthew Garrett wrote:
> It's ata_read_native_max_address_ext failing, and it's fine if I use
> ahci rather than ata_piix, so I'll just chalk this up to Apple's
> firmware being broken (again) and putting the hardware
etection and/or device programming and doing it
> this way reduces user confusion (sata_nv also supports ck804 but
> you probably need to load pata_acpi if ACPI is available) and
> allows better integration with the rest of the low level driver
> (e.g. ADMA mode + _GTM/_ST
h no
errors other than
sd: 2:0:1:0: timing out command, waited 180s
sd: 2:0:1:0: SCSI error: return code = 0x0028
end_request: I/O error, dev sda, sector 0
Buffer I/O error on device sda, logical block 0
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "
resize - that is, it seems
to be the ata_read_native_max_address_ext call that breaks it.
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
advantage that it's easy to tie ACPI
events to specific ata devices, which could then be integrated with the
bay and dock drivers.
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, Apr 05, 2007 at 02:13:52PM +0100, Alan Cox wrote:
> This one should fix the problems with slave devices and the Macintosh hang
Better, but still not happy with ata_piix - I get the following:
[ 10.972000] ata3.01: ata_hpa_resize 1: sectors = 234441648, hpa_sectors =
16337840
[ 10.972
On Mon, Apr 09, 2007 at 10:22:41PM +0100, Alan Cox wrote:
> Please apply Tejun's fix for LBA48 data and try again. Hopefully its just
> that which is causing the problem.
Yes, that works absolutely fine now.
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: se
hotplug
> to take effect..
On laptops, I suspect that we'll probably get an ACPI interrupt even if
the AHCI hotplug pathway can't manage.
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message t
On Tue, Jun 12, 2007 at 09:18:19AM -0300, Henrique de Moraes Holschuh wrote:
> On Tue, 12 Jun 2007, Matthew Garrett wrote:
> >
> > On laptops, I suspect that we'll probably get an ACPI interrupt even if
> > the AHCI hotplug pathway can't manage.
>
> As lon
On Tue, Jun 12, 2007 at 11:17:14AM -0300, Henrique de Moraes Holschuh wrote:
> On Tue, 12 Jun 2007, Matthew Garrett wrote:
> > Laptop bays are designed to deal with hotplugging PATA - I don't think
> > this is too much of an issue :)
>
> The new SATA ones use the SATA h
On Wed, Jun 13, 2007 at 12:45:21AM +0900, Tejun Heo wrote:
> Matthew Garrett wrote:
> > Yes, but they'll also send an ACPI interrupt even if the SATA host
> > controller doesn't - it's part of the spec for bays.
>
> Does the spec mandate that the ACPI inte
On Tue, Jun 12, 2007 at 11:46:56AM -0400, Jeff Garzik wrote:
> Matthew Garrett wrote:
> >On Tue, Jun 12, 2007 at 11:17:14AM -0300, Henrique de Moraes Holschuh
> >wrote:
> >>On Tue, 12 Jun 2007, Matthew Garrett wrote:
> >>>Laptop bays are designed to deal w
On Thu, Aug 02, 2007 at 02:14:08PM +0800, Shaohua Li wrote:
> ACPI spec defines the sequence of IDE power on/off:
Most distributions seem to be using the libata PATA code now - any plans
to implement it there as well?
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: s
can send notifications when hotswapped, which avoids the
need to obtain notification from the controller. This patch uses the
existing libata-acpi code and simply registers a notification in order
to trigger a rescan whenever the firmware signals an event.
Signed-off-by: Matthew Garrett <[EM
can send notifications when hotswapped, which avoids the
need to obtain notification from the controller. This patch uses the
existing libata-acpi code and simply registers a notification in order
to trigger a rescan whenever the firmware signals an event.
Signed-off-by: Matthew Garrett <[EM
he firmware or not. If we find a
reference to a controller or port in the firmware tables, it probably
indicates that the hardware has opinions about how this should be
handled. We might be safer leaving it to the firmware in those cases,
and using that flag to skip the controller-specific ho
On Fri, Sep 21, 2007 at 11:35:05AM +0900, Tejun Heo wrote:
> Matthew Garrett wrote:
> > The alternative would be to add a flag to the ap structure indicating
> > whether the hotplugging is handled by the firmware or not. If we find a
> > reference to a controller or port i
Quite why HP put their hotswap optical drives on the same PATA channel
as the internal drive is somewhat beyond me, but...)
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECT
you don't really wanna lose your root partition over power fluctuation.
In this case we explicitly know that it's in response to a hotplug event
(well, either that or the firmware is on impressive crack). Would it be
possible to communicate that in order to avoid the revalidation?
-
.
Signed-off-by: Matthew Garrett <[EMAIL PROTECTED]>
---
This makes two changes to the previous patch:
y. But I'm also lacking hardware to
test this one, so it's possible that I'm utterly wrong :)
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
both the port
and a device. Semantically the one from the port is a "check all
children" request and the one from the device a "check this individual
device", but I believe these are both equivalent in the current hotswap
implementation.
--
Matthew Garrett | [EMAIL PROTECTED
.
Signed-off-by: Matthew Garrett <[EMAIL PROTECTED]>
---
This incorporates Jeff's feedback. sdev is
On Tue, Oct 02, 2007 at 04:38:19PM -0400, Jeff Garzik wrote:
> Come on, dude! This doesn't even build:
Crap, sorry, I've pulled that from the wrong tree. I'll grab you a
working one now.
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line
Fix libata-acpi.c build failure.
Signed-off-by: Matthew Garrett <[EMAIL PROTECTED]>
---
Sorry, I'd diffed the original against libata-dev master rather than
ALL. This tidies up the changes.
diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
index 6896831..5ebbf16 1
send notifications when hotswapped, which avoids the
need to obtain notification from the controller. This patch uses the
existing libata-acpi code and simply registers a notification in order
to trigger a rescan whenever the firmware signals an event.
Signed-off-by: Matthew Garrett <[EM
tually causing any problems?
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
;s fatal, when it
probably shouldn't be. I'll send a patch shortly.
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Experience suggests that the _GTF method may be bad. We currently fail
device revalidation in that case, which seems excessive.
Signed-off-by: Matthew Garrett <[EMAIL PROTECTED]>
---
diff --git a/drivers/ata/libata-acpi.c b/drivers/ata/libata-acpi.c
index 08a52dd..545ea86 100644
--- a/d
g notification, even when they're sata - we'll get the hotplug
notify for them even if the phy's powered down, so that case also needs
to be handled.
--
Matthew Garrett | [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line "unsubscribe linux-ide" in
the bod
48 matches
Mail list logo
