Peter Favrholdt writes:
Hi,
I've seen intermittent problems with Promise SATA300 TX4 controllers
and Linux kernel 2.6.19 (through 2.6.20-rc2 with some additional
patches).
Sometimes the TX4 will loose a port - a reboot brings the drive back up
again. I'm quite sure the
of non-void function
These occur because -dma_host_on should be a function
returning void, but pmac.c bogusly declares it as returning
int, and furthermore fails to return a value from it.
Correcting the return type to void fixes both warnings.
Signed-off-by: Mikael Pettersson [EMAIL PROTECTED
486.
Signed-off-by: Mikael Pettersson [EMAIL PROTECTED]
--- linux-2.6.21-rc2/drivers/ata/pata_legacy.c.~1~ 2007-02-28
13:32:46.0 +0100
+++ linux-2.6.21-rc2/drivers/ata/pata_legacy.c 2007-03-03 18:40:37.0
+0100
@@ -69,7 +69,7 @@
#define NR_HOST 6
static int legacy_port
pata_legacy probes 6 io/ctr/irq combinations for devices.
Or rather, it loops, claims an io/ctr/irq combination, does
an ata_device_add(), and libata then does the probing.
However, the io/ctr/irq resource combinations aren't released
after failed probes (as in: no devices found). The result is
On Fri, 2 Mar 2007 13:51:19 +0200 (EET), Tomi Orava wrote:
There have been some reports of intermittent errors
with sata_promise, especially with newer disks.
My theory is that the driver isn't initialisating the
controller properly for SATAII 3Gbps transfer speeds.
I did a test run
This is a preliminary patch to add error reason decoding
and reporting to sata_promise. It's fairly simplistic but
should log all error info the controller is able to provide.
Works for me, but my test rig hardly ever throws any errors.
Testing by those that experience frequent errors would be
There have been some reports of intermittent errors
with sata_promise, especially with newer disks.
My theory is that the driver isn't initialisating the
controller properly for SATAII 3Gbps transfer speeds.
It would be helpful if people seeing intermittent errors
with sata_promise could do the
When I merged my 20619 new EH conversion with #libata-upstream
I had to manually resolve a conflict, and inadvertently lost
pdc_pata_ops' -post_internal_cmd binding. Corrected by this patch.
Signed-off-by: Mikael Pettersson [EMAIL PROTECTED]
---
drivers/ata/sata_promise.c |1 +
1 files
of the PATA-only 20619 redundantly set
up scr_addr for the ports. Remove this.
Tested on 20619, 20575, and 20775 chips.
Signed-off-by: Mikael Pettersson [EMAIL PROTECTED]
---
drivers/ata/sata_promise.c | 29 ++---
1 files changed, 10 insertions(+), 19 deletions(-)
diff
On Mon, 19 Feb 2007 12:43:50 +0800, Marc Marais wrote:
I've decided to post this to the linux-ide list to see if I can get to the
bottom of this problem I'm experiencing with sata_promise and my PATA drives.
I've pasted a thread from the linux-raid list where I was trying to
On Thu, 8 Feb 2007 09:58:45 +0100 (MET), Mikael Pettersson wrote:
On Thu, 8 Feb 2007 00:00:32 +0300, Sergei Shtylyov wrote:
Remove the bogus code pretending to set SW/MW DMA timings -- I wonder whether
its author really thought that he could achieve that wrtiting to BMIDE status
registers? Stop
and writing CDs.
Signed-off-by: Mikael Pettersson [EMAIL PROTECTED]
---
Changes since first version: pdc_pata_cbl_detect() is not removed
since it's now called from pdc_error_handler() via pdc_pre_reset().
drivers/ata/sata_promise.c | 55 +++--
1 files
Sergei Shtylyov writes:
The driver's tuneproc() method fails to set the drive's own speed -- fix this
by renaming the function to cmd64x_tune_pio(), making it return the mode set,
and wrapping the new tuneproc() method around it; while at it, also get rid
of the non-working prefetch
in public
documentation, so for now I just wrapped it with #if 0/#endif
Tested on a TX4000 with both modern working disks and old/quirky
disks. Also used a CD-RW drive to test reading and writing CDs.
Signed-off-by: Mikael Pettersson [EMAIL PROTECTED]
---
drivers/ata/sata_promise.c | 58
On Fri, 02 Feb 2007 11:49:17 -0500, Jeff Garzik wrote:
Alan wrote:
I don't have the hardware combination to test this one so would
appreciate people testing it before it goes anywhere further
I wonder if sata_promise PATA support needs this too?
Hmm, I saw Alan's post but ignored it because I
On Tue, 16 Jan 2007 17:04:27 -0500, Jeff Garzik wrote:
Alan wrote:
Jeff - at some point we could eliminate a lot of the NULL checks like
these by having the registration code fill in the defaults where
appropriate ?
libata policy up until this point has been to require all drivers fill
in the
Jeff Garzik writes:
Mikael Pettersson wrote:
If there is a highly common case, the code for that case
is available, and the code is cheap to execute (doesn't
require too many additional variables), then having an
explicit test + inline code is preferred. If any of these
conditions
On Tue, 16 Jan 2007 15:53:14 +0200, Jan Gutter wrote:
On Tue, 2007-01-16 at 20:42 +0900, Tejun Heo wrote:
Can you try 2.6.20-rc5? It has better error reporting and will tell us
which SCSI command is timing out.
Here you go: attaching dmesg
...
nvidia: module license 'NVIDIA' taints
Vincent Legoll writes:
Hello,
I tested libata-dev#promise-sata-pata branch, then I saw Mikael
Pettersson's patch, which kind of obsoleted the testing.
So I did libata-dev#upstream too.
Nothig bad happened yet, after about 1h30 of test for each kernel.
bonnie++, dd, untar,
- pdc_issue_atai_pkt_cmd() and its two helper procedures
pdc_wait_for_drq() and pdc_wait_on_busy() are removed
Tested on first- and second-generation chips, SATAPI and PATAPI,
with no observable regressions.
Signed-off-by: Mikael Pettersson [EMAIL PROTECTED]
---
drivers/ata/sata_promise.c
and PATAPI,
with no observable regressions.
Signed-off-by: Mikael Pettersson [EMAIL PROTECTED]
---
drivers/ata/sata_promise.c | 30 +++---
1 files changed, 23 insertions(+), 7 deletions(-)
--- linux-2.6.20-rc5/drivers/ata/sata_promise.c.~1~ 2007-01-13
16:45:54.0
This patch adds myself as maintainer of the sata_promise
libata driver.
Signed-off-by: Mikael Pettersson [EMAIL PROTECTED]
--- linux-2.6.20-rc4/MAINTAINERS.~1~2007-01-08 20:42:55.0 +0100
+++ linux-2.6.20-rc4/MAINTAINERS2007-01-10 01:04:23.0 +0100
@@ -2622,6 +2622,12
the exceptional per-port flags array in the driver's
private host structure, and uses it in -port_start() to
finalise the port's flags.
This patch obsoletes the #promise-sata-pata branch included
in the #all branch.
Signed-off-by: Mikael Pettersson [EMAIL PROTECTED]
---
Changes since the RFC version
On Sun, 07 Jan 2007 20:46:13 -0500, Jeff Garzik wrote:
Given that I agree with your RFC, this means I can drop all these
#promise-sata-pata patches, and kill the #promise-sata-pata branch soon,
right?
Yes
/Mikael
-
To unsubscribe from this list: send the line unsubscribe linux-ide in
the
On Sat, 30 Dec 2006 18:37:18 +0100 (MET), Mikael Pettersson wrote:
This patch against 2.6.20-rc2 adds partial ATAPI support to
the sata_promise driver. This patch is preliminary and for
review only.
...
As to why CD-writing fails with DMA enabled, I suspect that I
either need to blacklist specific
This patch against 2.6.20-rc2 adds partial ATAPI support to
the sata_promise driver. This patch is preliminary and for
review only.
Current Status:
- Tested with PATA optical devices on 20378 and 20575 chips.
- Mounting and reading CD/DVD discs in DMA mode works fine.
- Using cdrecord to write
On Tue, 19 Dec 2006 08:54:07 -0700, Gary Thomas wrote:
I'm trying to use the sata_promise driver (1.04) with a CDROM
and having little luck. I'm using this chipset:
00:0b.0 Mass storage controller: Promise Technology, Inc. PDC40775 (SATA
300 TX2plus) (rev 02)
If I plug in a SATAPI
On Fri, 15 Dec 2006 11:24:12 -0800, Andrew Morton wrote:
On Fri, 15 Dec 2006 15:45:55 +0059
Jiri Slaby [EMAIL PROTECTED] wrote:
Andrew Morton wrote:
Temporarily at
http://userweb.kernel.org/~akpm/2.6.20-rc1-mm1/
Will appear later at
On Sun, 03 Dec 2006 22:19:35 +0900, Tejun Heo wrote:
Jeff Garzik wrote:
Tejun Heo wrote:
Hello, Mikael.
Thanks for doing this.
Mikael Pettersson wrote:
[--snip--]
+static void pdc_freeze(struct ata_port *ap)
+{
+void __iomem *mmio = (void __iomem *) ap-ioaddr.cmd_addr;
+u32 tmp
-dev #upstream,
cleaned up hotplug_offset computation based on Tejun's comments,
expanded hotplug_offset removal rationale.
This patch does not depend on the pending new EH conversion patch.
Signed-off-by: Mikael Pettersson [EMAIL PROTECTED]
--- linux-2.6.19/drivers/ata/sata_promise.c.~1~ 2006-12
this
patch does.
This patch depends on the sata_promise SATAII updates
patch I sent recently.
Signed-off-by: Mikael Pettersson [EMAIL PROTECTED]
diff -rupN linux-2.6.19.sata_promise-1-genII-fixes/drivers/ata/sata_promise.c
linux-2.6.19.sata_promise-2-PHYMODE4-fixup/drivers/ata/sata_promise.c
--- linux
to compute hotplug_offset in pdc_host_init().
This patch depends on the sata_promise SATAII updates
patch I sent recently.
Signed-off-by: Mikael Pettersson [EMAIL PROTECTED]
diff -rupN linux-2.6.19.sata_promise-3-new_EH/drivers/ata/sata_promise.c
linux-2.6.19.sata_promise-4-cleanups/drivers/ata
101 - 132 of 132 matches
Mail list logo
