Re: libata broken on Pegasos PPC platform (was: Re: IDE broken on Pegasos PPC platform)

2007-09-25 Thread Olaf Hering
On Mon, Sep 24, Alan Cox wrote: hopefully that means the hack in the old VIA driver can also be killed off. Not that I know. But I did not browse the IDE core long enough to figure out how to assign both irqs in a generic way. - To unsubscribe from this list: send the line unsubscribe

[PATCH] advertise correct IDE mode on Pegasos2

2007-08-17 Thread Olaf Hering
version 20040810, and two IDE disks. Signed-off-by: Olaf Hering [EMAIL PROTECTED] --- arch/powerpc/kernel/prom_init.c | 11 --- arch/powerpc/platforms/chrp/pci.c | 28 drivers/ide/pci/via82cxxx.c |7 --- 3 files changed, 36 insertions(+), 10

Re: [PATCH] advertise correct IDE mode on Pegasos2

2007-08-17 Thread Olaf Hering
On Fri, Aug 17, Olaf Hering wrote: Still not 100% perfect. + prom_printf(Fixing up IDE class-code on Pegasos...\n); + rc = prom_getprop(ph, class-code, prop, sizeof(u32)); + if (rc == sizeof(u32)) { + prop[0] = ~0x5

Re: [PATCH] advertise correct IDE mode on Pegasos2

2007-08-17 Thread Olaf Hering
On Fri, Aug 17, Matt Sealey wrote: Setting them to ~0x5 will set them to 0 (legacy mode) and they will always read back as 0 (legacy mode.. sigh) even if in native mode. The pci_dev-class needs updating as well, see second version of the patch. - To unsubscribe from this list: send the line

[PATCH] advertise correct IDE mode on Pegasos2

2007-08-17 Thread Olaf Hering
to setup irq per channel. Tested on Pegasos2 with firmware version 20040810, and two IDE disks. Signed-off-by: Olaf Hering [EMAIL PROTECTED] --- arch/powerpc/kernel/prom_init.c | 11 --- arch/powerpc/platforms/chrp/pci.c | 29 + 2 files changed, 37

Re: adding Pegasus IDE quirk for pata_via

2007-08-16 Thread Olaf Hering
On Tue, Apr 10, Olaf Hering wrote: Where is the correct place for drivers/ata? so, where is the place for via irq quirks in libata? - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: adding Pegasus IDE quirk for pata_via

2007-08-16 Thread Olaf Hering
On Mon, Apr 09, Matt Sealey wrote: + if (bridge) { + u8 iir, irqlist[4] = { 14, 15, 10, 11 }; + + pci_read_config_byte(bridge, VIA_IDE_STEERING, iir); What value has VIA_IDE_STEERING?

Re: adding Pegasus IDE quirk for pata_via

2007-04-10 Thread Olaf Hering
On Mon, Apr 09, Alan Cox wrote: Again some comments would be appreciated from anyone who has a better idea on how this controller works. This simple code addition came out of 2 or 3 days of discussion with the Pegasos designer based on his experiences with the chip and is so simple

[PATCH] add correct interrupt property for pegasos ide

2007-04-04 Thread Olaf Hering
The firmware assigns irq 20/21 to the VIA IDE device on Pegasos. But the required interrupt is 14/15. Maybe someone confused decimal vs. hexadecimal values. Signed-off-by: Olaf Hering [EMAIL PROTECTED] --- arch/powerpc/kernel/prom_init.c | 55 drivers

Re: [PATCH] add correct interrupt property for pegasos ide

2007-04-04 Thread Olaf Hering
On Wed, Apr 04, Bartlomiej Zolnierkiewicz wrote: ? You are right, I did not test the ide driver again. pata_via works with the change. I will test the ide driver tomorrow. - To unsubscribe from this list: send the line unsubscribe linux-ide in the body of a message to [EMAIL PROTECTED] More

Re: request_queue_t depends on CONFIG_BLOCK

2007-03-23 Thread Olaf Hering
On Fri, Mar 23, Bartlomiej Zolnierkiewicz wrote: Because it is needed in a few places. Is there really any PPC64 specific code which needs linux/ide.h (ppc_ide_md is used only by PPC32)? This is about CONFIG_BLOCK=n, not about arch/... Is all non-driver code which has to poke into ide code

request_queue_t depends on CONFIG_BLOCK

2007-03-22 Thread Olaf Hering
How can this compile error be fixed properly? request_queue_t is inside CONFIG_BLOCK, ide_drive_s (and likely others) use it unconditionally. CC arch/powerpc/kernel/setup_64.o In file included from linux-2.6.21-rc4/arch/powerpc/kernel/setup_64.c:23:

Re: request_queue_t depends on CONFIG_BLOCK

2007-03-22 Thread Olaf Hering
On Thu, Mar 22, Christoph Hellwig wrote: On Thu, Mar 22, 2007 at 10:52:34PM +0100, Olaf Hering wrote: How can this compile error be fixed properly? request_queue_t is inside CONFIG_BLOCK, ide_drive_s (and likely others) use it unconditionally. CC arch/powerpc/kernel/setup_64

Re: [PATCH 12/15] ide: make ide_hwif_t.ide_dma_host_on void

2007-02-19 Thread Olaf Hering
On Sat, Feb 03, Bartlomiej Zolnierkiewicz wrote: [PATCH] ide: make ide_hwif_t.ide_dma_host_on void +++ b/drivers/ide/ppc/pmac.c @@ -1984,10 +1984,8 @@ static void pmac_ide_dma_host_off(ide_dr { } -static int -pmac_ide_dma_host_on (ide_drive_t *drive) +static int

[PATCH] use winbond libata instead of ide driver for pseries CD drives

2007-02-16 Thread Olaf Hering
Change the default for the built-in IDE on p610/p615/p630 from ide to libata. libata has better error handling and the drive can recover when hald does its CD media polling. Signed-off-by: Olaf Hering [EMAIL PROTECTED] --- arch/powerpc/configs/ppc64_defconfig |4 ++-- arch/powerpc

Re: [PATCH] use winbond libata instead of ide driver for pseries CD drives

2007-02-16 Thread Olaf Hering
On Fri, Feb 16, Bartlomiej Zolnierkiewicz wrote: Hi, On Friday 16 February 2007 10:20, Olaf Hering wrote: Change the default for the built-in IDE on p610/p615/p630 from ide to libata. libata has better error handling and the drive can recover when hald does its CD media polling

[PATCH] add delay around sl82c105_reset_engine calls

2007-02-10 Thread Olaf Hering
-by: Olaf Hering [EMAIL PROTECTED] --- drivers/ata/pata_sl82c105.c |3 +++ 1 file changed, 3 insertions(+) Index: linux-2.6/drivers/ata/pata_sl82c105.c === --- linux-2.6.orig/drivers/ata/pata_sl82c105.c +++ linux-2.6/drivers/ata

Re: What is the correct way to indicate an unassigned PCI resource ?

2007-01-05 Thread Olaf Hering
On Fri, Jan 05, Benjamin Herrenschmidt wrote: Nah, but also set resource-end = 0 too and or-in IORESOURCE_UNSET for flags not (=) (or just set it to 0, I have no problem with completely clearing the resource, that will keep it out of the way) I get this output with the change below: Using

Re: What is the correct way to indicate an unassigned PCI resource ?

2007-01-04 Thread Olaf Hering
On Wed, Dec 06, Benjamin Herrenschmidt wrote: On Tue, 2006-12-05 at 09:15 +0100, Olaf Hering wrote: On Tue, Dec 05, Benjamin Herrenschmidt wrote: Olaf, can you give me a dump of /proc/ioports ? What is sitting at 0 on that PCI bus ? with IDE=y == /proc/ioports ==

Re: [PATCH] add delay around sl82c105_reset_engine calls

2007-01-03 Thread Olaf Hering
On Mon, Dec 04, Alan wrote: On Mon, 4 Dec 2006 13:40:26 +0100 (MET) Olaf Hering [EMAIL PROTECTED] wrote: the hald media changed polling does really confuse things. noone knows why the delays are needed, but they give us access to the CD. Can you tell me what happens if you

Re: What is the correct way to indicate an unassigned PCI resource ?

2006-12-05 Thread Olaf Hering
On Tue, Dec 05, Benjamin Herrenschmidt wrote: Olaf, can you give me a dump of /proc/ioports ? What is sitting at 0 on that PCI bus ? with IDE=y == /proc/ioports == -001f : dma1 0020-0021 : 8259 (master) 0040-005f : timer 0060-006f : i8042 0080-008f

[PATCH] add delay around sl82c105_reset_engine calls

2006-12-04 Thread Olaf Hering
the hald media changed polling does really confuse things. noone knows why the delays are needed, but they give us access to the CD. Signed-off-by: Olaf Hering [EMAIL PROTECTED] --- drivers/scsi/pata_sl82c105.c |3 +++ 1 file changed, 3 insertions(+) --- a/drivers/scsi/pata_sl82c105.c

Re: [PATCH] mark PCI resource with start 0 as unassigned

2006-12-04 Thread Olaf Hering
On Mon, Dec 04, Segher Boessenkool wrote: --- a/arch/powerpc/kernel/pci_64.c +++ b/arch/powerpc/kernel/pci_64.c @@ -1234,6 +1234,14 @@ static void __devinit fixup_resource(str struct pci_controller *hose = pci_bus_to_host(dev-bus); unsigned long start, end, mask, offset; +/*

Re: [PATCH] add delay around sl82c105_reset_engine calls

2006-12-04 Thread Olaf Hering
On Mon, Dec 04, Alan wrote: On Mon, 4 Dec 2006 13:40:26 +0100 (MET) Olaf Hering [EMAIL PROTECTED] wrote: the hald media changed polling does really confuse things. noone knows why the delays are needed, but they give us access to the CD. Can you tell me what happens if you

Re: pata_sl82c105 can not reserve IO region

2006-12-03 Thread Olaf Hering
On Sun, Dec 03, Alan wrote: On Sun, 3 Dec 2006 23:24:49 +0100 (MET) Olaf Hering [EMAIL PROTECTED] wrote: This change seems to fix it, only a single reset occurs. I think that one is normal when a CD is in the drive during bootup, maybe it leaves the drive in a confused state

[PATCH] winbond IDE depends on IDEDMA

2006-11-30 Thread Olaf Hering
reference to `.__ide_dma_good_drive' drivers/built-in.o: In function `.sl82c105_ide_dma_start': sl82c105.c:(.text+0x62c24): undefined reference to `.ide_dma_start' make[1]: *** [.tmp_vmlinux1] Error 1 Signed-off-by: Olaf Hering [EMAIL PROTECTED] --- drivers/ide/Kconfig |2 +- 1 file changed

[PATCH] winbond IDE depends on IDEDMA

2006-11-30 Thread Olaf Hering
to `.__ide_dma_bad_drive' sl82c105.c:(.text+0x62934): undefined reference to `.__ide_dma_good_drive' drivers/built-in.o: In function `.sl82c105_ide_dma_start': sl82c105.c:(.text+0x62c24): undefined reference to `.ide_dma_start' make[1]: *** [.tmp_vmlinux1] Error 1 Signed-off-by: Olaf Hering [EMAIL PROTECTED